{"thread":{"id":"62943","subject":"[GSoC][PATCH v2] t7603: replace test -f by test_path_is_file","startedAt":"2025-02-12T17:29:54Z","lastAt":"2025-02-12T18:40:04Z","messageCount":3,"participants":["Lucas Oshiro","Junio C Hamano"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"512322","messageId":"20250212172909.21257-1-lucasseikioshiro@gmail.com","threadId":"62943","inReplyTo":null,"subject":"[GSoC][PATCH v2] t7603: replace test -f by test_path_is_file","fromName":"Lucas Oshiro","fromEmail":"lucasseikioshiro@gmail.com","sentAt":"2025-02-12T17:28:16Z","receivedAt":"2025-02-12T17:29:54Z","isPatch":true,"sender":{"key":"lucasseikioshiro@gmail.com","avatar":"https://avatars.githubusercontent.com/u/12701580?v=4"},"body":"`test_path_is_file` provides a better output when asserting whether a\nfile exists. Replace the occurrences of `test -f` in t7603 by it,\nfacilitating the trace of possible test fails.\n\nSigned-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>\n---\n\nThe only difference from v1 is a little typo, missing the t before the\ntest name.\n\n t/t7603-merge-reduce-heads.sh | 24 ++++++++++++------------\n 1 file changed, 12 insertions(+), 12 deletions(-)\n\ndiff --git a/t/t7603-merge-reduce-heads.sh b/t/t7603-merge-reduce-heads.sh\nindex 4887ca705b..1f8c3b7ccb 100755\n--- a/t/t7603-merge-reduce-heads.sh\n+++ b/t/t7603-merge-reduce-heads.sh\n@@ -52,12 +52,12 @@ test_expect_success 'merge c1 with c2, c3, c4, c5' '\n \ttest \"$(git rev-parse c3)\" = \"$(git rev-parse HEAD^3)\" &&\n \ttest \"$(git rev-parse c5)\" = \"$(git rev-parse HEAD^4)\" &&\n \tgit diff --exit-code &&\n-\ttest -f c0.c &&\n-\ttest -f c1.c &&\n-\ttest -f c2.c &&\n-\ttest -f c3.c &&\n-\ttest -f c4.c &&\n-\ttest -f c5.c &&\n+\ttest_path_is_file c0.c &&\n+\ttest_path_is_file c1.c &&\n+\ttest_path_is_file c2.c &&\n+\ttest_path_is_file c3.c &&\n+\ttest_path_is_file c4.c &&\n+\ttest_path_is_file c5.c &&\n \tgit show --format=%s -s >actual &&\n \t! grep c1 actual &&\n \tgrep c2 actual &&\n@@ -75,12 +75,12 @@ test_expect_success 'pull c2, c3, c4, c5 into c1' '\n \ttest \"$(git rev-parse c3)\" = \"$(git rev-parse HEAD^3)\" &&\n \ttest \"$(git rev-parse c5)\" = \"$(git rev-parse HEAD^4)\" &&\n \tgit diff --exit-code &&\n-\ttest -f c0.c &&\n-\ttest -f c1.c &&\n-\ttest -f c2.c &&\n-\ttest -f c3.c &&\n-\ttest -f c4.c &&\n-\ttest -f c5.c &&\n+\ttest_path_is_file c0.c &&\n+\ttest_path_is_file c1.c &&\n+\ttest_path_is_file c2.c &&\n+\ttest_path_is_file c3.c &&\n+\ttest_path_is_file c4.c &&\n+\ttest_path_is_file c5.c &&\n \tgit show --format=%s -s >actual &&\n \t! grep c1 actual &&\n \tgrep c2 actual &&\n-- \n2.48.1\n\n"},{"id":"512326","messageId":"xmqqy0ybt4xi.fsf@gitster.g","threadId":"62943","inReplyTo":"20250212172909.21257-1-lucasseikioshiro@gmail.com","subject":"Re: [GSoC][PATCH v2] t7603: replace test -f by test_path_is_file","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-02-12T18:04:57Z","receivedAt":"2025-02-12T18:05:00Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Lucas Oshiro <lucasseikioshiro@gmail.com> writes:\n\n> `test_path_is_file` provides a better output when asserting whether a\n> file exists. Replace the occurrences of `test -f` in t7603 by it,\n> facilitating the trace of possible test fails.\n>\n> Signed-off-by: Lucas Oshiro <lucasseikioshiro@gmail.com>\n> ---\n>\n> The only difference from v1 is a little typo, missing the t before the\n> test name.\n\n\nI think I fixed that while queueing the v1 iteration already.\n\nYou can check what happened to your patch by observing\nhttps://git.kernel.org/pub/scm/git/git.git/log/?h=seen and\nhttps://git.kernel.org/pub/scm/git/git.git/log/?h=next; other\nhosting sites may have similar lists, but I find the one at k.org\nthe handiest to view.\n\nThanks.\n"},{"id":"512329","messageId":"xmqqr043t3b2.fsf@gitster.g","threadId":"62943","inReplyTo":"xmqqy0ybt4xi.fsf@gitster.g","subject":"Re: [GSoC][PATCH v2] t7603: replace test -f by test_path_is_file","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-02-12T18:40:01Z","receivedAt":"2025-02-12T18:40:04Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"> You can check what happened to your patch by observing\n> https://git.kernel.org/pub/scm/git/git.git/log/?h=seen and\n> https://git.kernel.org/pub/scm/git/git.git/log/?h=next; other\n> hosting sites may have similar lists, but I find the one at k.org\n> the handiest to view.\n\nAnd according to the latter, the topic has been in 'next' already\nwith yesterday's pushout.\n\nI updated the 'next' again this morning, by the way.\n\nThanks.\n\n"}]}