{"thread":{"id":"62906","subject":"[PATCH] doc: documentation for http.uploadarchive config option","startedAt":"2025-02-05T21:20:28Z","lastAt":"2025-02-06T17:54:49Z","messageCount":4,"participants":["Piotr Szlazak via GitGitGadget","Junio C Hamano","Piotr Szlazak"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"511909","messageId":"pull.1885.git.git.1738790425046.gitgitgadget@gmail.com","threadId":"62906","inReplyTo":null,"subject":"[PATCH] doc: documentation for http.uploadarchive config option","fromName":"Piotr Szlazak via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-02-05T21:20:24Z","receivedAt":"2025-02-05T21:20:28Z","isPatch":true,"sender":{"key":"piotr.szlazak@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11884243?v=4"},"body":"From: Piotr Szlazak <piotr.szlazak@gmail.com>\n\nIn Git v2.44.0 support for 'git archive' over HTTP protocol\nwas added, but it was nowhere documented how it should be\nenabled in git-http-backend.\nThis commit adds needed information.\n\nSigned-off-by: Piotr Szlazak <piotr.szlazak@gmail.com>\n---\n    doc: documentation for http.uploadarchive config option\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1885%2Fpszlazak%2Fdocument-http-uploadarchive-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1885/pszlazak/document-http-uploadarchive-v1\nPull-Request: https://github.com/git/git/pull/1885\n\n Documentation/git-http-backend.txt | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/Documentation/git-http-backend.txt b/Documentation/git-http-backend.txt\nindex f37ddaded82..1dea4268520 100644\n--- a/Documentation/git-http-backend.txt\n+++ b/Documentation/git-http-backend.txt\n@@ -56,6 +56,10 @@ http.receivepack::\n \tdisabled by setting this item to `false`, or enabled for all\n \tusers, including anonymous users, by setting it to `true`.\n \n+http.uploadarchive::\n+\tThis serves 'git archive' clients for remote archive over HTTP/HTTPS\n+\tprotocols. It is disabled by default. It only works in protocol v2.\n+\n URL TRANSLATION\n ---------------\n To determine the location of the repository on disk, 'git http-backend'\n\nbase-commit: bc204b742735ae06f65bb20291c95985c9633b7f\n-- \ngitgitgadget\n"},{"id":"511999","messageId":"xmqqseorjhj4.fsf@gitster.g","threadId":"62906","inReplyTo":"pull.1885.git.git.1738790425046.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc: documentation for http.uploadarchive config option","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-02-06T14:04:47Z","receivedAt":"2025-02-06T14:04:51Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Piotr Szlazak via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Piotr Szlazak <piotr.szlazak@gmail.com>\n>\n> In Git v2.44.0 support for 'git archive' over HTTP protocol\n> was added, but it was nowhere documented how it should be\n> enabled in git-http-backend.\n\nGood eyes\n\n> This commit adds needed information.\n\nIt is more customary to say something like:\n\n    Add missing documentation.\n\naround here.\n\n> diff --git a/Documentation/git-http-backend.txt b/Documentation/git-http-backend.txt\n> index f37ddaded82..1dea4268520 100644\n> --- a/Documentation/git-http-backend.txt\n> +++ b/Documentation/git-http-backend.txt\n> @@ -56,6 +56,10 @@ http.receivepack::\n>  \tdisabled by setting this item to `false`, or enabled for all\n>  \tusers, including anonymous users, by setting it to `true`.\n>  \n> +http.uploadarchive::\n> +\tThis serves 'git archive' clients for remote archive over HTTP/HTTPS\n> +\tprotocols. It is disabled by default. It only works in protocol v2.\n\nThe description looks good, from the correctness point-of-view,\nand its style is in line with other entries before it.\n\nWe may want to later consider moving these four http.* configuration\nvariables somehow to Documentation/config/. directory so that it is\nshared across git-http-backend.1 and git-config.1 pages, but that is\nsomething we should leave outside the current effort.\n\nThanks.\n"},{"id":"512007","messageId":"pull.1885.v2.git.git.1738863927849.gitgitgadget@gmail.com","threadId":"62906","inReplyTo":"pull.1885.git.git.1738790425046.gitgitgadget@gmail.com","subject":"[PATCH v2] doc: documentation for http.uploadarchive config option","fromName":"Piotr Szlazak via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2025-02-06T17:45:27Z","receivedAt":"2025-02-06T17:45:32Z","isPatch":true,"sender":{"key":"piotr.szlazak@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11884243?v=4"},"body":"From: Piotr Szlazak <piotr.szlazak@gmail.com>\n\nIn Git v2.44.0 support for 'git archive' over HTTP protocol\nwas added, but it was nowhere documented how it should be\nenabled in git-http-backend.\n\nAdd missing documentation.\n\nSigned-off-by: Piotr Szlazak <piotr.szlazak@gmail.com>\n---\n    doc: documentation for http.uploadarchive config option\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1885%2Fpszlazak%2Fdocument-http-uploadarchive-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1885/pszlazak/document-http-uploadarchive-v2\nPull-Request: https://github.com/git/git/pull/1885\n\nRange-diff vs v1:\n\n 1:  4a5465d0329 ! 1:  ace5e71729c doc: documentation for http.uploadarchive config option\n     @@ Commit message\n          In Git v2.44.0 support for 'git archive' over HTTP protocol\n          was added, but it was nowhere documented how it should be\n          enabled in git-http-backend.\n     -    This commit adds needed information.\n     +\n     +    Add missing documentation.\n      \n          Signed-off-by: Piotr Szlazak <piotr.szlazak@gmail.com>\n      \n\n\n Documentation/git-http-backend.txt | 4 ++++\n 1 file changed, 4 insertions(+)\n\ndiff --git a/Documentation/git-http-backend.txt b/Documentation/git-http-backend.txt\nindex f37ddaded82..1dea4268520 100644\n--- a/Documentation/git-http-backend.txt\n+++ b/Documentation/git-http-backend.txt\n@@ -56,6 +56,10 @@ http.receivepack::\n \tdisabled by setting this item to `false`, or enabled for all\n \tusers, including anonymous users, by setting it to `true`.\n \n+http.uploadarchive::\n+\tThis serves 'git archive' clients for remote archive over HTTP/HTTPS\n+\tprotocols. It is disabled by default. It only works in protocol v2.\n+\n URL TRANSLATION\n ---------------\n To determine the location of the repository on disk, 'git http-backend'\n\nbase-commit: bc204b742735ae06f65bb20291c95985c9633b7f\n-- \ngitgitgadget\n"},{"id":"512008","messageId":"943551b1-c02c-4321-908b-8224c5cf8f1a@gmail.com","threadId":"62906","inReplyTo":"xmqqseorjhj4.fsf@gitster.g","subject":"Re: [PATCH] doc: documentation for http.uploadarchive config option","fromName":"Piotr Szlazak","fromEmail":"piotr.szlazak@gmail.com","sentAt":"2025-02-06T17:54:43Z","receivedAt":"2025-02-06T17:54:49Z","isPatch":true,"sender":{"key":"piotr.szlazak@gmail.com","avatar":"https://avatars.githubusercontent.com/u/11884243?v=4"},"body":"On 06.02.2025 15:04, Junio C Hamano wrote:\n> \"Piotr Szlazak via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n>\n>> From: Piotr Szlazak <piotr.szlazak@gmail.com>\n>>\n>> In Git v2.44.0 support for 'git archive' over HTTP protocol\n>> was added, but it was nowhere documented how it should be\n>> enabled in git-http-backend.\n> Good eyes\n>\n>> This commit adds needed information.\n> It is more customary to say something like:\n>\n>      Add missing documentation.\n>\n> around here.\n\nCommit message corrected in [PATCH v2].\n\n>\n>> diff --git a/Documentation/git-http-backend.txt b/Documentation/git-http-backend.txt\n>> index f37ddaded82..1dea4268520 100644\n>> --- a/Documentation/git-http-backend.txt\n>> +++ b/Documentation/git-http-backend.txt\n>> @@ -56,6 +56,10 @@ http.receivepack::\n>>   \tdisabled by setting this item to `false`, or enabled for all\n>>   \tusers, including anonymous users, by setting it to `true`.\n>>   \n>> +http.uploadarchive::\n>> +\tThis serves 'git archive' clients for remote archive over HTTP/HTTPS\n>> +\tprotocols. It is disabled by default. It only works in protocol v2.\n> The description looks good, from the correctness point-of-view,\n> and its style is in line with other entries before it.\n>\n> We may want to later consider moving these four http.* configuration\n> variables somehow to Documentation/config/. directory so that it is\n> shared across git-http-backend.1 and git-config.1 pages, but that is\n> something we should leave outside the current effort.\n>\n> Thanks.\n\nRegards!\n\n"}]}