{"thread":{"id":"62805","subject":"[PATCH v2] meson: fix perl dependencies for Documentation","startedAt":"2025-01-14T14:04:37Z","lastAt":"2025-01-14T14:35:04Z","messageCount":3,"participants":["Sam James","Patrick Steinhardt"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"510520","messageId":"5114dc9a00377826a55f6bab007d2ad1a4de8bc5.1736863427.git.sam@gentoo.org","threadId":"62805","inReplyTo":null,"subject":"[PATCH v2] meson: fix perl dependencies for Documentation","fromName":"Sam James","fromEmail":"sam@gentoo.org","sentAt":"2025-01-14T14:03:47Z","receivedAt":"2025-01-14T14:04:37Z","isPatch":true,"sender":{"key":"sam@gentoo.org","avatar":"https://avatars.githubusercontent.com/u/11667869?v=4"},"body":"We need an explicit `depends: documentation_deps` so that all of our\nDocumentation targets know they require asciidoc.conf. This shows up\nas parallel build failures with it not yet being available.\n\nOther targets look OK already.\n\nSigned-off-by: Sam James \n---\nv2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.\n\n Documentation/technical/meson.build | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build\nindex 21dfb8b5c9..3a65ee59b3 100644\n--- a/Documentation/technical/meson.build\n+++ b/Documentation/technical/meson.build\n@@ -60,6 +60,7 @@ foreach article : api_docs + articles\n command: asciidoc_html_options,\n input: article,\n output: fs.stem(article) + '.html',\n+ depends: documentation_deps,\n install: true,\n install_dir: get_option('datadir') / 'doc/git-doc/technical',\n )\n-- \n2.48.0\n\n"},{"id":"510521","messageId":"Z4Z0Fxj87XrqdZl7@pks.im","threadId":"62805","inReplyTo":"5114dc9a00377826a55f6bab007d2ad1a4de8bc5.1736863427.git.sam@gentoo.org","subject":"Re: [PATCH v2] meson: fix perl dependencies for Documentation","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-01-14T14:26:31Z","receivedAt":"2025-01-14T14:26:37Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Jan 14, 2025 at 02:03:47PM +0000, Sam James wrote:\n> We need an explicit `depends: documentation_deps` so that all of our\n> Documentation targets know they require asciidoc.conf. This shows up\n> as parallel build failures with it not yet being available.\n> \n> Other targets look OK already.\n> \n> Signed-off-by: Sam James \n> ---\n> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.\n> \n> Documentation/technical/meson.build | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build\n> index 21dfb8b5c9..3a65ee59b3 100644\n> --- a/Documentation/technical/meson.build\n> +++ b/Documentation/technical/meson.build\n> @@ -60,6 +60,7 @@ foreach article : api_docs + articles\n> command: asciidoc_html_options,\n> input: article,\n> output: fs.stem(article) + '.html',\n> + depends: documentation_deps,\n> install: true,\n> install_dir: get_option('datadir') / 'doc/git-doc/technical',\n> )\n\nOkay, this looks good to me now, thanks. One last nit on the subject\nthough: as far as I can see the change doesn't have anything to do with\nPerl, so it is somewhat confusing. How about:\n\n meson: fix missing deps for technical articles\n\nThanks!\n\nPatrick\n"},{"id":"510522","messageId":"87ikqhwjjf.fsf@gentoo.org","threadId":"62805","inReplyTo":"Z4Z0Fxj87XrqdZl7@pks.im","subject":"Re: [PATCH v2] meson: fix perl dependencies for Documentation","fromName":"Sam James","fromEmail":"sam@gentoo.org","sentAt":"2025-01-14T14:35:00Z","receivedAt":"2025-01-14T14:35:04Z","isPatch":true,"sender":{"key":"sam@gentoo.org","avatar":"https://avatars.githubusercontent.com/u/11667869?v=4"},"body":"Patrick Steinhardt writes:\n\n> On Tue, Jan 14, 2025 at 02:03:47PM +0000, Sam James wrote:\n>> We need an explicit `depends: documentation_deps` so that all of our\n>> Documentation targets know they require asciidoc.conf. This shows up\n>> as parallel build failures with it not yet being available.\n>> \n>> Other targets look OK already.\n>> \n>> Signed-off-by: Sam James \n>> ---\n>> v2: Drop incorrect dep I'd added for api-index.sh as pointed out by Patrick.\n>> \n>> Documentation/technical/meson.build | 1 +\n>> 1 file changed, 1 insertion(+)\n>> \n>> diff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build\n>> index 21dfb8b5c9..3a65ee59b3 100644\n>> --- a/Documentation/technical/meson.build\n>> +++ b/Documentation/technical/meson.build\n>> @@ -60,6 +60,7 @@ foreach article : api_docs + articles\n>> command: asciidoc_html_options,\n>> input: article,\n>> output: fs.stem(article) + '.html',\n>> + depends: documentation_deps,\n>> install: true,\n>> install_dir: get_option('datadir') / 'doc/git-doc/technical',\n>> )\n>\n> Okay, this looks good to me now, thanks. One last nit on the subject\n> though: as far as I can see the change doesn't have anything to do with\n> Perl, so it is somewhat confusing. How about:\n>\n> meson: fix missing deps for technical articles\n\nAgreed. Not sure where that came from.\n\nI'll send v3 for that then.\n\n>\n> Thanks!\n>\n> Patrick\n"}]}