{"thread":{"id":"62797","subject":"[PATCH] meson: move config-list from libgit to builtin","startedAt":"2025-01-13T14:06:55Z","lastAt":"2025-01-13T15:42:25Z","messageCount":3,"participants":["Alex Xu (Hello71)","Kristoffer Haugsbakk","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"510413","messageId":"20250113134632.21592-1-alex_y_xu@yahoo.ca","threadId":"62797","inReplyTo":"20250113134632.21592-1-alex_y_xu.ref@yahoo.ca","subject":"[PATCH] meson: move config-list from libgit to builtin","fromName":"Alex Xu (Hello71)","fromEmail":"alex_y_xu@yahoo.ca","sentAt":"2025-01-13T13:46:32Z","receivedAt":"2025-01-13T14:06:55Z","isPatch":true,"sender":{"key":"alex_y_xu@yahoo.ca","avatar":null},"body":"config-list is used by builtin/help.c, not libgit. this matches Makefile\ndependencies\n\nSigned-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>\n---\n meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/meson.build b/meson.build\nindex 0064eb64f5..ef3604a17f 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -614,7 +614,7 @@ libgit_sources += custom_target(\n   env: script_environment,\n )\n \n-libgit_sources += custom_target(\n+builtin_sources += custom_target(\n   output: 'config-list.h',\n   command: [\n     shell,\n-- \n2.47.1\n\n"},{"id":"510415","messageId":"efb8b6d1-c06a-4f73-89bb-6d164ab03cfa@app.fastmail.com","threadId":"62797","inReplyTo":"20250113134632.21592-1-alex_y_xu@yahoo.ca","subject":"Re: [PATCH] meson: move config-list from libgit to builtin","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2025-01-13T14:17:08Z","receivedAt":"2025-01-13T14:17:30Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"On Mon, Jan 13, 2025, at 14:46, Alex Xu (Hello71) wrote:\n> config-list is used by builtin/help.c, not libgit. this matches Makefile\n> dependencies\n>\n> Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>\n> ---\n>  meson.build | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/meson.build b/meson.build\n> index 0064eb64f5..ef3604a17f 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -614,7 +614,7 @@ libgit_sources += custom_target(\n>    env: script_environment,\n>  )\n> \n> -libgit_sources += custom_target(\n> +builtin_sources += custom_target(\n\nLooks like the same change is in another patch from today\n\nhttps://lore.kernel.org/git/20250113-b4-pks-meson-additions-v1-3-97f6a93f691d@pks.im/\n\n-- \nKristoffer Haugsbakk\n\n"},{"id":"510422","messageId":"Z4U0XengqX_a7ywU@pks.im","threadId":"62797","inReplyTo":"efb8b6d1-c06a-4f73-89bb-6d164ab03cfa@app.fastmail.com","subject":"Re: [PATCH] meson: move config-list from libgit to builtin","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-01-13T15:42:21Z","receivedAt":"2025-01-13T15:42:25Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Jan 13, 2025 at 03:17:08PM +0100, Kristoffer Haugsbakk wrote:\n> On Mon, Jan 13, 2025, at 14:46, Alex Xu (Hello71) wrote:\n> > config-list is used by builtin/help.c, not libgit. this matches Makefile\n> > dependencies\n> >\n> > Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>\n> > ---\n> >  meson.build | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> >\n> > diff --git a/meson.build b/meson.build\n> > index 0064eb64f5..ef3604a17f 100644\n> > --- a/meson.build\n> > +++ b/meson.build\n> > @@ -614,7 +614,7 @@ libgit_sources += custom_target(\n> >    env: script_environment,\n> >  )\n> > \n> > -libgit_sources += custom_target(\n> > +builtin_sources += custom_target(\n> \n> Looks like the same change is in another patch from today\n> \n> https://lore.kernel.org/git/20250113-b4-pks-meson-additions-v1-3-97f6a93f691d@pks.im/\n\nYup, indeed :) I'd prefer to go with my series as it also contains a\ncouple more additions, and because it also fixes the same issue for\n\"hook-list.h\".\n\nThanks for your contribution!\n\nPatrick\n"}]}