{"thread":{"id":"62787","subject":"[PATCH] meson: fix perl dependencies for Documentation","startedAt":"2025-01-11T06:39:04Z","lastAt":"2025-01-14T14:03:27Z","messageCount":3,"participants":["Sam James","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"510365","messageId":"79de1bcf31f708960a889066ce3d986e55155ad8.1736577530.git.sam@gentoo.org","threadId":"62787","inReplyTo":null,"subject":"[PATCH] meson: fix perl dependencies for Documentation","fromName":"Sam James","fromEmail":"sam@gentoo.org","sentAt":"2025-01-11T06:38:50Z","receivedAt":"2025-01-11T06:39:04Z","isPatch":true,"sender":{"key":"sam@gentoo.org","avatar":"https://avatars.githubusercontent.com/u/11667869?v=4"},"body":"We need an explicit `depends: documentation_deps` so that all of our\nDocumentation targets know they require asciidoc.conf. This shows up\nas parallel build failures with it not yet being available.\n\nOther targets look OK already.\n\nSigned-off-by: Sam James <sam@gentoo.org>\n---\n Documentation/technical/meson.build | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build\nindex 21dfb8b5c9..8c93da3566 100644\n--- a/Documentation/technical/meson.build\n+++ b/Documentation/technical/meson.build\n@@ -42,6 +42,7 @@ api_index = custom_target(\n     '@OUTPUT@',\n   ],\n   env: script_environment,\n+  depends: documentation_deps,\n   input: api_docs,\n   output: 'api-index.txt',\n )\n@@ -60,6 +61,7 @@ foreach article : api_docs + articles\n     command: asciidoc_html_options,\n     input: article,\n     output: fs.stem(article) + '.html',\n+    depends: documentation_deps,\n     install: true,\n     install_dir: get_option('datadir') / 'doc/git-doc/technical',\n   )\n-- \n2.48.0.rc2\n\n"},{"id":"510392","messageId":"Z4TOTVZbDlxh4Uuy@pks.im","threadId":"62787","inReplyTo":"79de1bcf31f708960a889066ce3d986e55155ad8.1736577530.git.sam@gentoo.org","subject":"Re: [PATCH] meson: fix perl dependencies for Documentation","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-01-13T08:26:59Z","receivedAt":"2025-01-13T08:27:03Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Sat, Jan 11, 2025 at 06:38:50AM +0000, Sam James wrote:\n> diff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build\n> index 21dfb8b5c9..8c93da3566 100644\n> --- a/Documentation/technical/meson.build\n> +++ b/Documentation/technical/meson.build\n> @@ -42,6 +42,7 @@ api_index = custom_target(\n>      '@OUTPUT@',\n>    ],\n>    env: script_environment,\n> +  depends: documentation_deps,\n>    input: api_docs,\n>    output: 'api-index.txt',\n>  )\n\nWait, this doesn't make a lot of sense to me. \"api-index.sh\" does not\ncare about \"asciidoc.conf\" at all, so why is this dependency needed?\n\n> @@ -60,6 +61,7 @@ foreach article : api_docs + articles\n>      command: asciidoc_html_options,\n>      input: article,\n>      output: fs.stem(article) + '.html',\n> +    depends: documentation_deps,\n>      install: true,\n>      install_dir: get_option('datadir') / 'doc/git-doc/technical',\n>    )\n\nThis one looks as expected, though.\n\nThanks!\n\nPatrick\n"},{"id":"510519","messageId":"87r055wl06.fsf@gentoo.org","threadId":"62787","inReplyTo":"Z4TOTVZbDlxh4Uuy@pks.im","subject":"Re: [PATCH] meson: fix perl dependencies for Documentation","fromName":"Sam James","fromEmail":"sam@gentoo.org","sentAt":"2025-01-14T14:03:21Z","receivedAt":"2025-01-14T14:03:27Z","isPatch":true,"sender":{"key":"sam@gentoo.org","avatar":"https://avatars.githubusercontent.com/u/11667869?v=4"},"body":"Patrick Steinhardt <ps@pks.im> writes:\n\n> On Sat, Jan 11, 2025 at 06:38:50AM +0000, Sam James wrote:\n>> diff --git a/Documentation/technical/meson.build b/Documentation/technical/meson.build\n>> index 21dfb8b5c9..8c93da3566 100644\n>> --- a/Documentation/technical/meson.build\n>> +++ b/Documentation/technical/meson.build\n>> @@ -42,6 +42,7 @@ api_index = custom_target(\n>>      '@OUTPUT@',\n>>    ],\n>>    env: script_environment,\n>> +  depends: documentation_deps,\n>>    input: api_docs,\n>>    output: 'api-index.txt',\n>>  )\n>\n> Wait, this doesn't make a lot of sense to me. \"api-index.sh\" does not\n> care about \"asciidoc.conf\" at all, so why is this dependency needed?\n\nYou're completely right -- I thought I'd found that api-index.sh *did*\nneed it, but it definitely doesn't upon checking.\n\n>\n>> @@ -60,6 +61,7 @@ foreach article : api_docs + articles\n>>      command: asciidoc_html_options,\n>>      input: article,\n>>      output: fs.stem(article) + '.html',\n>> +    depends: documentation_deps,\n>>      install: true,\n>>      install_dir: get_option('datadir') / 'doc/git-doc/technical',\n>>    )\n>\n> This one looks as expected, though.\n>\n> Thanks!\n\nI'll respin. Thanks.\n\n>\n> Patrick\n"}]}