{"thread":{"id":"62766","subject":"[PATCH] meson: fix perl dependencies","startedAt":"2025-01-08T03:42:51Z","lastAt":"2025-01-08T16:14:03Z","messageCount":4,"participants":["Sam James","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"510140","messageId":"371571630df201b0b0c680f6437decc6c60ecd3b.1736307757.git.sam@gentoo.org","threadId":"62766","inReplyTo":null,"subject":"[PATCH] meson: fix perl dependencies","fromName":"Sam James","fromEmail":"sam@gentoo.org","sentAt":"2025-01-08T03:42:37Z","receivedAt":"2025-01-08T03:42:51Z","isPatch":true,"sender":{"key":"sam@gentoo.org","avatar":"https://avatars.githubusercontent.com/u/11667869?v=4"},"body":"`generate_perl_command` needs `depends: [git_version_file]` and the uses\nin top-level meson.build were fine, but the ones in perl/ weren't, causing\nparallel build failures in some cases as GIT-BUILD-OPTIONS wasn't yet\navailable.\n\nSigned-off-by: Sam James <sam@gentoo.org>\n---\n perl/FromCPAN/Mail/meson.build     | 1 +\n perl/FromCPAN/meson.build          | 1 +\n perl/Git/LoadCPAN/Mail/meson.build | 1 +\n perl/Git/LoadCPAN/meson.build      | 1 +\n perl/Git/SVN/Memoize/meson.build   | 1 +\n perl/Git/SVN/meson.build           | 1 +\n perl/Git/meson.build               | 1 +\n perl/meson.build                   | 1 +\n 8 files changed, 8 insertions(+)\n\ndiff --git a/perl/FromCPAN/Mail/meson.build b/perl/FromCPAN/Mail/meson.build\nindex 129cff161c..b4ff2fc0b2 100644\n--- a/perl/FromCPAN/Mail/meson.build\n+++ b/perl/FromCPAN/Mail/meson.build\n@@ -4,4 +4,5 @@ test_dependencies += custom_target(\n   command: generate_perl_command,\n   install: true,\n   install_dir: get_option('datadir') / 'perl5/FromCPAN/Mail',\n+  depends: [git_version_file],\n )\ndiff --git a/perl/FromCPAN/meson.build b/perl/FromCPAN/meson.build\nindex 4e7ea909df..1f9ea6ce8e 100644\n--- a/perl/FromCPAN/meson.build\n+++ b/perl/FromCPAN/meson.build\n@@ -4,6 +4,7 @@ test_dependencies += custom_target(\n   command: generate_perl_command,\n   install: true,\n   install_dir: get_option('datadir') / 'perl5/FromCPAN',\n+  depends: [git_version_file],\n )\n \n subdir('Mail')\ndiff --git a/perl/Git/LoadCPAN/Mail/meson.build b/perl/Git/LoadCPAN/Mail/meson.build\nindex 7da5b37adb..89cde56be8 100644\n--- a/perl/Git/LoadCPAN/Mail/meson.build\n+++ b/perl/Git/LoadCPAN/Mail/meson.build\n@@ -4,4 +4,5 @@ test_dependencies += custom_target(\n   command: generate_perl_command,\n   install: true,\n   install_dir: get_option('datadir') / 'perl5/Git/LoadCPAN/Mail',\n+  depends: [git_version_file],\n )\ndiff --git a/perl/Git/LoadCPAN/meson.build b/perl/Git/LoadCPAN/meson.build\nindex 9468c073ae..1ee915c650 100644\n--- a/perl/Git/LoadCPAN/meson.build\n+++ b/perl/Git/LoadCPAN/meson.build\n@@ -4,6 +4,7 @@ test_dependencies += custom_target(\n   command: generate_perl_command,\n   install: true,\n   install_dir: get_option('datadir') / 'perl5/Git/LoadCPAN',\n+  depends: [git_version_file],\n )\n \n subdir('Mail')\ndiff --git a/perl/Git/SVN/Memoize/meson.build b/perl/Git/SVN/Memoize/meson.build\nindex 515ab3dd92..233ec670d7 100644\n--- a/perl/Git/SVN/Memoize/meson.build\n+++ b/perl/Git/SVN/Memoize/meson.build\n@@ -4,4 +4,5 @@ test_dependencies += custom_target(\n   command: generate_perl_command,\n   install: true,\n   install_dir: get_option('datadir') / 'perl5/Git/SVN',\n+  depends: [git_version_file],\n )\ndiff --git a/perl/Git/SVN/meson.build b/perl/Git/SVN/meson.build\nindex 8338531041..44abaf42b7 100644\n--- a/perl/Git/SVN/meson.build\n+++ b/perl/Git/SVN/meson.build\n@@ -14,6 +14,7 @@ foreach source : [\n     command: generate_perl_command,\n     install: true,\n     install_dir: get_option('datadir') / 'perl5/Git/SVN',\n+    depends: [git_version_file],\n   )\n endforeach\n \ndiff --git a/perl/Git/meson.build b/perl/Git/meson.build\nindex 259209d730..b21fa5591e 100644\n--- a/perl/Git/meson.build\n+++ b/perl/Git/meson.build\n@@ -11,6 +11,7 @@ foreach source : [\n     command: generate_perl_command,\n     install: true,\n     install_dir: get_option('datadir') / 'perl5/Git',\n+    depends: [git_version_file],\n   )\n endforeach\n \ndiff --git a/perl/meson.build b/perl/meson.build\nindex c22d6f8a1a..2d4ab1c4a9 100644\n--- a/perl/meson.build\n+++ b/perl/meson.build\n@@ -4,6 +4,7 @@ test_dependencies += custom_target(\n   command: generate_perl_command,\n   install: true,\n   install_dir: get_option('datadir') / 'perl5',\n+  depends: [git_version_file],\n )\n \n subdir('Git')\n-- \n2.48.0.rc2.29.g7bab57bd98\n\n"},{"id":"510145","messageId":"Z34Zv55SSDexBxHQ@pks.im","threadId":"62766","inReplyTo":"371571630df201b0b0c680f6437decc6c60ecd3b.1736307757.git.sam@gentoo.org","subject":"Re: [PATCH] meson: fix perl dependencies","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-01-08T06:22:55Z","receivedAt":"2025-01-08T06:23:00Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Wed, Jan 08, 2025 at 03:42:37AM +0000, Sam James wrote:\n> `generate_perl_command` needs `depends: [git_version_file]` and the uses\n> in top-level meson.build were fine, but the ones in perl/ weren't, causing\n> parallel build failures in some cases as GIT-BUILD-OPTIONS wasn't yet\n> available.\n\nThanks for your patch! The change looks obviously correct to me.\n\nPatrick\n"},{"id":"510169","messageId":"xmqqfrltnvbr.fsf@gitster.g","threadId":"62766","inReplyTo":"Z34Zv55SSDexBxHQ@pks.im","subject":"Re: [PATCH] meson: fix perl dependencies","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2025-01-08T16:07:04Z","receivedAt":"2025-01-08T16:07:07Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt <ps@pks.im> writes:\n\n> On Wed, Jan 08, 2025 at 03:42:37AM +0000, Sam James wrote:\n>> `generate_perl_command` needs `depends: [git_version_file]` and the uses\n>> in top-level meson.build were fine, but the ones in perl/ weren't, causing\n>> parallel build failures in some cases as GIT-BUILD-OPTIONS wasn't yet\n>> available.\n>\n> Thanks for your patch! The change looks obviously correct to me.\n>\n> Patrick\n\nThanks, both.  Will fast-track to 'master' before the final gets\ntagged, but we may want to advertise 'meson' support still as work\nin progress in the release notes.\n"},{"id":"510170","messageId":"Z36kRQpoK5fMXFhk@pks.im","threadId":"62766","inReplyTo":"xmqqfrltnvbr.fsf@gitster.g","subject":"Re: [PATCH] meson: fix perl dependencies","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2025-01-08T16:13:57Z","receivedAt":"2025-01-08T16:14:03Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Wed, Jan 08, 2025 at 08:07:04AM -0800, Junio C Hamano wrote:\n> Patrick Steinhardt <ps@pks.im> writes:\n> \n> > On Wed, Jan 08, 2025 at 03:42:37AM +0000, Sam James wrote:\n> >> `generate_perl_command` needs `depends: [git_version_file]` and the uses\n> >> in top-level meson.build were fine, but the ones in perl/ weren't, causing\n> >> parallel build failures in some cases as GIT-BUILD-OPTIONS wasn't yet\n> >> available.\n> >\n> > Thanks for your patch! The change looks obviously correct to me.\n> >\n> > Patrick\n> \n> Thanks, both.  Will fast-track to 'master' before the final gets\n> tagged, but we may want to advertise 'meson' support still as work\n> in progress in the release notes.\n\nYeah, agreed. Thanks!\n\nPatrick\n"}]}