{"thread":{"id":"62739","subject":"[GSoC][Newbie] Test Script Enhancements","startedAt":"2025-01-05T09:39:39Z","lastAt":"2025-01-05T09:51:59Z","messageCount":2,"participants":["Rhythm Narula","Eric Sunshine"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"509922","messageId":"CAKz1=ZOY7GziF9DNTLXv=G+OX8_vAbvOYS4L2s-D2C3kpr-zOg@mail.gmail.com","threadId":"62739","inReplyTo":null,"subject":"[GSoC][Newbie] Test Script Enhancements","fromName":"Rhythm Narula","fromEmail":"rhythm.narula26@gmail.com","sentAt":"2025-01-05T09:39:25Z","receivedAt":"2025-01-05T09:39:39Z","isPatch":false,"sender":{"key":"rhythm.narula26@gmail.com","avatar":"https://gravatar.com/avatar/4b26775567d9a6f7921c7c07499f1e4d377b524468036dd38a88d1823d0d1e3a?d=mp&s=160"},"body":"Hi Everyone,\nMy name is Rhythm Narula and I am currently working as a Software\nEngineer. I had the privilege of participating in GSoC 2023 with\nPitivi, GNOME, where I completed a project on generating closing\ncredit clips. LinkedIn -\nhttps://www.linkedin.com/in/rhythm-narula-34b652191/\n\nAs someone who uses Git daily for version control and collaboration, I\nhave developed a strong interest in understanding its internals and\ncontributing to its improvement, allowing me to impact millions of\ndevelopers worldwide.\n\nI understand that GSoC 2025 mini project ideas have not yet been\nreleased, however, I have been exploring 2024 mini project ideas and\nnoticed a few areas where improvements might still be possible. I have\noutlined these below and world appreciate your feedback on whether\nthese are accurate and worth pursuing:\n\n1. Avoid suppressing git’s exit code in test scripts\na.  diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh\nindex d21877150e..3433fcfc44 100755\n--- a/t/t5801-remote-helpers.sh\n+++ b/t/t5801-remote-helpers.sh\n@@ -271,7 +271,7 @@ test_expect_success 'push update refs failure' '\n\n clean_mark () {\n        cut -f 2 -d ' ' \"$1\" |\n-       git cat-file --batch-check |\n+       git cat-file --batch-check >actual &&\n        grep commit |\n        sort >$(basename \"$1\")\n }\n\n2. Modernize a test script\nIs there anyone working on t/t5801-remote-helpers.sh? Can I take this up?\n\nRegards,\nRhythm\n"},{"id":"509924","messageId":"CAPig+cTjK3_jme88H8D5AiXAoGc+Donu0tgBGYcS2F-KQ0Kfaw@mail.gmail.com","threadId":"62739","inReplyTo":"CAKz1=ZOY7GziF9DNTLXv=G+OX8_vAbvOYS4L2s-D2C3kpr-zOg@mail.gmail.com","subject":"Re: [GSoC][Newbie] Test Script Enhancements","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2025-01-05T09:51:48Z","receivedAt":"2025-01-05T09:51:59Z","isPatch":false,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Sun, Jan 5, 2025 at 4:39 AM Rhythm Narula <rhythm.narula26@gmail.com> wrote:\n> 1. Avoid suppressing git’s exit code in test scripts\n> a.  diff --git a/t/t5801-remote-helpers.sh b/t/t5801-remote-helpers.sh\n> @@ -271,7 +271,7 @@ test_expect_success 'push update refs failure' '\n>  clean_mark () {\n>         cut -f 2 -d ' ' \"$1\" |\n> -       git cat-file --batch-check |\n> +       git cat-file --batch-check >actual &&\n>         grep commit |\n>         sort >$(basename \"$1\")\n>  }\n\nAt a quick glance, I'd say that this change is incomplete and won't\nwork as you expect.\n\n> 2. Modernize a test script\n> Is there anyone working on t/t5801-remote-helpers.sh? Can I take this up?\n\nNo need to ask before working on something in Git. You're free to pick\nany modernization. A good way to check if anyone is touching this\nparticular script is to search the mail archive[*] for recent mentions\nof \"t5801\".\n\n[*]: https://lore.kernel.org/git/\n"}]}