{"thread":{"id":"6267","subject":"problem with Documentation/hooks.txt","startedAt":"2007-01-07T11:13:51Z","lastAt":"2007-01-07T15:28:53Z","messageCount":4,"participants":["Alan Chandler","Martin Waitz","Nicolas Vilz"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"31037","messageId":"200701071113.51597.alan@chandlerfamily.org.uk","threadId":"6267","inReplyTo":null,"subject":"problem with Documentation/hooks.txt","fromName":"Alan Chandler","fromEmail":"alan@chandlerfamily.org.uk","sentAt":"2007-01-07T11:13:51Z","receivedAt":"2007-01-07T11:13:51Z","isPatch":false,"sender":{"key":"alan@chandlerfamily.org.uk","avatar":"https://gravatar.com/avatar/1862247e5ea8eac114c842f9dc3a5db6253754e24ef7171757cf97eedce48b8c?d=mp&s=160"},"body":"I was just looking at the documentation of the post-commit hook in order \nto fix a problem on one of my repositories and I came across this:-\n\n\"The default 'post-commit' hook, when enabled, demonstrates how to\nsend out a commit notification e-mail.\"\n\nSo I went looking in the templates/hooks--post-commit file and it has \nnothing (literally :-) ).\n\nand as far as I can see looking over git's history it has always been \nlike that.\n\nI don't have an example to submit a patch - but I am sure lots of people \nhave done something like that and could provide one.\n\n\n-- \nAlan Chandler\nhttp://www.chandlerfamily.org.uk\n"},{"id":"31049","messageId":"20070107123408.GD6115@admingilde.org","threadId":"6267","inReplyTo":"200701071113.51597.alan@chandlerfamily.org.uk","subject":"Re: problem with Documentation/hooks.txt","fromName":"Martin Waitz","fromEmail":"tali@admingilde.org","sentAt":"2007-01-07T12:34:08Z","receivedAt":"2007-01-07T12:34:08Z","isPatch":false,"sender":{"key":"tali@admingilde.org","avatar":"https://gravatar.com/avatar/3f89b03eee362187effabe257898735b475673a12265c398ea9161259ae91553?d=mp&s=160"},"body":"hoi :)\n\nOn Sun, Jan 07, 2007 at 11:13:51AM +0000, Alan Chandler wrote:\n> I was just looking at the documentation of the post-commit hook in order \n> to fix a problem on one of my repositories and I came across this:-\n> \n> \"The default 'post-commit' hook, when enabled, demonstrates how to\n> send out a commit notification e-mail.\"\n\nHave a look at the 'update' hook instead.\nWhere have you found this hint? We should change the documentation here.\n\n-- \nMartin Waitz\n"},{"id":"31052","messageId":"200701071441.26001.alan@chandlerfamily.org.uk","threadId":"6267","inReplyTo":"20070107123408.GD6115@admingilde.org","subject":"Re: problem with Documentation/hooks.txt","fromName":"Alan Chandler","fromEmail":"alan@chandlerfamily.org.uk","sentAt":"2007-01-07T14:41:25Z","receivedAt":"2007-01-07T14:41:25Z","isPatch":false,"sender":{"key":"alan@chandlerfamily.org.uk","avatar":"https://gravatar.com/avatar/1862247e5ea8eac114c842f9dc3a5db6253754e24ef7171757cf97eedce48b8c?d=mp&s=160"},"body":"On Sunday 07 January 2007 12:34, Martin Waitz wrote:\n> hoi :)\n>\n> On Sun, Jan 07, 2007 at 11:13:51AM +0000, Alan Chandler wrote:\n> > I was just looking at the documentation of the post-commit hook in\n> > order to fix a problem on one of my repositories and I came across\n> > this:-\n> >\n> > \"The default 'post-commit' hook, when enabled, demonstrates how to\n> > send out a commit notification e-mail.\"\n>\n> Have a look at the 'update' hook instead.\n> Where have you found this hint? We should change the documentation\n> here.\nDocumentation/hooks.txt (under the post-commit hook section)\n\n\n-- \nAlan Chandler\nhttp://www.chandlerfamily.org.uk\n"},{"id":"31056","messageId":"20070107152852.GB10777@hermes.lan.home.vilz.de","threadId":"6267","inReplyTo":"20070107123408.GD6115@admingilde.org","subject":"Re: problem with Documentation/hooks.txt","fromName":"Nicolas Vilz","fromEmail":"niv@iaglans.de","sentAt":"2007-01-07T15:28:53Z","receivedAt":"2007-01-07T15:28:53Z","isPatch":false,"sender":{"key":"niv@iaglans.de","avatar":"https://gravatar.com/avatar/e4d43a32d721241212d4edb1d2210327e28423c913071b4bfeeaa0ce15296110?d=mp&s=160"},"body":"On Sun, Jan 07, 2007 at 01:34:08PM +0100, Martin Waitz wrote:\n> hoi :)\n> \n> On Sun, Jan 07, 2007 at 11:13:51AM +0000, Alan Chandler wrote:\n> > I was just looking at the documentation of the post-commit hook in order \n> > to fix a problem on one of my repositories and I came across this:-\n> > \n> > \"The default 'post-commit' hook, when enabled, demonstrates how to\n> > send out a commit notification e-mail.\"\n> \n> Have a look at the 'update' hook instead.\n> Where have you found this hint? We should change the documentation here.\n\nMay I repeat my ignored request to check the update-hook-example in\nDocumentation/howto/ for working correctly? It doesn't. \n\nI am no bash guru, but as far as i understand the code, the size of an\nargument is checked with matchlen. That is imho bad for regexp. \n\nI built the scenario described there and i couldn't commit to the tmp/*\nbranches. I also couldn't commit to the bw/ topics and i couldn't tag\nanything as the specific role proposed in this example.\n\nas long as the length of the refs-string from the commit matches the one\nin allowed-users, all is ok. But if it doesn't, which is imho obviously\nthe case if you use regexp in the allowed-users file, it doesn't work.\n\nUnfortunatelly i can't fix that myself, but it would be good to correct\nthat example, if it really doesn't work... or at least please tell me,\nwhat i am doing wrong :)\n\nNicolas Vilz\n"}]}