{"thread":{"id":"62594","subject":"[PATCH] doc: mention rev-list --ancestry-path restrictions","startedAt":"2024-12-03T20:18:06Z","lastAt":"2024-12-04T00:10:21Z","messageCount":3,"participants":["Kai Koponen via GitGitGadget","Elijah Newren","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"508556","messageId":"pull.1838.git.git.1733257083739.gitgitgadget@gmail.com","threadId":"62594","inReplyTo":null,"subject":"[PATCH] doc: mention rev-list --ancestry-path restrictions","fromName":"Kai Koponen via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-12-03T20:18:03Z","receivedAt":"2024-12-03T20:18:06Z","isPatch":true,"sender":{"key":"kaikoponen@google.com","avatar":"https://avatars.githubusercontent.com/u/161378660?v=4"},"body":"From: Kai Koponen <kaikoponen@google.com>\n\nThe rev-list documention doesn't mention that the given\ncommit must be in the specified commit range, leading\nto unexpected results.\n\nSigned-off-by: Kai Koponen <kaikoponen@google.com>\n---\n    doc: mention rev-list --ancestry-path restrictions\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1838%2Fgkaikoponen%2Fmaster-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1838/gkaikoponen/master-v1\nPull-Request: https://github.com/git/git/pull/1838\n\n Documentation/rev-list-options.txt | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)\n\ndiff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt\nindex 00ccf687441..459e5a02f52 100644\n--- a/Documentation/rev-list-options.txt\n+++ b/Documentation/rev-list-options.txt\n@@ -412,7 +412,8 @@ Default mode::\n \n --ancestry-path[=<commit>]::\n \tWhen given a range of commits to display (e.g. 'commit1..commit2'\n-\tor 'commit2 {caret}commit1'), only display commits in that range\n+\tor 'commit2 {caret}commit1'), and a commit <commit> in that range,\n+\tonly display commits in that range\n \tthat are ancestors of <commit>, descendants of <commit>, or\n \t<commit> itself.  If no commit is specified, use 'commit1' (the\n \texcluded part of the range) as <commit>.  Can be passed multiple\n\nbase-commit: cc01bad4a9f566cf4453c7edd6b433851b0835e2\n-- \ngitgitgadget\n"},{"id":"508576","messageId":"CABPp-BEiYvz-0MDS92iSb1Bj_UyBBUjy6D5SDsbPcoPnjzjucg@mail.gmail.com","threadId":"62594","inReplyTo":"pull.1838.git.git.1733257083739.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc: mention rev-list --ancestry-path restrictions","fromName":"Elijah Newren","fromEmail":"newren@gmail.com","sentAt":"2024-12-03T22:22:24Z","receivedAt":"2024-12-03T22:22:36Z","isPatch":true,"sender":{"key":"newren@gmail.com","avatar":"https://avatars.githubusercontent.com/u/5455730?v=4"},"body":"On Tue, Dec 3, 2024 at 12:18 PM Kai Koponen via GitGitGadget\n<gitgitgadget@gmail.com> wrote:\n>\n> From: Kai Koponen <kaikoponen@google.com>\n>\n> The rev-list documention doesn't mention that the given\n> commit must be in the specified commit range, leading\n> to unexpected results.\n>\n> Signed-off-by: Kai Koponen <kaikoponen@google.com>\n> ---\n>     doc: mention rev-list --ancestry-path restrictions\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1838%2Fgkaikoponen%2Fmaster-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1838/gkaikoponen/master-v1\n> Pull-Request: https://github.com/git/git/pull/1838\n>\n>  Documentation/rev-list-options.txt | 3 ++-\n>  1 file changed, 2 insertions(+), 1 deletion(-)\n>\n> diff --git a/Documentation/rev-list-options.txt b/Documentation/rev-list-options.txt\n> index 00ccf687441..459e5a02f52 100644\n> --- a/Documentation/rev-list-options.txt\n> +++ b/Documentation/rev-list-options.txt\n> @@ -412,7 +412,8 @@ Default mode::\n>\n>  --ancestry-path[=<commit>]::\n>         When given a range of commits to display (e.g. 'commit1..commit2'\n> -       or 'commit2 {caret}commit1'), only display commits in that range\n> +       or 'commit2 {caret}commit1'), and a commit <commit> in that range,\n> +       only display commits in that range\n>         that are ancestors of <commit>, descendants of <commit>, or\n>         <commit> itself.  If no commit is specified, use 'commit1' (the\n>         excluded part of the range) as <commit>.  Can be passed multiple\n>\n> base-commit: cc01bad4a9f566cf4453c7edd6b433851b0835e2\n> --\n> gitgitgadget\n\nMight be worth linking to the thread where this was discussed (in\nsingle-commit gitgitgadget PRs, that'd be done in the PR description),\nover here: https://lore.kernel.org/git/CADYQcGpXm=RTEYyxqdSowQ4Vg9jmXuCzOOpd-TgDX8U814BReg@mail.gmail.com/\n\nAnyway, patch looks good to me.\n"},{"id":"508587","messageId":"xmqqiks071g4.fsf@gitster.g","threadId":"62594","inReplyTo":"pull.1838.git.git.1733257083739.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc: mention rev-list --ancestry-path restrictions","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-12-04T00:10:19Z","receivedAt":"2024-12-04T00:10:21Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Kai Koponen via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Kai Koponen <kaikoponen@google.com>\n>\n> The rev-list documention doesn't mention that the given\n> commit must be in the specified commit range, leading\n> to unexpected results.\n>\n> Signed-off-by: Kai Koponen <kaikoponen@google.com>\n> ---\n>     doc: mention rev-list --ancestry-path restrictions\n\nThanks.\n"}]}