{"thread":{"id":"62496","subject":"malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","startedAt":"2024-11-15T09:40:59Z","lastAt":"2024-11-19T00:33:43Z","messageCount":9,"participants":["Attila Kerekes","René Scharfe","Junio C Hamano","Patrick Steinhardt","Philippe Blain"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"507352","messageId":"5FFE9429-7496-429F-BEC5-9D00C8409AC3@enrg8.com","threadId":"62496","inReplyTo":null,"subject":"malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","fromName":"Attila Kerekes","fromEmail":"ak@enrg8.com","sentAt":"2024-11-15T09:40:38Z","receivedAt":"2024-11-15T09:40:59Z","isPatch":false,"sender":{"key":"ak@enrg8.com","avatar":null},"body":"Dear Maintainers!\n\nSee my bug report below:\n\nWhat did you do before the bug happened? (Steps to reproduce your issue)\n\nrun the command:\n git maintenance start\n\nWhat did you expect to happen? (Expected behavior)\n\ngit maintenance is started\n\nWhat happened instead? (Actual behavior)\n\ngit(26100,0x1ffd63840) malloc: *** error for object 0x1: pointer being freed was not allocated\n\nWhat's different between what you expected and what actually happened?\n\ngit maintenance jobs did not get set up, instead i got a malloc error\n\nAnything else you want to add:\n\nMacOS 15.1 (24B83) on M3 mac.\n\ngit installed with brew\n\nthe Apple provided git 2.39.5 works fine when I run git maintenance start.\n\nPlease review the rest of the bug report below.\nYou can delete any lines you don't wish to share.\n\n\n[System Info]\ngit version:\ngit version 2.47.0\ncpu: arm64\nno commit associated with this build\nsizeof-long: 8\nsizeof-size_t: 8\nshell-path: /bin/sh\nfeature: fsmonitor--daemon\nlibcurl: 8.7.1\nzlib: 1.2.12\nuname: Darwin 24.1.0 Darwin Kernel Version 24.1.0: Thu Oct 10 21:05:23 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6031 arm64\ncompiler info: clang: 16.0.0 (clang-1600.0.26.3)\nlibc info: no libc information available\n$SHELL (typically, interactive shell): /bin/zsh\n\n\n[Enabled Hooks]\n\n\nBest Regards\nAttila\n"},{"id":"507372","messageId":"4ca84916-c5f5-4d52-8f6a-08b729bb66b8@web.de","threadId":"62496","inReplyTo":"5FFE9429-7496-429F-BEC5-9D00C8409AC3@enrg8.com","subject":"Re: malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","fromName":"René Scharfe","fromEmail":"l.s.r@web.de","sentAt":"2024-11-15T16:34:16Z","receivedAt":"2024-11-15T16:34:27Z","isPatch":false,"sender":{"key":"l.s.r@web.de","avatar":"https://avatars.githubusercontent.com/u/26122331?v=4"},"body":"Am 15.11.24 um 10:40 schrieb Attila Kerekes:\n> Dear Maintainers!\n>\n> See my bug report below:\n>\n> What did you do before the bug happened? (Steps to reproduce your issue)\n>\n> run the command:\n> git maintenance start\n>\n> What did you expect to happen? (Expected behavior)\n>\n> git maintenance is started\n>\n> What happened instead? (Actual behavior)\n>\n> git(26100,0x1ffd63840) malloc: *** error for object 0x1: pointer being freed was not allocated\n>\n> What's different between what you expected and what actually happened?\n>\n> git maintenance jobs did not get set up, instead i got a malloc error\n\nThis is a known error. Commit c95547a394 (builtin/gc: fix crash when\nrunning `git maintenance start`, 2024-10-10) fixes it, but has not made\nit into a released version, yet.\n\nRené\n\n"},{"id":"507373","messageId":"xmqq34js1kd2.fsf@gitster.g","threadId":"62496","inReplyTo":"4ca84916-c5f5-4d52-8f6a-08b729bb66b8@web.de","subject":"Re: malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-11-15T17:23:53Z","receivedAt":"2024-11-15T17:23:56Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"René Scharfe writes:\n\n> This is a known error. Commit c95547a394 (builtin/gc: fix crash when\n> running `git maintenance start`, 2024-10-10) fixes it, but has not made\n> it into a released version, yet.\n\nThanks.\n\nThere are bunch of topics that could go to 'maint' and be part of a\nmaintenance topic, and this certainly looks like one of those topics\nthat can go into 2.47.1 someday. The usual source of candidate\ntopics I use is messy and unusable for some unknown reason, but\noffhand I think these are safe and sensible to merge down to\n'maint':\n\n ds/line-log-asan-fix # 1 (2024-10-10) \n jk/fsmonitor-event-listener-race-fix # 2 (2024-10-15) \n ps/maintenance-start-crash-fix # 1 (2024-10-18) \n\nThanks.\n"},{"id":"507472","messageId":"Zzr4cgk_5MJNcHm1@pks.im","threadId":"62496","inReplyTo":"xmqq34js1kd2.fsf@gitster.g","subject":"Re: malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-11-18T08:19:04Z","receivedAt":"2024-11-18T08:19:17Z","isPatch":false,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Sat, Nov 16, 2024 at 02:23:53AM +0900, Junio C Hamano wrote:\n> René Scharfe writes:\n> \n> > This is a known error. Commit c95547a394 (builtin/gc: fix crash when\n> > running `git maintenance start`, 2024-10-10) fixes it, but has not made\n> > it into a released version, yet.\n> \n> Thanks.\n> \n> There are bunch of topics that could go to 'maint' and be part of a\n> maintenance topic, and this certainly looks like one of those topics\n> that can go into 2.47.1 someday. The usual source of candidate\n> topics I use is messy and unusable for some unknown reason, but\n> offhand I think these are safe and sensible to merge down to\n> 'maint':\n> \n> ds/line-log-asan-fix # 1 (2024-10-10) \n> jk/fsmonitor-event-listener-race-fix # 2 (2024-10-15) \n> ps/maintenance-start-crash-fix # 1 (2024-10-18) \n\nOther candidates that fix regressions:\n\n jk/fetch-prefetch-double-free-fix\n tb/multi-pack-reuse-dupfix\n pb/clar-build-fix\n ps/upgrade-clar\n wm/shortlog-hash\n\nI think that we have accumulated enough topics by now to warrant a\n2.47.1 release, but will of course leave that decision to you.\n\nThanks!\n\nPatrick\n"},{"id":"507492","messageId":"xmqqjzd0k92c.fsf@gitster.g","threadId":"62496","inReplyTo":"Zzr4cgk_5MJNcHm1@pks.im","subject":"Re: malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-11-18T12:42:03Z","receivedAt":"2024-11-18T12:42:05Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt writes:\n\n>> ds/line-log-asan-fix # 1 (2024-10-10) \n>> jk/fsmonitor-event-listener-race-fix # 2 (2024-10-15) \n>> ps/maintenance-start-crash-fix # 1 (2024-10-18) \n>\n> Other candidates that fix regressions:\n>\n> jk/fetch-prefetch-double-free-fix\n> tb/multi-pack-reuse-dupfix\n\nNeither of these has hit 'master' yet.\n\n> pb/clar-build-fix\n\nNot all that urgent (it is not end-user facing).\n\n> ps/upgrade-clar\n> wm/shortlog-hash\n\nUnfortuately, these were both based not on 'maint' but on 'master',\nand cannot ever be merged down to 'maint'. The last topic may\ndeserve to be cherry-picked to 'maint' when the time comes.\n\nRight now I have these lined up for 'maint'\n\n ds/line-log-asan-fix\n jk/fsmonitor-event-listener-race-fix\n ps/maintenance-start-crash-fix\n ps/cache-tree-w-broken-index-entry\n db/submodule-fetch-with-remote-name-fix\n\nThanks.\n"},{"id":"507496","messageId":"Zzs8JJO_HCLrEBM0@pks.im","threadId":"62496","inReplyTo":"xmqqjzd0k92c.fsf@gitster.g","subject":"Re: malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-11-18T13:07:48Z","receivedAt":"2024-11-18T13:08:00Z","isPatch":false,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Nov 18, 2024 at 09:42:03PM +0900, Junio C Hamano wrote:\n> Patrick Steinhardt writes:\n> > ps/upgrade-clar\n> > wm/shortlog-hash\n> \n> Unfortuately, these were both based not on 'maint' but on 'master',\n> and cannot ever be merged down to 'maint'. The last topic may\n> deserve to be cherry-picked to 'maint' when the time comes.\n\nWe got several reports about build failures with clar on esoteric\nplatforms, and ps/upgrade-clar fixes those. Distro maintainers can of\ncourse cherry-pick those patches, but I think it would make sense to\npull them into a maintenance release.\n\nI am happy to provide a backport for ps/upgrade-clar if you agree with\nme.\n\nPatrick\n"},{"id":"507532","messageId":"b09b16f5-4fa1-c802-86ac-9f0b1bcc9f53@gmail.com","threadId":"62496","inReplyTo":"xmqqjzd0k92c.fsf@gitster.g","subject":"Re: malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","fromName":"Philippe Blain","fromEmail":"levraiphilippeblain@gmail.com","sentAt":"2024-11-18T19:28:41Z","receivedAt":"2024-11-18T19:28:44Z","isPatch":false,"sender":{"key":"levraiphilippeblain@gmail.com","avatar":"https://avatars.githubusercontent.com/u/44212482?v=4"},"body":"Hi Junio,\n\nLe 2024-11-18 à 07:42, Junio C Hamano a écrit :\n> \n>> pb/clar-build-fix\n> \n> Not all that urgent (it is not end-user facing).\n\nI'm not sure what you mean by \"not end-user facing\".\nI ran into this issue while running 'make -j -l 2.5', \nas I mentioned when I sent the patch [1]. I guess you mean that\nend-users do not normally build the code themselves ?\n\nCheers,\n\nPhilippe.\n\n[1] https://lore.kernel.org/git/pull.1810.git.1728323033680.gitgitgadget@gmail.com/\n"},{"id":"507552","messageId":"xmqqy11ghzi6.fsf@gitster.g","threadId":"62496","inReplyTo":"Zzs8JJO_HCLrEBM0@pks.im","subject":"Re: malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-11-18T23:51:29Z","receivedAt":"2024-11-18T23:51:31Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt writes:\n\n> On Mon, Nov 18, 2024 at 09:42:03PM +0900, Junio C Hamano wrote:\n>> Patrick Steinhardt writes:\n>> > ps/upgrade-clar\n>> > wm/shortlog-hash\n>> \n>> Unfortuately, these were both based not on 'maint' but on 'master',\n>> and cannot ever be merged down to 'maint'. The last topic may\n>> deserve to be cherry-picked to 'maint' when the time comes.\n>\n> We got several reports about build failures with clar on esoteric\n> platforms, and ps/upgrade-clar fixes those. Distro maintainers can of\n> course cherry-pick those patches, but I think it would make sense to\n> pull them into a maintenance release.\n>\n> I am happy to provide a backport for ps/upgrade-clar if you agree with\n> me.\n\nI am primarily following the wish left by the interim maintainer.\nIf a fix was based on 'master', it was deemed not critical to be\ndownmerged to 'maint'. Other fixes may have been forked from\n'maint'. Cherry-picking is a declaration that the initial choice\nwas a grave mistake, and I'd rather avoid that for a small thing\nthat are not critical to the end-users and only affects developers.\n\nIn addition, for those building themselves, I'd prefer to nudge them\nto be on the latest release, and not backporting developer features\nat fringe like testing is probably a sensible way to do so.\n\nCherry-picking I can handle myself if it is necessaary. Accepting a\nnew patch from you would cost me more time than that ;-).\n\nThanks.\n"},{"id":"507556","messageId":"xmqqh684hxjv.fsf@gitster.g","threadId":"62496","inReplyTo":"b09b16f5-4fa1-c802-86ac-9f0b1bcc9f53@gmail.com","subject":"Re: malloc: *** error for object 0x1: pointer being freed was not allocated on MacOS with git 2.47.0","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-11-19T00:33:40Z","receivedAt":"2024-11-19T00:33:43Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Philippe Blain writes:\n\n> Hi Junio,\n>\n> Le 2024-11-18 à 07:42, Junio C Hamano a écrit :\n>> \n>>> pb/clar-build-fix\n>> \n>> Not all that urgent (it is not end-user facing).\n>\n> I'm not sure what you mean by \"not end-user facing\".\n> I ran into this issue while running 'make -j -l 2.5', \n\nAnything that needs to run \"make\" is by definition end-user facing\nin my book ;-)\n\nAs I said in my reply to Patrick, I am primarily following the\ndecision made by the interim maintainer when the fix was queued.\n\nThanks.\n"}]}