{"thread":{"id":"62430","subject":"[PATCH] t9101: Refactor test_expect_success format","startedAt":"2024-10-31T09:46:09Z","lastAt":"2024-11-18T08:34:59Z","messageCount":6,"participants":["Seyi Kuforiji","Taylor Blau","Seyi Chamber"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"506377","messageId":"20241031094554.68916-1-kuforiji98@gmail.com","threadId":"62430","inReplyTo":null,"subject":"[PATCH] t9101: Refactor test_expect_success format","fromName":"Seyi Kuforiji","fromEmail":"kuforiji98@gmail.com","sentAt":"2024-10-31T09:45:53Z","receivedAt":"2024-10-31T09:46:09Z","isPatch":true,"sender":{"key":"kuforiji98@gmail.com","avatar":"https://avatars.githubusercontent.com/u/94905626?v=4"},"body":"The current script uses an outdated formatting style for\ntest_expect_success blocks, where each argument is separated by a\nbackslash and newline. This style can lead to readability issues and\nmakes it harder to maintain the script.\n\nThe modern style consolidates\nthe multi-line command arguments into a single quoted block, which\nimproves readability, maintainability, and aligns the code with current\ncoding standards.\n\nSigned-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n---\n t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------\n 1 file changed, 26 insertions(+), 22 deletions(-)\n\ndiff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh\nindex b2ee626b9a..792f7896e4 100755\n--- a/t/t9101-git-svn-props.sh\n+++ b/t/t9101-git-svn-props.sh\n@@ -73,12 +73,13 @@ test_expect_success 'initialize git svn' 'git svn init \"$svnrepo\"'\n test_expect_success 'fetch revisions from svn' 'git svn fetch'\n \n name='test svn:keywords ignoring'\n-test_expect_success \"$name\" \\\n-\t'git checkout -b mybranch remotes/git-svn &&\n+test_expect_success \"$name\" '\n+\tgit checkout -b mybranch remotes/git-svn &&\n \techo Hi again >>kw.c &&\n \tgit commit -a -m \"test keywords ignoring\" &&\n \tgit svn set-tree remotes/git-svn..mybranch &&\n-\tgit pull . remotes/git-svn'\n+\tgit pull . remotes/git-svn\n+'\n \n expect='/* $Id$ */'\n got=\"$(sed -ne 2p kw.c)\"\n@@ -94,10 +95,11 @@ test_expect_success \"propset CR on crlf files\" '\n \t )\n '\n \n-test_expect_success 'fetch and pull latest from svn and checkout a new wc' \\\n-\t'git svn fetch &&\n-\t git pull . remotes/git-svn &&\n-\t svn_cmd co \"$svnrepo\" new_wc'\n+test_expect_success 'fetch and pull latest from svn and checkout a new wc' '\n+\tgit svn fetch &&\n+\tgit pull . remotes/git-svn &&\n+\tsvn_cmd co \"$svnrepo\" new_wc\n+'\n \n for i in crlf ne_crlf lf ne_lf cr ne_cr empty_cr empty_lf empty empty_crlf\n do\n@@ -110,15 +112,17 @@ cd test_wc\n \tprintf '$Id$\\rHello\\rWorld' >ne_cr\n \ta_cr=$(printf '$Id$\\r\\nHello\\r\\nWorld\\r\\n' | git hash-object --stdin)\n \ta_ne_cr=$(printf '$Id$\\r\\nHello\\r\\nWorld' | git hash-object --stdin)\n-\ttest_expect_success 'Set CRLF on cr files' \\\n-\t'svn_cmd propset svn:eol-style CRLF cr &&\n-\t svn_cmd propset svn:eol-style CRLF ne_cr &&\n-\t svn_cmd propset svn:keywords Id cr &&\n-\t svn_cmd propset svn:keywords Id ne_cr &&\n-\t svn_cmd commit -m \"propset CRLF on cr files\"'\n+\ttest_expect_success 'Set CRLF on cr files' '\n+\t\tsvn_cmd propset svn:eol-style CRLF cr &&\n+\t\tsvn_cmd propset svn:eol-style CRLF ne_cr &&\n+\t\tsvn_cmd propset svn:keywords Id cr &&\n+\t\tsvn_cmd propset svn:keywords Id ne_cr &&\n+\t\tsvn_cmd commit -m \"propset CRLF on cr files\"\n+\t'\n cd ..\n-test_expect_success 'fetch and pull latest from svn' \\\n-\t'git svn fetch && git pull . remotes/git-svn'\n+test_expect_success 'fetch and pull latest from svn' '\n+\tgit svn fetch && git pull . remotes/git-svn\n+'\n \n b_cr=\"$(git hash-object cr)\"\n b_ne_cr=\"$(git hash-object ne_cr)\"\n@@ -141,7 +145,7 @@ cat >show-ignore.expect <<\\EOF\n /deeply/nested/directory/no-such-file*\n EOF\n \n-test_expect_success 'test show-ignore' \"\n+test_expect_success 'test show-ignore' '\n \t(\n \t\tcd test_wc &&\n \t\tmkdir -p deeply/nested/directory &&\n@@ -155,7 +159,7 @@ no-such-file*\n \t) &&\n \tgit svn show-ignore >show-ignore.got &&\n \tcmp show-ignore.expect show-ignore.got\n-\"\n+'\n \n cat >create-ignore.expect <<\\EOF\n /no-such-file*\n@@ -170,7 +174,7 @@ cat >create-ignore-index.expect <<EOF\n 100644 $expectoid 0\tdeeply/nested/directory/.gitignore\n EOF\n \n-test_expect_success 'test create-ignore' \"\n+test_expect_success 'test create-ignore' '\n \tgit svn fetch && git pull . remotes/git-svn &&\n \tgit svn create-ignore &&\n \tcmp ./.gitignore create-ignore.expect &&\n@@ -179,7 +183,7 @@ test_expect_success 'test create-ignore' \"\n \tcmp ./deeply/nested/directory/.gitignore create-ignore.expect &&\n \tgit ls-files -s >ls_files_result &&\n \tgrep gitignore ls_files_result | cmp - create-ignore-index.expect\n-\t\"\n+'\n \n cat >prop.expect <<\\EOF\n \n@@ -207,7 +211,7 @@ test_expect_success 'test propget' '\n \ttest_propget svn:ignore nested/ ../prop.expect &&\n \ttest_propget svn:ignore ./nested ../prop.expect &&\n \ttest_propget svn:ignore .././deeply/nested ../prop.expect\n-\t'\n+'\n \n cat >prop.expect <<\\EOF\n Properties on '.':\n@@ -225,12 +229,12 @@ Properties on 'nested/directory/.keep':\n   svn:entry:uuid\n EOF\n \n-test_expect_success 'test proplist' \"\n+test_expect_success 'test proplist' '\n \tgit svn proplist . >actual &&\n \tcmp prop.expect actual &&\n \n \tgit svn proplist nested/directory/.keep >actual &&\n \tcmp prop2.expect actual\n-\t\"\n+'\n \n test_done\n-- \n2.47.0.86.g15030f9556\n\n"},{"id":"506405","messageId":"ZyPlYkwsFrxH+JwE@nand.local","threadId":"62430","inReplyTo":"20241031094554.68916-1-kuforiji98@gmail.com","subject":"Re: [PATCH] t9101: Refactor test_expect_success format","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-31T20:15:30Z","receivedAt":"2024-10-31T20:15:32Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Thu, Oct 31, 2024 at 10:45:53AM +0100, Seyi Kuforiji wrote:\n> The current script uses an outdated formatting style for\n> test_expect_success blocks, where each argument is separated by a\n> backslash and newline. This style can lead to readability issues and\n> makes it harder to maintain the script.\n>\n> The modern style consolidates\n> the multi-line command arguments into a single quoted block, which\n\nStrange line wrapping?\n\n> improves readability, maintainability, and aligns the code with current\n> coding standards.\n>\n> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n> ---\n>  t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------\n>  1 file changed, 26 insertions(+), 22 deletions(-)\n\nThis does not apply cleanly on 'master', so I assume that you wanted it\nbased on sk/t9101-cleanup. That's fine, but please let me know in the\nfuture in case it's every less obvious :-).\n\nThe changes themselves all look quite sensible, though.\n\nThanks,\nTaylor\n"},{"id":"506437","messageId":"CAGedMteyi0_C4PhfCXcD5gHe38px_g4hbxuG63o8tCSHdLcfGg@mail.gmail.com","threadId":"62430","inReplyTo":"ZyPlYkwsFrxH+JwE@nand.local","subject":"Re: [PATCH] t9101: Refactor test_expect_success format","fromName":"Seyi Chamber","fromEmail":"kuforiji98@gmail.com","sentAt":"2024-11-01T07:51:11Z","receivedAt":"2024-11-01T07:51:27Z","isPatch":true,"sender":{"key":"kuforiji98@gmail.com","avatar":"https://avatars.githubusercontent.com/u/94905626?v=4"},"body":"On Thu, 31 Oct 2024 at 21:15, Taylor Blau <me@ttaylorr.com> wrote:\n>\n> On Thu, Oct 31, 2024 at 10:45:53AM +0100, Seyi Kuforiji wrote:\n> > The current script uses an outdated formatting style for\n> > test_expect_success blocks, where each argument is separated by a\n> > backslash and newline. This style can lead to readability issues and\n> > makes it harder to maintain the script.\n> >\n> > The modern style consolidates\n> > the multi-line command arguments into a single quoted block, which\n>\n> Strange line wrapping?\n>\n\nThat error probably occurred while I was editing the message. Should I\nedit and send an updated patch?\n\n> > improves readability, maintainability, and aligns the code with current\n> > coding standards.\n> >\n> > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n> > ---\n> >  t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------\n> >  1 file changed, 26 insertions(+), 22 deletions(-)\n>\n> This does not apply cleanly on 'master', so I assume that you wanted it\n> based on sk/t9101-cleanup. That's fine, but please let me know in the\n> future in case it's every less obvious :-).\n>\n> The changes themselves all look quite sensible, though.\n>\n> Thanks,\n> Taylor\n\nThanks, Taylor for pointing out this issue. I have rebased my change\nonto the latest master branch and resolved the conflicts for future\nupdates.\n\nThanks,\nSeyi\n"},{"id":"506452","messageId":"ZyTo1lQaEVvZ1Eor@nand.local","threadId":"62430","inReplyTo":"CAGedMteyi0_C4PhfCXcD5gHe38px_g4hbxuG63o8tCSHdLcfGg@mail.gmail.com","subject":"Re: [PATCH] t9101: Refactor test_expect_success format","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-11-01T14:42:30Z","receivedAt":"2024-11-01T14:42:33Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Fri, Nov 01, 2024 at 08:51:11AM +0100, Seyi Chamber wrote:\n> On Thu, 31 Oct 2024 at 21:15, Taylor Blau <me@ttaylorr.com> wrote:\n> >\n> > On Thu, Oct 31, 2024 at 10:45:53AM +0100, Seyi Kuforiji wrote:\n> > > The current script uses an outdated formatting style for\n> > > test_expect_success blocks, where each argument is separated by a\n> > > backslash and newline. This style can lead to readability issues and\n> > > makes it harder to maintain the script.\n> > >\n> > > The modern style consolidates\n> > > the multi-line command arguments into a single quoted block, which\n> >\n> > Strange line wrapping?\n> >\n>\n> That error probably occurred while I was editing the message. Should I\n> edit and send an updated patch?\n\nPlease do so, thanks.\n\n> > > improves readability, maintainability, and aligns the code with current\n> > > coding standards.\n> > >\n> > > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n> > > ---\n> > >  t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------\n> > >  1 file changed, 26 insertions(+), 22 deletions(-)\n> >\n> > This does not apply cleanly on 'master', so I assume that you wanted it\n> > based on sk/t9101-cleanup. That's fine, but please let me know in the\n> > future in case it's every less obvious :-).\n> >\n> > The changes themselves all look quite sensible, though.\n> >\n> > Thanks,\n> > Taylor\n>\n> Thanks, Taylor for pointing out this issue. I have rebased my change\n> onto the latest master branch and resolved the conflicts for future\n> updates.\n\nThere is no specific need to rebase on top of current 'master' unless\nfailing to do so will cause the maintainer to see a conflicted state\nwhen applying.\n\nUnless told otherwise, I will apply new rounds of existing patch series\nonto top of their original base.\n\nThanks,\nTaylor\n"},{"id":"506480","messageId":"20241102102801.26432-1-kuforiji98@gmail.com","threadId":"62430","inReplyTo":"20241031094554.68916-1-kuforiji98@gmail.com","subject":"[PATCH v2] t9101: Refactor test_expect_success format","fromName":"Seyi Kuforiji","fromEmail":"kuforiji98@gmail.com","sentAt":"2024-11-02T10:28:01Z","receivedAt":"2024-11-02T10:28:30Z","isPatch":true,"sender":{"key":"kuforiji98@gmail.com","avatar":"https://avatars.githubusercontent.com/u/94905626?v=4"},"body":"The current script uses an outdated formatting style for\ntest_expect_success blocks, where each argument is separated by a\nbackslash and newline. This style can lead to readability issues and\nmakes it harder to maintain the script.The modern style consolidates the\nmulti-line command arguments into a single quoted block, which improves\nreadability, maintainability, and aligns the code with current coding\nstandards.\n\nSigned-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n---\n t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------\n 1 file changed, 26 insertions(+), 22 deletions(-)\n\ndiff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh\nindex b2ee626b9a..792f7896e4 100755\n--- a/t/t9101-git-svn-props.sh\n+++ b/t/t9101-git-svn-props.sh\n@@ -73,12 +73,13 @@ test_expect_success 'initialize git svn' 'git svn init \"$svnrepo\"'\n test_expect_success 'fetch revisions from svn' 'git svn fetch'\n \n name='test svn:keywords ignoring'\n-test_expect_success \"$name\" \\\n-\t'git checkout -b mybranch remotes/git-svn &&\n+test_expect_success \"$name\" '\n+\tgit checkout -b mybranch remotes/git-svn &&\n \techo Hi again >>kw.c &&\n \tgit commit -a -m \"test keywords ignoring\" &&\n \tgit svn set-tree remotes/git-svn..mybranch &&\n-\tgit pull . remotes/git-svn'\n+\tgit pull . remotes/git-svn\n+'\n \n expect='/* $Id$ */'\n got=\"$(sed -ne 2p kw.c)\"\n@@ -94,10 +95,11 @@ test_expect_success \"propset CR on crlf files\" '\n \t )\n '\n \n-test_expect_success 'fetch and pull latest from svn and checkout a new wc' \\\n-\t'git svn fetch &&\n-\t git pull . remotes/git-svn &&\n-\t svn_cmd co \"$svnrepo\" new_wc'\n+test_expect_success 'fetch and pull latest from svn and checkout a new wc' '\n+\tgit svn fetch &&\n+\tgit pull . remotes/git-svn &&\n+\tsvn_cmd co \"$svnrepo\" new_wc\n+'\n \n for i in crlf ne_crlf lf ne_lf cr ne_cr empty_cr empty_lf empty empty_crlf\n do\n@@ -110,15 +112,17 @@ cd test_wc\n \tprintf '$Id$\\rHello\\rWorld' >ne_cr\n \ta_cr=$(printf '$Id$\\r\\nHello\\r\\nWorld\\r\\n' | git hash-object --stdin)\n \ta_ne_cr=$(printf '$Id$\\r\\nHello\\r\\nWorld' | git hash-object --stdin)\n-\ttest_expect_success 'Set CRLF on cr files' \\\n-\t'svn_cmd propset svn:eol-style CRLF cr &&\n-\t svn_cmd propset svn:eol-style CRLF ne_cr &&\n-\t svn_cmd propset svn:keywords Id cr &&\n-\t svn_cmd propset svn:keywords Id ne_cr &&\n-\t svn_cmd commit -m \"propset CRLF on cr files\"'\n+\ttest_expect_success 'Set CRLF on cr files' '\n+\t\tsvn_cmd propset svn:eol-style CRLF cr &&\n+\t\tsvn_cmd propset svn:eol-style CRLF ne_cr &&\n+\t\tsvn_cmd propset svn:keywords Id cr &&\n+\t\tsvn_cmd propset svn:keywords Id ne_cr &&\n+\t\tsvn_cmd commit -m \"propset CRLF on cr files\"\n+\t'\n cd ..\n-test_expect_success 'fetch and pull latest from svn' \\\n-\t'git svn fetch && git pull . remotes/git-svn'\n+test_expect_success 'fetch and pull latest from svn' '\n+\tgit svn fetch && git pull . remotes/git-svn\n+'\n \n b_cr=\"$(git hash-object cr)\"\n b_ne_cr=\"$(git hash-object ne_cr)\"\n@@ -141,7 +145,7 @@ cat >show-ignore.expect <<\\EOF\n /deeply/nested/directory/no-such-file*\n EOF\n \n-test_expect_success 'test show-ignore' \"\n+test_expect_success 'test show-ignore' '\n \t(\n \t\tcd test_wc &&\n \t\tmkdir -p deeply/nested/directory &&\n@@ -155,7 +159,7 @@ no-such-file*\n \t) &&\n \tgit svn show-ignore >show-ignore.got &&\n \tcmp show-ignore.expect show-ignore.got\n-\"\n+'\n \n cat >create-ignore.expect <<\\EOF\n /no-such-file*\n@@ -170,7 +174,7 @@ cat >create-ignore-index.expect <<EOF\n 100644 $expectoid 0\tdeeply/nested/directory/.gitignore\n EOF\n \n-test_expect_success 'test create-ignore' \"\n+test_expect_success 'test create-ignore' '\n \tgit svn fetch && git pull . remotes/git-svn &&\n \tgit svn create-ignore &&\n \tcmp ./.gitignore create-ignore.expect &&\n@@ -179,7 +183,7 @@ test_expect_success 'test create-ignore' \"\n \tcmp ./deeply/nested/directory/.gitignore create-ignore.expect &&\n \tgit ls-files -s >ls_files_result &&\n \tgrep gitignore ls_files_result | cmp - create-ignore-index.expect\n-\t\"\n+'\n \n cat >prop.expect <<\\EOF\n \n@@ -207,7 +211,7 @@ test_expect_success 'test propget' '\n \ttest_propget svn:ignore nested/ ../prop.expect &&\n \ttest_propget svn:ignore ./nested ../prop.expect &&\n \ttest_propget svn:ignore .././deeply/nested ../prop.expect\n-\t'\n+'\n \n cat >prop.expect <<\\EOF\n Properties on '.':\n@@ -225,12 +229,12 @@ Properties on 'nested/directory/.keep':\n   svn:entry:uuid\n EOF\n \n-test_expect_success 'test proplist' \"\n+test_expect_success 'test proplist' '\n \tgit svn proplist . >actual &&\n \tcmp prop.expect actual &&\n \n \tgit svn proplist nested/directory/.keep >actual &&\n \tcmp prop2.expect actual\n-\t\"\n+'\n \n test_done\n-- \n2.47.0.86.g15030f9556\n\n"},{"id":"507474","messageId":"CAGedMtdQ6qcDAPf2oiFgqUrsOD3xk-7LFN=TsG7gqGw0QotQKw@mail.gmail.com","threadId":"62430","inReplyTo":"20241102102801.26432-1-kuforiji98@gmail.com","subject":"Re: [PATCH v2] t9101: Refactor test_expect_success format","fromName":"Seyi Chamber","fromEmail":"kuforiji98@gmail.com","sentAt":"2024-11-18T08:34:45Z","receivedAt":"2024-11-18T08:34:59Z","isPatch":true,"sender":{"key":"kuforiji98@gmail.com","avatar":"https://avatars.githubusercontent.com/u/94905626?v=4"},"body":"On Sat, 2 Nov 2024 at 11:28, Seyi Kuforiji <kuforiji98@gmail.com> wrote:\n>\n> The current script uses an outdated formatting style for\n> test_expect_success blocks, where each argument is separated by a\n> backslash and newline. This style can lead to readability issues and\n> makes it harder to maintain the script.The modern style consolidates the\n> multi-line command arguments into a single quoted block, which improves\n> readability, maintainability, and aligns the code with current coding\n> standards.\n>\n> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n> ---\n>  t/t9101-git-svn-props.sh | 48 ++++++++++++++++++++++------------------\n>  1 file changed, 26 insertions(+), 22 deletions(-)\n>\n> diff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh\n> index b2ee626b9a..792f7896e4 100755\n> --- a/t/t9101-git-svn-props.sh\n> +++ b/t/t9101-git-svn-props.sh\n> @@ -73,12 +73,13 @@ test_expect_success 'initialize git svn' 'git svn init \"$svnrepo\"'\n>  test_expect_success 'fetch revisions from svn' 'git svn fetch'\n>\n>  name='test svn:keywords ignoring'\n> -test_expect_success \"$name\" \\\n> -       'git checkout -b mybranch remotes/git-svn &&\n> +test_expect_success \"$name\" '\n> +       git checkout -b mybranch remotes/git-svn &&\n>         echo Hi again >>kw.c &&\n>         git commit -a -m \"test keywords ignoring\" &&\n>         git svn set-tree remotes/git-svn..mybranch &&\n> -       git pull . remotes/git-svn'\n> +       git pull . remotes/git-svn\n> +'\n>\n>  expect='/* $Id$ */'\n>  got=\"$(sed -ne 2p kw.c)\"\n> @@ -94,10 +95,11 @@ test_expect_success \"propset CR on crlf files\" '\n>          )\n>  '\n>\n> -test_expect_success 'fetch and pull latest from svn and checkout a new wc' \\\n> -       'git svn fetch &&\n> -        git pull . remotes/git-svn &&\n> -        svn_cmd co \"$svnrepo\" new_wc'\n> +test_expect_success 'fetch and pull latest from svn and checkout a new wc' '\n> +       git svn fetch &&\n> +       git pull . remotes/git-svn &&\n> +       svn_cmd co \"$svnrepo\" new_wc\n> +'\n>\n>  for i in crlf ne_crlf lf ne_lf cr ne_cr empty_cr empty_lf empty empty_crlf\n>  do\n> @@ -110,15 +112,17 @@ cd test_wc\n>         printf '$Id$\\rHello\\rWorld' >ne_cr\n>         a_cr=$(printf '$Id$\\r\\nHello\\r\\nWorld\\r\\n' | git hash-object --stdin)\n>         a_ne_cr=$(printf '$Id$\\r\\nHello\\r\\nWorld' | git hash-object --stdin)\n> -       test_expect_success 'Set CRLF on cr files' \\\n> -       'svn_cmd propset svn:eol-style CRLF cr &&\n> -        svn_cmd propset svn:eol-style CRLF ne_cr &&\n> -        svn_cmd propset svn:keywords Id cr &&\n> -        svn_cmd propset svn:keywords Id ne_cr &&\n> -        svn_cmd commit -m \"propset CRLF on cr files\"'\n> +       test_expect_success 'Set CRLF on cr files' '\n> +               svn_cmd propset svn:eol-style CRLF cr &&\n> +               svn_cmd propset svn:eol-style CRLF ne_cr &&\n> +               svn_cmd propset svn:keywords Id cr &&\n> +               svn_cmd propset svn:keywords Id ne_cr &&\n> +               svn_cmd commit -m \"propset CRLF on cr files\"\n> +       '\n>  cd ..\n> -test_expect_success 'fetch and pull latest from svn' \\\n> -       'git svn fetch && git pull . remotes/git-svn'\n> +test_expect_success 'fetch and pull latest from svn' '\n> +       git svn fetch && git pull . remotes/git-svn\n> +'\n>\n>  b_cr=\"$(git hash-object cr)\"\n>  b_ne_cr=\"$(git hash-object ne_cr)\"\n> @@ -141,7 +145,7 @@ cat >show-ignore.expect <<\\EOF\n>  /deeply/nested/directory/no-such-file*\n>  EOF\n>\n> -test_expect_success 'test show-ignore' \"\n> +test_expect_success 'test show-ignore' '\n>         (\n>                 cd test_wc &&\n>                 mkdir -p deeply/nested/directory &&\n> @@ -155,7 +159,7 @@ no-such-file*\n>         ) &&\n>         git svn show-ignore >show-ignore.got &&\n>         cmp show-ignore.expect show-ignore.got\n> -\"\n> +'\n>\n>  cat >create-ignore.expect <<\\EOF\n>  /no-such-file*\n> @@ -170,7 +174,7 @@ cat >create-ignore-index.expect <<EOF\n>  100644 $expectoid 0    deeply/nested/directory/.gitignore\n>  EOF\n>\n> -test_expect_success 'test create-ignore' \"\n> +test_expect_success 'test create-ignore' '\n>         git svn fetch && git pull . remotes/git-svn &&\n>         git svn create-ignore &&\n>         cmp ./.gitignore create-ignore.expect &&\n> @@ -179,7 +183,7 @@ test_expect_success 'test create-ignore' \"\n>         cmp ./deeply/nested/directory/.gitignore create-ignore.expect &&\n>         git ls-files -s >ls_files_result &&\n>         grep gitignore ls_files_result | cmp - create-ignore-index.expect\n> -       \"\n> +'\n>\n>  cat >prop.expect <<\\EOF\n>\n> @@ -207,7 +211,7 @@ test_expect_success 'test propget' '\n>         test_propget svn:ignore nested/ ../prop.expect &&\n>         test_propget svn:ignore ./nested ../prop.expect &&\n>         test_propget svn:ignore .././deeply/nested ../prop.expect\n> -       '\n> +'\n>\n>  cat >prop.expect <<\\EOF\n>  Properties on '.':\n> @@ -225,12 +229,12 @@ Properties on 'nested/directory/.keep':\n>    svn:entry:uuid\n>  EOF\n>\n> -test_expect_success 'test proplist' \"\n> +test_expect_success 'test proplist' '\n>         git svn proplist . >actual &&\n>         cmp prop.expect actual &&\n>\n>         git svn proplist nested/directory/.keep >actual &&\n>         cmp prop2.expect actual\n> -       \"\n> +'\n>\n>  test_done\n> --\n> 2.47.0.86.g15030f9556\n>\n\nHi Taylor,\n\nI trust you're well.\n\nI didn't get any status update on the patch I updated the commit\nmessage, found here:\nhttps://public-inbox.org/git/20241102102801.26432-1-kuforiji98@gmail.com/\n\nIs it good to go?\n\nThanks\nSeyi\n"}]}