{"thread":{"id":"62396","subject":"[PATCH Outreachy] t9101: ensure no whitespace after redirect","startedAt":"2024-10-23T12:11:22Z","lastAt":"2024-10-23T18:57:01Z","messageCount":3,"participants":["Seyi Kuforiji","Kristoffer Haugsbakk","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"505925","messageId":"20241023121113.915310-1-kuforiji98@gmail.com","threadId":"62396","inReplyTo":null,"subject":"[PATCH Outreachy] t9101: ensure no whitespace after redirect","fromName":"Seyi Kuforiji","fromEmail":"kuforiji98@gmail.com","sentAt":"2024-10-23T12:11:12Z","receivedAt":"2024-10-23T12:11:22Z","isPatch":true,"sender":{"key":"kuforiji98@gmail.com","avatar":"https://avatars.githubusercontent.com/u/94905626?v=4"},"body":"This change updates the script to conform to the coding\nstandards outlined in the Git project's documentation. According to the\nguidelines in Documentation/CodingGuidelines under \"Redirection\noperators\", there should be no whitespace after redirection operators.\n\nSigned-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n---\n t/t9101-git-svn-props.sh | 34 +++++++++++++++++-----------------\n 1 file changed, 17 insertions(+), 17 deletions(-)\n\ndiff --git a/t/t9101-git-svn-props.sh b/t/t9101-git-svn-props.sh\nindex 52046e60d5..b2ee626b9a 100755\n--- a/t/t9101-git-svn-props.sh\n+++ b/t/t9101-git-svn-props.sh\n@@ -21,32 +21,32 @@ a_empty_cr=\n a_empty_crlf=\n \n cd import\n-\tcat >> kw.c <<\\EOF\n+\tcat >>kw.c <<\\EOF\n /* Somebody prematurely put a keyword into this file */\n /* $Id$ */\n EOF\n \n-\tprintf \"Hello\\r\\nWorld\\r\\n\" > crlf\n+\tprintf \"Hello\\r\\nWorld\\r\\n\" >crlf\n \ta_crlf=$(git hash-object -w crlf)\n-\tprintf \"Hello\\rWorld\\r\" > cr\n+\tprintf \"Hello\\rWorld\\r\" >cr\n \ta_cr=$(git hash-object -w cr)\n-\tprintf \"Hello\\nWorld\\n\" > lf\n+\tprintf \"Hello\\nWorld\\n\" >lf\n \ta_lf=$(git hash-object -w lf)\n \n-\tprintf \"Hello\\r\\nWorld\" > ne_crlf\n+\tprintf \"Hello\\r\\nWorld\" >ne_crlf\n \ta_ne_crlf=$(git hash-object -w ne_crlf)\n-\tprintf \"Hello\\nWorld\" > ne_lf\n+\tprintf \"Hello\\nWorld\" >ne_lf\n \ta_ne_lf=$(git hash-object -w ne_lf)\n-\tprintf \"Hello\\rWorld\" > ne_cr\n+\tprintf \"Hello\\rWorld\" >ne_cr\n \ta_ne_cr=$(git hash-object -w ne_cr)\n \n \ttouch empty\n \ta_empty=$(git hash-object -w empty)\n-\tprintf \"\\n\" > empty_lf\n+\tprintf \"\\n\" >empty_lf\n \ta_empty_lf=$(git hash-object -w empty_lf)\n-\tprintf \"\\r\" > empty_cr\n+\tprintf \"\\r\" >empty_cr\n \ta_empty_cr=$(git hash-object -w empty_cr)\n-\tprintf \"\\r\\n\" > empty_crlf\n+\tprintf \"\\r\\n\" >empty_crlf\n \ta_empty_crlf=$(git hash-object -w empty_crlf)\n \n \tsvn_cmd import --no-auto-props -m 'import for git svn' . \"$svnrepo\" >/dev/null\n@@ -57,10 +57,10 @@ test_expect_success 'checkout working copy from svn' 'svn co \"$svnrepo\" test_wc'\n test_expect_success 'setup some commits to svn' '\n \t(\n \t\tcd test_wc &&\n-\t\techo Greetings >> kw.c &&\n+\t\techo Greetings >>kw.c &&\n \t\tpoke kw.c &&\n \t\tsvn_cmd commit -m \"Not yet an Id\" &&\n-\t\techo Hello world >> kw.c &&\n+\t\techo Hello world >>kw.c &&\n \t\tpoke kw.c &&\n \t\tsvn_cmd commit -m \"Modified file, but still not yet an Id\" &&\n \t\tsvn_cmd propset svn:keywords Id kw.c &&\n@@ -75,7 +75,7 @@ test_expect_success 'fetch revisions from svn' 'git svn fetch'\n name='test svn:keywords ignoring'\n test_expect_success \"$name\" \\\n \t'git checkout -b mybranch remotes/git-svn &&\n-\techo Hi again >> kw.c &&\n+\techo Hi again >>kw.c &&\n \tgit commit -a -m \"test keywords ignoring\" &&\n \tgit svn set-tree remotes/git-svn..mybranch &&\n \tgit pull . remotes/git-svn'\n@@ -106,8 +106,8 @@ done\n \n \n cd test_wc\n-\tprintf '$Id$\\rHello\\rWorld\\r' > cr\n-\tprintf '$Id$\\rHello\\rWorld' > ne_cr\n+\tprintf '$Id$\\rHello\\rWorld\\r' >cr\n+\tprintf '$Id$\\rHello\\rWorld' >ne_cr\n \ta_cr=$(printf '$Id$\\r\\nHello\\r\\nWorld\\r\\n' | git hash-object --stdin)\n \ta_ne_cr=$(printf '$Id$\\r\\nHello\\r\\nWorld' | git hash-object --stdin)\n \ttest_expect_success 'Set CRLF on cr files' \\\n@@ -126,7 +126,7 @@ b_ne_cr=\"$(git hash-object ne_cr)\"\n test_expect_success 'CRLF + $Id$' \"test '$a_cr' = '$b_cr'\"\n test_expect_success 'CRLF + $Id$ (no newline)' \"test '$a_ne_cr' = '$b_ne_cr'\"\n \n-cat > show-ignore.expect <<\\EOF\n+cat >show-ignore.expect <<\\EOF\n \n # /\n /no-such-file*\n@@ -153,7 +153,7 @@ no-such-file*\n ' . &&\n \t\tsvn_cmd commit -m 'propset svn:ignore'\n \t) &&\n-\tgit svn show-ignore > show-ignore.got &&\n+\tgit svn show-ignore >show-ignore.got &&\n \tcmp show-ignore.expect show-ignore.got\n \"\n \n-- \n2.47.0.86.g15030f9556\n\n"},{"id":"505948","messageId":"97e5c9ec-28c7-4f37-9dae-26e4219f1f98@app.fastmail.com","threadId":"62396","inReplyTo":"20241023121113.915310-1-kuforiji98@gmail.com","subject":"Re: [PATCH Outreachy] t9101: ensure no whitespace after redirect","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-10-23T16:46:42Z","receivedAt":"2024-10-23T16:47:04Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"Hi\n\nOn Wed, Oct 23, 2024, at 14:11, Seyi Kuforiji wrote:\n> This change updates the script to conform to the coding\n> standards outlined in the Git project's documentation. According to the\n> guidelines in Documentation/CodingGuidelines under \"Redirection\n> operators\", there should be no whitespace after redirection operators.\n>\n> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n\nI can confirmt that this patch, when applied, fixes all of the instances\nof this style violation.\n\nThanks!\n\n-- \nKristoffer Haugsbakk\n"},{"id":"505966","messageId":"ZxlG+4AFGtOBK0eM@nand.local","threadId":"62396","inReplyTo":"97e5c9ec-28c7-4f37-9dae-26e4219f1f98@app.fastmail.com","subject":"Re: [PATCH Outreachy] t9101: ensure no whitespace after redirect","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-23T18:56:59Z","receivedAt":"2024-10-23T18:57:01Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Wed, Oct 23, 2024 at 06:46:42PM +0200, Kristoffer Haugsbakk wrote:\n> Hi\n>\n> On Wed, Oct 23, 2024, at 14:11, Seyi Kuforiji wrote:\n> > This change updates the script to conform to the coding\n> > standards outlined in the Git project's documentation. According to the\n> > guidelines in Documentation/CodingGuidelines under \"Redirection\n> > operators\", there should be no whitespace after redirection operators.\n> >\n> > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n>\n> I can confirmt that this patch, when applied, fixes all of the instances\n> of this style violation.\n\nThanks, both. Will queue.\n\nThanks,\nTaylor\n"}]}