{"thread":{"id":"62389","subject":"Build failure on RHEL7 with 2.47.0","startedAt":"2024-10-22T13:05:04Z","lastAt":"2024-10-22T21:30:26Z","messageCount":4,"participants":["Mike Lothian","Patrick Steinhardt","Torsten Bögershausen","brian m. carlson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"505825","messageId":"CAHbf0-GMV9VS7BAjvZiNENNOdZqV3jQ4+0k1kTZLkQhFT=6D-Q@mail.gmail.com","threadId":"62389","inReplyTo":null,"subject":"Build failure on RHEL7 with 2.47.0","fromName":"Mike Lothian","fromEmail":"mike@fireburn.co.uk","sentAt":"2024-10-22T13:04:52Z","receivedAt":"2024-10-22T13:05:04Z","isPatch":false,"sender":{"key":"mike@fireburn.co.uk","avatar":null},"body":"Hi\n\nI'm seeing build failures on RHEL7 when trying to build 2.47.0 - RHEL8\nseems to be fine\n\n\n\n    CC t/unit-tests/clar/clar.o\n    CC t/unit-tests/unit-test.o\nt/unit-tests/clar/clar.c: In function ‘clar_time_now’:\nt/unit-tests/clar/clar.c:274:18: error: storage size of ‘tz’ isn’t known\n  274 |  struct timezone tz;\n      |                  ^~\nt/unit-tests/clar/clar.c: In function ‘clar_parse_args’:\nt/unit-tests/clar/clar.c:543:47: warning: implicit declaration of\nfunction ‘strdup’; did you mean ‘strcmp’?\n[-Wimplicit-function-declaration]\n  543 |    _clar.summary_filename = *(argument + 2) ? strdup(argument\n+ 2) : NULL;\n      |                                               ^~~~~~\n      |                                               strcmp\nt/unit-tests/clar/clar.c:543:68: warning: pointer/integer type\nmismatch in conditional expression\n  543 |    _clar.summary_filename = *(argument + 2) ? strdup(argument\n+ 2) : NULL;\n      |                                                                    ^\nt/unit-tests/clar/clar.c: In function ‘clar_test_init’:\nt/unit-tests/clar/clar.c:569:26: warning: assignment to ‘char *’ from\n‘int’ makes pointer from integer without a cast [-Wint-conversion]\n  569 |   _clar.summary_filename = strdup(summary_env);\n      |                          ^\nt/unit-tests/clar/clar.c:573:26: warning: assignment to ‘char *’ from\n‘int’ makes pointer from integer without a cast [-Wint-conversion]\n  573 |   _clar.summary_filename = strdup(\"summary.xml\");\n      |                          ^\nt/unit-tests/clar/clar.c: In function ‘clar__fail’:\nt/unit-tests/clar/clar.c:692:22: warning: assignment to ‘char *’ from\n‘int’ makes pointer from integer without a cast [-Wint-conversion]\n  692 |   error->description = strdup(description);\n      |                      ^\nIn file included from t/unit-tests/clar/clar.c:838:\nt/unit-tests/clar/clar/sandbox.h: In function ‘build_sandbox_path’:\nt/unit-tests/clar/clar/sandbox.h:138:6: warning: implicit declaration\nof function ‘mkdtemp’ [-Wimplicit-function-declaration]\n  138 |  if (mkdtemp(_clar_path) == NULL)\n      |      ^~~~~~~\nt/unit-tests/clar/clar/sandbox.h:138:26: warning: comparison between\npointer and integer\n  138 |  if (mkdtemp(_clar_path) == NULL)\n      |                          ^~\nIn file included from t/unit-tests/clar/clar.c:92:\nt/unit-tests/clar/clar/fs.h: In function ‘fs_copy’:\nt/unit-tests/clar/clar/fs.h:446:16: warning: implicit declaration of\nfunction ‘lstat’; did you mean ‘fstat’?\n[-Wimplicit-function-declaration]\n  446 |  cl_must_pass_(lstat(source, &source_st), \"Failed to stat copy source\");\n      |                ^~~~~\nt/unit-tests/clar/clar.h:89:49: note: in definition of macro ‘cl_must_pass_’\n   89 | #define cl_must_pass_(expr, desc) clar__assert((expr) >= 0,\n__FILE__, __func__, __LINE__, \"Function call failed: \" #expr, desc, 1)\n      |                                                 ^~~~\nmake: *** [t/unit-tests/clar/clar.o] Error 1\nmake: *** Waiting for unfinished jobs....\n\nHave I done something silly or is it just too old?\n\nThanks\n\nMike\n"},{"id":"505832","messageId":"Zxeu7GbcXa-kOzLf@pks.im","threadId":"62389","inReplyTo":"CAHbf0-GMV9VS7BAjvZiNENNOdZqV3jQ4+0k1kTZLkQhFT=6D-Q@mail.gmail.com","subject":"Re: Build failure on RHEL7 with 2.47.0","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-10-22T13:55:56Z","receivedAt":"2024-10-22T13:56:06Z","isPatch":false,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Oct 22, 2024 at 02:04:52PM +0100, Mike Lothian wrote:\n> Have I done something silly or is it just too old?\n\nNo, you haven't done anything silly. These are all getting fixed by the\npatch series posted at [1]. I'd be happy to hear whether those patches\nfix the issue for you.\n\nPatrick\n\n[1]: https://lore.kernel.org/git/cover.1729506329.git.ps@pks.im/\n"},{"id":"505833","messageId":"20241022140340.GA31399@tb-raspi4","threadId":"62389","inReplyTo":"CAHbf0-GMV9VS7BAjvZiNENNOdZqV3jQ4+0k1kTZLkQhFT=6D-Q@mail.gmail.com","subject":"Re: Build failure on RHEL7 with 2.47.0","fromName":"Torsten Bögershausen","fromEmail":"tboegi@web.de","sentAt":"2024-10-22T14:03:40Z","receivedAt":"2024-10-22T14:03:49Z","isPatch":false,"sender":{"key":"tboegi@web.de","avatar":"https://avatars.githubusercontent.com/u/7138363?v=4"},"body":"On Tue, Oct 22, 2024 at 02:04:52PM +0100, Mike Lothian wrote:\n> Hi\n>\n> I'm seeing build failures on RHEL7 when trying to build 2.47.0 - RHEL8\n> seems to be fine\n>\n>\n[]\n>\n> Have I done something silly or is it just too old?\n\n2 questions, 2 answers: No, yes.\nThere hasn't been much focus on supporting these/this old platform(s)\nthe last weeks or months.\nThanks for reporting, I myself can no longer compile Git under centos 7\nany more, but I am happy to work on patches.\n\n>\n> Thanks\n>\n> Mike\n>\n"},{"id":"505870","messageId":"ZxgZa74fplSUUL5W@tapette.crustytoothpaste.net","threadId":"62389","inReplyTo":"20241022140340.GA31399@tb-raspi4","subject":"Re: Build failure on RHEL7 with 2.47.0","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2024-10-22T21:30:19Z","receivedAt":"2024-10-22T21:30:26Z","isPatch":false,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2024-10-22 at 14:03:40, Torsten Bögershausen wrote:\n> On Tue, Oct 22, 2024 at 02:04:52PM +0100, Mike Lothian wrote:\n> > Hi\n> >\n> > I'm seeing build failures on RHEL7 when trying to build 2.47.0 - RHEL8\n> > seems to be fine\n> >\n> >\n> []\n> >\n> > Have I done something silly or is it just too old?\n> \n> 2 questions, 2 answers: No, yes.\n> There hasn't been much focus on supporting these/this old platform(s)\n> the last weeks or months.\n> Thanks for reporting, I myself can no longer compile Git under centos 7\n> any more, but I am happy to work on patches.\n\nI think RHEL/CentOS 7 is too old to support according to our platform\nsupport policy.  It's no longer receiving regular LTS support.\n\nThe clar patches I do believe will be coming in soon, but I think users\nwill need to upgrade on CentOS 7 nonetheless.\n-- \nbrian m. carlson (they/them or he/him)\nToronto, Ontario, CA\n"}]}