{"thread":{"id":"62387","subject":"[PATCH v2] t1016: clean up style","startedAt":"2024-10-22T11:07:38Z","lastAt":"2024-10-23T10:26:24Z","messageCount":3,"participants":["Andrew Kreimer","Taylor Blau"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"505817","messageId":"20241022110730.7655-1-algonell@gmail.com","threadId":"62387","inReplyTo":null,"subject":"[PATCH v2] t1016: clean up style","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-10-22T11:07:30Z","receivedAt":"2024-10-22T11:07:38Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"Use `test_config`.\n\nRemove whitespace after redirect operator.\n\nReported-by: Taylor Blau <me@ttaylorr.com>\nSigned-off-by: Andrew Kreimer <algonell@gmail.com>\n---\nv1:\n  - https://lore.kernel.org/all/20241020121729.27032-1-algonell@gmail.com/\n\nv2:\n  - Base on \"ak/typofix\":\n    - https://lore.kernel.org/all/20241017112835.10100-1-algonell@gmail.com/\n  - Tested:\n    - ubuntu-latest, GitHub Actions.\n\n t/t1016-compatObjectFormat.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1016-compatObjectFormat.sh b/t/t1016-compatObjectFormat.sh\nindex 92024fe51d..8341a2fe83 100755\n--- a/t/t1016-compatObjectFormat.sh\n+++ b/t/t1016-compatObjectFormat.sh\n@@ -116,8 +116,8 @@ do\n \t\tgit config core.repositoryformatversion 1 &&\n \t\tgit config extensions.objectformat $hash &&\n \t\tgit config extensions.compatobjectformat $(compat_hash $hash) &&\n-\t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n-\t\techo \"Hello World!\" > hello &&\n+\t\ttest_config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n+\t\techo \"Hello World!\" >hello &&\n \t\teval hello_${hash}_oid=$(git hash-object hello) &&\n \t\tgit update-index --add hello &&\n \t\tgit commit -m \"Initial commit\" &&\n-- \n2.39.5\n\n"},{"id":"505841","messageId":"ZxfUngQKdGZq2dWf@nand.local","threadId":"62387","inReplyTo":"20241022110730.7655-1-algonell@gmail.com","subject":"Re: [PATCH v2] t1016: clean up style","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-22T16:36:46Z","receivedAt":"2024-10-22T16:36:49Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Tue, Oct 22, 2024 at 02:07:30PM +0300, Andrew Kreimer wrote:\n> Use `test_config`.\n>\n> Remove whitespace after redirect operator.\n>\n> Reported-by: Taylor Blau <me@ttaylorr.com>\n> Signed-off-by: Andrew Kreimer <algonell@gmail.com>\n> ---\n> v1:\n>   - https://lore.kernel.org/all/20241020121729.27032-1-algonell@gmail.com/\n>\n> v2:\n>   - Base on \"ak/typofix\":\n>     - https://lore.kernel.org/all/20241017112835.10100-1-algonell@gmail.com/\n>   - Tested:\n>     - ubuntu-latest, GitHub Actions.\n\nThanks. In the future, it's preferred to send subsequent rounds in a\nreply to the initial round so that the discussion all happens in the\nsame thread.\n\nRegardless, thank you for this patch, I've queued it. It looks good to\nme, but perhaps others could chime in before we start merging this one\ndown.\n\n>  t/t1016-compatObjectFormat.sh | 4 ++--\n>  1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/t/t1016-compatObjectFormat.sh b/t/t1016-compatObjectFormat.sh\n> index 92024fe51d..8341a2fe83 100755\n> --- a/t/t1016-compatObjectFormat.sh\n> +++ b/t/t1016-compatObjectFormat.sh\n> @@ -116,8 +116,8 @@ do\n>  \t\tgit config core.repositoryformatversion 1 &&\n>  \t\tgit config extensions.objectformat $hash &&\n>  \t\tgit config extensions.compatobjectformat $(compat_hash $hash) &&\n> -\t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> -\t\techo \"Hello World!\" > hello &&\n> +\t\ttest_config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> +\t\techo \"Hello World!\" >hello &&\n>  \t\teval hello_${hash}_oid=$(git hash-object hello) &&\n>  \t\tgit update-index --add hello &&\n>  \t\tgit commit -m \"Initial commit\" &&\n> --\n> 2.39.5\n>\nThanks,\nTaylor\n"},{"id":"505919","messageId":"ZxjPTDYQGg-IvNuL@void.void","threadId":"62387","inReplyTo":"ZxfUngQKdGZq2dWf@nand.local","subject":"Re: [PATCH v2] t1016: clean up style","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-10-23T10:26:20Z","receivedAt":"2024-10-23T10:26:24Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"On Tue, Oct 22, 2024 at 12:36:46PM -0400, Taylor Blau wrote:\n> Thanks. In the future, it's preferred to send subsequent rounds in a\n> reply to the initial round so that the discussion all happens in the\n> same thread.\n\nNoted, thank you.\n"}]}