{"thread":{"id":"62376","subject":"[PATCH] SubmittingPatches: tags -> trailers","startedAt":"2024-10-20T16:57:22Z","lastAt":"2024-10-21T21:22:53Z","messageCount":3,"participants":["kristofferhaugsbakk@fastmail.com","Josh Soref","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"505565","messageId":"d3a1ba01104da8496d52308c07c5c274fd30b0c2.1729443395.git.code@khaugsbakk.name","threadId":"62376","inReplyTo":null,"subject":"[PATCH] SubmittingPatches: tags -> trailers","fromName":"","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-10-20T16:57:01Z","receivedAt":"2024-10-20T16:57:22Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"From: Kristoffer Haugsbakk \n\n“Trailer” is the preferred nomenclature in this project. Also add a\ndefinite article where I think it makes sense.\n\nAs we can see the rest of the document already prefers this term. This\njust gets rid of the last stragglers.\n\nSigned-off-by: Kristoffer Haugsbakk \n---\n\nNotes (series):\n Commit message:\n \n “ “Trailer” is the preferred nomenclature in this project.\n \n Must surely be true since git-interpret-trailers(1) does not even\n contain the string “tag”.\n \n I did a grep in this directory:\n \n git grep tags ':(exclude)RelNotes'\n \n It didn’t look like there were any other mentions of “tags” in this\n sense. Of course it was difficult to look through.\n \n +CC: Josh Soref based on\n e.g. ac9fff2bf1c (SubmittingPatches: discourage new trailers,\n 2023-12-28)\n\n Documentation/SubmittingPatches | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex d8a8caa7916..db17bc7fe2c 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -412,13 +412,13 @@ Also notice that a real name is used in the `Signed-off-by` trailer. Please\n don't hide your real name.\n \n [[commit-trailers]]\n-If you like, you can put extra tags at the end:\n+If you like, you can put extra trailers at the end:\n \n . `Reported-by:` is used to credit someone who found the bug that\n the patch attempts to fix.\n . `Acked-by:` says that the person who is more familiar with the area\n the patch attempts to modify liked the patch.\n-. `Reviewed-by:`, unlike the other tags, can only be offered by the\n+. `Reviewed-by:`, unlike the other trailers, can only be offered by the\n reviewers themselves when they are completely satisfied with the\n patch after a detailed analysis.\n . `Tested-by:` is used to indicate that the person applied the patch\n@@ -436,7 +436,7 @@ While you can also create your own trailer if the situation warrants it, we\n encourage you to instead use one of the common trailers in this project\n highlighted above.\n \n-Only capitalize the very first letter of tags, i.e. favor\n+Only capitalize the very first letter of the trailer, i.e. favor\n \"Signed-off-by\" over \"Signed-Off-By\" and \"Acked-by:\" over \"Acked-By\".\n \n [[git-tools]]\n\nbase-commit: 34b6ce9b30747131b6e781ff718a45328aa887d0\n-- \n2.46.1.641.g54e7913fcb6\n\n"},{"id":"505579","messageId":"CACZqfqBnqPpngxkYPhokOPdQN0T6tH4Zuzwv_wLgFCnY9FTXLA@mail.gmail.com","threadId":"62376","inReplyTo":"d3a1ba01104da8496d52308c07c5c274fd30b0c2.1729443395.git.code@khaugsbakk.name","subject":"Re: [PATCH] SubmittingPatches: tags -> trailers","fromName":"Josh Soref","fromEmail":"jsoref@gmail.com","sentAt":"2024-10-20T21:29:14Z","receivedAt":"2024-10-20T21:29:26Z","isPatch":true,"sender":{"key":"jsoref@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2119212?v=4"},"body":"Kristoffer Haugsbakk wrote:\n> “Trailer” is the preferred nomenclature in this project. Also add a\n> definite article where I think it makes sense.\n>\n> As we can see the rest of the document already prefers this term. This\n> just gets rid of the last stragglers.\n>\n> Signed-off-by: Kristoffer Haugsbakk \n> ---\n>\n> Notes (series):\n> Commit message:\n>\n> “ “Trailer” is the preferred nomenclature in this project.\n>\n> Must surely be true since git-interpret-trailers(1) does not even\n> contain the string “tag”.\n>\n> I did a grep in this directory:\n>\n> git grep tags ':(exclude)RelNotes'\n>\n> It didn’t look like there were any other mentions of “tags” in this\n> sense. Of course it was difficult to look through.\n>\n> +CC: Josh Soref based on\n> e.g. ac9fff2bf1c (SubmittingPatches: discourage new trailers,\n> 2023-12-28)\n\nThis change makes sense to me.\n"},{"id":"505772","messageId":"ZxbGKvsrTdlxsJNS@nand.local","threadId":"62376","inReplyTo":"CACZqfqBnqPpngxkYPhokOPdQN0T6tH4Zuzwv_wLgFCnY9FTXLA@mail.gmail.com","subject":"Re: [PATCH] SubmittingPatches: tags -> trailers","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-21T21:22:50Z","receivedAt":"2024-10-21T21:22:53Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sun, Oct 20, 2024 at 05:29:14PM -0400, Josh Soref wrote:\n> Kristoffer Haugsbakk wrote:\n> > “Trailer” is the preferred nomenclature in this project. Also add a\n> > definite article where I think it makes sense.\n> >\n> > As we can see the rest of the document already prefers this term. This\n> > just gets rid of the last stragglers.\n> >\n> > Signed-off-by: Kristoffer Haugsbakk \n> > ---\n> >\n> > Notes (series):\n> > Commit message:\n> >\n> > “ “Trailer” is the preferred nomenclature in this project.\n> >\n> > Must surely be true since git-interpret-trailers(1) does not even\n> > contain the string “tag”.\n> >\n> > I did a grep in this directory:\n> >\n> > git grep tags ':(exclude)RelNotes'\n> >\n> > It didn’t look like there were any other mentions of “tags” in this\n> > sense. Of course it was difficult to look through.\n> >\n> > +CC: Josh Soref based on\n> > e.g. ac9fff2bf1c (SubmittingPatches: discourage new trailers,\n> > 2023-12-28)\n>\n> This change makes sense to me.\n\nTo me as well. Thanks, both. Will queue.\n\nThanks,\nTaylor\n"}]}