{"thread":{"id":"62372","subject":"[PATCH] t1016: clean up style","startedAt":"2024-10-20T12:17:44Z","lastAt":"2024-10-22T10:29:41Z","messageCount":5,"participants":["Andrew Kreimer","Kristoffer Haugsbakk","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"505536","messageId":"20241020121729.27032-1-algonell@gmail.com","threadId":"62372","inReplyTo":null,"subject":"[PATCH] t1016: clean up style","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-10-20T12:17:29Z","receivedAt":"2024-10-20T12:17:44Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"Use `test_config`.\n\nRemove whitespace after redirect operator.\n\nReported-by: Taylor Blau \nSigned-off-by: Andrew Kreimer \n---\nAs discussed in:\n - https://lore.kernel.org/git/ZxFyKXDCJkRZYYQY@nand.local/\n\nTested:\n - ubuntu-latest, GitHub Actions.\n\n t/t1016-compatObjectFormat.sh | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t1016-compatObjectFormat.sh b/t/t1016-compatObjectFormat.sh\nindex be3206a16f..0cc62d2a2d 100755\n--- a/t/t1016-compatObjectFormat.sh\n+++ b/t/t1016-compatObjectFormat.sh\n@@ -116,8 +116,8 @@ do\n \t\tgit config core.repositoryformatversion 1 &&\n \t\tgit config extensions.objectformat $hash &&\n \t\tgit config extensions.compatobjectformat $(compat_hash $hash) &&\n-\t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n-\t\techo \"Hellow World!\" > hello &&\n+\t\ttest_config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n+\t\techo \"Hellow World!\" >hello &&\n \t\teval hello_${hash}_oid=$(git hash-object hello) &&\n \t\tgit update-index --add hello &&\n \t\tgit commit -m \"Initial commit\" &&\n-- \n2.39.5\n\n"},{"id":"505538","messageId":"98c5e44f-42c9-47c7-9fa1-e6cc3b35cdb4@app.fastmail.com","threadId":"62372","inReplyTo":"20241020121729.27032-1-algonell@gmail.com","subject":"Re: [PATCH] t1016: clean up style","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-10-20T12:46:18Z","receivedAt":"2024-10-20T12:46:40Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"Hi\n\nOn Sun, Oct 20, 2024, at 14:17, Andrew Kreimer wrote:\n> Use `test_config`.\n>\n> Remove whitespace after redirect operator.\n>\n> Reported-by: Taylor Blau \n> Signed-off-by: Andrew Kreimer \n> ---\n> As discussed in:\n> - https://lore.kernel.org/git/ZxFyKXDCJkRZYYQY@nand.local/\n> […]\n> -\t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> -\t\techo \"Hellow World!\" > hello &&\n> +\t\ttest_config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> +\t\techo \"Hellow World!\" >hello &&\n\nWhat Taylor wrote:\n\n> Thanks, both. [Andrew] -- it's fine to do this in the same, or a\n> separate patch in the new round. Thanks.\n\nYou’ve posted a new, standalone patch. But what Taylor asked for was a\nnew round on that typo patch where you either squash these changes into\nthe original patch or have the typo patch plus this one.\n\nAt least that’s how I understand it.\n\nThis patch by itself doesn’t do much since the file is full of this\nstyle violation. Which I now realize is what you meant when you\nasked:[1]\n\n> Do you mean that '> more' and '> another' should be handled similarly?\n\nYou were referring to other style violations in the file. But I only\nlooked at the email so I didn’t catch that.\n\n🔗 1: https://lore.kernel.org/git/ZxKSFBl_pV2r99dY@void.void/\n"},{"id":"505782","messageId":"ZxbLlA0xbuhP7DJK@nand.local","threadId":"62372","inReplyTo":"98c5e44f-42c9-47c7-9fa1-e6cc3b35cdb4@app.fastmail.com","subject":"Re: [PATCH] t1016: clean up style","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-21T21:45:56Z","receivedAt":"2024-10-21T21:45:59Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sun, Oct 20, 2024 at 02:46:18PM +0200, Kristoffer Haugsbakk wrote:\n> Hi\n>\n> On Sun, Oct 20, 2024, at 14:17, Andrew Kreimer wrote:\n> > Use `test_config`.\n> >\n> > Remove whitespace after redirect operator.\n> >\n> > Reported-by: Taylor Blau \n> > Signed-off-by: Andrew Kreimer \n> > ---\n> > As discussed in:\n> > - https://lore.kernel.org/git/ZxFyKXDCJkRZYYQY@nand.local/\n> > […]\n> > -\t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> > -\t\techo \"Hellow World!\" > hello &&\n> > +\t\ttest_config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> > +\t\techo \"Hellow World!\" >hello &&\n>\n> What Taylor wrote:\n>\n> > Thanks, both. [Andrew] -- it's fine to do this in the same, or a\n> > separate patch in the new round. Thanks.\n>\n> You’ve posted a new, standalone patch. But what Taylor asked for was a\n> new round on that typo patch where you either squash these changes into\n> the original patch or have the typo patch plus this one.\n>\n> At least that’s how I understand it.\n\nI said originally that either was fine, but then revised my statement\nafter remembering that the original topic was already in 'next', so any\nfurther changes would have to be done on top.\n\nThanks,\nTaylor\n"},{"id":"505783","messageId":"ZxbMFQSL1brz86f+@nand.local","threadId":"62372","inReplyTo":"ZxbLlA0xbuhP7DJK@nand.local","subject":"Re: [PATCH] t1016: clean up style","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-21T21:48:05Z","receivedAt":"2024-10-21T21:48:07Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Oct 21, 2024 at 05:45:56PM -0400, Taylor Blau wrote:\n> On Sun, Oct 20, 2024 at 02:46:18PM +0200, Kristoffer Haugsbakk wrote:\n> > Hi\n> >\n> > On Sun, Oct 20, 2024, at 14:17, Andrew Kreimer wrote:\n> > > Use `test_config`.\n> > >\n> > > Remove whitespace after redirect operator.\n> > >\n> > > Reported-by: Taylor Blau \n> > > Signed-off-by: Andrew Kreimer \n> > > ---\n> > > As discussed in:\n> > > - https://lore.kernel.org/git/ZxFyKXDCJkRZYYQY@nand.local/\n> > > […]\n> > > -\t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> > > -\t\techo \"Hellow World!\" > hello &&\n> > > +\t\ttest_config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> > > +\t\techo \"Hellow World!\" >hello &&\n> >\n> > What Taylor wrote:\n> >\n> > > Thanks, both. [Andrew] -- it's fine to do this in the same, or a\n> > > separate patch in the new round. Thanks.\n> >\n> > You’ve posted a new, standalone patch. But what Taylor asked for was a\n> > new round on that typo patch where you either squash these changes into\n> > the original patch or have the typo patch plus this one.\n> >\n> > At least that’s how I understand it.\n>\n> I said originally that either was fine, but then revised my statement\n> after remembering that the original topic was already in 'next', so any\n> further changes would have to be done on top.\n\n...but after queueing, this patch does not apply cleanly on ak/typofix,\nwhich is what this patch should be based on AFAICT.\n\nAndrew, would you please send a version based on the aforementioned\ntopic?\n\nThanks,\nTaylor\n"},{"id":"505816","messageId":"Zxd-jynYyT2j6blH@void.void","threadId":"62372","inReplyTo":"ZxbMFQSL1brz86f+@nand.local","subject":"Re: [PATCH] t1016: clean up style","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-10-22T10:29:35Z","receivedAt":"2024-10-22T10:29:41Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"On Mon, Oct 21, 2024 at 05:48:05PM -0400, Taylor Blau wrote:\n> ...but after queueing, this patch does not apply cleanly on ak/typofix,\n> which is what this patch should be based on AFAICT.\n> \n> Andrew, would you please send a version based on the aforementioned\n> topic?\n> \n> Thanks,\n> Taylor\n\nAbsolutely, thank you both for the clarification.\n"}]}