{"thread":{"id":"62371","subject":"[PATCH] meson: fix meson build on 'seen' branch","startedAt":"2024-10-20T00:54:56Z","lastAt":"2024-10-23T20:25:52Z","messageCount":4,"participants":["Ramsay Jones","Taylor Blau","Patrick Steinhardt"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"505527","messageId":"12325bcd-fc3b-4d2a-9ec5-20fa2b50297b@ramsayjones.plus.com","threadId":"62371","inReplyTo":null,"subject":"[PATCH] meson: fix meson build on 'seen' branch","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2024-10-20T00:54:47Z","receivedAt":"2024-10-20T00:54:56Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nSigned-off-by: Ramsay Jones \n---\n\nHi Taylor, Patrick,\n\nI tested the v3 patches on the base mentioned in the cover letter\nwithout issues. In the interim, I noticed that the v3 patches had\nbeen queued on the 'seen' branch. I tested with make, as usual, then\nwith meson (on Linux). This patch was required to fix the meson build\n(just in case you weren't already aware, although I suspect you are!).\n\nATB,\nRamsay Jones\n\n meson.build | 3 +++\n t/helper/meson.build | 1 +\n 2 files changed, 4 insertions(+)\n\ndiff --git a/meson.build b/meson.build\nindex 7c7a59d7fb..c057039ec0 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -65,6 +65,8 @@ libgit_sources = [\n 'commit-graph.c',\n 'commit-reach.c',\n 'commit.c',\n+ 'common-exit.c',\n+ 'common-init.c',\n 'compat/nonblock.c',\n 'compat/obstack.c',\n 'compat/terminal.c',\n@@ -178,6 +180,7 @@ libgit_sources = [\n 'patch-delta.c',\n 'patch-ids.c',\n 'path.c',\n+ 'path-walk.c',\n 'pathspec.c',\n 'pkt-line.c',\n 'preload-index.c',\ndiff --git a/t/helper/meson.build b/t/helper/meson.build\nindex 5e83884246..f502d1aaa3 100644\n--- a/t/helper/meson.build\n+++ b/t/helper/meson.build\n@@ -40,6 +40,7 @@ test_tool_sources = [\n 'test-parse-pathspec-file.c',\n 'test-partial-clone.c',\n 'test-path-utils.c',\n+ 'test-path-walk.c',\n 'test-pcre2-config.c',\n 'test-pkt-line.c',\n 'test-proc-receive.c',\n-- \n2.47.0\n"},{"id":"505786","messageId":"ZxbPkU+P8HUwVUDj@nand.local","threadId":"62371","inReplyTo":"12325bcd-fc3b-4d2a-9ec5-20fa2b50297b@ramsayjones.plus.com","subject":"Re: [PATCH] meson: fix meson build on 'seen' branch","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-21T22:02:57Z","receivedAt":"2024-10-21T22:03:00Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sun, Oct 20, 2024 at 01:54:47AM +0100, Ramsay Jones wrote:\n>\n> Signed-off-by: Ramsay Jones \n> ---\n>\n> Hi Taylor, Patrick,\n>\n> I tested the v3 patches on the base mentioned in the cover letter\n> without issues. In the interim, I noticed that the v3 patches had\n> been queued on the 'seen' branch. I tested with make, as usual, then\n> with meson (on Linux). This patch was required to fix the meson build\n> (just in case you weren't already aware, although I suspect you are!).\n\nThanks. It would be nice to have this folded into Patrick's branch.\nPatrick: thoughts?\n\nThanks,\nTaylor\n"},{"id":"505907","messageId":"Zxi8T2BoMX8ltM0E@pks.im","threadId":"62371","inReplyTo":"ZxbPkU+P8HUwVUDj@nand.local","subject":"Re: [PATCH] meson: fix meson build on 'seen' branch","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-10-23T09:05:19Z","receivedAt":"2024-10-23T09:05:26Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Oct 21, 2024 at 06:02:57PM -0400, Taylor Blau wrote:\n> On Sun, Oct 20, 2024 at 01:54:47AM +0100, Ramsay Jones wrote:\n> >\n> > Signed-off-by: Ramsay Jones \n> > ---\n> >\n> > Hi Taylor, Patrick,\n> >\n> > I tested the v3 patches on the base mentioned in the cover letter\n> > without issues. In the interim, I noticed that the v3 patches had\n> > been queued on the 'seen' branch. I tested with make, as usual, then\n> > with meson (on Linux). This patch was required to fix the meson build\n> > (just in case you weren't already aware, although I suspect you are!).\n> \n> Thanks. It would be nice to have this folded into Patrick's branch.\n> Patrick: thoughts?\n\nYeah, I'll pick these up with v4 of this patch series. I'll also try to\nmake sure next time around that things work cleanly with \"seen\" and pick\nup dependencies as required.\n\nPatrick\n"},{"id":"505976","messageId":"ZxlbzrrS+6q7PzFb@nand.local","threadId":"62371","inReplyTo":"Zxi8T2BoMX8ltM0E@pks.im","subject":"Re: [PATCH] meson: fix meson build on 'seen' branch","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-23T20:25:50Z","receivedAt":"2024-10-23T20:25:52Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Wed, Oct 23, 2024 at 11:05:19AM +0200, Patrick Steinhardt wrote:\n> On Mon, Oct 21, 2024 at 06:02:57PM -0400, Taylor Blau wrote:\n> > On Sun, Oct 20, 2024 at 01:54:47AM +0100, Ramsay Jones wrote:\n> > >\n> > > Signed-off-by: Ramsay Jones \n> > > ---\n> > >\n> > > Hi Taylor, Patrick,\n> > >\n> > > I tested the v3 patches on the base mentioned in the cover letter\n> > > without issues. In the interim, I noticed that the v3 patches had\n> > > been queued on the 'seen' branch. I tested with make, as usual, then\n> > > with meson (on Linux). This patch was required to fix the meson build\n> > > (just in case you weren't already aware, although I suspect you are!).\n> >\n> > Thanks. It would be nice to have this folded into Patrick's branch.\n> > Patrick: thoughts?\n>\n> Yeah, I'll pick these up with v4 of this patch series. I'll also try to\n> make sure next time around that things work cleanly with \"seen\" and pick\n> up dependencies as required.\n\nThanks, both.\n\nThanks,\nTaylor\n"}]}