{"thread":{"id":"62368","subject":"[PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","startedAt":"2024-10-19T16:34:51Z","lastAt":"2024-10-23T09:55:39Z","messageCount":9,"participants":["Seyi Kuforiji","Kristoffer Haugsbakk","Patrick Steinhardt","Seyi Chamber","Taylor Blau"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"505500","messageId":"20241019163439.274656-1-kuforiji98@gmail.com","threadId":"62368","inReplyTo":null,"subject":"[PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","fromName":"Seyi Kuforiji","fromEmail":"kuforiji98@gmail.com","sentAt":"2024-10-19T16:34:38Z","receivedAt":"2024-10-19T16:34:51Z","isPatch":true,"sender":{"key":"kuforiji98@gmail.com","avatar":"https://avatars.githubusercontent.com/u/94905626?v=4"},"body":"This change updates the script to conform to the coding standards\noutlined in the Git project's documentation. According to the guidelines\nin Documentation/CodingGuidelines under \"Redirection operators\", there\nshould be no whitespace after redirection operators.\n\nSigned-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n---\n t/t7011-skip-worktree-reading.sh | 22 +++++++++++-----------\n 1 file changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/t/t7011-skip-worktree-reading.sh b/t/t7011-skip-worktree-reading.sh\nindex 4adac5acd5..c86abd99bf 100755\n--- a/t/t7011-skip-worktree-reading.sh\n+++ b/t/t7011-skip-worktree-reading.sh\n@@ -32,24 +32,24 @@ setup_absent() {\n }\n \n test_absent() {\n-\techo \"100644 $EMPTY_BLOB 0\t1\" > expected &&\n-\tgit ls-files --stage 1 > result &&\n+\techo \"100644 $EMPTY_BLOB 0\t1\" >expected &&\n+\tgit ls-files --stage 1 >result &&\n \ttest_cmp expected result &&\n \ttest ! -f 1\n }\n \n setup_dirty() {\n \tgit update-index --force-remove 1 &&\n-\techo dirty > 1 &&\n+\techo dirty >1 &&\n \tgit update-index --add --cacheinfo 100644 $EMPTY_BLOB 1 &&\n \tgit update-index --skip-worktree 1\n }\n \n test_dirty() {\n-\techo \"100644 $EMPTY_BLOB 0\t1\" > expected &&\n-\tgit ls-files --stage 1 > result &&\n+\techo \"100644 $EMPTY_BLOB 0\t1\" >expected &&\n+\tgit ls-files --stage 1 >result &&\n \ttest_cmp expected result &&\n-\techo dirty > expected\n+\techo dirty >expected\n \ttest_cmp expected 1\n }\n \n@@ -59,7 +59,7 @@ test_expect_success 'setup' '\n \ttouch ./1 ./2 sub/1 sub/2 &&\n \tgit add 1 2 sub/1 sub/2 &&\n \tgit update-index --skip-worktree 1 sub/1 &&\n-\tgit ls-files -t > result &&\n+\tgit ls-files -t >result &&\n \ttest_cmp expect.skip result\n '\n \n@@ -86,7 +86,7 @@ test_expect_success 'update-index --remove' '\n \tsetup_dirty &&\n \tgit update-index --remove 1 &&\n \ttest -z \"$(git ls-files 1)\" &&\n-\techo dirty > expected &&\n+\techo dirty >expected &&\n \ttest_cmp expected 1\n '\n \n@@ -110,16 +110,16 @@ test_expect_success 'ls-files --modified' '\n \ttest -z \"$(git ls-files -m)\"\n '\n \n-echo \":000000 100644 $ZERO_OID $EMPTY_BLOB A\t1\" > expected\n+echo \":000000 100644 $ZERO_OID $EMPTY_BLOB A\t1\" >expected\n test_expect_success 'diff-index does not examine skip-worktree absent entries' '\n \tsetup_absent &&\n-\tgit diff-index HEAD -- 1 > result &&\n+\tgit diff-index HEAD -- 1 >result &&\n \ttest_cmp expected result\n '\n \n test_expect_success 'diff-index does not examine skip-worktree dirty entries' '\n \tsetup_dirty &&\n-\tgit diff-index HEAD -- 1 > result &&\n+\tgit diff-index HEAD -- 1 >result &&\n \ttest_cmp expected result\n '\n \n-- \n2.47.0.86.g15030f9556\n\n"},{"id":"505503","messageId":"cb88194a-15d2-4c3d-8768-189853572ac0@app.fastmail.com","threadId":"62368","inReplyTo":"20241019163439.274656-1-kuforiji98@gmail.com","subject":"Re: [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-10-19T17:54:30Z","receivedAt":"2024-10-19T17:54:53Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"On Sat, Oct 19, 2024, at 18:34, Seyi Kuforiji wrote:\n> This change updates the script to conform to the coding standards\n> outlined in the Git project's documentation. According to the guidelines\n> in Documentation/CodingGuidelines under \"Redirection operators\", there\n> should be no whitespace after redirection operators.\n>\n> Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n> ---\n>  t/t7011-skip-worktree-reading.sh | 22 +++++++++++-----------\n>  1 file changed, 11 insertions(+), 11 deletions(-)\n\nI can confirm that there are no changes in this version to the patch\nitself.  Which was expected since the change was good.\n\nThe difference in this version is that the commit message has been\nimproved.  At least according to my taste.\n\nThanks\n\n-- \nKristoffer Haugsbakk\n\n"},{"id":"505663","messageId":"ZxZDFyKxTn_D7c3o@pks.im","threadId":"62368","inReplyTo":"cb88194a-15d2-4c3d-8768-189853572ac0@app.fastmail.com","subject":"Re: [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-10-21T12:03:35Z","receivedAt":"2024-10-21T12:03:43Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Sat, Oct 19, 2024 at 07:54:30PM +0200, Kristoffer Haugsbakk wrote:\n> On Sat, Oct 19, 2024, at 18:34, Seyi Kuforiji wrote:\n> > This change updates the script to conform to the coding standards\n> > outlined in the Git project's documentation. According to the guidelines\n> > in Documentation/CodingGuidelines under \"Redirection operators\", there\n> > should be no whitespace after redirection operators.\n> >\n> > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n> > ---\n> >  t/t7011-skip-worktree-reading.sh | 22 +++++++++++-----------\n> >  1 file changed, 11 insertions(+), 11 deletions(-)\n> \n> I can confirm that there are no changes in this version to the patch\n> itself.  Which was expected since the change was good.\n> \n> The difference in this version is that the commit message has been\n> improved.  At least according to my taste.\n\nAgreed, this patch looks good to me, too. Thanks!\n\nPatrick\n"},{"id":"505716","messageId":"CAGedMteMtaOvyE2gX59bMudEUmCZw7nOh=MuDRi=7CbYm-gBDQ@mail.gmail.com","threadId":"62368","inReplyTo":"ZxZDFyKxTn_D7c3o@pks.im","subject":"Re: [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","fromName":"Seyi Chamber","fromEmail":"kuforiji98@gmail.com","sentAt":"2024-10-21T17:17:06Z","receivedAt":"2024-10-21T17:17:18Z","isPatch":true,"sender":{"key":"kuforiji98@gmail.com","avatar":"https://avatars.githubusercontent.com/u/94905626?v=4"},"body":"On Mon, 21 Oct 2024 at 13:03, Patrick Steinhardt <ps@pks.im> wrote:\n>\n> On Sat, Oct 19, 2024 at 07:54:30PM +0200, Kristoffer Haugsbakk wrote:\n> > On Sat, Oct 19, 2024, at 18:34, Seyi Kuforiji wrote:\n> > > This change updates the script to conform to the coding standards\n> > > outlined in the Git project's documentation. According to the guidelines\n> > > in Documentation/CodingGuidelines under \"Redirection operators\", there\n> > > should be no whitespace after redirection operators.\n> > >\n> > > Signed-off-by: Seyi Kuforiji <kuforiji98@gmail.com>\n> > > ---\n> > >  t/t7011-skip-worktree-reading.sh | 22 +++++++++++-----------\n> > >  1 file changed, 11 insertions(+), 11 deletions(-)\n> >\n> > I can confirm that there are no changes in this version to the patch\n> > itself.  Which was expected since the change was good.\n> >\n> > The difference in this version is that the commit message has been\n> > improved.  At least according to my taste.\n>\n> Agreed, this patch looks good to me, too. Thanks!\n>\n> Patrick\n\nYay!\n\nThank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk\n\nRegards\n\nSeyi\n"},{"id":"505738","messageId":"ZxaySpwA7jg7c1aw@nand.local","threadId":"62368","inReplyTo":"CAGedMteMtaOvyE2gX59bMudEUmCZw7nOh=MuDRi=7CbYm-gBDQ@mail.gmail.com","subject":"Re: [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-21T19:58:02Z","receivedAt":"2024-10-21T19:58:04Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote:\n> Yay!\n>\n> Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk\n\nThanks, all. Let's start merging this one down.\n\nThanks,\nTaylor\n"},{"id":"505846","messageId":"CAGedMtea3_65wuOc1c548TC1x=ThirB1gC8p6kTomwWf_VzDng@mail.gmail.com","threadId":"62368","inReplyTo":"ZxaySpwA7jg7c1aw@nand.local","subject":"Re: [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","fromName":"Seyi Chamber","fromEmail":"kuforiji98@gmail.com","sentAt":"2024-10-22T17:11:17Z","receivedAt":"2024-10-22T17:11:30Z","isPatch":true,"sender":{"key":"kuforiji98@gmail.com","avatar":"https://avatars.githubusercontent.com/u/94905626?v=4"},"body":"On Mon, 21 Oct 2024 at 20:58, Taylor Blau <me@ttaylorr.com> wrote:\n>\n> On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote:\n> > Yay!\n> >\n> > Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk\n>\n> Thanks, all. Let's start merging this one down.\n>\n> Thanks,\n> Taylor\n\nThanks, Taylor!\n\nI've also discovered that the test script t9101-git-svn-props.sh also\nrequires the same update done in this patch.\nIs this test script currently being worked on? @Patrick Steinhardt\n\nThanks\nSeyi\n"},{"id":"505893","messageId":"ZxiC06eY4mMh1Xun@pks.im","threadId":"62368","inReplyTo":"CAGedMtea3_65wuOc1c548TC1x=ThirB1gC8p6kTomwWf_VzDng@mail.gmail.com","subject":"Re: [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-10-23T05:00:08Z","receivedAt":"2024-10-23T05:00:16Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Tue, Oct 22, 2024 at 06:11:17PM +0100, Seyi Chamber wrote:\n> On Mon, 21 Oct 2024 at 20:58, Taylor Blau <me@ttaylorr.com> wrote:\n> >\n> > On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote:\n> > > Yay!\n> > >\n> > > Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk\n> >\n> > Thanks, all. Let's start merging this one down.\n> >\n> > Thanks,\n> > Taylor\n> \n> Thanks, Taylor!\n> \n> I've also discovered that the test script t9101-git-svn-props.sh also\n> requires the same update done in this patch.\n> Is this test script currently being worked on? @Patrick Steinhardt\n\nNot that I'd know of. I typically double check via lore by searching for\nthe relevant subsystem [1]. This only surfaces your mail and the Meson\npatch series, so at least nobody else has communicated intent to work on\nit.\n\nPatrick\n\n[1]: https://lore.kernel.org/git/?q=t9101\n"},{"id":"505898","messageId":"CAGedMtdN8qRRALiYdCFso90ExGEm0zirnpLXuva_bc8ehsK+Xw@mail.gmail.com","threadId":"62368","inReplyTo":"ZxiC06eY4mMh1Xun@pks.im","subject":"Re: [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","fromName":"Seyi Chamber","fromEmail":"kuforiji98@gmail.com","sentAt":"2024-10-23T07:24:18Z","receivedAt":"2024-10-23T07:24:31Z","isPatch":true,"sender":{"key":"kuforiji98@gmail.com","avatar":"https://avatars.githubusercontent.com/u/94905626?v=4"},"body":"On Wed, 23 Oct 2024 at 06:00, Patrick Steinhardt <ps@pks.im> wrote:\n>\n> On Tue, Oct 22, 2024 at 06:11:17PM +0100, Seyi Chamber wrote:\n> > On Mon, 21 Oct 2024 at 20:58, Taylor Blau <me@ttaylorr.com> wrote:\n> > >\n> > > On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote:\n> > > > Yay!\n> > > >\n> > > > Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk\n> > >\n> > > Thanks, all. Let's start merging this one down.\n> > >\n> > > Thanks,\n> > > Taylor\n> >\n> > Thanks, Taylor!\n> >\n> > I've also discovered that the test script t9101-git-svn-props.sh also\n> > requires the same update done in this patch.\n> > Is this test script currently being worked on? @Patrick Steinhardt\n>\n> Not that I'd know of. I typically double check via lore by searching for\n> the relevant subsystem [1]. This only surfaces your mail and the Meson\n> patch series, so at least nobody else has communicated intent to work on\n> it.\n>\n> Patrick\n>\n> [1]: https://lore.kernel.org/git/?q=t9101\n\nThanks, Patrick.\n\nIn the future, would you prefer I still run it by you before working\non a test script,\nor should I apply the same strategy you mentioned in your reply?\n\nRegards\n\nSeyi\n"},{"id":"505910","messageId":"ZxjIC5W4HprJqUxB@pks.im","threadId":"62368","inReplyTo":"CAGedMtdN8qRRALiYdCFso90ExGEm0zirnpLXuva_bc8ehsK+Xw@mail.gmail.com","subject":"Re: [PATCH v2 Outreachy] t7011: ensure no whitespace after redirect","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-10-23T09:55:31Z","receivedAt":"2024-10-23T09:55:39Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Wed, Oct 23, 2024 at 08:24:18AM +0100, Seyi Chamber wrote:\n> On Wed, 23 Oct 2024 at 06:00, Patrick Steinhardt <ps@pks.im> wrote:\n> >\n> > On Tue, Oct 22, 2024 at 06:11:17PM +0100, Seyi Chamber wrote:\n> > > On Mon, 21 Oct 2024 at 20:58, Taylor Blau <me@ttaylorr.com> wrote:\n> > > >\n> > > > On Mon, Oct 21, 2024 at 06:17:06PM +0100, Seyi Chamber wrote:\n> > > > > Yay!\n> > > > >\n> > > > > Thank you for the feedback @Patrick Steinhardt @Kristoffer Haugsbakk\n> > > >\n> > > > Thanks, all. Let's start merging this one down.\n> > > >\n> > > > Thanks,\n> > > > Taylor\n> > >\n> > > Thanks, Taylor!\n> > >\n> > > I've also discovered that the test script t9101-git-svn-props.sh also\n> > > requires the same update done in this patch.\n> > > Is this test script currently being worked on? @Patrick Steinhardt\n> >\n> > Not that I'd know of. I typically double check via lore by searching for\n> > the relevant subsystem [1]. This only surfaces your mail and the Meson\n> > patch series, so at least nobody else has communicated intent to work on\n> > it.\n> >\n> > Patrick\n> >\n> > [1]: https://lore.kernel.org/git/?q=t9101\n> \n> Thanks, Patrick.\n> \n> In the future, would you prefer I still run it by you before working\n> on a test script,\n> or should I apply the same strategy you mentioned in your reply?\n\nThere's no need to run it by anybody, so please feel free to use the\nsame strategy.\n\nPatrick\n"}]}