{"thread":{"id":"62366","subject":"[PATCH] Fix duplicate word typos","startedAt":"2024-10-19T09:44:24Z","lastAt":"2024-10-22T05:07:10Z","messageCount":8,"participants":["Sven Strickroth","Kristoffer Haugsbakk","Patrick Steinhardt","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"505490","messageId":"b50f9706-bb45-4bf0-8d32-59149615301b@mrtux-pc.local","threadId":"62366","inReplyTo":null,"subject":"[PATCH] Fix duplicate word typos","fromName":"Sven Strickroth","fromEmail":"email@cs-ware.de","sentAt":"2024-10-19T10:37:58Z","receivedAt":"2024-10-19T09:44:24Z","isPatch":true,"sender":{"key":"email@cs-ware.de","avatar":"https://avatars.githubusercontent.com/u/428133?v=4"},"body":"Used regex to find these typos: \"(?<!struct )(?<=\\s)([a-z]{1,}) \\1(?=\\s)\"\n\nSigned-off-by: Sven Strickroth <email@cs-ware.de>\n---\n Documentation/RelNotes/2.45.0.txt                      | 2 +-\n Documentation/RelNotes/2.46.0.txt                      | 2 +-\n Documentation/git-format-patch.txt                     | 2 +-\n Documentation/gitprotocol-v2.txt                       | 2 +-\n Documentation/howto/keep-canonical-history-correct.txt | 2 +-\n builtin/difftool.c                                     | 2 +-\n ci/lib.sh                                              | 2 +-\n fsmonitor.c                                            | 2 +-\n oidtree.c                                              | 2 +-\n read-cache-ll.h                                        | 2 +-\n refs/reftable-backend.c                                | 2 +-\n 11 files changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/Documentation/RelNotes/2.45.0.txt b/Documentation/RelNotes/2.45.0.txt\nindex fec193679f..aa0315259b 100644\n--- a/Documentation/RelNotes/2.45.0.txt\n+++ b/Documentation/RelNotes/2.45.0.txt\n@@ -9,7 +9,7 @@ UI, Workflows & Features\n    With \"git init --ref-format=reftable\", hopefully it would be a lot\n    more efficient to manage a repository with many references.\n \n- * \"git checkout -p\" and friends learned that that \"@\" is a synonym\n+ * \"git checkout -p\" and friends learned that \"@\" is a synonym\n    for \"HEAD\".\n \n  * Variants of vimdiff learned to honor mergetool.<variant>.layout\ndiff --git a/Documentation/RelNotes/2.46.0.txt b/Documentation/RelNotes/2.46.0.txt\nindex b25475918a..c06a04a91b 100644\n--- a/Documentation/RelNotes/2.46.0.txt\n+++ b/Documentation/RelNotes/2.46.0.txt\n@@ -78,7 +78,7 @@ UI, Workflows & Features\n    turn on cover letters automatically (unless told never to enable\n    cover letter with \"--no-cover-letter\" and such).\n \n- * The \"--heads\" option of \"ls-remote\" and \"show-ref\" has been been\n+ * The \"--heads\" option of \"ls-remote\" and \"show-ref\" has been\n    deprecated; \"--branches\" replaces \"--heads\".\n \n  * For over a year, setting add.interactive.useBuiltin configuration\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex 8708b31593..5dc7bb4cfc 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -250,7 +250,7 @@ is not complete yet (\"WIP\" stands for \"Work In Progress\").\n +\n If the convention of the receiving community for a particular extra\n string is to have it _after_ the subject prefix, the string _<rfc>_\n-can be prefixed with a dash (\"`-`\") to signal that the the rest of\n+can be prefixed with a dash (\"`-`\") to signal that the rest of\n the _<rfc>_ string should be appended to the subject prefix instead,\n e.g., `--rfc='-(WIP)'` results in \"PATCH (WIP)\".\n \ndiff --git a/Documentation/gitprotocol-v2.txt b/Documentation/gitprotocol-v2.txt\nindex ca83b2ecc5..1652fef3ae 100644\n--- a/Documentation/gitprotocol-v2.txt\n+++ b/Documentation/gitprotocol-v2.txt\n@@ -776,7 +776,7 @@ This would allow for optimizing the common case of servers who'd like\n to provide one \"big bundle\" containing only their \"main\" branch,\n and/or incremental updates thereof.\n +\n-A client receiving such a a response MAY assume that they can skip\n+A client receiving such a response MAY assume that they can skip\n retrieving the header from a bundle at the indicated URI, and thus\n save themselves and the server(s) the request(s) needed to inspect the\n headers of that bundle or bundles.\ndiff --git a/Documentation/howto/keep-canonical-history-correct.txt b/Documentation/howto/keep-canonical-history-correct.txt\nindex 5f800fd85a..e98f03275e 100644\n--- a/Documentation/howto/keep-canonical-history-correct.txt\n+++ b/Documentation/howto/keep-canonical-history-correct.txt\n@@ -13,7 +13,7 @@ that appears to be \"backwards\" from what other project developers\n expect. This howto presents a suggested integration workflow for\n maintaining a central repository.\n \n-Suppose that that central repository has this history:\n+Suppose that the central repository has this history:\n \n ------------\n     ---o---o---A\ndiff --git a/builtin/difftool.c b/builtin/difftool.c\nindex 5772e82106..ca1b089065 100644\n--- a/builtin/difftool.c\n+++ b/builtin/difftool.c\n@@ -340,7 +340,7 @@ static void write_file_in_directory(struct strbuf *dir, size_t dir_len,\n /* Write the file contents for the left and right sides of the difftool\n  * dir-diff representation for submodules and symlinks. Symlinks and submodules\n  * are written as regular text files so that external diff tools can diff them\n- * as text files, resulting in behavior that is analogous to to what \"git diff\"\n+ * as text files, resulting in behavior that is analogous to what \"git diff\"\n  * displays for symlink and submodule diffs.\n  */\n static void write_standin_files(struct pair_entry *entry,\ndiff --git a/ci/lib.sh b/ci/lib.sh\nindex 74b430be23..bfa1fe370b 100755\n--- a/ci/lib.sh\n+++ b/ci/lib.sh\n@@ -62,7 +62,7 @@ trap \"end_group 'CI setup'\" EXIT\n # something went wrong.\n #\n # We already enabled tracing executed commands earlier. This helps by showing\n-# how # environment variables are set and and dependencies are installed.\n+# how # environment variables are set and dependencies are installed.\n set -e\n \n skip_branch_tip_with_tag () {\ndiff --git a/fsmonitor.c b/fsmonitor.c\nindex 237ca59d00..309a2541cb 100644\n--- a/fsmonitor.c\n+++ b/fsmonitor.c\n@@ -247,7 +247,7 @@ static size_t handle_using_name_hash_icase(\n \t * technically this is a tracked file or a sparse-directory.\n \t * It should not have any entries in the untracked-cache, so\n \t * we should not need to use the case-corrected spelling to\n-\t * invalidate the the untracked-cache.  So we may not need to\n+\t * invalidate the untracked-cache.  So we may not need to\n \t * do this.  For now, I'm going to be conservative and always\n \t * do it; we can revisit this later.\n \t */\ndiff --git a/oidtree.c b/oidtree.c\nindex 92d03b52db..151568f74f 100644\n--- a/oidtree.c\n+++ b/oidtree.c\n@@ -47,7 +47,7 @@ void oidtree_insert(struct oidtree *ot, const struct object_id *oid)\n \n \t/*\n \t * n.b. Current callers won't get us duplicates, here.  If a\n-\t * future caller causes duplicates, there'll be a a small leak\n+\t * future caller causes duplicates, there'll be a small leak\n \t * that won't be freed until oidtree_clear.  Currently it's not\n \t * worth maintaining a free list\n \t */\ndiff --git a/read-cache-ll.h b/read-cache-ll.h\nindex b5d11d07a8..71b49d9af4 100644\n--- a/read-cache-ll.h\n+++ b/read-cache-ll.h\n@@ -196,7 +196,7 @@ struct index_state {\n  *\n  * If the variable won't be used again, use release_index() to free()\n  * its resources. If it needs to be used again use discard_index(),\n- * which does the same thing, but will use use index_state_init() at\n+ * which does the same thing, but will use index_state_init() at\n  * the end. The discard_index() will use its own \"istate->repo\" as the\n  * \"r\" argument to index_state_init() in that case.\n  */\ndiff --git a/refs/reftable-backend.c b/refs/reftable-backend.c\nindex 3c6107c7ce..38eb14d591 100644\n--- a/refs/reftable-backend.c\n+++ b/refs/reftable-backend.c\n@@ -2131,7 +2131,7 @@ static int write_reflog_existence_table(struct reftable_writer *writer,\n \treftable_writer_set_limits(writer, ts, ts);\n \n \t/*\n-\t * The existence entry has both old and new object ID set to the the\n+\t * The existence entry has both old and new object ID set to the\n \t * null object ID. Our iterators are aware of this and will not present\n \t * them to their callers.\n \t */\n-- \n2.47.0.windows.1\n\n\n"},{"id":"505491","messageId":"e1ee980d-d8d2-4c9c-9a73-ba6af9009ba2@app.fastmail.com","threadId":"62366","inReplyTo":"b50f9706-bb45-4bf0-8d32-59149615301b@mrtux-pc.local","subject":"Re: [PATCH] Fix duplicate word typos","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-10-19T10:06:54Z","receivedAt":"2024-10-19T10:07:15Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"Hi\n\nI guess it was an intentional choice to not use an “area” in the commit\nmessage?\n\nI found this similar patch which used `*` as the area: abcb66c614c (*:\nfix typos which duplicate a word, 2021-06-11); review here:\n\nhttps://lore.kernel.org/git/CAPig+cTjjNrU9q8UPm+CRuTKq8_XNc+1z7-3F4bvetBi+NjKeQ@mail.gmail.com/\n\nOn Sat, Oct 19, 2024, at 12:37, Sven Strickroth wrote:\n> Used regex to find these typos: \"(?<!struct )(?<=\\s)([a-z]{1,}) \\1(?=\\s)\"\n\nThis would be more conventional:\n\n    Used regex to find these typos:\n\n        (?<!struct )(?<=\\s)([a-z]{1,}) \\1(?=\\s)\n\nEither that or code fence (MarkDown style).\n\n>\n> Signed-off-by: Sven Strickroth <email@cs-ware.de>\n\nI can confirm that this patch only does that.  Except:\n\n> ---\n> […]\n> -Suppose that that central repository has this history:\n> +Suppose that the central repository has this history:\n\nHere the doubled “that” is replaced with “the” which makes the sentence\ncorrect.  Good.\n\nThere are also no grammatically correct “that that” constructs that have\nbeen removed.\n\n> Documentation/RelNotes/2.45.0.txt\n\nI was wondering if typo fixes are done for released-released versions\n(not going through RC).  But the aforementioned patch abcb66c614c does\nfix a release note or two for some old versions.\n\n-- \nKristoffer Haugsbakk\n\n"},{"id":"505625","messageId":"ZxYjISSiV-vlE96W@pks.im","threadId":"62366","inReplyTo":"e1ee980d-d8d2-4c9c-9a73-ba6af9009ba2@app.fastmail.com","subject":"Re: [PATCH] Fix duplicate word typos","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-10-21T09:47:13Z","receivedAt":"2024-10-21T09:47:22Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Sat, Oct 19, 2024 at 12:06:54PM +0200, Kristoffer Haugsbakk wrote:\n> Hi\n> \n> I guess it was an intentional choice to not use an “area” in the commit\n> message?\n> \n> I found this similar patch which used `*` as the area: abcb66c614c (*:\n> fix typos which duplicate a word, 2021-06-11); review here:\n> \n> https://lore.kernel.org/git/CAPig+cTjjNrU9q8UPm+CRuTKq8_XNc+1z7-3F4bvetBi+NjKeQ@mail.gmail.com/\n\nI think many projects also use the \"global:\" prefix to denote changes\nall over the place. We also do this in Git, even though I should\nprobably say that all patches that do have that prefix are from myself\n:P In any case, I don't have a strong opinion here.\n\nPatrick\n"},{"id":"505627","messageId":"89ee8fab-ac1e-4e9b-98b7-f2ad25e8f0d0@app.fastmail.com","threadId":"62366","inReplyTo":"ZxYjISSiV-vlE96W@pks.im","subject":"Re: [PATCH] Fix duplicate word typos","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-10-21T09:57:25Z","receivedAt":"2024-10-21T09:57:48Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"On Mon, Oct 21, 2024, at 11:47, Patrick Steinhardt wrote:\n> On Sat, Oct 19, 2024 at 12:06:54PM +0200, Kristoffer Haugsbakk wrote:\n>> Hi\n>>\n>> I guess it was an intentional choice to not use an “area” in the commit\n>> message?\n>>\n>> I found this similar patch which used `*` as the area: abcb66c614c (*:\n>> fix typos which duplicate a word, 2021-06-11); review here:\n>>\n>> https://lore.kernel.org/git/CAPig+cTjjNrU9q8UPm+CRuTKq8_XNc+1z7-3F4bvetBi+NjKeQ@mail.gmail.com/\n>\n> I think many projects also use the \"global:\" prefix to denote changes\n> all over the place. We also do this in Git, even though I should\n> probably say that all patches that do have that prefix are from myself\n> :P In any case, I don't have a strong opinion here.\n>\n> Patrick\n\nI forgot to mention that “treewide” is used to a decent degree.  :)\n\nCheers\n\n-- \nKristoffer Haugsbakk\n\n"},{"id":"505717","messageId":"6ce47185-690d-415e-95c9-06a3b828be29e@cs-ware.de","threadId":"62366","inReplyTo":"89ee8fab-ac1e-4e9b-98b7-f2ad25e8f0d0@app.fastmail.com","subject":"[PATCH v2] global: Fix duplicate word typos","fromName":"Sven Strickroth","fromEmail":"email@cs-ware.de","sentAt":"2024-10-21T15:12:26Z","receivedAt":"2024-10-21T17:20:40Z","isPatch":true,"sender":{"key":"email@cs-ware.de","avatar":"https://avatars.githubusercontent.com/u/428133?v=4"},"body":"Used regex to find these typos:\n\n    (?<!struct )(?<=\\s)([a-z]{1,}) \\1(?=\\s)\n\nSigned-off-by: Sven Strickroth <email@cs-ware.de>\n---\n Documentation/RelNotes/2.45.0.txt                      | 2 +-\n Documentation/RelNotes/2.46.0.txt                      | 2 +-\n Documentation/git-format-patch.txt                     | 2 +-\n Documentation/gitprotocol-v2.txt                       | 2 +-\n Documentation/howto/keep-canonical-history-correct.txt | 2 +-\n builtin/difftool.c                                     | 2 +-\n ci/lib.sh                                              | 2 +-\n fsmonitor.c                                            | 2 +-\n oidtree.c                                              | 2 +-\n read-cache-ll.h                                        | 2 +-\n refs/reftable-backend.c                                | 2 +-\n 11 files changed, 11 insertions(+), 11 deletions(-)\n\ndiff --git a/Documentation/RelNotes/2.45.0.txt b/Documentation/RelNotes/2.45.0.txt\nindex fec193679f..aa0315259b 100644\n--- a/Documentation/RelNotes/2.45.0.txt\n+++ b/Documentation/RelNotes/2.45.0.txt\n@@ -9,7 +9,7 @@ UI, Workflows & Features\n    With \"git init --ref-format=reftable\", hopefully it would be a lot\n    more efficient to manage a repository with many references.\n \n- * \"git checkout -p\" and friends learned that that \"@\" is a synonym\n+ * \"git checkout -p\" and friends learned that \"@\" is a synonym\n    for \"HEAD\".\n \n  * Variants of vimdiff learned to honor mergetool.<variant>.layout\ndiff --git a/Documentation/RelNotes/2.46.0.txt b/Documentation/RelNotes/2.46.0.txt\nindex b25475918a..c06a04a91b 100644\n--- a/Documentation/RelNotes/2.46.0.txt\n+++ b/Documentation/RelNotes/2.46.0.txt\n@@ -78,7 +78,7 @@ UI, Workflows & Features\n    turn on cover letters automatically (unless told never to enable\n    cover letter with \"--no-cover-letter\" and such).\n \n- * The \"--heads\" option of \"ls-remote\" and \"show-ref\" has been been\n+ * The \"--heads\" option of \"ls-remote\" and \"show-ref\" has been\n    deprecated; \"--branches\" replaces \"--heads\".\n \n  * For over a year, setting add.interactive.useBuiltin configuration\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex 8708b31593..5dc7bb4cfc 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -250,7 +250,7 @@ is not complete yet (\"WIP\" stands for \"Work In Progress\").\n +\n If the convention of the receiving community for a particular extra\n string is to have it _after_ the subject prefix, the string _<rfc>_\n-can be prefixed with a dash (\"`-`\") to signal that the the rest of\n+can be prefixed with a dash (\"`-`\") to signal that the rest of\n the _<rfc>_ string should be appended to the subject prefix instead,\n e.g., `--rfc='-(WIP)'` results in \"PATCH (WIP)\".\n \ndiff --git a/Documentation/gitprotocol-v2.txt b/Documentation/gitprotocol-v2.txt\nindex ca83b2ecc5..1652fef3ae 100644\n--- a/Documentation/gitprotocol-v2.txt\n+++ b/Documentation/gitprotocol-v2.txt\n@@ -776,7 +776,7 @@ This would allow for optimizing the common case of servers who'd like\n to provide one \"big bundle\" containing only their \"main\" branch,\n and/or incremental updates thereof.\n +\n-A client receiving such a a response MAY assume that they can skip\n+A client receiving such a response MAY assume that they can skip\n retrieving the header from a bundle at the indicated URI, and thus\n save themselves and the server(s) the request(s) needed to inspect the\n headers of that bundle or bundles.\ndiff --git a/Documentation/howto/keep-canonical-history-correct.txt b/Documentation/howto/keep-canonical-history-correct.txt\nindex 5f800fd85a..e98f03275e 100644\n--- a/Documentation/howto/keep-canonical-history-correct.txt\n+++ b/Documentation/howto/keep-canonical-history-correct.txt\n@@ -13,7 +13,7 @@ that appears to be \"backwards\" from what other project developers\n expect. This howto presents a suggested integration workflow for\n maintaining a central repository.\n \n-Suppose that that central repository has this history:\n+Suppose that the central repository has this history:\n \n ------------\n     ---o---o---A\ndiff --git a/builtin/difftool.c b/builtin/difftool.c\nindex 5772e82106..ca1b089065 100644\n--- a/builtin/difftool.c\n+++ b/builtin/difftool.c\n@@ -340,7 +340,7 @@ static void write_file_in_directory(struct strbuf *dir, size_t dir_len,\n /* Write the file contents for the left and right sides of the difftool\n  * dir-diff representation for submodules and symlinks. Symlinks and submodules\n  * are written as regular text files so that external diff tools can diff them\n- * as text files, resulting in behavior that is analogous to to what \"git diff\"\n+ * as text files, resulting in behavior that is analogous to what \"git diff\"\n  * displays for symlink and submodule diffs.\n  */\n static void write_standin_files(struct pair_entry *entry,\ndiff --git a/ci/lib.sh b/ci/lib.sh\nindex 74b430be23..bfa1fe370b 100755\n--- a/ci/lib.sh\n+++ b/ci/lib.sh\n@@ -62,7 +62,7 @@ trap \"end_group 'CI setup'\" EXIT\n # something went wrong.\n #\n # We already enabled tracing executed commands earlier. This helps by showing\n-# how # environment variables are set and and dependencies are installed.\n+# how # environment variables are set and dependencies are installed.\n set -e\n \n skip_branch_tip_with_tag () {\ndiff --git a/fsmonitor.c b/fsmonitor.c\nindex 237ca59d00..309a2541cb 100644\n--- a/fsmonitor.c\n+++ b/fsmonitor.c\n@@ -247,7 +247,7 @@ static size_t handle_using_name_hash_icase(\n \t * technically this is a tracked file or a sparse-directory.\n \t * It should not have any entries in the untracked-cache, so\n \t * we should not need to use the case-corrected spelling to\n-\t * invalidate the the untracked-cache.  So we may not need to\n+\t * invalidate the untracked-cache.  So we may not need to\n \t * do this.  For now, I'm going to be conservative and always\n \t * do it; we can revisit this later.\n \t */\ndiff --git a/oidtree.c b/oidtree.c\nindex 92d03b52db..151568f74f 100644\n--- a/oidtree.c\n+++ b/oidtree.c\n@@ -47,7 +47,7 @@ void oidtree_insert(struct oidtree *ot, const struct object_id *oid)\n \n \t/*\n \t * n.b. Current callers won't get us duplicates, here.  If a\n-\t * future caller causes duplicates, there'll be a a small leak\n+\t * future caller causes duplicates, there'll be a small leak\n \t * that won't be freed until oidtree_clear.  Currently it's not\n \t * worth maintaining a free list\n \t */\ndiff --git a/read-cache-ll.h b/read-cache-ll.h\nindex b5d11d07a8..71b49d9af4 100644\n--- a/read-cache-ll.h\n+++ b/read-cache-ll.h\n@@ -196,7 +196,7 @@ struct index_state {\n  *\n  * If the variable won't be used again, use release_index() to free()\n  * its resources. If it needs to be used again use discard_index(),\n- * which does the same thing, but will use use index_state_init() at\n+ * which does the same thing, but will use index_state_init() at\n  * the end. The discard_index() will use its own \"istate->repo\" as the\n  * \"r\" argument to index_state_init() in that case.\n  */\ndiff --git a/refs/reftable-backend.c b/refs/reftable-backend.c\nindex 3c6107c7ce..38eb14d591 100644\n--- a/refs/reftable-backend.c\n+++ b/refs/reftable-backend.c\n@@ -2131,7 +2131,7 @@ static int write_reflog_existence_table(struct reftable_writer *writer,\n \treftable_writer_set_limits(writer, ts, ts);\n \n \t/*\n-\t * The existence entry has both old and new object ID set to the the\n+\t * The existence entry has both old and new object ID set to the\n \t * null object ID. Our iterators are aware of this and will not present\n \t * them to their callers.\n \t */\n-- \n2.47.0.windows.1\n"},{"id":"505740","messageId":"ZxazzIUA/JQDi/Uw@nand.local","threadId":"62366","inReplyTo":"89ee8fab-ac1e-4e9b-98b7-f2ad25e8f0d0@app.fastmail.com","subject":"Re: [PATCH] Fix duplicate word typos","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-21T20:04:28Z","receivedAt":"2024-10-21T20:04:31Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Mon, Oct 21, 2024 at 11:57:25AM +0200, Kristoffer Haugsbakk wrote:\n> On Mon, Oct 21, 2024, at 11:47, Patrick Steinhardt wrote:\n> > On Sat, Oct 19, 2024 at 12:06:54PM +0200, Kristoffer Haugsbakk wrote:\n> >> Hi\n> >>\n> >> I guess it was an intentional choice to not use an “area” in the commit\n> >> message?\n> >>\n> >> I found this similar patch which used `*` as the area: abcb66c614c (*:\n> >> fix typos which duplicate a word, 2021-06-11); review here:\n> >>\n> >> https://lore.kernel.org/git/CAPig+cTjjNrU9q8UPm+CRuTKq8_XNc+1z7-3F4bvetBi+NjKeQ@mail.gmail.com/\n> >\n> > I think many projects also use the \"global:\" prefix to denote changes\n> > all over the place. We also do this in Git, even though I should\n> > probably say that all patches that do have that prefix are from myself\n> > :P In any case, I don't have a strong opinion here.\n> >\n> > Patrick\n>\n> I forgot to mention that “treewide” is used to a decent degree.  :)\n\nYes, I think in any case we can blame Patrick for setting the convention\nhere ;-).\n\n(For what it's worth, I have occasionally used '*:' in the past, but I\ndon't think it matters so long as we use something to avoid 99.9% of\ncommits being prefixed with an area and having a few odd ones stuck\nout).\n\nThanks,\nTaylor\n"},{"id":"505741","messageId":"Zxaz//QiYvOpRvZY@nand.local","threadId":"62366","inReplyTo":"e1ee980d-d8d2-4c9c-9a73-ba6af9009ba2@app.fastmail.com","subject":"Re: [PATCH] Fix duplicate word typos","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-21T20:05:19Z","receivedAt":"2024-10-21T20:05:21Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sat, Oct 19, 2024 at 12:06:54PM +0200, Kristoffer Haugsbakk wrote:\n> I can confirm that this patch only does that.  Except:\n>\n> > ---\n> > […]\n> > -Suppose that that central repository has this history:\n> > +Suppose that the central repository has this history:\n>\n> Here the doubled “that” is replaced with “the” which makes the sentence\n> correct.  Good.\n>\n> There are also no grammatically correct “that that” constructs that have\n> been removed.\n\nThanks for a careful review.\n\nThanks,\nTaylor\n"},{"id":"505802","messageId":"Zxcy9W0DXnaCR9FJ@pks.im","threadId":"62366","inReplyTo":"6ce47185-690d-415e-95c9-06a3b828be29e@cs-ware.de","subject":"Re: [PATCH v2] global: Fix duplicate word typos","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-10-22T05:07:01Z","receivedAt":"2024-10-22T05:07:10Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Oct 21, 2024 at 05:12:26PM +0200, Sven Strickroth wrote:\n> Used regex to find these typos:\n> \n>     (?<!struct )(?<=\\s)([a-z]{1,}) \\1(?=\\s)\n\nOne more nit: the first word after the area should be lower-case. So the\nsubject should be \"foo: something\" rather than \"foo: Something\". Other\nthan that the patch looks good to me. I don't really think that this is\nworth a reroll, but others may disagree with that.\n\n> diff --git a/ci/lib.sh b/ci/lib.sh\n> index 74b430be23..bfa1fe370b 100755\n> --- a/ci/lib.sh\n> +++ b/ci/lib.sh\n> @@ -62,7 +62,7 @@ trap \"end_group 'CI setup'\" EXIT\n>  # something went wrong.\n>  #\n>  # We already enabled tracing executed commands earlier. This helps by showing\n> -# how # environment variables are set and and dependencies are installed.\n> +# how # environment variables are set and dependencies are installed.\n>  set -e\n>  \n>  skip_branch_tip_with_tag () {\n\nThis one has a stray \"#\" in it, but it's perfectly fine to not fix this\nas part of this commit.\n\nThanks!\n\nPatrick\n"}]}