{"thread":{"id":"62353","subject":"[PATCH] t: fix typos","startedAt":"2024-10-17T11:28:42Z","lastAt":"2024-10-19T13:08:09Z","messageCount":9,"participants":["Andrew Kreimer","Taylor Blau","Kristoffer Haugsbakk"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"505359","messageId":"20241017112835.10100-1-algonell@gmail.com","threadId":"62353","inReplyTo":null,"subject":"[PATCH] t: fix typos","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-10-17T11:28:35Z","receivedAt":"2024-10-17T11:28:42Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"Fix typos in documentation, comments, etc.\n\nVia codespell.\n\nSigned-off-by: Andrew Kreimer <algonell@gmail.com>\n---\nSynced with:\n  - Merge branch 'la/trailer-info' into seen.\n\nTested:\n  - ubuntu-latest, GitHub Actions.\n\n t/t0000-basic.sh                         | 4 ++--\n t/t0021-conversion.sh                    | 4 ++--\n t/t0212/parse_events.perl                | 2 +-\n t/t0600-reffiles-backend.sh              | 2 +-\n t/t1016-compatObjectFormat.sh            | 2 +-\n t/t1092-sparse-checkout-compatibility.sh | 6 +++---\n t/t1400-update-ref.sh                    | 4 ++--\n t/t1506-rev-parse-diagnosis.sh           | 2 +-\n t/t2082-parallel-checkout-attributes.sh  | 2 +-\n 9 files changed, 14 insertions(+), 14 deletions(-)\n\ndiff --git a/t/t0000-basic.sh b/t/t0000-basic.sh\nindex 98b81e4d63..35c5c2b4f9 100755\n--- a/t/t0000-basic.sh\n+++ b/t/t0000-basic.sh\n@@ -684,7 +684,7 @@ test_expect_success 'subtest: tests respect lazy prerequisites' '\n \twrite_and_run_sub_test_lib_test lazy-prereqs <<-\\EOF &&\n \n \ttest_lazy_prereq LAZY_TRUE true\n-\ttest_expect_success LAZY_TRUE \"lazy prereq is satisifed\" \"true\"\n+\ttest_expect_success LAZY_TRUE \"lazy prereq is satisfied\" \"true\"\n \ttest_expect_success !LAZY_TRUE \"negative lazy prereq\" \"false\"\n \n \ttest_lazy_prereq LAZY_FALSE false\n@@ -695,7 +695,7 @@ test_expect_success 'subtest: tests respect lazy prerequisites' '\n \tEOF\n \n \tcheck_sub_test_lib_test lazy-prereqs <<-\\EOF\n-\tok 1 - lazy prereq is satisifed\n+\tok 1 - lazy prereq is satisfied\n \tok 2 # skip negative lazy prereq (missing !LAZY_TRUE)\n \tok 3 # skip lazy prereq not satisfied (missing LAZY_FALSE)\n \tok 4 - negative false prereq\ndiff --git a/t/t0021-conversion.sh b/t/t0021-conversion.sh\nindex eeb2714d9d..9e6c6ee0d4 100755\n--- a/t/t0021-conversion.sh\n+++ b/t/t0021-conversion.sh\n@@ -1116,11 +1116,11 @@ do\n \t\ttest_delayed_checkout_progress test_terminal git checkout $opt\n \t'\n \n-\ttest_expect_success PERL \"delayed checkout ommits progress on non-tty ($mode checkout)\" '\n+\ttest_expect_success PERL \"delayed checkout omits progress on non-tty ($mode checkout)\" '\n \t\ttest_delayed_checkout_progress ! git checkout $opt\n \t'\n \n-\ttest_expect_success PERL,TTY \"delayed checkout ommits progress with --quiet ($mode checkout)\" '\n+\ttest_expect_success PERL,TTY \"delayed checkout omits progress with --quiet ($mode checkout)\" '\n \t\ttest_delayed_checkout_progress ! test_terminal git checkout --quiet $opt\n \t'\n \ndiff --git a/t/t0212/parse_events.perl b/t/t0212/parse_events.perl\nindex 30a9f51e9f..7146476c69 100644\n--- a/t/t0212/parse_events.perl\n+++ b/t/t0212/parse_events.perl\n@@ -204,7 +204,7 @@\n     }\n \n     # A series of potentially nested and threaded region and data events\n-    # is fundamentally incompatibile with the type of summary record we\n+    # is fundamentally incompatible with the type of summary record we\n     # are building in this script.  Since they are intended for\n     # perf-trace-like analysis rather than a result summary, we ignore\n     # most of them here.\ndiff --git a/t/t0600-reffiles-backend.sh b/t/t0600-reffiles-backend.sh\nindex 20df336cc3..bef2b70871 100755\n--- a/t/t0600-reffiles-backend.sh\n+++ b/t/t0600-reffiles-backend.sh\n@@ -271,7 +271,7 @@ test_expect_success 'setup worktree' '\n # Some refs (refs/bisect/*, pseudorefs) are kept per worktree, so they should\n # only appear in the for-each-reflog output if it is called from the correct\n # worktree, which is exercised in this test. This test is poorly written for\n-# mulitple reasons: 1) it creates invalidly formatted log entres. 2) it uses\n+# multiple reasons: 1) it creates invalidly formatted log entries. 2) it uses\n # direct FS access for creating the reflogs. 3) PSEUDO-WT and refs/bisect/random\n # do not create reflogs by default, so it is not testing a realistic scenario.\n test_expect_success 'for_each_reflog()' '\ndiff --git a/t/t1016-compatObjectFormat.sh b/t/t1016-compatObjectFormat.sh\nindex be3206a16f..92024fe51d 100755\n--- a/t/t1016-compatObjectFormat.sh\n+++ b/t/t1016-compatObjectFormat.sh\n@@ -117,7 +117,7 @@ do\n \t\tgit config extensions.objectformat $hash &&\n \t\tgit config extensions.compatobjectformat $(compat_hash $hash) &&\n \t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n-\t\techo \"Hellow World!\" > hello &&\n+\t\techo \"Hello World!\" > hello &&\n \t\teval hello_${hash}_oid=$(git hash-object hello) &&\n \t\tgit update-index --add hello &&\n \t\tgit commit -m \"Initial commit\" &&\ndiff --git a/t/t1092-sparse-checkout-compatibility.sh b/t/t1092-sparse-checkout-compatibility.sh\nindex 3d44bd7643..2157f37da3 100755\n--- a/t/t1092-sparse-checkout-compatibility.sh\n+++ b/t/t1092-sparse-checkout-compatibility.sh\n@@ -708,7 +708,7 @@ test_expect_success 'reset with wildcard pathspec' '\n \ttest_all_match git ls-files -s -- deep &&\n \n \t# The following `git reset`s result in updating the index on files with\n-\t# `skip-worktree` enabled. To avoid failing due to discrepencies in reported\n+\t# `skip-worktree` enabled. To avoid failing due to discrepancies in reported\n \t# \"modified\" files, `test_sparse_match` reset is performed separately from\n \t# \"full-checkout\" reset, then the index contents of all repos are verified.\n \n@@ -824,7 +824,7 @@ test_expect_success 'update-index --remove outside sparse definition' '\n \t# Reset the state\n \ttest_all_match git reset --hard &&\n \n-\t# --force-remove supercedes --ignore-skip-worktree-entries, removing\n+\t# --force-remove supersedes --ignore-skip-worktree-entries, removing\n \t# a skip-worktree file from the index (and disk) when both are specified\n \t# with --remove\n \ttest_sparse_match git update-index --force-remove --ignore-skip-worktree-entries folder1/a &&\n@@ -2081,7 +2081,7 @@ test_expect_success 'grep is not expanded' '\n test_expect_failure 'grep within submodules is not expanded' '\n \tinit_repos_as_submodules &&\n \n-\t# do not use ensure_not_expanded() here, becasue `grep` should be\n+\t# do not use ensure_not_expanded() here, because `grep` should be\n \t# run in the superproject, not in \"./sparse-index\"\n \tGIT_TRACE2_EVENT=\"$(pwd)/trace2.txt\" \\\n \tgit grep --cached --recurse-submodules a -- \"*/folder1/*\" &&\ndiff --git a/t/t1400-update-ref.sh b/t/t1400-update-ref.sh\nindex eb1691860d..bb057596f1 100755\n--- a/t/t1400-update-ref.sh\n+++ b/t/t1400-update-ref.sh\n@@ -1838,10 +1838,10 @@ do\n \n \ttest_expect_success \"stdin $type create dangling symref ref works\" '\n \t\ttest_when_finished \"git symbolic-ref -d refs/heads/symref\" &&\n-\t\tformat_command $type \"symref-create refs/heads/symref\" \"refs/heads/unkown\" >stdin &&\n+\t\tformat_command $type \"symref-create refs/heads/symref\" \"refs/heads/unknown\" >stdin &&\n \t\tgit update-ref --stdin $type --no-deref <stdin &&\n \t\tgit symbolic-ref refs/heads/symref >expect &&\n-\t\techo refs/heads/unkown >actual &&\n+\t\techo refs/heads/unknown >actual &&\n \t\ttest_cmp expect actual\n \t'\n \ndiff --git a/t/t1506-rev-parse-diagnosis.sh b/t/t1506-rev-parse-diagnosis.sh\nindex ef40511d89..a3464976e3 100755\n--- a/t/t1506-rev-parse-diagnosis.sh\n+++ b/t/t1506-rev-parse-diagnosis.sh\n@@ -195,7 +195,7 @@ test_expect_success 'dotdot is not an empty set' '\n '\n \n test_expect_success 'dotdot does not peel endpoints' '\n-\tgit tag -a -m \"annote\" annotated HEAD &&\n+\tgit tag -a -m \"annotate\" annotated HEAD &&\n \tA=$(git rev-parse annotated) &&\n \tH=$(git rev-parse annotated^0) &&\n \t{\ndiff --git a/t/t2082-parallel-checkout-attributes.sh b/t/t2082-parallel-checkout-attributes.sh\nindex aec55496eb..da06cafad7 100755\n--- a/t/t2082-parallel-checkout-attributes.sh\n+++ b/t/t2082-parallel-checkout-attributes.sh\n@@ -91,7 +91,7 @@ test_expect_success 'parallel-checkout with eol conversions' '\n \n # Entries that require an external filter are not eligible for parallel\n # checkout. Check that both the parallel-eligible and non-eligible entries are\n-# properly writen in a single checkout operation.\n+# properly written in a single checkout operation.\n #\n test_expect_success 'parallel-checkout and external filter' '\n \tset_checkout_config 2 0 &&\n-- \n2.39.5\n\n"},{"id":"505389","messageId":"ZxFyKXDCJkRZYYQY@nand.local","threadId":"62353","inReplyTo":"20241017112835.10100-1-algonell@gmail.com","subject":"Re: [PATCH] t: fix typos","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-17T20:23:05Z","receivedAt":"2024-10-17T20:23:09Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Thu, Oct 17, 2024 at 02:28:35PM +0300, Andrew Kreimer wrote:\n> Fix typos in documentation, comments, etc.\n>\n> Via codespell.\n>\n> Signed-off-by: Andrew Kreimer <algonell@gmail.com>\n> ---\n> Synced with:\n>   - Merge branch 'la/trailer-info' into seen.\n\nPlease do not base new topics on 'seen', as it is likely to change\nday-to-day.\n\n> @@ -117,7 +117,7 @@ do\n>  \t\tgit config extensions.objectformat $hash &&\n>  \t\tgit config extensions.compatobjectformat $(compat_hash $hash) &&\n>  \t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> -\t\techo \"Hellow World!\" > hello &&\n> +\t\techo \"Hello World!\" > hello &&\n\nNot the fault of this patch, but there is a style issue here that there\nshould not be a space between '>' and 'hello' (i.e. it should read\n'>hello', not '> hello').\n\nLikewise with the 'git config' use above should be test_config, etc. But\nthis patch does not need to care about that, since it did not introduce\nthose issues in the first place.\n\nThe rest looks good, thanks.\n\nThanks,\nTaylor\n"},{"id":"505451","messageId":"ZxKSFBl_pV2r99dY@void.void","threadId":"62353","inReplyTo":"ZxFyKXDCJkRZYYQY@nand.local","subject":"Re: [PATCH] t: fix typos","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-10-18T16:51:32Z","receivedAt":"2024-10-18T16:51:36Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"On Thu, Oct 17, 2024 at 04:23:05PM -0400, Taylor Blau wrote:\n> Please do not base new topics on 'seen', as it is likely to change\n> day-to-day.\n> \n\nNoted, thank you.\n\n> > @@ -117,7 +117,7 @@ do\n> >  \t\tgit config extensions.objectformat $hash &&\n> >  \t\tgit config extensions.compatobjectformat $(compat_hash $hash) &&\n> >  \t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n> > -\t\techo \"Hellow World!\" > hello &&\n> > +\t\techo \"Hello World!\" > hello &&\n> \n> Not the fault of this patch, but there is a style issue here that there\n> should not be a space between '>' and 'hello' (i.e. it should read\n> '>hello', not '> hello').\n> \n\nDo you mean that '> more' and '> another' should be handled similarly?\n\n> Likewise with the 'git config' use above should be test_config, etc. But\n> this patch does not need to care about that, since it did not introduce\n> those issues in the first place.\n> \n\nWill try to address this one.\n"},{"id":"505452","messageId":"be0c95ee-1d9f-4e97-9710-0ceba9c3aaed@app.fastmail.com","threadId":"62353","inReplyTo":"ZxKSFBl_pV2r99dY@void.void","subject":"Re: [PATCH] t: fix typos","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-10-18T16:58:48Z","receivedAt":"2024-10-18T16:59:10Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"On Fri, Oct 18, 2024, at 18:51, Andrew Kreimer wrote:\n> On Thu, Oct 17, 2024 at 04:23:05PM -0400, Taylor Blau wrote:\n>> Please do not base new topics on 'seen', as it is likely to change\n>> day-to-day.\n>>\n>\n> Noted, thank you.\n>\n>> > @@ -117,7 +117,7 @@ do\n>> >  \t\tgit config extensions.objectformat $hash &&\n>> >  \t\tgit config extensions.compatobjectformat $(compat_hash $hash) &&\n>> >  \t\tgit config gpg.program $TEST_DIRECTORY/t1016/gpg &&\n>> > -\t\techo \"Hellow World!\" > hello &&\n>> > +\t\techo \"Hello World!\" > hello &&\n>>\n>> Not the fault of this patch, but there is a style issue here that there\n>> should not be a space between '>' and 'hello' (i.e. it should read\n>> '>hello', not '> hello').\n>>\n>\n> Do you mean that '> more' and '> another' should be handled similarly?\n\nWhat do these two refer to?\n\nThe code style says that redirection operators should have no space\nafter them.  See Documentation/CodingGuidelines at “Redirection\noperators”.\n\n-- \nKristoffer Haugsbakk\n\n\n"},{"id":"505453","messageId":"ZxKi7qn6tEWyBXsd@void.void","threadId":"62353","inReplyTo":"be0c95ee-1d9f-4e97-9710-0ceba9c3aaed@app.fastmail.com","subject":"Re: [PATCH] t: fix typos","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-10-18T18:03:26Z","receivedAt":"2024-10-18T18:03:31Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"On Fri, Oct 18, 2024 at 06:58:48PM +0200, Kristoffer Haugsbakk wrote:\n> The code style says that redirection operators should have no space\n> after them.  See Documentation/CodingGuidelines at “Redirection\n> operators”.\n> \n> -- \n> Kristoffer Haugsbakk\n\nThanks for the clarification, will address this one as well.\n"},{"id":"505462","messageId":"ZxLNj59mKfZubiY/@nand.local","threadId":"62353","inReplyTo":"ZxKi7qn6tEWyBXsd@void.void","subject":"Re: [PATCH] t: fix typos","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-18T21:05:19Z","receivedAt":"2024-10-18T21:05:23Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Fri, Oct 18, 2024 at 09:03:26PM +0300, Andrew Kreimer wrote:\n> On Fri, Oct 18, 2024 at 06:58:48PM +0200, Kristoffer Haugsbakk wrote:\n> > The code style says that redirection operators should have no space\n> > after them.  See Documentation/CodingGuidelines at “Redirection\n> > operators”.\n> >\n> > --\n> > Kristoffer Haugsbakk\n>\n> Thanks for the clarification, will address this one as well.\n\nThanks, both. Kristoffer -- it's fine to do this in the same, or a\nseparate patch in the new round. Thanks.\n\nThanks,\nTaylor\n"},{"id":"505463","messageId":"ZxLN0u5r88hQsY+c@nand.local","threadId":"62353","inReplyTo":"ZxLNj59mKfZubiY/@nand.local","subject":"Re: [PATCH] t: fix typos","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-18T21:06:26Z","receivedAt":"2024-10-18T21:06:30Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Fri, Oct 18, 2024 at 05:05:19PM -0400, Taylor Blau wrote:\n> On Fri, Oct 18, 2024 at 09:03:26PM +0300, Andrew Kreimer wrote:\n> > On Fri, Oct 18, 2024 at 06:58:48PM +0200, Kristoffer Haugsbakk wrote:\n> > > The code style says that redirection operators should have no space\n> > > after them.  See Documentation/CodingGuidelines at “Redirection\n> > > operators”.\n> > >\n> > > --\n> > > Kristoffer Haugsbakk\n> >\n> > Thanks for the clarification, will address this one as well.\n>\n> Thanks, both. Kristoffer -- it's fine to do this in the same, or a\n> separate patch in the new round. Thanks.\n\nOops, I meant s/Kristoffer/Andrew/ here. Sorry about that.\n\nThanks,\nTaylor\n"},{"id":"505474","messageId":"ZxLWAmXJORyVldip@nand.local","threadId":"62353","inReplyTo":"ZxLN0u5r88hQsY+c@nand.local","subject":"Re: [PATCH] t: fix typos","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-18T21:41:22Z","receivedAt":"2024-10-18T21:41:26Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Fri, Oct 18, 2024 at 05:06:26PM -0400, Taylor Blau wrote:\n> > > Thanks for the clarification, will address this one as well.\n> >\n> > Thanks, both. Kristoffer -- it's fine to do this in the same, or a\n> > separate patch in the new round. Thanks.\n>\n> Oops, I meant s/Kristoffer/Andrew/ here. Sorry about that.\n\nWow. It must be time for me to close my laptop for the day ;-).\n\nSince this topic is already on 'next', please submit any new patches in\na separate topic so I can queue them independently. Thanks.\n\nThanks,\nTaylor\n"},{"id":"505499","messageId":"ZxOvNNz6qGGGES8F@void.void","threadId":"62353","inReplyTo":"ZxLWAmXJORyVldip@nand.local","subject":"Re: [PATCH] t: fix typos","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-10-19T13:08:04Z","receivedAt":"2024-10-19T13:08:09Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"On Fri, Oct 18, 2024 at 05:41:22PM -0400, Taylor Blau wrote:\n> Since this topic is already on 'next', please submit any new patches in\n> a separate topic so I can queue them independently. Thanks.\n\nOn it.\n"}]}