{"thread":{"id":"62352","subject":"[Outreachy][RFC]: teach the '-e' option for git notes sub command","startedAt":"2024-10-17T09:44:06Z","lastAt":"2024-10-19T09:13:30Z","messageCount":3,"participants":["Abraham Samuel","Patrick Steinhardt"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"505355","messageId":"CAO1n886ZRRD6m_GQsYz-AGwpbkDB4S+0+hRx-9mmN=6iJ1o7Mg@mail.gmail.com","threadId":"62352","inReplyTo":null,"subject":"[Outreachy][RFC]: teach the '-e' option for git notes sub command","fromName":"Abraham Samuel","fromEmail":"sammymore50@gmail.com","sentAt":"2024-10-17T09:43:56Z","receivedAt":"2024-10-17T09:44:06Z","isPatch":false,"sender":{"key":"sammymore50@gmail.com","avatar":null},"body":"Hello,\n\nI was searching through the list for a #leftoverbits project that I could do.\nI then came across this conversation\n\nhttps://public-inbox.org/git/xmqqed7bhobk.fsf@gitster.g/.\n\nThe suggestion was made to make messages seeded with -m/-F to the \"git\nnotes add\" subcommand be editable when the \"-e\" option is passed to\nit. This allows modifying the message by opening the default editor to\nenable the message to be edited before adding the note.\n\nI have checked the current version of git and there is no \"-e\" option\nimplemented.\nI am also studying similar implementations for git commit and git tag\nto help me understand the implementation.\nHowever, I would like to know if I am permitted to go ahead and if\nyes, I would appreciate pointers to other resources to aid me in\nimplementing it.\n\nThanks\nAbraham.\n"},{"id":"505363","messageId":"ZxD-FCW9drBpC4c5@pks.im","threadId":"62352","inReplyTo":"CAO1n886ZRRD6m_GQsYz-AGwpbkDB4S+0+hRx-9mmN=6iJ1o7Mg@mail.gmail.com","subject":"Re: [Outreachy][RFC]: teach the '-e' option for git notes sub command","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-10-17T12:07:53Z","receivedAt":"2024-10-17T12:07:59Z","isPatch":false,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Thu, Oct 17, 2024 at 10:43:56AM +0100, Abraham Samuel wrote:\n> Hello,\n> \n> I was searching through the list for a #leftoverbits project that I could do.\n> I then came across this conversation\n> \n> https://public-inbox.org/git/xmqqed7bhobk.fsf@gitster.g/.\n> \n> The suggestion was made to make messages seeded with -m/-F to the \"git\n> notes add\" subcommand be editable when the \"-e\" option is passed to\n> it. This allows modifying the message by opening the default editor to\n> enable the message to be edited before adding the note.\n> \n> I have checked the current version of git and there is no \"-e\" option\n> implemented.\n> I am also studying similar implementations for git commit and git tag\n> to help me understand the implementation.\n> However, I would like to know if I am permitted to go ahead and if\n> yes, I would appreciate pointers to other resources to aid me in\n> implementing it.\n\nYou don't have to ask for permission in order to fix issues. So please,\nfeel free to go ahead.\n\nI assume you've already read through the common documents that we have\nin Documentation/, like MyFirstContribution.txt et al. Other than that\nI'd recommend to have a look at how this is implemented in preexisting\ncommands, but you already had that idea yourself. You could also dig\ninto the history of how those `-e` options have been introduced for\nthese commands, which might give you an idea what was required to be\ndone for them, and you'll likely have to do something similar for `git\nnotes add`.\n\nI don't really think we have any other resources that would be helpful\nin this context.\n\nPatrick\n"},{"id":"505489","messageId":"CAO1n884Kd5v7A--=895xAc0nHqQtVsCcJn5ad-4pdGhQv1SNCA@mail.gmail.com","threadId":"62352","inReplyTo":"ZxD-FCW9drBpC4c5@pks.im","subject":"Re: [Outreachy][RFC]: teach the '-e' option for git notes sub command","fromName":"Abraham Samuel","fromEmail":"sammymore50@gmail.com","sentAt":"2024-10-19T09:13:19Z","receivedAt":"2024-10-19T09:13:30Z","isPatch":false,"sender":{"key":"sammymore50@gmail.com","avatar":null},"body":"On Thu, Oct 17, 2024 at 1:07 PM Patrick Steinhardt <ps@pks.im> wrote:\n>\n> On Thu, Oct 17, 2024 at 10:43:56AM +0100, Abraham Samuel wrote:\n> > Hello,\n> >\n> > I was searching through the list for a #leftoverbits project that I could do.\n> > I then came across this conversation\n> >\n> > https://public-inbox.org/git/xmqqed7bhobk.fsf@gitster.g/.\n> >\n> > The suggestion was made to make messages seeded with -m/-F to the \"git\n> > notes add\" subcommand be editable when the \"-e\" option is passed to\n> > it. This allows modifying the message by opening the default editor to\n> > enable the message to be edited before adding the note.\n> >\n> > I have checked the current version of git and there is no \"-e\" option\n> > implemented.\n> > I am also studying similar implementations for git commit and git tag\n> > to help me understand the implementation.\n> > However, I would like to know if I am permitted to go ahead and if\n> > yes, I would appreciate pointers to other resources to aid me in\n> > implementing it.\n>\n> You don't have to ask for permission in order to fix issues. So please,\n> feel free to go ahead.\n>\n> I assume you've already read through the common documents that we have\n> in Documentation/, like MyFirstContribution.txt et al.Other than that\n\nHello Patrick,\nThank you very much.\nI have previously read the Documents you referenced and already done\nthe microProject\nhttps://lore.kernel.org/git/pull.1811.v4.git.1728498122419.gitgitgadget@gmail.com/\nwhich has been integrated into master and closed.\n\n> I'd recommend to have a look at how this is implemented in preexisting\n> commands, but you already had that idea yourself. You could also dig\n> into the history of how those `-e` options have been introduced for\n> these commands, which might give you an idea what was required to be\n> done for them, and you'll likely have to do something similar for `git\n> notes add`.\n>\n> I don't really think we have any other resources that would be helpful\n> in this context.\n>\n> Patrick\n\nI have submitted a new patch with respect to this.\nhttps://lore.kernel.org/git/pull.1817.git.1729296853800.gitgitgadget@gmail.com/\n\nThanks for your time.\n"}]}