{"thread":{"id":"62323","subject":"[RFC Outreachy] Leftoverbits, which involve replacing atoi with strtol or strtol_i or equivalent.","startedAt":"2024-10-12T11:21:26Z","lastAt":"2024-10-16T01:25:58Z","messageCount":8,"participants":["Usman Akinyemi","Taylor Blau"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"504911","messageId":"CAPSxiM9FoGBhsnBE4E0Fvq-x_HvyFGGkkhaLNoRdVkvE6CpaZw@mail.gmail.com","threadId":"62323","inReplyTo":null,"subject":"[RFC Outreachy] Leftoverbits, which involve replacing atoi with strtol or strtol_i or equivalent.","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2024-10-12T11:21:13Z","receivedAt":"2024-10-12T11:21:26Z","isPatch":false,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"Hello,\n\nI was looking at some #leftoverbits which I can work on and I came\nacross this conversation.\nhttps://public-inbox.org/git/CAC4O8c-nuOTS=a0sVp1603KaM2bZjs+yNZzdAaa5CGTNGFE7hQ@mail.gmail.com/\n\nI followed the conversation and came accross\nthree instances where I think atoi can be\nconverted to strtol or strtol_i or parse_timestamp().\nThese are the three files which I think the atoi can be\nreplaced with.\n\nmerge-ll.c\n\nsomething like this can be replace with\nif (check->items[1].value) {\n marker_size = atoi(check->items[1].value);\n if (marker_size <= 0)\n marker_size = DEFAULT_CONFLICT_MARKER_SIZE;\n}\n\nif (check->items[1].value) {\n char *endptr;\n long temp_marker_size = strtol(check->items[1].value, &endptr, 10);\n\n // Check for conversion errors\n if (endptr == check->items[1].value || *endptr != '\\0' ||\ntemp_marker_size <= 0) {\n marker_size = DEFAULT_CONFLICT_MARKER_SIZE; // Set to default on error\n } else {\n marker_size = (int)temp_marker_size;\n }\n}\n\nalternative is to use strtol_i here which I think is more neater.\nif (check->items[1].value) {\n if (strtol_i(check->items[1].value, 10, &marker_size) != 0 ||\nmarker_size <= 0) {\n marker_size = DEFAULT_CONFLICT_MARKER_SIZE;\n }\n}\n\n\ndaemon.c\nif (skip_prefix(arg, \"--timeout=\", &v)) {\n timeout = atoi(v);\n continue;\n}\nif (skip_prefix(arg, \"--init-timeout=\", &v)) {\n init_timeout = atoi(v);\n continue;\n}\nif (skip_prefix(arg, \"--max-connections=\", &v)) {\n max_connections = atoi(v);\n if (max_connections < 0)\n max_connections = 0; /* unlimited */\n continue;\n}\n\n\nif (skip_prefix(arg, \"--timeout=\", &v)) {\n timeout = parse_age(v);\n continue;\n}\n\nif (skip_prefix(arg, \"--init-timeout=\", &v)) {\n init_timeout = parse_age(v);\n continue;\n}\n\nif (skip_prefix(arg, \"--max-connections=\", &v)) {\n // Use strtol_i to convert the string to an integer\n if (strtol_i(v, 10, &max_connections) != 0 || max_connections < 0) {\n max_connections = 0; // Set to default on error\n }\n continue;\n}\n\nimap-send.c\n\nif (!strcmp(\"UIDVALIDITY\", arg)) {\n if (!(arg = next_arg(&s)) || !(ctx->uidvalidity = atoi(arg))) {\n fprintf(stderr, \"IMAP error: malformed UIDVALIDITY status\\n\");\n return RESP_BAD;\n }\n} else if (!strcmp(\"UIDNEXT\", arg)) {\n if (!(arg = next_arg(&s)) || !(imap->uidnext = atoi(arg))) {\n fprintf(stderr, \"IMAP error: malformed NEXTUID status\\n\");\n return RESP_BAD;\n }\n} else if (!strcmp(\"CAPABILITY\", arg)) {\n parse_capability(imap, s);\n} else if (!strcmp(\"ALERT\", arg)) {\n /* RFC2060 says that these messages MUST be displayed\n * to the user\n */\n for (; isspace((unsigned char)*p); p++);\n fprintf(stderr, \"*** IMAP ALERT *** %s\\n\", p);\n} else if (cb && cb->ctx && !strcmp(\"APPENDUID\", arg)) {\n if (!(arg = next_arg(&s)) || !(ctx->uidvalidity = atoi(arg)) ||\n !(arg = next_arg(&s)) || !(*(int *)cb->ctx = atoi(arg))) {\n fprintf(stderr, \"IMAP error: malformed APPENDUID status\\n\");\n return RESP_BAD;\n }\n}\n\nproposed one using strtol_i and I think instead of using strtol_i here, we can\nhave another custom function that indicate what cause the UIDVALIDITY\nto be malformed\neither overflow, letter etc\n\nif (!strcmp(\"UIDVALIDITY\", arg)) {\n if (!(arg = next_arg(&s)) || strtol_i(arg, 10, &ctx->uidvalidity) != 0) {\n fprintf(stderr, \"IMAP error: malformed UIDVALIDITY status\\n\");\n return RESP_BAD;\n }\n\n\n} else if (!strcmp(\"UIDNEXT\", arg)) {\n if (!(arg = next_arg(&s)) || strtol_i(arg, 10, &imap->uidnext) != 0) {\n fprintf(stderr, \"IMAP error: malformed NEXTUID status\\n\");\n return RESP_BAD;\n }\n\n} else if (!strcmp(\"CAPABILITY\", arg)) {\n parse_capability(imap, s);\n} else if (!strcmp(\"ALERT\", arg)) {\n // RFC2060 says that these messages MUST be displayed to the user\n for (; isspace((unsigned char)*p); p++);\n fprintf(stderr, \"*** IMAP ALERT *** %s\\n\", p);\n} else if (cb && cb->ctx && !strcmp(\"APPENDUID\", arg)) {\n if (!(arg = next_arg(&s)) ||\n (strtol_i(arg, 10, &ctx->uidvalidity) != 0) ||\n !(arg = next_arg(&s)) ||\n (strtol_i(arg, 10, (int *)cb->ctx) != 0)) {\n\n fprintf(stderr, \"IMAP error: malformed APPENDUID status\\n\");\n return RESP_BAD;\n }\n}\n\n- Another instance inside imap-send.c\n} else {\n tag = atoi(arg);\n for (pcmdp = &imap->in_progress; (cmdp = *pcmdp); pcmdp = &cmdp->next)\n if (cmdp->tag == tag)\n goto gottag;\n fprintf(stderr, \"IMAP error: unexpected tag %s\\n\", arg);\n return RESP_BAD;\n}\n\n- Possible solution.\n\n} else {\n int tag_result; // Variable to hold the result of strtol_i\n if (strtol_i(arg, 10, &tag_result) != 0) {\n fprintf(stderr, \"IMAP error: malformed tag %s\\n\", arg);\n return RESP_BAD;\n }\n\n // Now use the valid tag_result\n for (pcmdp = &imap->in_progress; (cmdp = *pcmdp); pcmdp = &cmdp->next)\n if (cmdp->tag == tag_result)\n goto gottag;\n\n fprintf(stderr, \"IMAP error: unexpected tag %s\\n\", arg);\n return RESP_BAD;\n}\n\nThank you.\nUsman Akinyemi.\n"},{"id":"504919","messageId":"ZwqcHDzaR2U2JNu0@nand.local","threadId":"62323","inReplyTo":"CAPSxiM9FoGBhsnBE4E0Fvq-x_HvyFGGkkhaLNoRdVkvE6CpaZw@mail.gmail.com","subject":"Re: [RFC Outreachy] Leftoverbits, which involve replacing atoi with strtol or strtol_i or equivalent.","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-12T15:56:12Z","receivedAt":"2024-10-12T15:56:15Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi Usman,\n\nOn Sat, Oct 12, 2024 at 11:21:13AM +0000, Usman Akinyemi wrote:\n> Hello,\n>\n> I was looking at some #leftoverbits which I can work on and I came\n> across this conversation.\n> https://public-inbox.org/git/CAC4O8c-nuOTS=a0sVp1603KaM2bZjs+yNZzdAaa5CGTNGFE7hQ@mail.gmail.com/\n>\n> I followed the conversation and came accross\n> three instances where I think atoi can be\n> converted to strtol or strtol_i or parse_timestamp().\n> These are the three files which I think the atoi can be\n> replaced with.\n\nThis seems like a good #leftoverbits to use as an Outreachy\ncontribution. From a brief skim, it looks like this is going in the\nright direction.\n\nBut to get help from the rest of the list, please submit this change as\na patch or patch series, following the instructions in:\n\n - Documentation/MyFirstContribution.txt, and\n - Documentation/SubmittingPatches\n\nThanks,\nTaylor\n"},{"id":"504941","messageId":"CAPSxiM_U5ffBCsTrbBqsJK0jUZtAuWSLook8CLKat46CX0QC7g@mail.gmail.com","threadId":"62323","inReplyTo":"ZwqcHDzaR2U2JNu0@nand.local","subject":"Re: [RFC Outreachy] Leftoverbits, which involve replacing atoi with strtol or strtol_i or equivalent.","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2024-10-13T03:46:05Z","receivedAt":"2024-10-13T03:46:17Z","isPatch":false,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"On Sat, Oct 12, 2024 at 3:56 PM Taylor Blau wrote:\n>\n> Hi Usman,\n>\n> On Sat, Oct 12, 2024 at 11:21:13AM +0000, Usman Akinyemi wrote:\n> > Hello,\n> >\n> > I was looking at some #leftoverbits which I can work on and I came\n> > across this conversation.\n> > https://public-inbox.org/git/CAC4O8c-nuOTS=a0sVp1603KaM2bZjs+yNZzdAaa5CGTNGFE7hQ@mail.gmail.com/\n> >\n> > I followed the conversation and came accross\n> > three instances where I think atoi can be\n> > converted to strtol or strtol_i or parse_timestamp().\n> > These are the three files which I think the atoi can be\n> > replaced with.\n>\n> This seems like a good #leftoverbits to use as an Outreachy\n> contribution. From a brief skim, it looks like this is going in the\n> right direction.\n>\n> But to get help from the rest of the list, please submit this change as\n> a patch or patch series, following the instructions in:\n>\n> - Documentation/MyFirstContribution.txt, and\n> - Documentation/SubmittingPatches\n>\nThanks Taylor, I already went through these as I already sent my first\npatch before. Also, I already sent a patch as you suggested. Thank\nyou very much.\nUsman Akinyemi.\n> Thanks,\n> Taylor\n"},{"id":"505107","messageId":"Zw26bU17+2SRfv8L@nand.local","threadId":"62323","inReplyTo":"CAPSxiM_U5ffBCsTrbBqsJK0jUZtAuWSLook8CLKat46CX0QC7g@mail.gmail.com","subject":"Re: [RFC Outreachy] Leftoverbits, which involve replacing atoi with strtol or strtol_i or equivalent.","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-10-15T00:42:21Z","receivedAt":"2024-10-15T00:42:24Z","isPatch":false,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"On Sun, Oct 13, 2024 at 03:46:05AM +0000, Usman Akinyemi wrote:\n> On Sat, Oct 12, 2024 at 3:56 PM Taylor Blau wrote:\n> >\n> > Hi Usman,\n> >\n> > On Sat, Oct 12, 2024 at 11:21:13AM +0000, Usman Akinyemi wrote:\n> > > Hello,\n> > >\n> > > I was looking at some #leftoverbits which I can work on and I came\n> > > across this conversation.\n> > > https://public-inbox.org/git/CAC4O8c-nuOTS=a0sVp1603KaM2bZjs+yNZzdAaa5CGTNGFE7hQ@mail.gmail.com/\n> > >\n> > > I followed the conversation and came accross\n> > > three instances where I think atoi can be\n> > > converted to strtol or strtol_i or parse_timestamp().\n> > > These are the three files which I think the atoi can be\n> > > replaced with.\n> >\n> > This seems like a good #leftoverbits to use as an Outreachy\n> > contribution. From a brief skim, it looks like this is going in the\n> > right direction.\n> >\n> > But to get help from the rest of the list, please submit this change as\n> > a patch or patch series, following the instructions in:\n> >\n> > - Documentation/MyFirstContribution.txt, and\n> > - Documentation/SubmittingPatches\n> >\n> Thanks Taylor, I already went through these as I already sent my first\n> patch before. Also, I already sent a patch as you suggested. Thank\n> you very much.\n> Usman Akinyemi.\n\nI must be missing something... I don't see any patches from you that\ntouch e.g., merge-ll.c, which is the first file you mention in this\nthread.\n\nTry searching the list archive for:\n\n f:'Usman Akinyemi' dfn:merge-ll.c\n\nIs this different from the other patches you have sent to the list? My\napologies if I am missing something here.\n\nThanks,\nTaylor\n"},{"id":"505110","messageId":"CAPSxiM9jHn-RQ3FXJRQNKAE9xPr_4yJbWB--oWgQeKhEMLmE4Q@mail.gmail.com","threadId":"62323","inReplyTo":"Zw26bU17+2SRfv8L@nand.local","subject":"Re: [RFC Outreachy] Leftoverbits, which involve replacing atoi with strtol or strtol_i or equivalent.","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2024-10-15T03:49:28Z","receivedAt":"2024-10-15T03:49:39Z","isPatch":false,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"On Tue, Oct 15, 2024 at 12:42 AM Taylor Blau wrote:\n>\n> On Sun, Oct 13, 2024 at 03:46:05AM +0000, Usman Akinyemi wrote:\n> > On Sat, Oct 12, 2024 at 3:56 PM Taylor Blau wrote:\n> > >\n> > > Hi Usman,\n> > >\n> > > On Sat, Oct 12, 2024 at 11:21:13AM +0000, Usman Akinyemi wrote:\n> > > > Hello,\n> > > >\n> > > > I was looking at some #leftoverbits which I can work on and I came\n> > > > across this conversation.\n> > > > https://public-inbox.org/git/CAC4O8c-nuOTS=a0sVp1603KaM2bZjs+yNZzdAaa5CGTNGFE7hQ@mail.gmail.com/\n> > > >\n> > > > I followed the conversation and came accross\n> > > > three instances where I think atoi can be\n> > > > converted to strtol or strtol_i or parse_timestamp().\n> > > > These are the three files which I think the atoi can be\n> > > > replaced with.\n> > >\n> > > This seems like a good #leftoverbits to use as an Outreachy\n> > > contribution. From a brief skim, it looks like this is going in the\n> > > right direction.\n> > >\n> > > But to get help from the rest of the list, please submit this change as\n> > > a patch or patch series, following the instructions in:\n> > >\n> > > - Documentation/MyFirstContribution.txt, and\n> > > - Documentation/SubmittingPatches\n> > >\n> > Thanks Taylor, I already went through these as I already sent my first\n> > patch before. Also, I already sent a patch as you suggested. Thank\n> > you very much.\n> > Usman Akinyemi.\n>\n> I must be missing something... I don't see any patches from you that\n> touch e.g., merge-ll.c, which is the first file you mention in this\n> thread.\n>\n> Try searching the list archive for:\n>\n> f:'Usman Akinyemi' dfn:merge-ll.c\n>\n> Is this different from the other patches you have sent to the list? My\n> apologies if I am missing something here.\n>\n> Thanks,\n> Taylor\nHi, Taylor\n\nThanks for the reply. There is a little confusion going on.\n\nThis is what happened. I had two patches which are entirely different\nfrom this leftoverbit. Both has been reviewed by other maintainer and\nintegrated into seen by Junio through\nhttps://github.com/git/git/commit/4dae47e02757333b7d6a6508e36ccb5463b6ad92\n and https://github.com/git/git/commit/dfdc6a71e76c7a1dab22fc9d9e437c858cfea6dc.\nI submitted this leftoverbit patch but I made the mistake of basing it\non top of the previous branch which I use for the two above commits.\nThis is the commit which has the leftoverbit and the previous two\ncommits which have already been integrated into seen.\nhttps://public-inbox.org/git/pull.1810.git.git.1728774574.gitgitgadget@gmail.com/T/#t\nThat is the reason why you saw it again. Also, I noticed you also\nintegrated the two patches again into seen and gave some comments. I\nthink that might not be needed again. Thank you.\n"},{"id":"505111","messageId":"CAPSxiM_qw0akVoG5cJRgwk6oP1q519zBp2m6GmFYGmrrc3jXfg@mail.gmail.com","threadId":"62323","inReplyTo":"CAPSxiM9jHn-RQ3FXJRQNKAE9xPr_4yJbWB--oWgQeKhEMLmE4Q@mail.gmail.com","subject":"Re: [RFC Outreachy] Leftoverbits, which involve replacing atoi with strtol or strtol_i or equivalent.","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2024-10-15T03:54:50Z","receivedAt":"2024-10-15T03:55:01Z","isPatch":false,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"On Tue, Oct 15, 2024 at 3:49 AM Usman Akinyemi\n wrote:\n>\n> On Tue, Oct 15, 2024 at 12:42 AM Taylor Blau wrote:\n> >\n> > On Sun, Oct 13, 2024 at 03:46:05AM +0000, Usman Akinyemi wrote:\n> > > On Sat, Oct 12, 2024 at 3:56 PM Taylor Blau wrote:\n> > > >\n> > > > Hi Usman,\n> > > >\n> > > > On Sat, Oct 12, 2024 at 11:21:13AM +0000, Usman Akinyemi wrote:\n> > > > > Hello,\n> > > > >\n> > > > > I was looking at some #leftoverbits which I can work on and I came\n> > > > > across this conversation.\n> > > > > https://public-inbox.org/git/CAC4O8c-nuOTS=a0sVp1603KaM2bZjs+yNZzdAaa5CGTNGFE7hQ@mail.gmail.com/\n> > > > >\n> > > > > I followed the conversation and came accross\n> > > > > three instances where I think atoi can be\n> > > > > converted to strtol or strtol_i or parse_timestamp().\n> > > > > These are the three files which I think the atoi can be\n> > > > > replaced with.\n> > > >\n> > > > This seems like a good #leftoverbits to use as an Outreachy\n> > > > contribution. From a brief skim, it looks like this is going in the\n> > > > right direction.\n> > > >\n> > > > But to get help from the rest of the list, please submit this change as\n> > > > a patch or patch series, following the instructions in:\n> > > >\n> > > > - Documentation/MyFirstContribution.txt, and\n> > > > - Documentation/SubmittingPatches\n> > > >\n> > > Thanks Taylor, I already went through these as I already sent my first\n> > > patch before. Also, I already sent a patch as you suggested. Thank\n> > > you very much.\n> > > Usman Akinyemi.\n> >\n> > I must be missing something... I don't see any patches from you that\n> > touch e.g., merge-ll.c, which is the first file you mention in this\n> > thread.\n> >\n> > Try searching the list archive for:\n> >\n> > f:'Usman Akinyemi' dfn:merge-ll.c\n> >\n> > Is this different from the other patches you have sent to the list? My\n> > apologies if I am missing something here.\n> >\n> > Thanks,\n> > Taylor\n> Hi, Taylor\n>\n> Thanks for the reply. There is a little confusion going on.\n>\n> This is what happened. I had two patches which are entirely different\n> from this leftoverbit. Both has been reviewed by other maintainer and\n> integrated into seen by Junio through\n> https://github.com/git/git/commit/4dae47e02757333b7d6a6508e36ccb5463b6ad92\n> and https://github.com/git/git/commit/dfdc6a71e76c7a1dab22fc9d9e437c858cfea6dc.\n> I submitted this leftoverbit patch but I made the mistake of basing it\n> on top of the previous branch which I use for the two above commits.\n> This is the commit which has the leftoverbit and the previous two\n> commits which have already been integrated into seen.\n> https://public-inbox.org/git/pull.1810.git.git.1728774574.gitgitgadget@gmail.com/T/#t\n> That is the reason why you saw it again. Also, I noticed you also\n> integrated the two patches again into seen and gave some comments. I\n> think that might not be needed again. Thank you.\nI meant for those particular two patches, since it is integrated into\nseen already,\nI can probably wait for it to be merged then work on the review which\nyou gave or what do you think should be done ?\nThank you.\n"},{"id":"505112","messageId":"CAPSxiM-voyrHf0M2ELD6OmJr_ECQMd=+si0wd6_boy7VJCQzyw@mail.gmail.com","threadId":"62323","inReplyTo":"CAPSxiM_qw0akVoG5cJRgwk6oP1q519zBp2m6GmFYGmrrc3jXfg@mail.gmail.com","subject":"Re: [RFC Outreachy] Leftoverbits, which involve replacing atoi with strtol or strtol_i or equivalent.","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2024-10-15T04:04:58Z","receivedAt":"2024-10-15T04:05:10Z","isPatch":false,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"On Tue, Oct 15, 2024 at 3:54 AM Usman Akinyemi\n wrote:\n>\n> On Tue, Oct 15, 2024 at 3:49 AM Usman Akinyemi\n> wrote:\n> >\n> > On Tue, Oct 15, 2024 at 12:42 AM Taylor Blau wrote:\n> > >\n> > > On Sun, Oct 13, 2024 at 03:46:05AM +0000, Usman Akinyemi wrote:\n> > > > On Sat, Oct 12, 2024 at 3:56 PM Taylor Blau wrote:\n> > > > >\n> > > > > Hi Usman,\n> > > > >\n> > > > > On Sat, Oct 12, 2024 at 11:21:13AM +0000, Usman Akinyemi wrote:\n> > > > > > Hello,\n> > > > > >\n> > > > > > I was looking at some #leftoverbits which I can work on and I came\n> > > > > > across this conversation.\n> > > > > > https://public-inbox.org/git/CAC4O8c-nuOTS=a0sVp1603KaM2bZjs+yNZzdAaa5CGTNGFE7hQ@mail.gmail.com/\n> > > > > >\n> > > > > > I followed the conversation and came accross\n> > > > > > three instances where I think atoi can be\n> > > > > > converted to strtol or strtol_i or parse_timestamp().\n> > > > > > These are the three files which I think the atoi can be\n> > > > > > replaced with.\n> > > > >\n> > > > > This seems like a good #leftoverbits to use as an Outreachy\n> > > > > contribution. From a brief skim, it looks like this is going in the\n> > > > > right direction.\n> > > > >\n> > > > > But to get help from the rest of the list, please submit this change as\n> > > > > a patch or patch series, following the instructions in:\n> > > > >\n> > > > > - Documentation/MyFirstContribution.txt, and\n> > > > > - Documentation/SubmittingPatches\n> > > > >\n> > > > Thanks Taylor, I already went through these as I already sent my first\n> > > > patch before. Also, I already sent a patch as you suggested. Thank\n> > > > you very much.\n> > > > Usman Akinyemi.\n> > >\n> > > I must be missing something... I don't see any patches from you that\n> > > touch e.g., merge-ll.c, which is the first file you mention in this\n> > > thread.\n> > >\n> > > Try searching the list archive for:\n> > >\n> > > f:'Usman Akinyemi' dfn:merge-ll.c\n> > >\n> > > Is this different from the other patches you have sent to the list? My\n> > > apologies if I am missing something here.\n> > >\n> > > Thanks,\n> > > Taylor\n> > Hi, Taylor\n> >\n> > Thanks for the reply. There is a little confusion going on.\n> >\n> > This is what happened. I had two patches which are entirely different\n> > from this leftoverbit. Both has been reviewed by other maintainer and\n> > integrated into seen by Junio through\n> > https://github.com/git/git/commit/4dae47e02757333b7d6a6508e36ccb5463b6ad92\n> > and https://github.com/git/git/commit/dfdc6a71e76c7a1dab22fc9d9e437c858cfea6dc.\n> > I submitted this leftoverbit patch but I made the mistake of basing it\n> > on top of the previous branch which I use for the two above commits.\n> > This is the commit which has the leftoverbit and the previous two\n> > commits which have already been integrated into seen.\n> > https://public-inbox.org/git/pull.1810.git.git.1728774574.gitgitgadget@gmail.com/T/#t\n> > That is the reason why you saw it again. Also, I noticed you also\n> > integrated the two patches again into seen and gave some comments. I\n> > think that might not be needed again. Thank you.\n> I meant for those particular two patches, since it is integrated into\n> seen already,\n> I can probably wait for it to be merged then work on the review which\n> you gave or what do you think should be done ?\n> Thank you.\nHi Taylor,\n\nI went through your comment for the two previous patches, some of them\nhave already been addressed in the original thread\nhttps://public-inbox.org/git/CAPSxiM8cpX9NYB02fAPA7WbLsLrvmFfsE2=VN=Ncguif7mQN9Q@mail.gmail.com/.\nI am really sorry for confusing you.\nThank you.\n"},{"id":"505221","messageId":"CAPSxiM-Cn8ZSC+LzRfeyY+Z_Vfj=DguweQ+ZjC4dau-Z64dnWg@mail.gmail.com","threadId":"62323","inReplyTo":"CAPSxiM-voyrHf0M2ELD6OmJr_ECQMd=+si0wd6_boy7VJCQzyw@mail.gmail.com","subject":"Re: [RFC Outreachy] Leftoverbits, which involve replacing atoi with strtol or strtol_i or equivalent.","fromName":"Usman Akinyemi","fromEmail":"usmanakinyemi202@gmail.com","sentAt":"2024-10-16T01:25:46Z","receivedAt":"2024-10-16T01:25:58Z","isPatch":false,"sender":{"key":"usmanakinyemi202@gmail.com","avatar":"https://avatars.githubusercontent.com/u/86585626?v=4"},"body":"On Tue, Oct 15, 2024 at 4:04 AM Usman Akinyemi\n wrote:\n>\n> On Tue, Oct 15, 2024 at 3:54 AM Usman Akinyemi\n> wrote:\n> >\n> > On Tue, Oct 15, 2024 at 3:49 AM Usman Akinyemi\n> > wrote:\n> > >\n> > > On Tue, Oct 15, 2024 at 12:42 AM Taylor Blau wrote:\n> > > >\n> > > > On Sun, Oct 13, 2024 at 03:46:05AM +0000, Usman Akinyemi wrote:\n> > > > > On Sat, Oct 12, 2024 at 3:56 PM Taylor Blau wrote:\n> > > > > >\n> > > > > > Hi Usman,\n> > > > > >\n> > > > > > On Sat, Oct 12, 2024 at 11:21:13AM +0000, Usman Akinyemi wrote:\n> > > > > > > Hello,\n> > > > > > >\n> > > > > > > I was looking at some #leftoverbits which I can work on and I came\n> > > > > > > across this conversation.\n> > > > > > > https://public-inbox.org/git/CAC4O8c-nuOTS=a0sVp1603KaM2bZjs+yNZzdAaa5CGTNGFE7hQ@mail.gmail.com/\n> > > > > > >\n> > > > > > > I followed the conversation and came accross\n> > > > > > > three instances where I think atoi can be\n> > > > > > > converted to strtol or strtol_i or parse_timestamp().\n> > > > > > > These are the three files which I think the atoi can be\n> > > > > > > replaced with.\n> > > > > >\n> > > > > > This seems like a good #leftoverbits to use as an Outreachy\n> > > > > > contribution. From a brief skim, it looks like this is going in the\n> > > > > > right direction.\n> > > > > >\n> > > > > > But to get help from the rest of the list, please submit this change as\n> > > > > > a patch or patch series, following the instructions in:\n> > > > > >\n> > > > > > - Documentation/MyFirstContribution.txt, and\n> > > > > > - Documentation/SubmittingPatches\n> > > > > >\n> > > > > Thanks Taylor, I already went through these as I already sent my first\n> > > > > patch before. Also, I already sent a patch as you suggested. Thank\n> > > > > you very much.\n> > > > > Usman Akinyemi.\n> > > >\n> > > > I must be missing something... I don't see any patches from you that\n> > > > touch e.g., merge-ll.c, which is the first file you mention in this\n> > > > thread.\n> > > >\n> > > > Try searching the list archive for:\n> > > >\n> > > > f:'Usman Akinyemi' dfn:merge-ll.c\n> > > >\n> > > > Is this different from the other patches you have sent to the list? My\n> > > > apologies if I am missing something here.\n> > > >\n> > > > Thanks,\n> > > > Taylor\n> > > Hi, Taylor\n> > >\n> > > Thanks for the reply. There is a little confusion going on.\n> > >\n> > > This is what happened. I had two patches which are entirely different\n> > > from this leftoverbit. Both has been reviewed by other maintainer and\n> > > integrated into seen by Junio through\n> > > https://github.com/git/git/commit/4dae47e02757333b7d6a6508e36ccb5463b6ad92\n> > > and https://github.com/git/git/commit/dfdc6a71e76c7a1dab22fc9d9e437c858cfea6dc.\n> > > I submitted this leftoverbit patch but I made the mistake of basing it\n> > > on top of the previous branch which I use for the two above commits.\n> > > This is the commit which has the leftoverbit and the previous two\n> > > commits which have already been integrated into seen.\n> > > https://public-inbox.org/git/pull.1810.git.git.1728774574.gitgitgadget@gmail.com/T/#t\n> > > That is the reason why you saw it again. Also, I noticed you also\n> > > integrated the two patches again into seen and gave some comments. I\n> > > think that might not be needed again. Thank you.\n> > I meant for those particular two patches, since it is integrated into\n> > seen already,\n> > I can probably wait for it to be merged then work on the review which\n> > you gave or what do you think should be done ?\n> > Thank you.\n> Hi Taylor,\n>\n> I went through your comment for the two previous patches, some of them\n> have already been addressed in the original thread\n> https://public-inbox.org/git/CAPSxiM8cpX9NYB02fAPA7WbLsLrvmFfsE2=VN=Ncguif7mQN9Q@mail.gmail.com/.\n> I am really sorry for confusing you.\n> Thank you.\nHi Taylor,\n\nI am bringing your attention to this. Thank you.\n"}]}