{"thread":{"id":"62168","subject":"[PATCH] doc/git-format-patch: link git-apply","startedAt":"2024-09-22T13:00:41Z","lastAt":"2024-09-23T17:03:12Z","messageCount":2,"participants":["Alexander Ziaee via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"503213","messageId":"pull.1785.git.git.1727010037470.gitgitgadget@gmail.com","threadId":"62168","inReplyTo":null,"subject":"[PATCH] doc/git-format-patch: link git-apply","fromName":"Alexander Ziaee via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-22T13:00:37Z","receivedAt":"2024-09-22T13:00:41Z","isPatch":true,"sender":{"key":"name:Alexander Ziaee","avatar":null},"body":"From: Alexander Ziaee <ziaee@google.com>\n\ngit formatted patches can be applied with git-apply(1),\nso link git-apply(1) in git-format-patch(1) § see also.\n\nSigned-off-by:\tAlexander Ziaee <ziaee@google.com>\n---\n    doc/git-format-patch: link git-apply\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1785%2Fconcussious%2Fmaster-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1785/concussious/master-v1\nPull-Request: https://github.com/git/git/pull/1785\n\n Documentation/git-format-patch.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\nindex 8708b315930..eeebc805d6c 100644\n--- a/Documentation/git-format-patch.txt\n+++ b/Documentation/git-format-patch.txt\n@@ -790,7 +790,7 @@ merge commit.\n \n SEE ALSO\n --------\n-linkgit:git-am[1], linkgit:git-send-email[1]\n+linkgit:git-am[1], linkgit:git-apply[1], linkgit:git-send-email[1]\n \n GIT\n ---\n\nbase-commit: 94b60adee30619a05296cf5ed6addb0e6d4e25dc\n-- \ngitgitgadget\n"},{"id":"503268","messageId":"xmqqtte62tgz.fsf@gitster.g","threadId":"62168","inReplyTo":"pull.1785.git.git.1727010037470.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc/git-format-patch: link git-apply","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-09-23T17:03:08Z","receivedAt":"2024-09-23T17:03:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Alexander Ziaee via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Alexander Ziaee <ziaee@google.com>\n>\n> git formatted patches can be applied with git-apply(1),\n\nNot necessarily.  They are meant to be consumed via \"am\", which\nknows how to unwrap MIME, split the message into the log part and\nthe diff part, and create a commit out of the result, by calling\n\"mailinfo\", \"apply\" and \"comimt-tree\" as the underlying mechanism.\n\nSimple patches can often be consumed by \"apply\", but that is not\nguaranteed.\n\nTo put it another way, if we link \"apply\" because format-patch\noutput can (sometimes) be consumed with the command in order to use\nits the diff part, we would need to link \"mailinfo\" because the\nformat-patch output can (always) be consumed with the command in\norder to extract the log message part and separate the diff part\nout.  So I am modereately negative on this change, especially we\nalready refer readers to \"am\" (and \"am\" in turn refers to \"apply\").\n\nThanks.\n\n> so link git-apply(1) in git-format-patch(1) § see also.\n>\n> Signed-off-by:\tAlexander Ziaee <ziaee@google.com>\n> ---\n>     doc/git-format-patch: link git-apply\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1785%2Fconcussious%2Fmaster-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1785/concussious/master-v1\n> Pull-Request: https://github.com/git/git/pull/1785\n>\n>  Documentation/git-format-patch.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-format-patch.txt b/Documentation/git-format-patch.txt\n> index 8708b315930..eeebc805d6c 100644\n> --- a/Documentation/git-format-patch.txt\n> +++ b/Documentation/git-format-patch.txt\n> @@ -790,7 +790,7 @@ merge commit.\n>  \n>  SEE ALSO\n>  --------\n> -linkgit:git-am[1], linkgit:git-send-email[1]\n> +linkgit:git-am[1], linkgit:git-apply[1], linkgit:git-send-email[1]\n>  \n>  GIT\n>  ---\n>\n> base-commit: 94b60adee30619a05296cf5ed6addb0e6d4e25dc\n"}]}