{"thread":{"id":"62145","subject":"[PATCH 00/20] Fix typos","startedAt":"2024-09-19T18:34:44Z","lastAt":"2024-09-20T07:00:17Z","messageCount":27,"participants":["Andrew Kreimer via GitGitGadget","Eric Sunshine","Kristoffer Haugsbakk","Junio C Hamano","Andrew Kreimer"],"isPatch":true,"patchVersion":1,"patchTotal":20},"messages":[{"id":"503065","messageId":"pull.1794.git.1726770880.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":null,"subject":"[PATCH 00/20] Fix typos","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:20Z","receivedAt":"2024-09-19T18:34:44Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"Fix typos in documentation, comments, etc.\n\nAndrew Kreimer (20):\n config.mak.dev: fix a typo\n diffcore-rename: fix typos\n fsmonitor-settings: fix a typo\n git-instaweb: fix a typo\n git-p4: fix typos\n gpg-interface: fix a typo\n http: fix a typo\n merge-ll: fix a typo\n merge-ort: fix typos\n object-file: fix a typo\n pretty: fix a typo\n read-cache-ll: fix a typo\n rebase: fix a typo\n ref-filter: fix a typo\n refs: fix typos\n revision: fix a typo\n run-command: fix a typo\n setup: fix a typo\n sideband: fix a typo\n upload-pack: fix a typo\n\n config.mak.dev | 2 +-\n diffcore-rename.c | 4 ++--\n fsmonitor-settings.c | 2 +-\n git-instaweb.sh | 2 +-\n git-p4.py | 4 ++--\n gpg-interface.c | 2 +-\n http.c | 2 +-\n merge-ll.c | 2 +-\n merge-ort.c | 4 ++--\n object-file.c | 2 +-\n pretty.c | 2 +-\n read-cache-ll.h | 2 +-\n rebase.c | 2 +-\n ref-filter.c | 2 +-\n refs.h | 6 +++---\n revision.h | 2 +-\n run-command.h | 2 +-\n setup.c | 2 +-\n sideband.c | 2 +-\n upload-pack.c | 2 +-\n 20 files changed, 25 insertions(+), 25 deletions(-)\n\n\nbase-commit: 3fb745257b30a643ee78c9a7c52ab107c82e4745\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1794%2Falgonell%2Ffix-typos-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1794/algonell/fix-typos-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1794\n-- \ngitgitgadget\n"},{"id":"503066","messageId":"f469df28c89974185377661a01d927390a11b23f.1726770880.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 02/20] diffcore-rename: fix typos","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:22Z","receivedAt":"2024-09-19T18:34:45Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix typos in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n diffcore-rename.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/diffcore-rename.c b/diffcore-rename.c\nindex fab45b10d7e..3d6826baa3a 100644\n--- a/diffcore-rename.c\n+++ b/diffcore-rename.c\n@@ -933,7 +933,7 @@ static int find_basename_matches(struct diff_options *options,\n \t * spend more cycles to find similarities between files, so it may\n \t * be less likely that this heuristic is wanted. If someone is\n \t * doing break detection, that means they do not want filename\n-\t * similarity to imply any form of content similiarity, and thus\n+\t * similarity to imply any form of content similarity, and thus\n \t * this heuristic would definitely be incompatible.\n \t */\n \n@@ -1534,7 +1534,7 @@ void diffcore_rename_extended(struct diff_options *options,\n \t\t * - remove ones not found in relevant_sources\n \t\t * and\n \t\t * - remove ones in relevant_sources which are needed only\n-\t\t * for directory renames IF no ancestory directory\n+\t\t * for directory renames IF no ancestry directory\n \t\t * actually needs to know any more individual path\n \t\t * renames under them\n \t\t */\n-- \ngitgitgadget\n\n"},{"id":"503067","messageId":"588327a291d95a0bae01b41316f271d98809db24.1726770880.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 01/20] config.mak.dev: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:21Z","receivedAt":"2024-09-19T18:34:45Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n config.mak.dev | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/config.mak.dev b/config.mak.dev\nindex 50026d1e0e8..8eca7fa2282 100644\n--- a/config.mak.dev\n+++ b/config.mak.dev\n@@ -69,7 +69,7 @@ DEVELOPER_CFLAGS += -Wno-missing-braces\n endif\n endif\n \n-# Old versions of clang complain about initializaing a\n+# Old versions of clang complain about initializing a\n # struct-within-a-struct using just \"{0}\" rather than \"{{0}}\". This\n # error is considered a false-positive and not worth fixing, because\n # new clang versions do not, so just disable it.\n-- \ngitgitgadget\n\n"},{"id":"503068","messageId":"9056dc6773d77422ab7b7f044275c500dc5327b9.1726770880.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 03/20] fsmonitor-settings: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:23Z","receivedAt":"2024-09-19T18:34:47Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n fsmonitor-settings.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/fsmonitor-settings.c b/fsmonitor-settings.c\nindex e818583420a..a6587a8972b 100644\n--- a/fsmonitor-settings.c\n+++ b/fsmonitor-settings.c\n@@ -7,7 +7,7 @@\n #include \"fsmonitor-path-utils.h\"\n \n /*\n- * We keep this structure defintion private and have getters\n+ * We keep this structure definition private and have getters\n * for all fields so that we can lazy load it as needed.\n */\n struct fsmonitor_settings {\n-- \ngitgitgadget\n\n"},{"id":"503069","messageId":"4f48fced7296c6f924ad4ff1646c5e1c9635742b.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 04/20] git-instaweb: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:24Z","receivedAt":"2024-09-19T18:34:48Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n git-instaweb.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/git-instaweb.sh b/git-instaweb.sh\nindex 994431c8872..8dbe21d5887 100755\n--- a/git-instaweb.sh\n+++ b/git-instaweb.sh\n@@ -612,7 +612,7 @@ python_conf() {\n \tln -sf \"$root/static\" \"$fqgitdir/gitweb/$httpd_only/\"\n \n \t# generate a standalone 'python http.server' script in $fqgitdir/gitweb\n-\t# This asumes that python is in user's $PATH\n+\t# This assumes that python is in user's $PATH\n \t# This script is Python 2 and 3 compatible\n \tcat > \"$fqgitdir/gitweb/gitweb.py\" <\n\nFix typos in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n git-p4.py | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/git-p4.py b/git-p4.py\nindex f1ab31d5403..c0ca7becaf4 100755\n--- a/git-p4.py\n+++ b/git-p4.py\n@@ -54,7 +54,7 @@ import time\n import zipfile\n import zlib\n \n-# On python2.7 where raw_input() and input() are both availble,\n+# On python2.7 where raw_input() and input() are both available,\n # we want raw_input's semantics, but aliased to input for python3\n # compatibility\n # support basestring in python3\n@@ -1804,7 +1804,7 @@ class P4Submit(Command, P4UserMap):\n status from the script will abort the process.\n \n The purpose of the hook is to edit the message file in place, and it is not\n- supressed by the `--no-verify` option. This hook is called even if\n+ suppressed by the `--no-verify` option. This hook is called even if\n `--prepare-p4-only` is set.\n \n The `p4-changelist` hook is executed after the changelist message has been\n-- \ngitgitgadget\n\n"},{"id":"503071","messageId":"3ecec180fc9233d06ee85153bedcecd710666557.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 06/20] gpg-interface: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:26Z","receivedAt":"2024-09-19T18:34:51Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n gpg-interface.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/gpg-interface.c b/gpg-interface.c\nindex 6587085cd19..cf4a72692d9 100644\n--- a/gpg-interface.c\n+++ b/gpg-interface.c\n@@ -400,7 +400,7 @@ static void parse_ssh_output(struct signature_check *sigc)\n \t * Note that \"PRINCIPAL\" can contain whitespace, \"RSA\" and\n \t * \"SHA256\" part could be a different token that names of\n \t * the algorithms used, and \"FINGERPRINT\" is a hexadecimal\n-\t * string. By finding the last occurence of \" with \", we can\n+\t * string. By finding the last occurrence of \" with \", we can\n \t * reliably parse out the PRINCIPAL.\n \t */\n \tsigc->result = 'B';\n-- \ngitgitgadget\n\n"},{"id":"503072","messageId":"b7f6e81c3ddf9a6e8b9a8ba745ff7c3017825304.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 07/20] http: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:27Z","receivedAt":"2024-09-19T18:34:51Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n http.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/http.c b/http.c\nindex 6c6cc5c822a..376af88c5dc 100644\n--- a/http.c\n+++ b/http.c\n@@ -1707,7 +1707,7 @@ void run_active_slot(struct active_request_slot *slot)\n \t * The value of slot->finished we set before the loop was used\n \t * to set our \"finished\" variable when our request completed.\n \t *\n-\t * 1. The slot may not have been reused for another requst\n+\t * 1. The slot may not have been reused for another request\n \t * yet, in which case it still has &finished.\n \t *\n \t * 2. The slot may already be in-use to serve another request,\n-- \ngitgitgadget\n\n"},{"id":"503073","messageId":"7c950c793213681cbaa0e9cf25294291edc2fdce.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 08/20] merge-ll: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:28Z","receivedAt":"2024-09-19T18:34:52Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n merge-ll.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/merge-ll.c b/merge-ll.c\nindex badb6dea57c..8e63071922b 100644\n--- a/merge-ll.c\n+++ b/merge-ll.c\n@@ -334,7 +334,7 @@ static int read_merge_config(const char *var, const char *value,\n \t\t * %X - the revision for our version\n \t\t * %Y - the revision for their version\n \t\t *\n-\t\t * If the file is not named indentically in all versions, then each\n+\t\t * If the file is not named identically in all versions, then each\n \t\t * revision is joined with the corresponding path, separated by a colon.\n \t\t * The external merge driver should write the results in the\n \t\t * file named by %A, and signal that it has done with zero exit\n-- \ngitgitgadget\n\n"},{"id":"503074","messageId":"915f395cb9fbed3c5d3de5d31423e2145f533e6e.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 09/20] merge-ort: fix typos","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:29Z","receivedAt":"2024-09-19T18:34:53Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix typos in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n merge-ort.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/merge-ort.c b/merge-ort.c\nindex 3752c7e595d..3460d14172c 100644\n--- a/merge-ort.c\n+++ b/merge-ort.c\n@@ -1147,7 +1147,7 @@ static void collect_rename_info(struct merge_options *opt,\n \t * Update dir_rename_mask (determines ignore-rename-source validity)\n \t *\n \t * dir_rename_mask helps us keep track of when directory rename\n-\t * detection may be relevant. Basically, whenver a directory is\n+\t * detection may be relevant. Basically, whenever a directory is\n \t * removed on one side of history, and a file is added to that\n \t * directory on the other side of history, directory rename\n \t * detection is relevant (meaning we have to detect renames for all\n@@ -3835,7 +3835,7 @@ static int write_completed_directory(struct merge_options *opt,\n \t * \t src/moduleB 2\n \t *\n \t * which is used to know that xtract.c & token.txt are from the\n-\t * toplevel dirctory, while umm.c & stuff.h & baz.c are from the\n+\t * toplevel directory, while umm.c & stuff.h & baz.c are from the\n \t * src/moduleB directory. Again, following the example above,\n \t * once we need to process src/moduleB, then info->offsets is\n \t * updated to\n-- \ngitgitgadget\n\n"},{"id":"503075","messageId":"877bbf5c3904c2453b4dfe0eed6695fa3fafe063.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 10/20] object-file: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:30Z","receivedAt":"2024-09-19T18:34:55Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n object-file.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/object-file.c b/object-file.c\nindex c5994202ba0..21266429817 100644\n--- a/object-file.c\n+++ b/object-file.c\n@@ -2275,7 +2275,7 @@ int stream_loose_object(struct input_stream *in_stream, size_t len,\n \n \t/*\n \t * Common steps for write_loose_object and stream_loose_object to\n-\t * end writing loose oject:\n+\t * end writing loose object:\n \t *\n \t * - End the compression of zlib stream.\n \t * - Get the calculated oid.\n-- \ngitgitgadget\n\n"},{"id":"503076","messageId":"0fb72f40748f9c236a9d3bfbf7f4e807aa3bf59a.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 11/20] pretty: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:31Z","receivedAt":"2024-09-19T18:34:56Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n pretty.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/pretty.c b/pretty.c\nindex 5e5ae452530..6403e268900 100644\n--- a/pretty.c\n+++ b/pretty.c\n@@ -2205,7 +2205,7 @@ static void strbuf_add_tabexpand(struct strbuf *sb, struct grep_opt *opt,\n }\n \n /*\n- * pp_handle_indent() prints out the intendation, and\n+ * pp_handle_indent() prints out the indentation, and\n * the whole line (without the final newline), after\n * de-tabifying.\n */\n-- \ngitgitgadget\n\n"},{"id":"503077","messageId":"2fb8ed2f4a963c8aea366948fb315d1cff4d4d0b.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 12/20] read-cache-ll: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:32Z","receivedAt":"2024-09-19T18:34:56Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n read-cache-ll.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/read-cache-ll.h b/read-cache-ll.h\nindex e0e39607ef3..b5d11d07a86 100644\n--- a/read-cache-ll.h\n+++ b/read-cache-ll.h\n@@ -151,7 +151,7 @@ enum sparse_index_mode {\n \n \t/*\n \t * The index has already been collapsed to sparse directories\n-\t * whereever possible.\n+\t * wherever possible.\n \t */\n \tINDEX_COLLAPSED,\n \n-- \ngitgitgadget\n\n"},{"id":"503078","messageId":"7c8fc79fa8c8daf288cecb068d220ccfa07d7d7f.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 13/20] rebase: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:33Z","receivedAt":"2024-09-19T18:34:58Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n rebase.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/rebase.c b/rebase.c\nindex 69a1822da34..9d1ae95978e 100644\n--- a/rebase.c\n+++ b/rebase.c\n@@ -11,7 +11,7 @@\n * The callers that care if (any) rebase is requested should say\n * if (REBASE_TRUE <= rebase_parse_value(string))\n *\n- * The callers that want to differenciate an unrecognised value and\n+ * The callers that want to differentiate an unrecognised value and\n * false can do so by treating _INVALID and _FALSE differently.\n */\n enum rebase_type rebase_parse_value(const char *value)\n-- \ngitgitgadget\n\n"},{"id":"503079","messageId":"9697dc1c81db33dca7e4a3c093ee83cdc0efea1e.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 14/20] ref-filter: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:34Z","receivedAt":"2024-09-19T18:34:58Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n ref-filter.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/ref-filter.c b/ref-filter.c\nindex b06e18a569a..308097e740b 100644\n--- a/ref-filter.c\n+++ b/ref-filter.c\n@@ -2384,7 +2384,7 @@ static int populate_value(struct ref_array_item *ref, struct strbuf *err)\n \tCALLOC_ARRAY(ref->value, used_atom_cnt);\n \n \t/**\n-\t * NEEDSWORK: The following code might be unncessary if all codepaths\n+\t * NEEDSWORK: The following code might be unnecessary if all codepaths\n \t * that call populate_value() populates the symref member of ref_array_item\n \t * like in apply_ref_filter(). Currently pretty_print_ref() is the only codepath\n \t * that calls populate_value() without first populating symref.\n-- \ngitgitgadget\n\n"},{"id":"503080","messageId":"1e21964bb14a0b6a4c00b5a1848db655423041d3.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 15/20] refs: fix typos","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:35Z","receivedAt":"2024-09-19T18:35:00Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix typos in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n refs.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\ndiff --git a/refs.h b/refs.h\nindex f8b919a1388..6d06098f8f4 100644\n--- a/refs.h\n+++ b/refs.h\n@@ -16,7 +16,7 @@ enum ref_storage_format ref_storage_format_by_name(const char *name);\n const char *ref_storage_format_to_name(enum ref_storage_format ref_storage_format);\n \n /*\n- * Resolve a reference, recursively following symbolic refererences.\n+ * Resolve a reference, recursively following symbolic references.\n *\n * Return the name of the non-symbolic reference that ultimately pointed\n * at the resolved object name. The return value, if not NULL, is a\n@@ -488,7 +488,7 @@ int refs_delete_reflog(struct ref_store *refs, const char *refname);\n * from UTC. Its absolute value is formed by multiplying the hour\n * part by 100 and adding the minute part. For example, 1 hour ahead\n * of UTC, CET == \"+0100\", is represented as positive one hundred (not\n- * postiive sixty).\n+ * positive sixty).\n *\n * The msg parameter is a single complete line; a reflog message given\n * to refs_delete_ref, refs_update_ref, etc. is returned to the\n@@ -986,7 +986,7 @@ struct ref_store *get_worktree_ref_store(const struct worktree *wt);\n \n /*\n * Some of the names specified by refs have special meaning to Git.\n- * Organize these namespaces in a comon 'ref_namespace' array for\n+ * Organize these namespaces in a common 'ref_namespace' array for\n * reference from multiple places in the codebase.\n */\n \n-- \ngitgitgadget\n\n"},{"id":"503081","messageId":"1f12c379b8ff1253273f6d0b33a6640ec7125e0d.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 16/20] revision: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:36Z","receivedAt":"2024-09-19T18:35:00Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n revision.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/revision.h b/revision.h\nindex 0e470d1df19..71e984c452b 100644\n--- a/revision.h\n+++ b/revision.h\n@@ -549,7 +549,7 @@ int rewrite_parents(struct rev_info *revs,\n * The log machinery saves the original parent list so that\n * get_saved_parents() can later tell what the real parents of the\n * commits are, when commit->parents has been modified by history\n- * simpification.\n+ * simplification.\n *\n * get_saved_parents() will transparently return commit->parents if\n * history simplification is off.\n-- \ngitgitgadget\n\n"},{"id":"503082","messageId":"d341face8530c4db1fbebf83b3eed053d089fca9.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 17/20] run-command: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:37Z","receivedAt":"2024-09-19T18:35:01Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n run-command.h | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/run-command.h b/run-command.h\nindex 03e7222d8b5..0df25e445f0 100644\n--- a/run-command.h\n+++ b/run-command.h\n@@ -535,7 +535,7 @@ enum start_bg_result {\n \t/* timeout expired waiting for child to become \"ready\" */\n \tSBGR_TIMEOUT,\n \n-\t/* child process exited or was signalled before becomming \"ready\" */\n+\t/* child process exited or was signalled before becoming \"ready\" */\n \tSBGR_DIED,\n };\n \n-- \ngitgitgadget\n\n"},{"id":"503083","messageId":"d219753e4f8338ad2f960f7d3b2c6481645da871.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 18/20] setup: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:38Z","receivedAt":"2024-09-19T18:35:02Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n setup.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/setup.c b/setup.c\nindex 29f86739212..b7084f03126 100644\n--- a/setup.c\n+++ b/setup.c\n@@ -518,7 +518,7 @@ static void setup_original_cwd(void)\n \t * directory we inherited from our parent process, which is a\n \t * directory we want to avoid removing.\n \t *\n-\t * For convience, we would like to have the path relative to the\n+\t * For convenience, we would like to have the path relative to the\n \t * worktree instead of an absolute path.\n \t *\n \t * Yes, startup_info->original_cwd is usually the same as 'prefix',\n-- \ngitgitgadget\n\n"},{"id":"503084","messageId":"0c21d4aa35b5dfc294cefc8ca2613dccca5c2e36.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 19/20] sideband: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:39Z","receivedAt":"2024-09-19T18:35:03Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n sideband.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/sideband.c b/sideband.c\nindex 4e816be4e92..02805573fab 100644\n--- a/sideband.c\n+++ b/sideband.c\n@@ -191,7 +191,7 @@ int demultiplex_sideband(const char *me, int status,\n \t\t\tint linelen = brk - b;\n \n \t\t\t/*\n-\t\t\t * For message accross packet boundary, there would have\n+\t\t\t * For message across packet boundary, there would have\n \t\t\t * a nonempty \"scratch\" buffer from last call of this\n \t\t\t * function, and there may have a leading CR/LF in \"buf\".\n \t\t\t * For this case we should add a clear-to-eol suffix to\n-- \ngitgitgadget\n\n"},{"id":"503085","messageId":"8095b76e268c4017de3f34ba3d3700281aff8866.1726770881.git.gitgitgadget@gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"[PATCH 20/20] upload-pack: fix a typo","fromName":"Andrew Kreimer via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-19T18:34:40Z","receivedAt":"2024-09-19T18:35:04Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"From: Andrew Kreimer \n\nFix a typo in comments.\n\nSigned-off-by: Andrew Kreimer \n---\n upload-pack.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/upload-pack.c b/upload-pack.c\nindex f03ba3e98be..143bdffa4a8 100644\n--- a/upload-pack.c\n+++ b/upload-pack.c\n@@ -1802,7 +1802,7 @@ int upload_pack_v2(struct repository *r, struct packet_reader *request)\n \t\t\t} else {\n \t\t\t\t/*\n \t\t\t\t * Request had 'want's but no 'have's so we can\n-\t\t\t\t * immedietly go to construct and send a pack.\n+\t\t\t\t * immediately go to construct and send a pack.\n \t\t\t\t */\n \t\t\t\tstate = FETCH_SEND_PACK;\n \t\t\t}\n-- \ngitgitgadget\n"},{"id":"503090","messageId":"CAPig+cRhgf4pLycL7u9Zc13TXdN54ccv6xMQ9p6v8pvfRESTLA@mail.gmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"Re: [PATCH 00/20] Fix typos","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2024-09-19T19:35:25Z","receivedAt":"2024-09-19T19:35:37Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Sep 19, 2024 at 2:35 PM Andrew Kreimer via GitGitGadget\n wrote:\n> Fix typos in documentation, comments, etc.\n>\n> Andrew Kreimer (20):\n\nThanks. These all look fine.\n\nOut of curiosity, did you use a tool to discover these mistakes?\n"},{"id":"503093","messageId":"ab9213d5-fb1b-482e-854b-4f5d4e82821a@app.fastmail.com","threadId":"62145","inReplyTo":"pull.1794.git.1726770880.gitgitgadget@gmail.com","subject":"Re: [PATCH 00/20] Fix typos","fromName":"Kristoffer Haugsbakk","fromEmail":"kristofferhaugsbakk@fastmail.com","sentAt":"2024-09-19T20:33:18Z","receivedAt":"2024-09-19T20:33:40Z","isPatch":true,"sender":{"key":"kristofferhaugsbakk@fastmail.com","avatar":null},"body":"All of these look correct.\n\nMaybe all of the commits could be combined into one commit with the\nmessage “treewide: fix typos”. But that wasn’t asked for last time.[1]\nSo I dunno.\n\n🔗 1: https://lore.kernel.org/git/xmqq34lzqyi8.fsf@gitster.g/\n\n-- \nKristoffer Haugsbakk\n"},{"id":"503094","messageId":"xmqq34lv74us.fsf@gitster.g","threadId":"62145","inReplyTo":"ab9213d5-fb1b-482e-854b-4f5d4e82821a@app.fastmail.com","subject":"Re: [PATCH 00/20] Fix typos","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-09-19T20:42:19Z","receivedAt":"2024-09-19T20:42:22Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Kristoffer Haugsbakk\" writes:\n\n> All of these look correct.\n>\n> Maybe all of the commits could be combined into one commit with the\n> message “treewide: fix typos”. But that wasn’t asked for last time.[1]\n> So I dunno.\n\nIt depends. When done carefully to make sure that nothing textually\nconflicts with any topics in flight, a single \"treewide\" patch is\nslightly nicer. If nothing conflicts with nothing else, either\nformat is fine. If something have nasty conflicts (e.g., a refactor\nmoved the comment with typos far from the original location or even\nto a different file), individual patch form is easier to discard the\nones that need to wait.\n\nI do not know which case this 20-patch collection falls into.\n\nThanks.\n"},{"id":"503095","messageId":"CAPig+cTnB-aHLX8BhYk8sYgRF6S5XgsVmmJAji1oRRac+MLbtQ@mail.gmail.com","threadId":"62145","inReplyTo":"xmqq34lv74us.fsf@gitster.g","subject":"Re: [PATCH 00/20] Fix typos","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2024-09-19T20:54:48Z","receivedAt":"2024-09-19T20:55:00Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Thu, Sep 19, 2024 at 4:42 PM Junio C Hamano wrote:\n> \"Kristoffer Haugsbakk\" writes:\n> > Maybe all of the commits could be combined into one commit with the\n> > message “treewide: fix typos”. But that wasn’t asked for last time.[1]\n> > So I dunno.\n>\n> It depends. When done carefully to make sure that nothing textually\n> conflicts with any topics in flight, a single \"treewide\" patch is\n> slightly nicer. If nothing conflicts with nothing else, either\n> format is fine. If something have nasty conflicts (e.g., a refactor\n> moved the comment with typos far from the original location or even\n> to a different file), individual patch form is easier to discard the\n> ones that need to wait.\n>\n> I do not know which case this 20-patch collection falls into.\n\nFor what it's worth, I found the submission easier to review as\nseparate patches because it allowed me to review a small batch, do\nsomething else for a bit, review another batch, do something else,\netc., without losing my place since I deleted the ones I had already\nreviewed, so I knew that those remaining in my Inbox were still\npending review.\n"},{"id":"503096","messageId":"xmqqy13n5pkh.fsf@gitster.g","threadId":"62145","inReplyTo":"CAPig+cTnB-aHLX8BhYk8sYgRF6S5XgsVmmJAji1oRRac+MLbtQ@mail.gmail.com","subject":"Re: [PATCH 00/20] Fix typos","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-09-19T20:57:50Z","receivedAt":"2024-09-19T20:57:53Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Eric Sunshine writes:\n\n> For what it's worth, I found the submission easier to review as\n> separate patches because it allowed me to review a small batch, do\n> something else for a bit, review another batch, do something else,\n> etc., without losing my place since I deleted the ones I had already\n> reviewed, so I knew that those remaining in my Inbox were still\n> pending review.\n\nIt is a very good point.\n\nFWIW, all except for one apply cleanly to both v2.46.0 and 'seen',\nand one fixes a typo introduced between v2.46.0 and 'master'.\n\nWill queue.\nThanks.\n\n"},{"id":"503114","messageId":"Zu0dfP4UT7v_Uvmu@void.void","threadId":"62145","inReplyTo":"CAPig+cRhgf4pLycL7u9Zc13TXdN54ccv6xMQ9p6v8pvfRESTLA@mail.gmail.com","subject":"Re: [PATCH 00/20] Fix typos","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-09-20T07:00:12Z","receivedAt":"2024-09-20T07:00:17Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"On Thu, Sep 19, 2024 at 03:35:25PM -0400, Eric Sunshine wrote:\n> On Thu, Sep 19, 2024 at 2:35 PM Andrew Kreimer via GitGitGadget\n> wrote:\n> > Fix typos in documentation, comments, etc.\n> >\n> > Andrew Kreimer (20):\n> \n> Thanks. These all look fine.\n> \n> Out of curiosity, did you use a tool to discover these mistakes?\n\nThank you all!\n\nSure, my secret sauce is codespell:\nhttps://github.com/codespell-project/codespell\n"}]}