{"thread":{"id":"62138","subject":"[PATCH] cmake: stop looking for `REFTABLE_TEST_OBJS` in the Makefile","startedAt":"2024-09-18T19:23:23Z","lastAt":"2024-09-18T19:23:23Z","messageCount":1,"participants":["Johannes Schindelin via GitGitGadget"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"503014","messageId":"pull.1796.git.1726687400286.gitgitgadget@gmail.com","threadId":"62138","inReplyTo":null,"subject":"[PATCH] cmake: stop looking for `REFTABLE_TEST_OBJS` in the Makefile","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-09-18T19:23:20Z","receivedAt":"2024-09-18T19:23:23Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nAs of 15e29ea1c648 (t: move reftable/stack_test.c to the unit testing\nframework, 2024-09-08), the reftable tests are no longer part of\n`test-tool.exe`, so let's stop looking for those lines that are no\nlonger in the `Makefile`.\n\nSigned-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n---\n    cmake: stop looking for REFTABLE_TEST_OBJS in the Makefile\n    \n    This is an add-on for cp/unit-test-reftable-stack to let it build with\n    CMake and Visual C.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1796%2Fdscho%2Funit-test-reftable-stack%2Bcmake-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1796/dscho/unit-test-reftable-stack+cmake-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1796\n\n contrib/buildsystems/CMakeLists.txt | 6 +-----\n 1 file changed, 1 insertion(+), 5 deletions(-)\n\ndiff --git a/contrib/buildsystems/CMakeLists.txt b/contrib/buildsystems/CMakeLists.txt\nindex 832f46b316b..af7447de6f1 100644\n--- a/contrib/buildsystems/CMakeLists.txt\n+++ b/contrib/buildsystems/CMakeLists.txt\n@@ -970,10 +970,6 @@ if(BUILD_TESTING)\n add_executable(test-fake-ssh ${CMAKE_SOURCE_DIR}/t/helper/test-fake-ssh.c)\n target_link_libraries(test-fake-ssh common-main)\n \n-#reftable-tests\n-parse_makefile_for_sources(test-reftable_SOURCES \"REFTABLE_TEST_OBJS\")\n-list(TRANSFORM test-reftable_SOURCES PREPEND \"${CMAKE_SOURCE_DIR}/\")\n-\n #unit-tests\n add_library(unit-test-lib OBJECT ${CMAKE_SOURCE_DIR}/t/unit-tests/test-lib.c)\n add_library(unit-test-lib-oid OBJECT ${CMAKE_SOURCE_DIR}/t/unit-tests/lib-oid.c)\n@@ -1009,7 +1005,7 @@ parse_makefile_for_sources(test-tool_SOURCES \"TEST_BUILTINS_OBJS\")\n add_library(test-lib OBJECT ${CMAKE_SOURCE_DIR}/t/unit-tests/test-lib.c)\n \n list(TRANSFORM test-tool_SOURCES PREPEND \"${CMAKE_SOURCE_DIR}/t/helper/\")\n-add_executable(test-tool ${CMAKE_SOURCE_DIR}/t/helper/test-tool.c ${test-tool_SOURCES} ${test-reftable_SOURCES})\n+add_executable(test-tool ${CMAKE_SOURCE_DIR}/t/helper/test-tool.c ${test-tool_SOURCES})\n target_link_libraries(test-tool test-lib common-main)\n \n set_target_properties(test-fake-ssh test-tool\n\nbase-commit: 2b14ced370aea017efc32b525fd72a6dd2cc60c5\n-- \ngitgitgadget\n"}]}