{"thread":{"id":"62118","subject":"[PATCH] cbtree: fix a typo","startedAt":"2024-09-15T23:05:32Z","lastAt":"2024-09-16T17:50:19Z","messageCount":4,"participants":["Andrew Kreimer","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"502818","messageId":"20240915230522.129253-1-algonell@gmail.com","threadId":"62118","inReplyTo":null,"subject":"[PATCH] cbtree: fix a typo","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-09-15T23:05:22Z","receivedAt":"2024-09-15T23:05:32Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"Fix a typo in comments.\n\nSigned-off-by: Andrew Kreimer <algonell@gmail.com>\n---\n cbtree.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/cbtree.c b/cbtree.c\nindex c1cc30a5dc..cf8cf75b89 100644\n--- a/cbtree.c\n+++ b/cbtree.c\n@@ -12,7 +12,7 @@ static struct cb_node *cb_node_of(const void *p)\n \treturn (struct cb_node *)((uintptr_t)p - 1);\n }\n \n-/* locate the best match, does not do a final comparision */\n+/* locate the best match, does not do a final comparison */\n static struct cb_node *cb_internal_best_match(struct cb_node *p,\n \t\t\t\t\tconst uint8_t *k, size_t klen)\n {\n-- \n2.39.5\n\n"},{"id":"502832","messageId":"Zufef70mfdUwSwnY@pks.im","threadId":"62118","inReplyTo":"20240915230522.129253-1-algonell@gmail.com","subject":"Re: [PATCH] cbtree: fix a typo","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-09-16T07:30:07Z","receivedAt":"2024-09-16T07:30:13Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Sep 16, 2024 at 02:05:22AM +0300, Andrew Kreimer wrote:\n> Fix a typo in comments.\n> \n> Signed-off-by: Andrew Kreimer <algonell@gmail.com>\n\nThanks for these fixes, all three of them look good to me. For future\nsuch patch series I'd recommend to send a single series that combines\nsuch related fixes. It makes it a bit easier to keep track of these\nsimilar patches and review them in one go.\n\n> ---\n>  cbtree.c | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/cbtree.c b/cbtree.c\n> index c1cc30a5dc..cf8cf75b89 100644\n> --- a/cbtree.c\n> +++ b/cbtree.c\n> @@ -12,7 +12,7 @@ static struct cb_node *cb_node_of(const void *p)\n>  \treturn (struct cb_node *)((uintptr_t)p - 1);\n>  }\n>  \n> -/* locate the best match, does not do a final comparision */\n> +/* locate the best match, does not do a final comparison */\n>  static struct cb_node *cb_internal_best_match(struct cb_node *p,\n>  \t\t\t\t\tconst uint8_t *k, size_t klen)\n>  {\n\nWe might convert this to be a proper sentence while at it, namely\ns/locate/Locate/ and s/comparison/&./. But no need to reroll this patch\nfor that, as your change is a strict improvement by itself already.\n\nThanks!\n\nPatrick\n"},{"id":"502843","messageId":"Zuf_3mNRm3KuQxlV@void.void","threadId":"62118","inReplyTo":"Zufef70mfdUwSwnY@pks.im","subject":"Re: [PATCH] cbtree: fix a typo","fromName":"Andrew Kreimer","fromEmail":"algonell@gmail.com","sentAt":"2024-09-16T09:52:30Z","receivedAt":"2024-09-16T09:52:35Z","isPatch":true,"sender":{"key":"algonell@gmail.com","avatar":"https://avatars.githubusercontent.com/u/4669001?v=4"},"body":"On Mon, Sep 16, 2024 at 09:30:07AM +0200, Patrick Steinhardt wrote:\n> On Mon, Sep 16, 2024 at 02:05:22AM +0300, Andrew Kreimer wrote:\n> > Fix a typo in comments.\n> > \n> > Signed-off-by: Andrew Kreimer <algonell@gmail.com>\n> \n> Thanks for these fixes, all three of them look good to me. For future\n> such patch series I'd recommend to send a single series that combines\n> such related fixes. It makes it a bit easier to keep track of these\n> similar patches and review them in one go.\n> \n\nUnderstood.\n\n> > ---\n> >  cbtree.c | 2 +-\n> >  1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/cbtree.c b/cbtree.c\n> > index c1cc30a5dc..cf8cf75b89 100644\n> > --- a/cbtree.c\n> > +++ b/cbtree.c\n> > @@ -12,7 +12,7 @@ static struct cb_node *cb_node_of(const void *p)\n> >  \treturn (struct cb_node *)((uintptr_t)p - 1);\n> >  }\n> >  \n> > -/* locate the best match, does not do a final comparision */\n> > +/* locate the best match, does not do a final comparison */\n> >  static struct cb_node *cb_internal_best_match(struct cb_node *p,\n> >  \t\t\t\t\tconst uint8_t *k, size_t klen)\n> >  {\n> \n> We might convert this to be a proper sentence while at it, namely\n> s/locate/Locate/ and s/comparison/&./. But no need to reroll this patch\n> for that, as your change is a strict improvement by itself already.\n> \n> Thanks!\n> \n> Patrick\n\nThank you!\n"},{"id":"502898","messageId":"xmqq34lzqyi8.fsf@gitster.g","threadId":"62118","inReplyTo":"Zuf_3mNRm3KuQxlV@void.void","subject":"Re: [PATCH] cbtree: fix a typo","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-09-16T17:50:07Z","receivedAt":"2024-09-16T17:50:19Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Andrew Kreimer <algonell@gmail.com> writes:\n\n>> Thanks!\n>> \n>> Patrick\n>\n> Thank you!\n\nWill queue.  Thanks.\n"}]}