{"thread":{"id":"62097","subject":"[PATCH 0/2] add missing LIBCURL prereq to a few tests","startedAt":"2024-09-11T10:31:22Z","lastAt":"2024-09-11T15:53:12Z","messageCount":4,"participants":["Martin Ågren","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"502612","messageId":"cover.1726049108.git.martin.agren@gmail.com","threadId":"62097","inReplyTo":null,"subject":"[PATCH 0/2] add missing LIBCURL prereq to a few tests","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2024-09-11T10:30:58Z","receivedAt":"2024-09-11T10:31:22Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"Hi,\n\nI recently had reason to build Git without libcurl. That surfaced two\ntest scripts that use `git http-fetch` or similar without giving the\nLIBCURL prerequisite.\n\nMartin\n\nMartin Ågren (2):\n  t1517: add missing LIBCURL prereq\n  t0211: add missing LIBCURL prereq\n\n t/t0211-trace2-perf.sh  | 6 ++++--\n t/t1517-outside-repo.sh | 2 +-\n 2 files changed, 5 insertions(+), 3 deletions(-)\n\n-- \n2.46.0.733.g1eb83ef1a1\n\n"},{"id":"502613","messageId":"55d45be1d6775a630b9f61487b6b60efab9c7769.1726049108.git.martin.agren@gmail.com","threadId":"62097","inReplyTo":"cover.1726049108.git.martin.agren@gmail.com","subject":"[PATCH 1/2] t1517: add missing LIBCURL prereq","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2024-09-11T10:30:59Z","receivedAt":"2024-09-11T10:31:25Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"After building Git with NO_LIBCURL, there is no `git remote-http`, so\nit's not meaningful to test that it can run outside of a repository.\nIndeed, that test will fail. Add the LIBCURL prereq to it.\n\nSigned-off-by: Martin Ågren <martin.agren@gmail.com>\n---\n This is from b25ec8b8d5 (t1517: more coverage for commands that work\n without repository, 2024-05-31), which first appeared in 2.46.0.\n\n t/t1517-outside-repo.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t1517-outside-repo.sh b/t/t1517-outside-repo.sh\nindex 990a036582..342defbb61 100755\n--- a/t/t1517-outside-repo.sh\n+++ b/t/t1517-outside-repo.sh\n@@ -98,7 +98,7 @@ test_expect_success 'stripspace outside repository' '\n \tnongit git stripspace -s </dev/null\n '\n \n-test_expect_success 'remote-http outside repository' '\n+test_expect_success LIBCURL 'remote-http outside repository' '\n \ttest_must_fail git remote-http 2>actual &&\n \ttest_grep \"^error: remote-curl\" actual &&\n \t(\n-- \n2.46.0.733.g1eb83ef1a1\n\n"},{"id":"502614","messageId":"4f749b283be03e11af30e6ad14909c22834dc3e5.1726049108.git.martin.agren@gmail.com","threadId":"62097","inReplyTo":"cover.1726049108.git.martin.agren@gmail.com","subject":"[PATCH 2/2] t0211: add missing LIBCURL prereq","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2024-09-11T10:31:00Z","receivedAt":"2024-09-11T10:31:27Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"After building Git with NO_LIBCURL, we're lacking `git remote-http` and\n`git http-fetch`, so when we test that they trace as they should, we're\nbound to fail. Add the LIBCURL prereq to those tests.\n\nSigned-off-by: Martin Ågren <martin.agren@gmail.com>\n---\n This is from around 6111252cbf (trace2: emit 'def_param' set with\n 'cmd_name' event, 2024-03-07), which first appeared in 2.45.0.\n\n t/t0211-trace2-perf.sh | 6 ++++--\n 1 file changed, 4 insertions(+), 2 deletions(-)\n\ndiff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\nindex 070fe7a5da..dddc130560 100755\n--- a/t/t0211-trace2-perf.sh\n+++ b/t/t0211-trace2-perf.sh\n@@ -337,7 +337,8 @@ test_expect_success 'expect def_params for query command' '\n # remote-curl.c rather than git.c.  Confirm that we get def_param\n # events from both layers.\n #\n-test_expect_success 'expect def_params for remote-curl and _run_dashed_' '\n+test_expect_success LIBCURL \\\n+\t\t'expect def_params for remote-curl and _run_dashed_' '\n \ttest_when_finished \"rm prop.perf actual\" &&\n \n \ttest_config_global \"trace2.configParams\" \"cfg.prop.*\" &&\n@@ -366,7 +367,8 @@ test_expect_success 'expect def_params for remote-curl and _run_dashed_' '\n # an executable built from http-fetch.c.  Confirm that we get\n # def_param events from both layers.\n #\n-test_expect_success 'expect def_params for http-fetch and _run_dashed_' '\n+test_expect_success LIBCURL \\\n+\t\t'expect def_params for http-fetch and _run_dashed_' '\n \ttest_when_finished \"rm prop.perf actual\" &&\n \n \ttest_config_global \"trace2.configParams\" \"cfg.prop.*\" &&\n-- \n2.46.0.733.g1eb83ef1a1\n\n"},{"id":"502630","messageId":"xmqqwmji9ogp.fsf@gitster.g","threadId":"62097","inReplyTo":"cover.1726049108.git.martin.agren@gmail.com","subject":"Re: [PATCH 0/2] add missing LIBCURL prereq to a few tests","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-09-11T15:53:10Z","receivedAt":"2024-09-11T15:53:12Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Ågren <martin.agren@gmail.com> writes:\n\n> Hi,\n>\n> I recently had reason to build Git without libcurl. That surfaced two\n> test scripts that use `git http-fetch` or similar without giving the\n> LIBCURL prerequisite.\n>\n> Martin\n>\n> Martin Ågren (2):\n>   t1517: add missing LIBCURL prereq\n>   t0211: add missing LIBCURL prereq\n>\n>  t/t0211-trace2-perf.sh  | 6 ++++--\n>  t/t1517-outside-repo.sh | 2 +-\n>  2 files changed, 5 insertions(+), 3 deletions(-)\n\nThanks.\n"}]}