{"thread":{"id":"6209","subject":"GITWEB branch shortlog broken after recent update on kernel.org","startedAt":"2007-01-03T19:21:22Z","lastAt":"2007-01-05T21:25:58Z","messageCount":6,"participants":["Michael Krufky","Robert Fitzsimons","Jakub Narebski","J.H."],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"30766","messageId":"459C0232.3090804@linuxtv.org","threadId":"6209","inReplyTo":null,"subject":"GITWEB branch shortlog broken after recent update on kernel.org","fromName":"Michael Krufky","fromEmail":"mkrufky@linuxtv.org","sentAt":"2007-01-03T19:21:22Z","receivedAt":"2007-01-03T19:21:22Z","isPatch":false,"sender":{"key":"mkrufky@linuxtv.org","avatar":null},"body":"Ever since gitweb on kernel.org was recently updated, I've been experiencing a\nnasty bug -- It seems that it is no longer possible to view a shortlog from any\nbranch or head other than master.\n\nFor example:\n\nhttp://www2.kernel.org/git/?p=linux/kernel/git/mkrufky/v4l-dvb-2.6.x.y.git\n\n^^ this is a link to my v4l-dvb-2.6.x.y stable repository.  I have branched off\neach kernel release to include all of the -stable release history.  You will\nnotice these in the 'heads' section near the bottom of the page.\n\nIf you click on the 2.6.16.y shortlog link:\n\nhttp://www2.kernel.org/git/?p=linux/kernel/git/mkrufky/v4l-dvb-2.6.x.y.git;a=shortlog;h=2.6.16.y\n\ngitweb displays the shortlog from the master branch, instead of the 2.6.16.y head.\n\nHowever, if you click the \"log\" link:\n\nhttp://www2.kernel.org/git/?p=linux/kernel/git/mkrufky/v4l-dvb-2.6.x.y.git;a=log;h=2.6.16.y\n\nOnly then, does gitweb show us the correct history for that branch.\n\n\"tree\" is also working properly -- it seems that \"shortlog\" is the only feature\naffected by this bug.\n\nIn the previous vesion of gitweb installed on kernel.org, this feature did\nindeed function properly.\n\nCan this be fixed?  I often use gitweb to view changesets in developer trees\nbefore those changesets get pulled into the master branch of a repository.  I\nfind this feature very helpful for reviewing changesets, and I'd like for it to\nwork again.\n\nThanks in advance,\n\nMichael Krufky\n"},{"id":"30770","messageId":"20070103202555.GA25768@localhost","threadId":"6209","inReplyTo":"459C0232.3090804@linuxtv.org","subject":"[PATCH] gitweb: Fix shortlog only showing HEAD revision.","fromName":"Robert Fitzsimons","fromEmail":"robfitz@273k.net","sentAt":"2007-01-03T20:25:55Z","receivedAt":"2007-01-03T20:25:55Z","isPatch":true,"sender":{"key":"robfitz@273k.net","avatar":null},"body":"My change in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6 had a small bug\nfound by Michael Krufky which caused the passed in hash value to be\nignored, so shortlog would only show the HEAD revision.\n\nSigned-off-by: Robert Fitzsimons <robfitz@273k.net>\n---\n\nThanks for finding this Michael.  It' just a small bug introducted by a\nrecent change I made.  Including John 'Warthog9' so hopefully he can add\nthis to the version of gitweb which is hosted on kernel.org.\n\nRobert\n\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex d845e91..2e94c2c 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -4423,7 +4423,7 @@ sub git_shortlog {\n \t}\n \tmy $refs = git_get_references();\n \n-\tmy @commitlist = parse_commits($head, 101, (100 * $page));\n+\tmy @commitlist = parse_commits($hash, 101, (100 * $page));\n \n \tmy $paging_nav = format_paging_nav('shortlog', $hash, $head, $page, (100 * ($page+1)));\n \tmy $next_link = '';\n-- \nt1.gaaaa\n"},{"id":"30771","messageId":"11678562042320-git-send-email-jnareb@gmail.com","threadId":"6209","inReplyTo":"459C0232.3090804@linuxtv.org","subject":"[PATCH] gitweb: Make shortlog use 'h' (head) parameter again","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-01-03T20:30:04Z","receivedAt":"2007-01-03T20:30:04Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"This fixes typo in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\nMichael Krufky wrote:\n\n> Ever since gitweb on kernel.org was recently updated, I've been experiencing a\n> nasty bug -- It seems that it is no longer possible to view a shortlog from any\n> branch or head other than master.\n[...]\n> \"log\" and \"tree\" is working properly -- it seems that \"shortlog\" is the only\n> feature affected by this bug.\n\nThis corrects this bug.  When introducing parse_commits to shortlog,\nthere was typo in parse_commits arguments: it was $head instead of $hash.\n\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 2ead917..2179054 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -4423,7 +4423,7 @@ sub git_shortlog {\n \t}\n \tmy $refs = git_get_references();\n \n-\tmy @commitlist = parse_commits($head, 101, (100 * $page));\n+\tmy @commitlist = parse_commits($hash, 101, (100 * $page));\n \n \tmy $paging_nav = format_paging_nav('shortlog', $hash, $head, $page, (100 * ($page+1)));\n \tmy $next_link = '';\n-- \n1.4.4.3\n"},{"id":"30772","messageId":"enh3v7$ji7$1@sea.gmane.org","threadId":"6209","inReplyTo":"20070103202555.GA25768@localhost","subject":"Re: [PATCH] gitweb: Fix shortlog only showing HEAD revision.","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-01-03T20:36:55Z","receivedAt":"2007-01-03T20:36:55Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Robert Fitzsimons wrote:\n\n> My change in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6 had a small bug\n> found by Michael Krufky which caused the passed in hash value to be\n> ignored, so shortlog would only show the HEAD revision.\n> \n> Signed-off-by: Robert Fitzsimons <robfitz@273k.net>\n\nIdentical change, better commit message (I think).\n-- \nJakub Narebski\nWarsaw, Poland\nShadeHawk on #git\n"},{"id":"30905","messageId":"459EC16F.1070809@linuxtv.org","threadId":"6209","inReplyTo":"20070103202555.GA25768@localhost","subject":"Re: [PATCH] gitweb: Fix shortlog only showing HEAD revision.","fromName":"Michael Krufky","fromEmail":"mkrufky@linuxtv.org","sentAt":"2007-01-05T21:21:51Z","receivedAt":"2007-01-05T21:21:51Z","isPatch":true,"sender":{"key":"mkrufky@linuxtv.org","avatar":null},"body":"Robert Fitzsimons wrote:\n> My change in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6 had a small bug\n> found by Michael Krufky which caused the passed in hash value to be\n> ignored, so shortlog would only show the HEAD revision.\n> \n> Signed-off-by: Robert Fitzsimons <robfitz@273k.net>\n> ---\n> \n> Thanks for finding this Michael.  It' just a small bug introducted by a\n> recent change I made.  Including John 'Warthog9' so hopefully he can add\n> this to the version of gitweb which is hosted on kernel.org.\n> \n> Robert\n\nRobert,\n\nThank you for fixing this bug so quickly.  I've noticed that the gitweb\ntemplates on kernel.org have changed at least once since you wrote this email to\nme... (I can tell, based on the fact that the git:// link has moved from the\nproject column to a link labeled, \"git\" all the way to the right.)\n\nUnfortunately, however, the bug that I had originally reported has not yet been\nfixed on the kernel.org www server.  Either the patch in question hasn't yet\nbeen applied to that installation, or it HAS in fact been applied, but doesn't\nfix the problem as intended.\n\nDo you know which of the above is true?\n\nThanks again,\n\nMike Krufky\n\n>  gitweb/gitweb.perl |    2 +-\n>  1 files changed, 1 insertions(+), 1 deletions(-)\n> \n> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> index d845e91..2e94c2c 100755\n> --- a/gitweb/gitweb.perl\n> +++ b/gitweb/gitweb.perl\n> @@ -4423,7 +4423,7 @@ sub git_shortlog {\n>  \t}\n>  \tmy $refs = git_get_references();\n>  \n> -\tmy @commitlist = parse_commits($head, 101, (100 * $page));\n> +\tmy @commitlist = parse_commits($hash, 101, (100 * $page));\n>  \n>  \tmy $paging_nav = format_paging_nav('shortlog', $hash, $head, $page, (100 * ($page+1)));\n>  \tmy $next_link = '';\n"},{"id":"30906","messageId":"1168032358.2505.10.camel@localhost.localdomain","threadId":"6209","inReplyTo":"459EC16F.1070809@linuxtv.org","subject":"Re: [PATCH] gitweb: Fix shortlog only showing HEAD revision.","fromName":"J.H.","fromEmail":"warthog19@eaglescrag.net","sentAt":"2007-01-05T21:25:58Z","receivedAt":"2007-01-05T21:25:58Z","isPatch":true,"sender":{"key":"warthog19@eaglescrag.net","avatar":null},"body":"On Fri, 2007-01-05 at 16:21 -0500, Michael Krufky wrote:\n> Robert Fitzsimons wrote:\n> > My change in 190d7fdcf325bb444fa806f09ebbb403a4ae4ee6 had a small bug\n> > found by Michael Krufky which caused the passed in hash value to be\n> > ignored, so shortlog would only show the HEAD revision.\n> > \n> > Signed-off-by: Robert Fitzsimons <robfitz@273k.net>\n> > ---\n> > \n> > Thanks for finding this Michael.  It' just a small bug introducted by a\n> > recent change I made.  Including John 'Warthog9' so hopefully he can add\n> > this to the version of gitweb which is hosted on kernel.org.\n> > \n> > Robert\n> \n> Robert,\n> \n> Thank you for fixing this bug so quickly.  I've noticed that the gitweb\n> templates on kernel.org have changed at least once since you wrote this email to\n> me... (I can tell, based on the fact that the git:// link has moved from the\n> project column to a link labeled, \"git\" all the way to the right.)\n> \n> Unfortunately, however, the bug that I had originally reported has not yet been\n> fixed on the kernel.org www server.  Either the patch in question hasn't yet\n> been applied to that installation, or it HAS in fact been applied, but doesn't\n> fix the problem as intended.\n\nSimple answer - it's sitting in my tree waiting for me to have enough\ntime to get back to gitweb.  There are several things in flight and I'm\nnot prepared to push them out in their current state.\n\nSo yes the problem is fixed, but it will probably be sometime this\nweekend before it gets pushed out to the kernel.org servers.\n\n> \n> Do you know which of the above is true?\n> \n> Thanks again,\n> \n> Mike Krufky\n> \n> >  gitweb/gitweb.perl |    2 +-\n> >  1 files changed, 1 insertions(+), 1 deletions(-)\n> > \n> > diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\n> > index d845e91..2e94c2c 100755\n> > --- a/gitweb/gitweb.perl\n> > +++ b/gitweb/gitweb.perl\n> > @@ -4423,7 +4423,7 @@ sub git_shortlog {\n> >  \t}\n> >  \tmy $refs = git_get_references();\n> >  \n> > -\tmy @commitlist = parse_commits($head, 101, (100 * $page));\n> > +\tmy @commitlist = parse_commits($hash, 101, (100 * $page));\n> >  \n> >  \tmy $paging_nav = format_paging_nav('shortlog', $hash, $head, $page, (100 * ($page+1)));\n> >  \tmy $next_link = '';\n> \n> -\n> To unsubscribe from this list: send the line \"unsubscribe git\" in\n> the body of a message to majordomo@vger.kernel.org\n> More majordomo info at  http://vger.kernel.org/majordomo-info.html\n"}]}