{"thread":{"id":"6208","subject":"[PATCH 1/2] gitweb: Fix bug in git_difftree_body (was '!=' instead of 'ne')","startedAt":"2007-01-03T19:47:24Z","lastAt":"2007-01-03T19:47:25Z","messageCount":2,"participants":["Jakub Narebski"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"30764","messageId":"11678536452473-git-send-email-jnareb@gmail.com","threadId":"6208","inReplyTo":null,"subject":"[PATCH 1/2] gitweb: Fix bug in git_difftree_body (was '!=' instead of 'ne')","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-01-03T19:47:24Z","receivedAt":"2007-01-03T19:47:24Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"Fix bug in git_difftree_body subroutine; it was used '!=' comparison\noperator for strings (file type) instead of correct 'ne'.\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 7f54834..05b3876 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2274,7 +2274,7 @@ sub git_difftree_body {\n \t\t\tmy $mode_chnge = \"\";\n \t\t\tif ($diff{'from_mode'} != $diff{'to_mode'}) {\n \t\t\t\t$mode_chnge = \"<span class=\\\"file_status mode_chnge\\\">[changed\";\n-\t\t\t\tif ($from_file_type != $to_file_type) {\n+\t\t\t\tif ($from_file_type ne $to_file_type) {\n \t\t\t\t\t$mode_chnge .= \" from $from_file_type to $to_file_type\";\n \t\t\t\t}\n \t\t\t\tif (($from_mode_oct & 0777) != ($to_mode_oct & 0777)) {\n-- \n1.4.4.3\n"},{"id":"30765","messageId":"11678536473286-git-send-email-jnareb@gmail.com","threadId":"6208","inReplyTo":"11678536452473-git-send-email-jnareb@gmail.com","subject":"[PATCH 2/2] gitweb: There can be empty patches (in git_patchset_body)","fromName":"Jakub Narebski","fromEmail":"jnareb@gmail.com","sentAt":"2007-01-03T19:47:25Z","receivedAt":"2007-01-03T19:47:25Z","isPatch":true,"sender":{"key":"jnareb@gmail.com","avatar":"https://avatars.githubusercontent.com/u/2706?v=4"},"body":"We now do not skip over empty patches in git_patchset_body\n(where empty means that they consist only of git diff header,\nand of extended diff header), so uncomment branch of code dealing\nwith empty patches (patches which do not have even two-line\nfrom/to header)\n\nSigned-off-by: Jakub Narebski <jnareb@gmail.com>\n---\n gitweb/gitweb.perl |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)\n\ndiff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl\nindex 05b3876..2ead917 100755\n--- a/gitweb/gitweb.perl\n+++ b/gitweb/gitweb.perl\n@@ -2527,7 +2527,7 @@ sub git_patchset_body {\n \t\tprint \"<div class=\\\"diff from_file\\\">$patch_line</div>\\n\";\n \n \t\t$patch_line = <$fd>;\n-\t\t#last PATCH unless $patch_line;\n+\t\tlast PATCH unless $patch_line;\n \t\tchomp $patch_line;\n \n \t\t#assert($patch_line =~ m/^+++/) if DEBUG;\n-- \n1.4.4.3\n"}]}