{"thread":{"id":"62036","subject":"[PATCH] Documentation/BreakingChanges: announce removal of git-pack-redundant(1)","startedAt":"2024-09-02T08:13:05Z","lastAt":"2024-09-03T18:31:33Z","messageCount":2,"participants":["Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"501970","messageId":"a6be9f5e9eb1f426b1a17b89e3db1bc7532758b5.1725264748.git.ps@pks.im","threadId":"62036","inReplyTo":null,"subject":"[PATCH] Documentation/BreakingChanges: announce removal of git-pack-redundant(1)","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-09-02T08:13:00Z","receivedAt":"2024-09-02T08:13:05Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"The git-pack-redundant(1) command is already in the process of being\nphased out and dies unless the user passes the `--i-still-use-this` flag\nsince 4406522b76 (pack-redundant: escalate deprecation warning to an\nerror, 2023-03-23). We haven't heard any complaints, so let's announce\nthe removal of this command in Git 3.0 in our breaking changes document.\n\nSigned-off-by: Patrick Steinhardt \n---\n Documentation/BreakingChanges.txt | 20 ++++++++++++++++++++\n 1 file changed, 20 insertions(+)\n\ndiff --git a/Documentation/BreakingChanges.txt b/Documentation/BreakingChanges.txt\nindex 0532bfcf7f9..2b64665694f 100644\n--- a/Documentation/BreakingChanges.txt\n+++ b/Documentation/BreakingChanges.txt\n@@ -115,6 +115,26 @@ info/grafts as outdated, 2014-03-05) and will be removed.\n +\n Cf. <20140304174806.GA11561@sigill.intra.peff.net>.\n \n+* The git-pack-redundant(1) command can be used to remove redundant pack files.\n+ The subcommand is unusably slow and the reason why nobody reports it as a\n+ performance bug is suspected to be the absense of users. We have nominated\n+ the command for removal and have started to emit a user-visible warning in\n+ c3b58472be (pack-redundant: gauge the usage before proposing its removal,\n+ 2020-08-25) whenever the command is executed.\n++\n+So far there was a single complaint about somebody still using the command, but\n+that complaint did not cause us to reverse course. On the contrary, we have\n+doubled down on the deprecation and starting with 4406522b76 (pack-redundant:\n+escalate deprecation warning to an error, 2023-03-23), the command dies unless\n+the user passes the `--i-still-use-this` option.\n++\n+There have not been any subsequent complaints, so this command will finally be\n+removed.\n++\n+Cf. ,\n+ ,\n+ <20230323204047.GA9290@coredump.intra.peff.net>,\n+\n == Superseded features that will not be deprecated\n \n Some features have gained newer replacements that aim to improve the design in\n-- \n2.46.0.421.g159f2d50e7.dirty\n\n"},{"id":"502054","messageId":"xmqqy148k2rg.fsf@gitster.g","threadId":"62036","inReplyTo":"a6be9f5e9eb1f426b1a17b89e3db1bc7532758b5.1725264748.git.ps@pks.im","subject":"Re: [PATCH] Documentation/BreakingChanges: announce removal of git-pack-redundant(1)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-09-03T18:31:31Z","receivedAt":"2024-09-03T18:31:33Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt writes:\n\n> The git-pack-redundant(1) command is already in the process of being\n> phased out and dies unless the user passes the `--i-still-use-this` flag\n> since 4406522b76 (pack-redundant: escalate deprecation warning to an\n> error, 2023-03-23). We haven't heard any complaints, so let's announce\n> the removal of this command in Git 3.0 in our breaking changes document.\n>\n> Signed-off-by: Patrick Steinhardt \n> ---\n> Documentation/BreakingChanges.txt | 20 ++++++++++++++++++++\n> 1 file changed, 20 insertions(+)\n\n\nFinally ;-)\n\nThe \"--i-still-use-this\" (unless major distros have stripped it out)\nwas a good approach to allow us do this.\n\nWill queue. Thanks.\n\n\n> diff --git a/Documentation/BreakingChanges.txt b/Documentation/BreakingChanges.txt\n> index 0532bfcf7f9..2b64665694f 100644\n> --- a/Documentation/BreakingChanges.txt\n> +++ b/Documentation/BreakingChanges.txt\n> @@ -115,6 +115,26 @@ info/grafts as outdated, 2014-03-05) and will be removed.\n> +\n> Cf. <20140304174806.GA11561@sigill.intra.peff.net>.\n> \n> +* The git-pack-redundant(1) command can be used to remove redundant pack files.\n> + The subcommand is unusably slow and the reason why nobody reports it as a\n> + performance bug is suspected to be the absense of users. We have nominated\n> + the command for removal and have started to emit a user-visible warning in\n> + c3b58472be (pack-redundant: gauge the usage before proposing its removal,\n> + 2020-08-25) whenever the command is executed.\n> ++\n> +So far there was a single complaint about somebody still using the command, but\n> +that complaint did not cause us to reverse course. On the contrary, we have\n> +doubled down on the deprecation and starting with 4406522b76 (pack-redundant:\n> +escalate deprecation warning to an error, 2023-03-23), the command dies unless\n> +the user passes the `--i-still-use-this` option.\n> ++\n> +There have not been any subsequent complaints, so this command will finally be\n> +removed.\n> ++\n> +Cf. ,\n> + ,\n> + <20230323204047.GA9290@coredump.intra.peff.net>,\n> +\n> == Superseded features that will not be deprecated\n> \n> Some features have gained newer replacements that aim to improve the design in\n"}]}