{"thread":{"id":"62030","subject":"[PATCH v2] compat/terminal: mark parameter of git_terminal_prompt() UNUSED","startedAt":"2024-08-31T14:59:05Z","lastAt":"2024-09-05T10:48:14Z","messageCount":2,"participants":["Ramsay Jones","Jeff King"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"501953","messageId":"ce1c1d66-e0eb-4143-b334-1a83c0492415@ramsayjones.plus.com","threadId":"62030","inReplyTo":null,"subject":"[PATCH v2] compat/terminal: mark parameter of git_terminal_prompt() UNUSED","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2024-08-31T14:58:56Z","receivedAt":"2024-08-31T14:59:05Z","isPatch":true,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nIf neither HAVE_DEV_TTY nor GIT_WINDOWS_NATIVE is set, the fallback\ncode calls the system getpass(). This unfortunately ignores the \"echo\"\nboolean parameter, as we have no way to implement that functionality.\nBut we still have to keep the unused parameter, since our interface\nhas to match the other implementations.\n\nCo-authored-by: Jeff King <peff@peff.net>\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n\nHi,\n\nSorry for being a bit tardy with this, but I'm up-to-my-ears! :)\n\nI feel a bit sheepish about taking authorship of this patch, since Jeff\ncontributed way more than I did to the text! (I was going to count the\nwords to get a better metric, but I have to go out now; if I don't send\nthis now it will be tomorrow ...).\n\nATB,\nRamsay Jones\n\n compat/terminal.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/compat/terminal.c b/compat/terminal.c\nindex 0afda730f2..d54efa1c5d 100644\n--- a/compat/terminal.c\n+++ b/compat/terminal.c\n@@ -594,7 +594,7 @@ void restore_term(void)\n {\n }\n \n-char *git_terminal_prompt(const char *prompt, int echo)\n+char *git_terminal_prompt(const char *prompt, int echo UNUSED)\n {\n \treturn getpass(prompt);\n }\n-- \n2.46.0\n"},{"id":"502232","messageId":"20240905104812.GA2598693@coredump.intra.peff.net","threadId":"62030","inReplyTo":"ce1c1d66-e0eb-4143-b334-1a83c0492415@ramsayjones.plus.com","subject":"Re: [PATCH v2] compat/terminal: mark parameter of git_terminal_prompt() UNUSED","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2024-09-05T10:48:12Z","receivedAt":"2024-09-05T10:48:14Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Aug 31, 2024 at 03:58:56PM +0100, Ramsay Jones wrote:\n\n> Sorry for being a bit tardy with this, but I'm up-to-my-ears! :)\n\nWell, then I don't feel so bad about being late to respond. :)\n\n> I feel a bit sheepish about taking authorship of this patch, since Jeff\n> contributed way more than I did to the text! (I was going to count the\n> words to get a better metric, but I have to go out now; if I don't send\n> this now it will be tomorrow ...).\n\nThis looks great to me, and I think the authorship is fine as it is. The\nhard part IMHO was finding the problem in the first place!\n\n-Peff\n"}]}