{"thread":{"id":"62008","subject":"[PATCH v2] git-config.1: fix description of --regexp in synopsis","startedAt":"2024-08-26T18:49:02Z","lastAt":"2024-08-27T12:09:13Z","messageCount":2,"participants":["Junio C Hamano","Patrick Steinhardt"],"isPatch":true,"patchVersion":2,"patchTotal":null},"messages":[{"id":"501693","messageId":"xmqq4j77jf1i.fsf@gitster.g","threadId":"62008","inReplyTo":null,"subject":"[PATCH v2] git-config.1: fix description of --regexp in synopsis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-08-26T18:48:57Z","receivedAt":"2024-08-26T18:49:02Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"The synopsis says --regexp=<regexp> but the --regexp option is a\nBoolean that says \"the name given is not literal, but a pattern to\nmatch the name\".\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n * t0450 strikes again X-<.  This should pass that test.\n\n Documentation/git-config.txt | 2 +-\n builtin/config.c             | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-config.txt b/Documentation/git-config.txt\nindex 65c645d461..85a7edc407 100644\n--- a/Documentation/git-config.txt\n+++ b/Documentation/git-config.txt\n@@ -10,7 +10,7 @@ SYNOPSIS\n --------\n [verse]\n 'git config list' [<file-option>] [<display-option>] [--includes]\n-'git config get' [<file-option>] [<display-option>] [--includes] [--all] [--regexp=<regexp>] [--value=<value>] [--fixed-value] [--default=<default>] <name>\n+'git config get' [<file-option>] [<display-option>] [--includes] [--all] [--regexp] [--value=<value>] [--fixed-value] [--default=<default>] <name>\n 'git config set' [<file-option>] [--type=<type>] [--all] [--value=<value>] [--fixed-value] <name> <value>\n 'git config unset' [<file-option>] [--all] [--value=<value>] [--fixed-value] <name> <value>\n 'git config rename-section' [<file-option>] <old-name> <new-name>\ndiff --git a/builtin/config.c b/builtin/config.c\nindex 20a0b64090..97e4d5f57c 100644\n--- a/builtin/config.c\n+++ b/builtin/config.c\n@@ -17,7 +17,7 @@\n \n static const char *const builtin_config_usage[] = {\n \tN_(\"git config list [<file-option>] [<display-option>] [--includes]\"),\n-\tN_(\"git config get [<file-option>] [<display-option>] [--includes] [--all] [--regexp=<regexp>] [--value=<value>] [--fixed-value] [--default=<default>] <name>\"),\n+\tN_(\"git config get [<file-option>] [<display-option>] [--includes] [--all] [--regexp] [--value=<value>] [--fixed-value] [--default=<default>] <name>\"),\n \tN_(\"git config set [<file-option>] [--type=<type>] [--all] [--value=<value>] [--fixed-value] <name> <value>\"),\n \tN_(\"git config unset [<file-option>] [--all] [--value=<value>] [--fixed-value] <name> <value>\"),\n \tN_(\"git config rename-section [<file-option>] <old-name> <new-name>\"),\n-- \n2.46.0-528-g6fe5f670b3\n\n"},{"id":"501715","messageId":"Zs3B5NwyXfbo5z5h@tanuki","threadId":"62008","inReplyTo":"xmqq4j77jf1i.fsf@gitster.g","subject":"Re: [PATCH v2] git-config.1: fix description of --regexp in synopsis","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-08-27T12:09:08Z","receivedAt":"2024-08-27T12:09:13Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Aug 26, 2024 at 11:48:57AM -0700, Junio C Hamano wrote:\n> The synopsis says --regexp=<regexp> but the --regexp option is a\n> Boolean that says \"the name given is not literal, but a pattern to\n> match the name\".\n> \n> Signed-off-by: Junio C Hamano <gitster@pobox.com>\n> ---\n>  * t0450 strikes again X-<.  This should pass that test.\n\nThanks, this version looks good to me!\n\nPatrick\n"}]}