{"thread":{"id":"61983","subject":"[PATCH 0/2] Update the win+VS build definition","startedAt":"2024-08-20T14:31:13Z","lastAt":"2024-08-20T20:38:14Z","messageCount":6,"participants":["Johannes Schindelin via GitGitGadget","Junio C Hamano","Johannes Schindelin"],"isPatch":true,"patchVersion":1,"patchTotal":2},"messages":[{"id":"501374","messageId":"pull.1775.git.1724164270.gitgitgadget@gmail.com","threadId":"61983","inReplyTo":null,"subject":"[PATCH 0/2] Update the win+VS build definition","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-08-20T14:31:08Z","receivedAt":"2024-08-20T14:31:13Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"These two patches have been in Git for Windows' fork for quite a while.\n\nWhile the win+VS builds are not run in Git's CI builds, it is still a good\nidea to upstream these changes.\n\nJohannes Schindelin (2):\n ci: bump microsoft/setup-msbuild from v1 to v2\n ci(win+VS): download the vcpkg artifacts using a dedicated GitHub\n Action\n\n .github/workflows/main.yml | 14 +++++---------\n 1 file changed, 5 insertions(+), 9 deletions(-)\n\n\nbase-commit: bb9c16bd4f1a9a00799e10c81ee6506cf468c0c7\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1775%2Fdscho%2Fwin%2BVS-updates-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1775/dscho/win+VS-updates-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1775\n-- \ngitgitgadget\n"},{"id":"501375","messageId":"51eeafc713ca5a83499ceca3602e77c15dbfcab9.1724164270.git.gitgitgadget@gmail.com","threadId":"61983","inReplyTo":"pull.1775.git.1724164270.gitgitgadget@gmail.com","subject":"[PATCH 1/2] ci: bump microsoft/setup-msbuild from v1 to v2","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-08-20T14:31:09Z","receivedAt":"2024-08-20T14:31:15Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nThe main benefit: The new version uses a node.js version that is not yet\ndeprecated.\n\nLinks:\n- [Release notes](https://github.com/microsoft/setup-msbuild/releases)\n- [Changelog](https://github.com/microsoft/setup-msbuild/blob/main/building-release.md)\n- [Commits](https://github.com/microsoft/setup-msbuild/compare/v1...v2)\n\nThis patch was originally by GitHub's Dependabot, but I cannot attribute\nthat bot properly because it has no dedicated email address. Probably\nbecause it hasn't reached legal age yet, or something.\n\nSigned-off-by: Johannes Schindelin \n---\n .github/workflows/main.yml | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 13cc0fe8077..85e5767aae6 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -190,7 +190,7 @@ jobs:\n Expand-Archive compat.zip -DestinationPath . -Force\n Remove-Item compat.zip\n - name: add msbuild to PATH\n- uses: microsoft/setup-msbuild@v1\n+ uses: microsoft/setup-msbuild@v2\n - name: copy dlls to root\n shell: cmd\n run: compat\\vcbuild\\vcpkg_copy_dlls.bat release\n-- \ngitgitgadget\n\n"},{"id":"501376","messageId":"1e2ad9d536e075098edd913b326086a88c69ad4a.1724164270.git.gitgitgadget@gmail.com","threadId":"61983","inReplyTo":"pull.1775.git.1724164270.gitgitgadget@gmail.com","subject":"[PATCH 2/2] ci(win+VS): download the vcpkg artifacts using a dedicated GitHub Action","fromName":"Johannes Schindelin via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-08-20T14:31:10Z","receivedAt":"2024-08-20T14:31:16Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"From: Johannes Schindelin \n\nThe Git for Windows project provides a GitHub Action to download and\ncache Azure Pipelines artifacts (such as the `vcpkg` artifacts), hiding\ngnarly internals, and also providing some robustness against network\nglitches. Let's use it.\n\nSigned-off-by: Johannes Schindelin \n---\n .github/workflows/main.yml | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)\n\ndiff --git a/.github/workflows/main.yml b/.github/workflows/main.yml\nindex 85e5767aae6..1ee0433acc1 100644\n--- a/.github/workflows/main.yml\n+++ b/.github/workflows/main.yml\n@@ -181,14 +181,10 @@ jobs:\n repository: 'microsoft/vcpkg'\n path: 'compat/vcbuild/vcpkg'\n - name: download vcpkg artifacts\n- shell: powershell\n- run: |\n- $urlbase = \"https://dev.azure.com/git/git/_apis/build/builds\"\n- $id = ((Invoke-WebRequest -UseBasicParsing \"${urlbase}?definitions=9&statusFilter=completed&resultFilter=succeeded&`$top=1\").content | ConvertFrom-JSON).value[0].id\n- $downloadUrl = ((Invoke-WebRequest -UseBasicParsing \"${urlbase}/$id/artifacts\").content | ConvertFrom-JSON).value[0].resource.downloadUrl\n- (New-Object Net.WebClient).DownloadFile($downloadUrl, \"compat.zip\")\n- Expand-Archive compat.zip -DestinationPath . -Force\n- Remove-Item compat.zip\n+ uses: git-for-windows/get-azure-pipelines-artifact@v0\n+ with:\n+ repository: git/git\n+ definitionId: 9\n - name: add msbuild to PATH\n uses: microsoft/setup-msbuild@v2\n - name: copy dlls to root\n-- \ngitgitgadget\n"},{"id":"501379","messageId":"xmqqv7zvb4mu.fsf@gitster.g","threadId":"61983","inReplyTo":"pull.1775.git.1724164270.gitgitgadget@gmail.com","subject":"Re: [PATCH 0/2] Update the win+VS build definition","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-08-20T15:22:49Z","receivedAt":"2024-08-20T15:22:55Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Johannes Schindelin via GitGitGadget\" \nwrites:\n\n> These two patches have been in Git for Windows' fork for quite a while.\n>\n> While the win+VS builds are not run in Git's CI builds, it is still a good\n> idea to upstream these changes.\n>\n> Johannes Schindelin (2):\n> ci: bump microsoft/setup-msbuild from v1 to v2\n> ci(win+VS): download the vcpkg artifacts using a dedicated GitHub\n> Action\n>\n> .github/workflows/main.yml | 14 +++++---------\n> 1 file changed, 5 insertions(+), 9 deletions(-)\n\nThanks. \n\nDo you mind if I applied these directly to 'maint' and merged the\nresult upwards?\n"},{"id":"501391","messageId":"ab765f95-1208-fa77-01a7-2dd4f5eea90d@gmx.de","threadId":"61983","inReplyTo":"xmqqv7zvb4mu.fsf@gitster.g","subject":"Re: [PATCH 0/2] Update the win+VS build definition","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2024-08-20T20:15:43Z","receivedAt":"2024-08-20T20:15:50Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Junio,\n\nOn Tue, 20 Aug 2024, Junio C Hamano wrote:\n\n> \"Johannes Schindelin via GitGitGadget\" \n> writes:\n>\n> > These two patches have been in Git for Windows' fork for quite a while.\n> >\n> > While the win+VS builds are not run in Git's CI builds, it is still a good\n> > idea to upstream these changes.\n> >\n> > Johannes Schindelin (2):\n> > ci: bump microsoft/setup-msbuild from v1 to v2\n> > ci(win+VS): download the vcpkg artifacts using a dedicated GitHub\n> > Action\n> >\n> > .github/workflows/main.yml | 14 +++++---------\n> > 1 file changed, 5 insertions(+), 9 deletions(-)\n>\n> Thanks.\n>\n> Do you mind if I applied these directly to 'maint' and merged the\n> result upwards?\n\nI concur that this is a good idea.\n\nThank you,\nJohannes\n"},{"id":"501393","messageId":"xmqq34mz6ibw.fsf@gitster.g","threadId":"61983","inReplyTo":"ab765f95-1208-fa77-01a7-2dd4f5eea90d@gmx.de","subject":"Re: [PATCH 0/2] Update the win+VS build definition","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-08-20T20:38:11Z","receivedAt":"2024-08-20T20:38:14Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin writes:\n\n>> Do you mind if I applied these directly to 'maint' and merged the\n>> result upwards?\n>\n> I concur that this is a good idea.\n\nWill, do. Thanks.\n"}]}