{"thread":{"id":"61858","subject":"[PATCH] unit-tests/test-lib: fix typo in check_pointer_eq() description","startedAt":"2024-07-29T04:14:43Z","lastAt":"2024-07-29T04:33:14Z","messageCount":3,"participants":["Kousik Sanagavarapu","Eric Sunshine"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"499503","messageId":"20240729041435.7618-1-five231003@gmail.com","threadId":"61858","inReplyTo":null,"subject":"[PATCH] unit-tests/test-lib: fix typo in check_pointer_eq() description","fromName":"Kousik Sanagavarapu","fromEmail":"five231003@gmail.com","sentAt":"2024-07-29T04:13:19Z","receivedAt":"2024-07-29T04:14:43Z","isPatch":true,"sender":{"key":"five231003@gmail.com","avatar":"https://avatars.githubusercontent.com/u/75560439?v=4"},"body":"The comment surrounding chech_pointer_eq() should explain about what\nthis function does instead of explaining check_int().  Correct this.\n\nSigned-off-by: Kousik Sanagavarapu <five231003@gmail.com>\n---\n t/unit-tests/test-lib.h | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/t/unit-tests/test-lib.h b/t/unit-tests/test-lib.h\nindex 2de6d715d5..c59f646fd9 100644\n--- a/t/unit-tests/test-lib.h\n+++ b/t/unit-tests/test-lib.h\n@@ -76,8 +76,9 @@ int test_assert(const char *location, const char *check, int ok);\n int check_bool_loc(const char *loc, const char *check, int ok);\n \n /*\n- * Compare two integers. Prints a message with the two values if the\n- * comparison fails. NB this is not thread safe.\n+ * Compare the equality of two pointers of same type. Prints a message\n+ * with the two values if the equality fails. NB this is not thread\n+ * safe.\n  */\n #define check_pointer_eq(a, b)\t\t\t\t\t\t\\\n \t(test__tmp[0].p = (a), test__tmp[1].p = (b),\t\t\t\\\n-- \n2.46.0.rc2.1.g1fdd4dfe68\n\n"},{"id":"499504","messageId":"CAPig+cShnMPrtvaYqQS33qmpDu9VDyFK5jADJ995s7vNJB2p4g@mail.gmail.com","threadId":"61858","inReplyTo":"20240729041435.7618-1-five231003@gmail.com","subject":"Re: [PATCH] unit-tests/test-lib: fix typo in check_pointer_eq() description","fromName":"Eric Sunshine","fromEmail":"sunshine@sunshineco.com","sentAt":"2024-07-29T04:26:21Z","receivedAt":"2024-07-29T04:26:33Z","isPatch":true,"sender":{"key":"sunshine@sunshineco.com","avatar":"https://avatars.githubusercontent.com/u/163641?v=4"},"body":"On Mon, Jul 29, 2024 at 12:14 AM Kousik Sanagavarapu\n<five231003@gmail.com> wrote:\n> The comment surrounding chech_pointer_eq() should explain about what\n> this function does instead of explaining check_int().  Correct this.\n\ns/chech/check/\n\n> Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>\n"},{"id":"499505","messageId":"20240729043303.3486-1-five231003@gmail.com","threadId":"61858","inReplyTo":"20240729041435.7618-1-five231003@gmail.com","subject":"[PATCH v2] unit-tests/test-lib: fix typo in check_pointer_eq() description","fromName":"Kousik Sanagavarapu","fromEmail":"five231003@gmail.com","sentAt":"2024-07-29T04:32:48Z","receivedAt":"2024-07-29T04:33:14Z","isPatch":true,"sender":{"key":"five231003@gmail.com","avatar":"https://avatars.githubusercontent.com/u/75560439?v=4"},"body":"The comment surrounding check_pointer_eq() should explain about what\nthis function does instead of explaining check_int().  Correct this.\n\nSigned-off-by: Kousik Sanagavarapu <five231003@gmail.com>\n---\n t/unit-tests/test-lib.h | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)\n\ndiff --git a/t/unit-tests/test-lib.h b/t/unit-tests/test-lib.h\nindex 2de6d715d5..c59f646fd9 100644\n--- a/t/unit-tests/test-lib.h\n+++ b/t/unit-tests/test-lib.h\n@@ -76,8 +76,9 @@ int test_assert(const char *location, const char *check, int ok);\n int check_bool_loc(const char *loc, const char *check, int ok);\n \n /*\n- * Compare two integers. Prints a message with the two values if the\n- * comparison fails. NB this is not thread safe.\n+ * Compare the equality of two pointers of same type. Prints a message\n+ * with the two values if the equality fails. NB this is not thread\n+ * safe.\n  */\n #define check_pointer_eq(a, b)\t\t\t\t\t\t\\\n \t(test__tmp[0].p = (a), test__tmp[1].p = (b),\t\t\t\\\n-- \n2.46.0.rc2.1.g1fdd4dfe68\n\n"}]}