{"thread":{"id":"61823","subject":"[PATCH 1/1] doc: remove dangling closing parenthesis","startedAt":"2024-07-22T22:54:41Z","lastAt":"2024-07-23T16:48:30Z","messageCount":6,"participants":["Tomas Nordin","Junio C Hamano","Karthik Nayak"],"isPatch":true,"patchVersion":1,"patchTotal":1},"messages":[{"id":"499092","messageId":"20240722225302.124356-1-tomasn@posteo.net","threadId":"61823","inReplyTo":null,"subject":"[PATCH 1/1] doc: remove dangling closing parenthesis","fromName":"Tomas Nordin","fromEmail":"tomasn@posteo.net","sentAt":"2024-07-22T22:53:02Z","receivedAt":"2024-07-22T22:54:41Z","isPatch":true,"sender":{"key":"tomasn@posteo.net","avatar":"https://avatars.githubusercontent.com/u/5942154?v=4"},"body":"The second line of the synopsis, starting with [--dry-run] has a\ndangling closing paren in the second optional group. Probably added by\nmistake, so remove it.\n\nSigned-off-by: Tomas Nordin \n---\n Documentation/git-commit.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex 89ecfc63a8..c822113c11 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -9,7 +9,7 @@ SYNOPSIS\n --------\n [verse]\n 'git commit' [-a | --interactive | --patch] [-s] [-v] [-u] [--amend]\n-\t [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):])]\n+\t [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):]]\n \t [-F | -m ] [--reset-author] [--allow-empty]\n \t [--allow-empty-message] [--no-verify] [-e] [--author=]\n \t [--date=] [--cleanup=] [--[no-]status]\n-- \n2.39.2\n\n"},{"id":"499093","messageId":"xmqqy15t824l.fsf@gitster.g","threadId":"61823","inReplyTo":"20240722225302.124356-1-tomasn@posteo.net","subject":"Re: [PATCH 1/1] doc: remove dangling closing parenthesis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-07-22T22:59:06Z","receivedAt":"2024-07-22T22:59:09Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tomas Nordin writes:\n\n> The second line of the synopsis, starting with [--dry-run] has a\n> dangling closing paren in the second optional group. Probably added by\n> mistake, so remove it.\n>\n> Signed-off-by: Tomas Nordin \n> ---\n> Documentation/git-commit.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\n> index 89ecfc63a8..c822113c11 100644\n> --- a/Documentation/git-commit.txt\n> +++ b/Documentation/git-commit.txt\n> @@ -9,7 +9,7 @@ SYNOPSIS\n> --------\n> [verse]\n> 'git commit' [-a | --interactive | --patch] [-s] [-v] [-u] [--amend]\n> -\t [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):])]\n> +\t [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):]]\n> \t [-F | -m ] [--reset-author] [--allow-empty]\n> \t [--allow-empty-message] [--no-verify] [-e] [--author=]\n> \t [--date=] [--cleanup=] [--[no-]status]\n\nWonderful. Thanks.\n\nWill queue.\n\n"},{"id":"499110","messageId":"xmqqo76p54ib.fsf@gitster.g","threadId":"61823","inReplyTo":"xmqqy15t824l.fsf@gitster.g","subject":"Re: [PATCH 1/1] doc: remove dangling closing parenthesis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-07-23T00:35:56Z","receivedAt":"2024-07-23T00:35:59Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Junio C Hamano writes:\n\n> Wonderful. Thanks.\n>\n> Will queue.\n\nSpoke too early. We need a matching change to in-code help,\notherwise t0450 would break.\n\nHere is what I have, which hopefully needs no more fix-ups.\n\nThanks.\n\n----- >8 --------- >8 -----\nSubject: [PATCH] doc: remove dangling closing parenthesis\n\nThe second line of the synopsis, starting with [--dry-run] has a\ndangling closing paren in the second optional group. Probably added by\nmistake, so remove it.\n\nSigned-off-by: Tomas Nordin \nSigned-off-by: Junio C Hamano \n---\n Documentation/git-commit.txt | 2 +-\n builtin/commit.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\nindex 89ecfc63a8..c822113c11 100644\n--- a/Documentation/git-commit.txt\n+++ b/Documentation/git-commit.txt\n@@ -9,7 +9,7 @@ SYNOPSIS\n --------\n [verse]\n 'git commit' [-a | --interactive | --patch] [-s] [-v] [-u] [--amend]\n-\t [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):])]\n+\t [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):]]\n \t [-F | -m ] [--reset-author] [--allow-empty]\n \t [--allow-empty-message] [--no-verify] [-e] [--author=]\n \t [--date=] [--cleanup=] [--[no-]status]\ndiff --git a/builtin/commit.c b/builtin/commit.c\nindex 6e1484446b..7f9dd45d05 100644\n--- a/builtin/commit.c\n+++ b/builtin/commit.c\n@@ -41,7 +41,7 @@\n \n static const char * const builtin_commit_usage[] = {\n \tN_(\"git commit [-a | --interactive | --patch] [-s] [-v] [-u] [--amend]\\n\"\n-\t \" [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):])]\\n\"\n+\t \" [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):]]\\n\"\n \t \" [-F | -m ] [--reset-author] [--allow-empty]\\n\"\n \t \" [--allow-empty-message] [--no-verify] [-e] [--author=]\\n\"\n \t \" [--date=] [--cleanup=] [--[no-]status]\\n\"\n-- \n2.46.0-rc1-52-gda884b23f2\n\n"},{"id":"499138","messageId":"CAOLa=ZSJHz4RXvmmJi=KdDYCQ-3=q0p1KW1WgZAeotSQ+A_UJQ@mail.gmail.com","threadId":"61823","inReplyTo":"xmqqo76p54ib.fsf@gitster.g","subject":"Re: [PATCH 1/1] doc: remove dangling closing parenthesis","fromName":"Karthik Nayak","fromEmail":"karthik.188@gmail.com","sentAt":"2024-07-23T08:50:25Z","receivedAt":"2024-07-23T08:50:29Z","isPatch":true,"sender":{"key":"karthik.188@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1786334?v=4"},"body":"Junio C Hamano writes:\n\n> Junio C Hamano writes:\n>\n>> Wonderful. Thanks.\n>>\n>> Will queue.\n>\n> Spoke too early. We need a matching change to in-code help,\n> otherwise t0450 would break.\n>\n> Here is what I have, which hopefully needs no more fix-ups.\n>\n> Thanks.\n>\n\nCan confirm that your patch below fixes t0450.\n\n> ----- >8 --------- >8 -----\n> Subject: [PATCH] doc: remove dangling closing parenthesis\n>\n> The second line of the synopsis, starting with [--dry-run] has a\n> dangling closing paren in the second optional group. Probably added by\n> mistake, so remove it.\n>\n> Signed-off-by: Tomas Nordin \n> Signed-off-by: Junio C Hamano \n> ---\n> Documentation/git-commit.txt | 2 +-\n> builtin/commit.c | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt\n> index 89ecfc63a8..c822113c11 100644\n> --- a/Documentation/git-commit.txt\n> +++ b/Documentation/git-commit.txt\n> @@ -9,7 +9,7 @@ SYNOPSIS\n> --------\n> [verse]\n> 'git commit' [-a | --interactive | --patch] [-s] [-v] [-u] [--amend]\n> -\t [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):])]\n> +\t [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):]]\n> \t [-F | -m ] [--reset-author] [--allow-empty]\n> \t [--allow-empty-message] [--no-verify] [-e] [--author=]\n> \t [--date=] [--cleanup=] [--[no-]status]\n> diff --git a/builtin/commit.c b/builtin/commit.c\n> index 6e1484446b..7f9dd45d05 100644\n> --- a/builtin/commit.c\n> +++ b/builtin/commit.c\n> @@ -41,7 +41,7 @@\n>\n> static const char * const builtin_commit_usage[] = {\n> \tN_(\"git commit [-a | --interactive | --patch] [-s] [-v] [-u] [--amend]\\n\"\n> -\t \" [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):])]\\n\"\n> +\t \" [--dry-run] [(-c | -C | --squash) | --fixup [(amend|reword):]]\\n\"\n> \t \" [-F | -m ] [--reset-author] [--allow-empty]\\n\"\n> \t \" [--allow-empty-message] [--no-verify] [-e] [--author=]\\n\"\n> \t \" [--date=] [--cleanup=] [--[no-]status]\\n\"\n> --\n> 2.46.0-rc1-52-gda884b23f2\n\nLooks good! Thanks.\n"},{"id":"499146","messageId":"87h6cgwcwl.fsf@posteo.net","threadId":"61823","inReplyTo":"xmqqo76p54ib.fsf@gitster.g","subject":"Re: [PATCH 1/1] doc: remove dangling closing parenthesis","fromName":"Tomas Nordin","fromEmail":"tomasn@posteo.net","sentAt":"2024-07-23T11:44:42Z","receivedAt":"2024-07-23T11:44:46Z","isPatch":true,"sender":{"key":"tomasn@posteo.net","avatar":"https://avatars.githubusercontent.com/u/5942154?v=4"},"body":"Junio C Hamano writes:\n\n> Junio C Hamano writes:\n>\n>> Wonderful. Thanks.\n>>\n>> Will queue.\n>\n> Spoke too early. We need a matching change to in-code help,\n> otherwise t0450 would break.\n\nGood test suit (which I didn't run)...\n"},{"id":"499178","messageId":"xmqqikww2gx6.fsf@gitster.g","threadId":"61823","inReplyTo":"87h6cgwcwl.fsf@posteo.net","subject":"Re: [PATCH 1/1] doc: remove dangling closing parenthesis","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-07-23T16:48:21Z","receivedAt":"2024-07-23T16:48:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Tomas Nordin writes:\n\n> Junio C Hamano writes:\n>\n>> Junio C Hamano writes:\n>>\n>>> Wonderful. Thanks.\n>>>\n>>> Will queue.\n>>\n>> Spoke too early. We need a matching change to in-code help,\n>> otherwise t0450 would break.\n>\n> Good test suit (which I didn't run)...\n\nIt skips a large number of commands that have mismatch in \"git cmd\n-h\" output and \"git cmd --help | head\" output. I am not sure what\nour longer term plans are. Perhaps make it a #leftoverbit item to\nshrink the t/t0450/txt-help-mismatches file? I dunno.\n\nThanks.\n"}]}