{"thread":{"id":"61798","subject":"Makefile: drop -Wno-universal-initializer from SP_EXTRA_FLAGS","startedAt":"2024-07-18T01:12:22Z","lastAt":"2024-07-18T01:12:22Z","messageCount":1,"participants":["Ramsay Jones"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"498889","messageId":"587e339a-8520-48d5-8090-e8d8bfb0c1f4@ramsayjones.plus.com","threadId":"61798","inReplyTo":null,"subject":"Makefile: drop -Wno-universal-initializer from SP_EXTRA_FLAGS","fromName":"Ramsay Jones","fromEmail":"ramsay@ramsayjones.plus.com","sentAt":"2024-07-18T01:12:19Z","receivedAt":"2024-07-18T01:12:22Z","isPatch":false,"sender":{"key":"ramsay@ramsayjones.plus.com","avatar":"https://avatars.githubusercontent.com/u/33702710?v=4"},"body":"\nCommit 1c96642326 (\"sparse: allow '{ 0 }' to be used without warnings\",\n2020-05-22) added -Wno-universal-initializer to the SP_EXTRA_FLAGS in\norder to suppress potential sparse warnings from using '{0}' as an\naggregate initializer. At that time, the default was for sparse to\nissue warnings (i.e. the default was -Wuniversal-initializer) if such\nan initializer was used to initialize an aggregate whose first member\nwas a pointer type. However, this default was changed just a few days\nlater to -Wno-universal-initializer (first released in sparse v0.6.2)\nand has been so in all subsequent release versions of sparse.  Thus,\nincluding -Wno-universal-initializer in the SP_EXTRA_FLAGS variable is\nredundant.\n\nRemove the unnecessary warning flag from SP_EXTRA_FLAGS, essentially\nreverting commit 1c96642326.\n\nSigned-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>\n---\n Makefile | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Makefile b/Makefile\nindex d6479092a0..ce3ff2476c 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1376,7 +1376,7 @@ PTHREAD_CFLAGS =\n \n # For the 'sparse' target\n SPARSE_FLAGS ?= -std=gnu99\n-SP_EXTRA_FLAGS = -Wno-universal-initializer\n+SP_EXTRA_FLAGS =\n \n # For informing GIT-BUILD-OPTIONS of the SANITIZE=leak,address targets\n SANITIZE_LEAK =\n-- \n2.45.0\n"}]}