{"thread":{"id":"61790","subject":"[PATCH] Documentation/gitpacking: make sample configs listing blocks","startedAt":"2024-07-17T10:54:57Z","lastAt":"2024-07-18T22:51:10Z","messageCount":3,"participants":["Martin Ågren","Junio C Hamano","Taylor Blau"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"498821","messageId":"20240717105432.2801097-1-martin.agren@gmail.com","threadId":"61790","inReplyTo":null,"subject":"[PATCH] Documentation/gitpacking: make sample configs listing blocks","fromName":"Martin Ågren","fromEmail":"martin.agren@gmail.com","sentAt":"2024-07-17T10:54:28Z","receivedAt":"2024-07-17T10:54:57Z","isPatch":true,"sender":{"key":"martin.agren@gmail.com","avatar":null},"body":"This document contains a few sample config snippets. At least with\nAsciidoctor, the section headers are rendered *more* indented than the\nvariables that follow:\n\n [bitmapPseudoMerge \"all\"]\n pattern = \"refs/\"\n ...\n\nTo address this, wrap these listings in AsciiDoc listing blocks. Remove\nthe indentation from the section headings. This is similar to how we\nhandle such sample config elsewhere, e.g., in config.txt.\n\nWhile we're here, fix the nearby \"wiht\" typo.\n\nSigned-off-by: Martin Ågren \n---\n These buglets were introduced in faf558b23e (pseudo-merge: implement\n support for selecting pseudo-merge commits, 2024-05-23) as part of \n tb/pseudo-merge-reachability-bitmap.\n\n Documentation/gitpacking.txt | 14 ++++++++++----\n 1 file changed, 10 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/gitpacking.txt b/Documentation/gitpacking.txt\nindex 4a6fcba6f7..321154d4e6 100644\n--- a/Documentation/gitpacking.txt\n+++ b/Documentation/gitpacking.txt\n@@ -143,14 +143,16 @@ include::config/bitmap-pseudo-merge.txt[]\n Suppose that you have a repository with a large number of references,\n and you want a bare-bones configuration of pseudo-merge bitmaps that\n will enhance bitmap coverage of the `refs/` namespace. You may start\n-wiht a configuration like so:\n+with a configuration like so:\n \n- [bitmapPseudoMerge \"all\"]\n+----\n+[bitmapPseudoMerge \"all\"]\n \tpattern = \"refs/\"\n \tthreshold = now\n \tstableThreshold = never\n \tsampleRate = 100\n \tmaxMerges = 64\n+----\n \n This will create pseudo-merge bitmaps for all references, regardless of\n their age, and group them into 64 pseudo-merge commits.\n@@ -159,8 +161,10 @@ If you wanted to separate tags from branches when generating\n pseudo-merge commits, you would instead define the pattern with a\n capture group, like so:\n \n- [bitmapPseudoMerge \"all\"]\n+----\n+[bitmapPseudoMerge \"all\"]\n \tpattern = \"refs/(heads/tags)/\"\n+----\n \n Suppose instead that you are working in a fork-network repository, with\n each fork specified by some numeric ID, and whose refs reside in\n@@ -168,12 +172,14 @@ each fork specified by some numeric ID, and whose refs reside in\n fork) in the network. In this instance, you may instead write something\n like:\n \n- [bitmapPseudoMerge \"all\"]\n+----\n+[bitmapPseudoMerge \"all\"]\n \tpattern = \"refs/virtual/([0-9]+)/(heads|tags)/\"\n \tthreshold = now\n \tstableThreshold = never\n \tsampleRate = 100\n \tmaxMerges = 64\n+----\n \n Which would generate pseudo-merge group identifiers like \"1234-heads\",\n and \"5678-tags\" (for branches in fork \"1234\", and tags in remote \"5678\",\n-- \n2.46.0.rc0.321.g44c27ab58a\n\n"},{"id":"498836","messageId":"xmqq4j8o589k.fsf@gitster.g","threadId":"61790","inReplyTo":"20240717105432.2801097-1-martin.agren@gmail.com","subject":"Re: [PATCH] Documentation/gitpacking: make sample configs listing blocks","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-07-17T15:48:55Z","receivedAt":"2024-07-17T15:48:58Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Martin Ågren writes:\n\n> To address this, wrap these listings in AsciiDoc listing blocks. Remove\n> the indentation from the section headings. This is similar to how we\n> handle such sample config elsewhere, e.g., in config.txt.\n>\n> While we're here, fix the nearby \"wiht\" typo.\n>\n> Signed-off-by: Martin Ågren \n> ---\n> These buglets were introduced in faf558b23e (pseudo-merge: implement\n> support for selecting pseudo-merge commits, 2024-05-23) as part of \n> tb/pseudo-merge-reachability-bitmap.\n\nThanks, will queue.\n"},{"id":"498950","messageId":"ZpmcW/fT6BZVwE1L@nand.local","threadId":"61790","inReplyTo":"20240717105432.2801097-1-martin.agren@gmail.com","subject":"Re: [PATCH] Documentation/gitpacking: make sample configs listing blocks","fromName":"Taylor Blau","fromEmail":"me@ttaylorr.com","sentAt":"2024-07-18T22:51:07Z","receivedAt":"2024-07-18T22:51:10Z","isPatch":true,"sender":{"key":"me@ttaylorr.com","avatar":"https://avatars.githubusercontent.com/u/301000140?v=4"},"body":"Hi Martin,\n\nOn Wed, Jul 17, 2024 at 12:54:28PM +0200, Martin Ågren wrote:\n> ---\n> These buglets were introduced in faf558b23e (pseudo-merge: implement\n> support for selecting pseudo-merge commits, 2024-05-23) as part of\n> tb/pseudo-merge-reachability-bitmap.\n>\n> Documentation/gitpacking.txt | 14 ++++++++++----\n> 1 file changed, 10 insertions(+), 4 deletions(-)\n\nOops. Thank you for finding and fixing, it is much appreciated.\n\nThanks,\nTaylor\n"}]}