{"thread":{"id":"61731","subject":"[PATCH] doc: fix the max number of git show-branches shown","startedAt":"2024-07-03T22:36:28Z","lastAt":"2024-07-08T15:29:47Z","messageCount":12,"participants":["wonda-tea-coffee via GitGitGadget","Jeff King","Junio C Hamano","Rikita Ishikawa via GitGitGadget","rikita ishikawa"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"498063","messageId":"pull.1757.git.1720046185710.gitgitgadget@gmail.com","threadId":"61731","inReplyTo":null,"subject":"[PATCH] doc: fix the max number of git show-branches shown","fromName":"wonda-tea-coffee via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-07-03T22:36:25Z","receivedAt":"2024-07-03T22:36:28Z","isPatch":true,"sender":{"key":"name:wonda-tea-coffee","avatar":null},"body":"From: wonda-tea-coffee \n\nContrary to the number listed in the current document,\nonly 26 are actually shown.\n\nSigned-off-by: wonda-tea-coffee \n---\n doc: fix the max number of git show-branches shown\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1757%2Fwonda-tea-coffee%2Fupdate-git-show-branch-description-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1757/wonda-tea-coffee/update-git-show-branch-description-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1757\n\n Documentation/git-show-branch.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-show-branch.txt b/Documentation/git-show-branch.txt\nindex c771c897707..bc31d8b6d33 100644\n--- a/Documentation/git-show-branch.txt\n+++ b/Documentation/git-show-branch.txt\n@@ -22,7 +22,7 @@ Shows the commit ancestry graph starting from the commits named\n with s or s (or all refs under refs/heads\n and/or refs/tags) semi-visually.\n \n-It cannot show more than 29 branches and commits at a time.\n+It cannot show more than 26 branches and commits at a time.\n \n It uses `showbranch.default` multi-valued configuration items if\n no or is given on the command line.\n\nbase-commit: 06e570c0dfb2a2deb64d217db78e2ec21672f558\n-- \ngitgitgadget\n"},{"id":"498149","messageId":"20240706062701.GC700645@coredump.intra.peff.net","threadId":"61731","inReplyTo":"pull.1757.git.1720046185710.gitgitgadget@gmail.com","subject":"Re: [PATCH] doc: fix the max number of git show-branches shown","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2024-07-06T06:27:01Z","receivedAt":"2024-07-06T06:27:03Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Wed, Jul 03, 2024 at 10:36:25PM +0000, wonda-tea-coffee via GitGitGadget wrote:\n\n> From: wonda-tea-coffee \n> \n> Contrary to the number listed in the current document,\n> only 26 are actually shown.\n\nThe commit message would be a good place to explain how we know \"26\" is\nthe right number. ;)\n\nIt looks like this is computed at build-time based on FLAG_BITS:\n\n #define REV_SHIFT 2\n #define MAX_REVS (FLAG_BITS - REV_SHIFT) /* should not exceed bits_per_int - REV_SHIFT */\n\nThat's defined in object.h. Looking at \"git log -GFLAG_BITS object.h\",\nit seems it was 27, then 29, and now 28. So I'm not sure how it was ever\n29, but 26 makes sense now.\n\nIt is unfortunate that it _could_ change again without us realizing the\ndocumentation is now stale. But I don't think it's something we'd touch\nvery often, so this is probably OK in practice (and as the TODO above\nthose lines says, ultimately this should use a commit-slab to handle an\narbitrary number of refs).\n\n> Signed-off-by: wonda-tea-coffee \n\nWe generally want a real name here, since this is certifying that you\nagree to the DCO. See:\n\n https://git-scm.com/docs/SubmittingPatches#sign-off\n\n-Peff\n"},{"id":"498162","messageId":"pull.1757.v2.git.1720259599119.gitgitgadget@gmail.com","threadId":"61731","inReplyTo":"pull.1757.git.1720046185710.gitgitgadget@gmail.com","subject":"[PATCH v2] doc: fix the max number of git show-branches shown","fromName":"wonda-tea-coffee via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-07-06T09:53:18Z","receivedAt":"2024-07-06T09:53:23Z","isPatch":true,"sender":{"key":"name:wonda-tea-coffee","avatar":null},"body":"From: wonda-tea-coffee \n\nThe number to be displayed is calculated by the\nfollowing defined in object.h.\n\n```\n #define REV_SHIFT 2\n #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n```\n\nFLAG_BITS is currently 28, so 26 is the correct\nnumber.\n\nSigned-off-by: Rikita Ishikawa \n---\n doc: fix the max number of git show-branches shown\n \n Changes since v1:\n \n * Explain in the commit message why \"26\" is the correct number.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1757%2Fwonda-tea-coffee%2Fupdate-git-show-branch-description-v2\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1757/wonda-tea-coffee/update-git-show-branch-description-v2\nPull-Request: https://github.com/gitgitgadget/git/pull/1757\n\nRange-diff vs v1:\n\n 1: b809d610a36 ! 1: 6fc335807d2 doc: fix the max number of git show-branches shown\n @@ Metadata\n ## Commit message ##\n doc: fix the max number of git show-branches shown\n \n - Contrary to the number listed in the current document,\n - only 26 are actually shown.\n + The number to be displayed is calculated by the\n + following defined in object.h.\n \n - Signed-off-by: wonda-tea-coffee \n + ```\n + #define REV_SHIFT 2\n + #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n + ```\n +\n + FLAG_BITS is currently 28, so 26 is the correct\n + number.\n +\n + Signed-off-by: Rikita Ishikawa \n \n ## Documentation/git-show-branch.txt ##\n @@ Documentation/git-show-branch.txt: Shows the commit ancestry graph starting from the commits named\n\n\n Documentation/git-show-branch.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-show-branch.txt b/Documentation/git-show-branch.txt\nindex c771c897707..bc31d8b6d33 100644\n--- a/Documentation/git-show-branch.txt\n+++ b/Documentation/git-show-branch.txt\n@@ -22,7 +22,7 @@ Shows the commit ancestry graph starting from the commits named\n with s or s (or all refs under refs/heads\n and/or refs/tags) semi-visually.\n \n-It cannot show more than 29 branches and commits at a time.\n+It cannot show more than 26 branches and commits at a time.\n \n It uses `showbranch.default` multi-valued configuration items if\n no or is given on the command line.\n\nbase-commit: 06e570c0dfb2a2deb64d217db78e2ec21672f558\n-- \ngitgitgadget\n"},{"id":"498172","messageId":"xmqqplrqpeio.fsf@gitster.g","threadId":"61731","inReplyTo":"20240706062701.GC700645@coredump.intra.peff.net","subject":"Re: [PATCH] doc: fix the max number of git show-branches shown","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-07-06T18:21:51Z","receivedAt":"2024-07-06T18:21:56Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff King writes:\n\n> It looks like this is computed at build-time based on FLAG_BITS:\n>\n> #define REV_SHIFT 2\n> #define MAX_REVS (FLAG_BITS - REV_SHIFT) /* should not exceed bits_per_int - REV_SHIFT */\n>\n> That's defined in object.h. Looking at \"git log -GFLAG_BITS object.h\",\n> it seems it was 27, then 29, and now 28. So I'm not sure how it was ever\n> 29, but 26 makes sense now.\n\nOriginally it was bits-per-word minus REV_SHIFT -- back then we\ndidn't even have FLAG_BITS.\n\n> It is unfortunate that it _could_ change again without us realizing the\n> documentation is now stale. But I don't think it's something we'd touch\n> very often, so this is probably OK in practice (and as the TODO above\n> those lines says, ultimately this should use a commit-slab to handle an\n> arbitrary number of refs).\n\nYup, I was hoping I can craft a response that tricks somebody\n(preferrably those who are not too experienced, as it should be too\neasy for some of the experienced ones) into tackling that TODO item,\nbut you responded before I did ;-).\n\n>> Signed-off-by: wonda-tea-coffee \n>\n> We generally want a real name here, since this is certifying that you\n> agree to the DCO. See:\n>\n> https://git-scm.com/docs/SubmittingPatches#sign-off\n\nAnother rule is that the name used to sign-off and the name of the\nauthor of the patch on \"From: \" line must match.\n\nThanks. I was getting tired of the only person to point it out to\nnew contributors.\n\n"},{"id":"498183","messageId":"20240706231451.GD746087@coredump.intra.peff.net","threadId":"61731","inReplyTo":"pull.1757.v2.git.1720259599119.gitgitgadget@gmail.com","subject":"Re: [PATCH v2] doc: fix the max number of git show-branches shown","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2024-07-06T23:14:51Z","receivedAt":"2024-07-06T23:14:52Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sat, Jul 06, 2024 at 09:53:18AM +0000, wonda-tea-coffee via GitGitGadget wrote:\n\n> From: wonda-tea-coffee \n> \n> The number to be displayed is calculated by the\n> following defined in object.h.\n> \n> ```\n> #define REV_SHIFT 2\n> #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n> ```\n> \n> FLAG_BITS is currently 28, so 26 is the correct\n> number.\n> \n> Signed-off-by: Rikita Ishikawa \n\nThanks, this version looks good to me. As Junio noted, we'd generally\nwant the \"From\" to match the Sign-off (where the former is coming from\nthe author name in the commit). You can either re-send, or if you give\nthe OK, he might just fix it up as he applies.\n\n-Peff\n"},{"id":"498184","messageId":"pull.1757.v3.git.1720318768439.gitgitgadget@gmail.com","threadId":"61731","inReplyTo":"pull.1757.v2.git.1720259599119.gitgitgadget@gmail.com","subject":"[PATCH v3] doc: fix the max number of git show-branches shown","fromName":"Rikita Ishikawa via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-07-07T02:19:28Z","receivedAt":"2024-07-07T02:19:32Z","isPatch":true,"sender":{"key":"name:Rikita Ishikawa","avatar":null},"body":"From: wonda-tea-coffee \n\nThe number to be displayed is calculated by the\nfollowing defined in object.h.\n\n```\n #define REV_SHIFT 2\n #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n```\n\nFLAG_BITS is currently 28, so 26 is the correct\nnumber.\n\nSigned-off-by: Rikita Ishikawa \n---\n doc: fix the max number of git show-branches shown\n \n Changes since v1:\n \n * Explain in the commit message why \"26\" is the correct number.\n * No change (to rename GitHub and re-send).\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1757%2Fwonda-tea-coffee%2Fupdate-git-show-branch-description-v3\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1757/wonda-tea-coffee/update-git-show-branch-description-v3\nPull-Request: https://github.com/gitgitgadget/git/pull/1757\n\nRange-diff vs v2:\n\n 1: 6fc335807d2 = 1: c1e236d843c doc: fix the max number of git show-branches shown\n\n\n Documentation/git-show-branch.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-show-branch.txt b/Documentation/git-show-branch.txt\nindex c771c897707..bc31d8b6d33 100644\n--- a/Documentation/git-show-branch.txt\n+++ b/Documentation/git-show-branch.txt\n@@ -22,7 +22,7 @@ Shows the commit ancestry graph starting from the commits named\n with s or s (or all refs under refs/heads\n and/or refs/tags) semi-visually.\n \n-It cannot show more than 29 branches and commits at a time.\n+It cannot show more than 26 branches and commits at a time.\n \n It uses `showbranch.default` multi-valued configuration items if\n no or is given on the command line.\n\nbase-commit: 06e570c0dfb2a2deb64d217db78e2ec21672f558\n-- \ngitgitgadget\n"},{"id":"498185","messageId":"pull.1757.v4.git.1720319311301.gitgitgadget@gmail.com","threadId":"61731","inReplyTo":"pull.1757.v3.git.1720318768439.gitgitgadget@gmail.com","subject":"[PATCH v4] doc: fix the max number of git show-branches shown","fromName":"Rikita Ishikawa via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-07-07T02:28:31Z","receivedAt":"2024-07-07T02:28:34Z","isPatch":true,"sender":{"key":"name:Rikita Ishikawa","avatar":null},"body":"From: Rikita Ishikawa \n\nThe number to be displayed is calculated by the\nfollowing defined in object.h.\n\n```\n #define REV_SHIFT 2\n #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n```\n\nFLAG_BITS is currently 28, so 26 is the correct\nnumber.\n\nSigned-off-by: Rikita Ishikawa \n---\n doc: fix the max number of git show-branches shown\n \n Changes since v1:\n \n * Explain in the commit message why \"26\" is the correct number.\n * No change (to rename GitHub and re-send).\n * Change the author of the commit.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1757%2Fwonda-tea-coffee%2Fupdate-git-show-branch-description-v4\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1757/wonda-tea-coffee/update-git-show-branch-description-v4\nPull-Request: https://github.com/gitgitgadget/git/pull/1757\n\nRange-diff vs v3:\n\n 1: c1e236d843c ! 1: 76ab2f17015 doc: fix the max number of git show-branches shown\n @@\n ## Metadata ##\n -Author: wonda-tea-coffee \n +Author: Rikita Ishikawa \n \n ## Commit message ##\n doc: fix the max number of git show-branches shown\n\n\n Documentation/git-show-branch.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-show-branch.txt b/Documentation/git-show-branch.txt\nindex c771c897707..bc31d8b6d33 100644\n--- a/Documentation/git-show-branch.txt\n+++ b/Documentation/git-show-branch.txt\n@@ -22,7 +22,7 @@ Shows the commit ancestry graph starting from the commits named\n with s or s (or all refs under refs/heads\n and/or refs/tags) semi-visually.\n \n-It cannot show more than 29 branches and commits at a time.\n+It cannot show more than 26 branches and commits at a time.\n \n It uses `showbranch.default` multi-valued configuration items if\n no or is given on the command line.\n\nbase-commit: 06e570c0dfb2a2deb64d217db78e2ec21672f558\n-- \ngitgitgadget\n"},{"id":"498186","messageId":"CAKPZ46fzz3PyLhSXU8RrzfBbWSSH34hcLz9wVvErNsfF6vH-_A@mail.gmail.com","threadId":"61731","inReplyTo":"pull.1757.v4.git.1720319311301.gitgitgadget@gmail.com","subject":"Re: [PATCH v4] doc: fix the max number of git show-branches shown","fromName":"rikita ishikawa","fromEmail":"lagrange.resolvent@gmail.com","sentAt":"2024-07-07T02:30:42Z","receivedAt":"2024-07-07T02:30:54Z","isPatch":true,"sender":{"key":"lagrange.resolvent@gmail.com","avatar":null},"body":"Sorry for sending in consecutive messages.\nI changed `From:`.\nThank you for following us often.\n\n2024年7月7日(日) 11:28 Rikita Ishikawa via GitGitGadget :\n>\n> From: Rikita Ishikawa \n>\n> The number to be displayed is calculated by the\n> following defined in object.h.\n>\n> ```\n> #define REV_SHIFT 2\n> #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n> ```\n>\n> FLAG_BITS is currently 28, so 26 is the correct\n> number.\n>\n> Signed-off-by: Rikita Ishikawa \n> ---\n> doc: fix the max number of git show-branches shown\n>\n> Changes since v1:\n>\n> * Explain in the commit message why \"26\" is the correct number.\n> * No change (to rename GitHub and re-send).\n> * Change the author of the commit.\n>\n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1757%2Fwonda-tea-coffee%2Fupdate-git-show-branch-description-v4\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1757/wonda-tea-coffee/update-git-show-branch-description-v4\n> Pull-Request: https://github.com/gitgitgadget/git/pull/1757\n>\n> Range-diff vs v3:\n>\n> 1: c1e236d843c ! 1: 76ab2f17015 doc: fix the max number of git show-branches shown\n> @@\n> ## Metadata ##\n> -Author: wonda-tea-coffee \n> +Author: Rikita Ishikawa \n>\n> ## Commit message ##\n> doc: fix the max number of git show-branches shown\n>\n>\n> Documentation/git-show-branch.txt | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/Documentation/git-show-branch.txt b/Documentation/git-show-branch.txt\n> index c771c897707..bc31d8b6d33 100644\n> --- a/Documentation/git-show-branch.txt\n> +++ b/Documentation/git-show-branch.txt\n> @@ -22,7 +22,7 @@ Shows the commit ancestry graph starting from the commits named\n> with s or s (or all refs under refs/heads\n> and/or refs/tags) semi-visually.\n>\n> -It cannot show more than 29 branches and commits at a time.\n> +It cannot show more than 26 branches and commits at a time.\n>\n> It uses `showbranch.default` multi-valued configuration items if\n> no or is given on the command line.\n>\n> base-commit: 06e570c0dfb2a2deb64d217db78e2ec21672f558\n> --\n> gitgitgadget\n"},{"id":"498214","messageId":"20240708085232.GA819836@coredump.intra.peff.net","threadId":"61731","inReplyTo":"pull.1757.v4.git.1720319311301.gitgitgadget@gmail.com","subject":"Re: [PATCH v4] doc: fix the max number of git show-branches shown","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2024-07-08T08:52:32Z","receivedAt":"2024-07-08T08:52:40Z","isPatch":true,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Sun, Jul 07, 2024 at 02:28:31AM +0000, Rikita Ishikawa via GitGitGadget wrote:\n\n> From: Rikita Ishikawa \n> \n> The number to be displayed is calculated by the\n> following defined in object.h.\n> \n> ```\n> #define REV_SHIFT 2\n> #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n> ```\n> \n> FLAG_BITS is currently 28, so 26 is the correct\n> number.\n> \n> Signed-off-by: Rikita Ishikawa \n> ---\n\nThanks, this version looks pretty good to me.\n\nOne minor nit: commit messages are not actually markdown (even when\nrendered on GitHub), so your ``` block delimiters are a bit unusual.\nWe'd usually just rely on the indentation and blank lines to show the\nstructure.\n\n-Peff\n"},{"id":"498244","messageId":"CAKPZ46d6Fv+=8f931Qrbec2-5rnGBDbZm1AhKhh78E31em71jA@mail.gmail.com","threadId":"61731","inReplyTo":"20240708085232.GA819836@coredump.intra.peff.net","subject":"Re: [PATCH v4] doc: fix the max number of git show-branches shown","fromName":"rikita ishikawa","fromEmail":"lagrange.resolvent@gmail.com","sentAt":"2024-07-08T13:01:33Z","receivedAt":"2024-07-08T13:01:47Z","isPatch":true,"sender":{"key":"lagrange.resolvent@gmail.com","avatar":null},"body":"Thanks for the feedback.\nI will fix it.\n"},{"id":"498246","messageId":"pull.1757.v5.git.1720444080034.gitgitgadget@gmail.com","threadId":"61731","inReplyTo":"pull.1757.v4.git.1720319311301.gitgitgadget@gmail.com","subject":"[PATCH v5] doc: fix the max number of git show-branches shown","fromName":"Rikita Ishikawa via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-07-08T13:07:59Z","receivedAt":"2024-07-08T13:08:03Z","isPatch":true,"sender":{"key":"name:Rikita Ishikawa","avatar":null},"body":"From: Rikita Ishikawa \n\nThe number to be displayed is calculated by the\nfollowing defined in object.h.\n\n #define REV_SHIFT 2\n #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n\nFLAG_BITS is currently 28, so 26 is the correct\nnumber.\n\nSigned-off-by: Rikita Ishikawa \n---\n doc: fix the max number of git show-branches shown\n \n Changes since v1:\n \n * Explain in the commit message why \"26\" is the correct number.\n * No change (to rename GitHub and re-send).\n * Change the author of the commit.\n * Fixed code block in commit message.\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1757%2Fwonda-tea-coffee%2Fupdate-git-show-branch-description-v5\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1757/wonda-tea-coffee/update-git-show-branch-description-v5\nPull-Request: https://github.com/gitgitgadget/git/pull/1757\n\nRange-diff vs v4:\n\n 1: 76ab2f17015 ! 1: 7c0af41794f doc: fix the max number of git show-branches shown\n @@ Commit message\n The number to be displayed is calculated by the\n following defined in object.h.\n \n - ```\n - #define REV_SHIFT 2\n - #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n - ```\n + #define REV_SHIFT 2\n + #define MAX_REVS (FLAG_BITS - REV_SHIFT)\n \n FLAG_BITS is currently 28, so 26 is the correct\n number.\n\n\n Documentation/git-show-branch.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-show-branch.txt b/Documentation/git-show-branch.txt\nindex c771c897707..bc31d8b6d33 100644\n--- a/Documentation/git-show-branch.txt\n+++ b/Documentation/git-show-branch.txt\n@@ -22,7 +22,7 @@ Shows the commit ancestry graph starting from the commits named\n with s or s (or all refs under refs/heads\n and/or refs/tags) semi-visually.\n \n-It cannot show more than 29 branches and commits at a time.\n+It cannot show more than 26 branches and commits at a time.\n \n It uses `showbranch.default` multi-valued configuration items if\n no or is given on the command line.\n\nbase-commit: 06e570c0dfb2a2deb64d217db78e2ec21672f558\n-- \ngitgitgadget\n"},{"id":"498271","messageId":"xmqqmsmrlx5m.fsf@gitster.g","threadId":"61731","inReplyTo":"pull.1757.v5.git.1720444080034.gitgitgadget@gmail.com","subject":"Re: [PATCH v5] doc: fix the max number of git show-branches shown","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-07-08T15:29:41Z","receivedAt":"2024-07-08T15:29:47Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"Rikita Ishikawa via GitGitGadget\" writes:\n\n> From: Rikita Ishikawa \n> ...\n> FLAG_BITS is currently 28, so 26 is the correct\n> number.\n>\n> Signed-off-by: Rikita Ishikawa \n\nLooking good. Thanks. Will queue.\n"}]}