{"thread":{"id":"61615","subject":"[Wishlist Bug] git-shell: Support libreadline","startedAt":"2024-06-10T13:52:25Z","lastAt":"2024-06-12T15:19:18Z","messageCount":3,"participants":["Marc-Jano Knopp","brian m. carlson"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"496773","messageId":"tovyij5wnnliqqn443n6ksjrnwgs7xthopxvqlieacix7jjdqg@2mnwgzlpj7fo","threadId":"61615","inReplyTo":null,"subject":"[Wishlist Bug] git-shell: Support libreadline","fromName":"Marc-Jano Knopp","fromEmail":"y--gitbugs@marc-jano.de","sentAt":"2024-06-10T13:42:42Z","receivedAt":"2024-06-10T13:52:25Z","isPatch":false,"sender":{"key":"y--gitbugs@marc-jano.de","avatar":null},"body":"Hi all!\n\n\nI would like git-shell to support libreadline:\n\n  https://tiswww.cwru.edu/php/chet/readline/rltop.html\n\n\n------------------- snip ---------------------\nThank you for filling out a Git bug report!\nPlease answer the following questions to help us understand your issue.\n\nWhat did you do before the bug happened? (Steps to reproduce your issue)\n\n  Live in peace.\n\nWhat did you expect to happen? (Expected behavior)\n\n  git-shell letting me edit the input (Emacs/vi/cursor-keys) and\n  access the command history.\n\nWhat happened instead? (Actual behavior)\n\n  git-shell gave me Thompson shell vibes and sent me into foul-mouthed\n  screaming tantrums.\n\nWhat's different between what you expected and what actually happened?\n\n  Expected libreadline support, got sent to labor camp instead.\n\nAnything else you want to add:\n\n  I installed git-shell as the shell for git users on a git server,\n  and filled /usr/local/share/git-shell-commands with various shell\n  scripts for git repository maintenance on that server. Having\n  git-shell support libreadline would much alleviate two common\n  scenarios:\n  - commands can be very quickly edited / fixed\n  - commands that have been executed before can be quickly accessed\n    and either re-executed or edited and executed, especially with\n    keybindings like\n\n    ,----[ ~/.inputrc ]---\n    | \"\\C-p\": history-search-backward\n    | \"\\C-n\": history-search-forward\n    `----\n\n    where you start typing \"foo\", then use C-p/n to go thru all commands\n    in history that start with \"foo\". Life saver.\n\n  Please either simply don't limit the command history (via\n  \"stifle_history()\"), or give users the possibility to define a maximum\n  of history lines.\n\n  Location of the history probably does not have to be configurable,\n  ~/.git-shell-history will do just fine (for me).\n\n  Thanks for considering this wish-list bug. :-}\n\n\nPlease review the rest of the bug report below.\nYou can delete any lines you don't wish to share.\n\n\n[System Info]\ngit version:\ngit version 2.39.2 {wanted to try 2.45.1 before reporting, but got shoved into dependency hell}\ncpu: x86_64\nno commit associated with this build\nsizeof-long: 8\nsizeof-size_t: 8\nshell-path: /bin/sh\nuname: Linux 6.1.0-21-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.90-1 (2024-05-03) x86_64\ncompiler info: gnuc: 12.2\nlibc info: glibc: 2.36\n$SHELL (typically, interactive shell): /usr/bin/zsh\n\n\n[Enabled Hooks]\nnot run from a git repository - no hooks to show\n------------------- snip ---------------------\n\n\nMJK (not subscribed, Cc: welcome)\n"},{"id":"496807","messageId":"Zmd1joZIqo217TBh@tapette.crustytoothpaste.net","threadId":"61615","inReplyTo":"tovyij5wnnliqqn443n6ksjrnwgs7xthopxvqlieacix7jjdqg@2mnwgzlpj7fo","subject":"Re: [Wishlist Bug] git-shell: Support libreadline","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2024-06-10T21:52:14Z","receivedAt":"2024-06-10T21:52:22Z","isPatch":false,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2024-06-10 at 13:42:42, Marc-Jano Knopp wrote:\n> Hi all!\n> \n> \n> I would like git-shell to support libreadline:\n> \n>   https://tiswww.cwru.edu/php/chet/readline/rltop.html\n\nUnfortunately, I don't think we can do that.  libreadline is GPLv3+, and\nGit is GPLv2, so it would violate the license to distribute a binary\nlinked that way.\n\nIt's possible that libeditline could be used instead to provide similar\nfeatures, though.  If it's important to you that this be implemented,\nyou can send a patch, or you can see if someone else is interested\nenough to do so.\n-- \nbrian m. carlson (they/them or he/him)\nToronto, Ontario, CA\n"},{"id":"497038","messageId":"h2cf4cqfmnxkogeliqjjnqxbthwbjwqaaqsgyu36rgjyetwdb4@6fgdhhuzsbet","threadId":"61615","inReplyTo":"Zmd1joZIqo217TBh@tapette.crustytoothpaste.net","subject":"Re: [Wishlist Bug] git-shell: Support libreadline","fromName":"Marc-Jano Knopp","fromEmail":"y--gitbugs@marc-jano.de","sentAt":"2024-06-12T15:19:08Z","receivedAt":"2024-06-12T15:19:18Z","isPatch":false,"sender":{"key":"y--gitbugs@marc-jano.de","avatar":null},"body":"On Mon, 2024-06-10, at 23:52:14 (+0200), brian m. carlson wrote:\n> On 2024-06-10 at 13:42:42, Marc-Jano Knopp wrote:\n> > Hi all!\n> > \n> > \n> > I would like git-shell to support libreadline:\n> > \n> >   https://tiswww.cwru.edu/php/chet/readline/rltop.html\n> \n> Unfortunately, I don't think we can do that.  libreadline is GPLv3+, and\n> Git is GPLv2, so it would violate the license to distribute a binary\n> linked that way.\n\nOh, it's a legal issue ... *sigh*\n\n\n> It's possible that libeditline could be used instead to provide similar\n> features, though.  If it's important to you that this be implemented,\n> you can send a patch, or you can see if someone else is interested\n> enough to do so.\n\nThanks for the hint!\n\n\nMJK\n"}]}