{"thread":{"id":"61498","subject":"[PATCH] t/t4202-log.sh: fix misspelled variable","startedAt":"2024-05-17T13:40:04Z","lastAt":"2024-05-17T13:40:04Z","messageCount":1,"participants":["Marcel Telka"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"494969","messageId":"ZkdeMLeDUsAAqYBL@telcontar","threadId":"61498","inReplyTo":null,"subject":"[PATCH] t/t4202-log.sh: fix misspelled variable","fromName":"Marcel Telka","fromEmail":"marcel@telka.sk","sentAt":"2024-05-17T13:40:00Z","receivedAt":"2024-05-17T13:40:04Z","isPatch":true,"sender":{"key":"marcel@telka.sk","avatar":"https://avatars.githubusercontent.com/u/3000173?v=4"},"body":"The GPGSSH_GOOD_SIGNATURE_TRUSTED variable was spelled as\nGOOD_SIGNATURE_TRUSTED and so the grep was used the null RE that\nmatches everything.\n\nSigned-off-by: Marcel Telka <marcel@telka.sk>\n---\n t/t4202-log.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t4202-log.sh b/t/t4202-log.sh\nindex 60fe60d761..86c695eb0a 100755\n--- a/t/t4202-log.sh\n+++ b/t/t4202-log.sh\n@@ -2022,7 +2022,7 @@ test_expect_success GPGSM 'log --graph --show-signature x509' '\n test_expect_success GPGSSH 'log --graph --show-signature ssh' '\n \ttest_config gpg.ssh.allowedSignersFile \"${GPGSSH_ALLOWED_SIGNERS}\" &&\n \tgit log --graph --show-signature -n1 signed-ssh >actual &&\n-\tgrep \"${GOOD_SIGNATURE_TRUSTED}\" actual\n+\tgrep \"${GPGSSH_GOOD_SIGNATURE_TRUSTED}\" actual\n '\n \n test_expect_success GPGSSH,GPGSSH_VERIFYTIME 'log shows failure on expired signature key' '\n"}]}