{"thread":{"id":"61485","subject":"[PATCH] t/t0211-trace2-perf.sh: fix typo patern -> pattern","startedAt":"2024-05-15T22:51:05Z","lastAt":"2024-05-16T15:40:26Z","messageCount":3,"participants":["Marcel Telka","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"494848","messageId":"ZkU8VAUnKx_SXU5U@telcontar","threadId":"61485","inReplyTo":null,"subject":"[PATCH] t/t0211-trace2-perf.sh: fix typo patern -> pattern","fromName":"Marcel Telka","fromEmail":"marcel@telka.sk","sentAt":"2024-05-15T22:51:00Z","receivedAt":"2024-05-15T22:51:05Z","isPatch":true,"sender":{"key":"marcel@telka.sk","avatar":"https://avatars.githubusercontent.com/u/3000173?v=4"},"body":"Signed-off-by: Marcel Telka <marcel@telka.sk>\n---\n t/t0211-trace2-perf.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\nindex 13ef69b92f..070fe7a5da 100755\n--- a/t/t0211-trace2-perf.sh\n+++ b/t/t0211-trace2-perf.sh\n@@ -233,7 +233,7 @@ have_counter_event () {\n \n \tpattern=\"d0|${thread}|${event}||||${category}|name:${name} value:${value}\" &&\n \n-\tgrep \"${patern}\" ${file}\n+\tgrep \"${pattern}\" ${file}\n }\n \n test_expect_success 'global counter test/test1' '\n"},{"id":"494850","messageId":"ZkWI9--gMH0Xgv3f@tanuki","threadId":"61485","inReplyTo":"ZkU8VAUnKx_SXU5U@telcontar","subject":"Re: [PATCH] t/t0211-trace2-perf.sh: fix typo patern -> pattern","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-05-16T04:17:59Z","receivedAt":"2024-05-16T04:18:04Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Thu, May 16, 2024 at 12:51:00AM +0200, Marcel Telka wrote:\n\nThanks for the patch, which looks obviously good to me. It would be nice\nto have a short explanation in the commit message that explains why this\nissue was able to sneak.\n\nPatrick\n\n> Signed-off-by: Marcel Telka <marcel@telka.sk>\n> ---\n>  t/t0211-trace2-perf.sh | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\n> index 13ef69b92f..070fe7a5da 100755\n> --- a/t/t0211-trace2-perf.sh\n> +++ b/t/t0211-trace2-perf.sh\n> @@ -233,7 +233,7 @@ have_counter_event () {\n>  \n>  \tpattern=\"d0|${thread}|${event}||||${category}|name:${name} value:${value}\" &&\n>  \n> -\tgrep \"${patern}\" ${file}\n> +\tgrep \"${pattern}\" ${file}\n>  }\n>  \n>  test_expect_success 'global counter test/test1' '\n> \n"},{"id":"494895","messageId":"xmqq34qhu5qo.fsf@gitster.g","threadId":"61485","inReplyTo":"ZkWI9--gMH0Xgv3f@tanuki","subject":"Re: [PATCH] t/t0211-trace2-perf.sh: fix typo patern -> pattern","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-05-16T15:38:23Z","receivedAt":"2024-05-16T15:40:26Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt <ps@pks.im> writes:\n\n> On Thu, May 16, 2024 at 12:51:00AM +0200, Marcel Telka wrote:\n>\n> Thanks for the patch, which looks obviously good to me. It would be nice\n> to have a short explanation in the commit message that explains why this\n> issue was able to sneak.\n>\n> Patrick\n\nA good piece of advice.\n\nFYI, I have the following since last night, as the original report\nwas whitespace damaged and did not apply.\n\n-------- >8 --------------- >8 --------------- >8 --------\nSubject: [PATCH] t0211: typofix\n\nMarcel Telka noticed that one test assigns to $pattern and then\nuses $patern in an invocation of \"grep\".  Of course, looking for\nan empty string will succeed, so the test succeeds for a wrong\nreason.\n\nSigned-off-by: Junio C Hamano <gitster@pobox.com>\n---\n t/t0211-trace2-perf.sh | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh\nindex 0b3436e8ca..37a51e6449 100755\n--- a/t/t0211-trace2-perf.sh\n+++ b/t/t0211-trace2-perf.sh\n@@ -233,7 +233,7 @@ have_counter_event () {\n \n \tpattern=\"d0|${thread}|${event}||||${category}|name:${name} value:${value}\" &&\n \n-\tgrep \"${patern}\" ${file}\n+\tgrep \"${pattern}\" ${file}\n }\n \n test_expect_success 'global counter test/test1' '\n-- \n2.45.1-190-g19fe900cfc\n"}]}