{"thread":{"id":"61480","subject":"t0211-trace2-perf.sh: typo patern -> pattern","startedAt":"2024-05-15T14:42:26Z","lastAt":"2024-05-15T17:09:51Z","messageCount":4,"participants":["Marcel Telka","Junio C Hamano","Jeff Hostetler"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"494819","messageId":"ZkTIPlTS4jcQ-rHX@telcontar","threadId":"61480","inReplyTo":null,"subject":"t0211-trace2-perf.sh: typo patern -> pattern","fromName":"Marcel Telka","fromEmail":"marcel@telka.sk","sentAt":"2024-05-15T14:35:42Z","receivedAt":"2024-05-15T14:42:26Z","isPatch":false,"sender":{"key":"marcel@telka.sk","avatar":"https://avatars.githubusercontent.com/u/3000173?v=4"},"body":"Hi,\n\nThere seems to be apparent typo in the t/t0211-trace2-perf.sh file:\n\n\n--- a/t/t0211-trace2-perf.sh\n+++ b/t/t0211-trace2-perf.sh\n@@ -233,7 +233,7 @@ have_counter_event () {\n \n        pattern=\"d0|${thread}|${event}||||${category}|name:${name} value:${value}\" &&\n \n-       grep \"${patern}\" ${file}\n+       grep \"${pattern}\" ${file}\n }\n \n test_expect_success 'global counter test/test1' '\n\n\nThanks.\n\n-- \n+-------------------------------------------+\n| Marcel Telka   e-mail:   marcel@telka.sk  |\n|                homepage: http://telka.sk/ |\n+-------------------------------------------+\n"},{"id":"494828","messageId":"xmqqjzjvxbk0.fsf@gitster.g","threadId":"61480","inReplyTo":"ZkTIPlTS4jcQ-rHX@telcontar","subject":"Re: t0211-trace2-perf.sh: typo patern -> pattern","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-05-15T16:52:15Z","receivedAt":"2024-05-15T16:52:20Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Marcel Telka <marcel@telka.sk> writes:\n\n> Hi,\n>\n> There seems to be apparent typo in the t/t0211-trace2-perf.sh file:\n>\n>\n> --- a/t/t0211-trace2-perf.sh\n> +++ b/t/t0211-trace2-perf.sh\n> @@ -233,7 +233,7 @@ have_counter_event () {\n>  \n>         pattern=\"d0|${thread}|${event}||||${category}|name:${name} value:${value}\" &&\n>  \n> -       grep \"${patern}\" ${file}\n> +       grep \"${pattern}\" ${file}\n>  }\n>  \n>  test_expect_success 'global counter test/test1' '\n\nAh, indeed, there is no assignment to the variable $patern so this\ngrep matches by looking for all the empty strings in the file X-<.\n\n"},{"id":"494829","messageId":"fe76b111-f080-5d1f-c51f-591e9381c116@jeffhostetler.com","threadId":"61480","inReplyTo":"xmqqjzjvxbk0.fsf@gitster.g","subject":"Re: t0211-trace2-perf.sh: typo patern -> pattern","fromName":"Jeff Hostetler","fromEmail":"git@jeffhostetler.com","sentAt":"2024-05-15T16:59:10Z","receivedAt":"2024-05-15T17:05:27Z","isPatch":false,"sender":{"key":"git@jeffhostetler.com","avatar":null},"body":"\n\nOn 5/15/24 12:52 PM, Junio C Hamano wrote:\n> Marcel Telka <marcel@telka.sk> writes:\n> \n>> Hi,\n>>\n>> There seems to be apparent typo in the t/t0211-trace2-perf.sh file:\n>>\n>>\n>> --- a/t/t0211-trace2-perf.sh\n>> +++ b/t/t0211-trace2-perf.sh\n>> @@ -233,7 +233,7 @@ have_counter_event () {\n>>   \n>>          pattern=\"d0|${thread}|${event}||||${category}|name:${name} value:${value}\" &&\n>>   \n>> -       grep \"${patern}\" ${file}\n>> +       grep \"${pattern}\" ${file}\n>>   }\n>>   \n>>   test_expect_success 'global counter test/test1' '\n> \n> Ah, indeed, there is no assignment to the variable $patern so this\n> grep matches by looking for all the empty strings in the file X-<.\n> \n> \n\nOOPS.\n\nThanks for the fix.\nJeff\n"},{"id":"494831","messageId":"xmqqr0e3vw6d.fsf@gitster.g","threadId":"61480","inReplyTo":"fe76b111-f080-5d1f-c51f-591e9381c116@jeffhostetler.com","subject":"Re: t0211-trace2-perf.sh: typo patern -> pattern","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-05-15T17:09:46Z","receivedAt":"2024-05-15T17:09:51Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Jeff Hostetler <git@jeffhostetler.com> writes:\n\n> On 5/15/24 12:52 PM, Junio C Hamano wrote:\n>> Marcel Telka <marcel@telka.sk> writes:\n>> \n>>> Hi,\n>>>\n>>> There seems to be apparent typo in the t/t0211-trace2-perf.sh file:\n>>>\n>>>\n>>> --- a/t/t0211-trace2-perf.sh\n>>> +++ b/t/t0211-trace2-perf.sh\n>>> @@ -233,7 +233,7 @@ have_counter_event () {\n>>>            pattern=\"d0|${thread}|${event}||||${category}|name:${name}\n>>> value:${value}\" &&\n>>>   -       grep \"${patern}\" ${file}\n>>> +       grep \"${pattern}\" ${file}\n>>>   }\n>>>     test_expect_success 'global counter test/test1' '\n>> Ah, indeed, there is no assignment to the variable $patern so this\n>> grep matches by looking for all the empty strings in the file X-<.\n>> \n>\n> OOPS.\n>\n> Thanks for the fix.\n\nNobody sent an applicable patch yet, though ;-)\n"}]}