{"thread":{"id":"61454","subject":"[PATCH] doc: git-update-index: add --show-index-version to synopsis","startedAt":"2024-05-10T18:36:40Z","lastAt":"2024-05-12T01:52:08Z","messageCount":3,"participants":["Dov Murik","Linus Arver"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"494486","messageId":"20240510183622.77750-1-dov.murik@linux.dev","threadId":"61454","inReplyTo":null,"subject":"[PATCH] doc: git-update-index: add --show-index-version to synopsis","fromName":"Dov Murik","fromEmail":"dov.murik@linux.dev","sentAt":"2024-05-10T18:36:22Z","receivedAt":"2024-05-10T18:36:40Z","isPatch":true,"sender":{"key":"dov.murik@linux.dev","avatar":"https://avatars.githubusercontent.com/u/9211?v=4"},"body":"Fixes: 606e088d5d9a (\"update-index: add --show-index-version\")\nSigned-off-by: Dov Murik \n---\n Documentation/git-update-index.txt | 1 +\n 1 file changed, 1 insertion(+)\n\ndiff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\nindex 8c47890a6a..7128aed540 100644\n--- a/Documentation/git-update-index.txt\n+++ b/Documentation/git-update-index.txt\n@@ -25,6 +25,7 @@ SYNOPSIS\n \t [--really-refresh] [--unresolve] [--again | -g]\n \t [--info-only] [--index-info]\n \t [-z] [--stdin] [--index-version ]\n+\t [--show-index-version]\n \t [--verbose]\n \t [--] [...]\n \n\nbase-commit: 3402c0e53fb798cb471dd6562eb5c938885b7295\n-- \n2.39.3 (Apple Git-146)\n\n"},{"id":"494529","messageId":"CAMo6p=GuLtJtwiS+N366ArFB2ejrYxnsy3S9Ud4tCeW=R5R57g@mail.gmail.com","threadId":"61454","inReplyTo":"20240510183622.77750-1-dov.murik@linux.dev","subject":"Re: [PATCH] doc: git-update-index: add --show-index-version to synopsis","fromName":"Linus Arver","fromEmail":"linusarver@gmail.com","sentAt":"2024-05-11T03:18:36Z","receivedAt":"2024-05-11T03:18:38Z","isPatch":true,"sender":{"key":"linusarver@gmail.com","avatar":"https://avatars.githubusercontent.com/u/725613?v=4"},"body":"Hi Dov,\n\nDov Murik writes:\n\n> Fixes: 606e088d5d9a (\"update-index: add --show-index-version\")\n\nI don't think this trailer is a standard one. Also, the \"fixes\" doesn't\nreally explain much. Perhaps you meant something like\n\n In 606e088d5d (update-index: add --show-index-version, 2023-09-12),\n we added the new '--show-index-version' option and documented it,\n but forgot to add it to the synopsis section. Do so now.\n\n?\n\n> Signed-off-by: Dov Murik \n> ---\n> Documentation/git-update-index.txt | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\n> index 8c47890a6a..7128aed540 100644\n> --- a/Documentation/git-update-index.txt\n> +++ b/Documentation/git-update-index.txt\n> @@ -25,6 +25,7 @@ SYNOPSIS\n> \t [--really-refresh] [--unresolve] [--again | -g]\n> \t [--info-only] [--index-info]\n> \t [-z] [--stdin] [--index-version ]\n> +\t [--show-index-version]\n> \t [--verbose]\n> \t [--] [...]\n>\n>\n> base-commit: 3402c0e53fb798cb471dd6562eb5c938885b7295\n> --\n> 2.39.3 (Apple Git-146)\n"},{"id":"494551","messageId":"ZkAgwBvwswcjZRrF@Transmit-DovM-Remote","threadId":"61454","inReplyTo":"CAMo6p=GuLtJtwiS+N366ArFB2ejrYxnsy3S9Ud4tCeW=R5R57g@mail.gmail.com","subject":"Re: [PATCH] doc: git-update-index: add --show-index-version to synopsis","fromName":"Dov Murik","fromEmail":"dov.murik@linux.dev","sentAt":"2024-05-12T01:52:00Z","receivedAt":"2024-05-12T01:52:08Z","isPatch":true,"sender":{"key":"dov.murik@linux.dev","avatar":"https://avatars.githubusercontent.com/u/9211?v=4"},"body":"Hi Linus,\n\nThank you for looking at this patch.\n\n\n\nOn Fri, May 10, 2024 at 10:18:36PM -0500, Linus Arver wrote:\n> Hi Dov,\n> \n> Dov Murik writes:\n> \n> > Fixes: 606e088d5d9a (\"update-index: add --show-index-version\")\n> \n> I don't think this trailer is a standard one.\n\nI saw it in Linux kernel patches. From [1]:\n\n A Fixes: tag indicates that the patch fixes an issue in a previous\n commit. It is used to make it easy to determine where a bug\n originated, which can help review a bug fix. This tag also assists\n the stable kernel team in determining which stable kernel versions\n should receive your fix. This is the preferred method for indicating\n a bug fixed by the patch.\n\nBut I now understand it is not used in git patches; sorry about that.\n\n[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html\n\n\n\n> Also, the \"fixes\" doesn't\n> really explain much. Perhaps you meant something like\n> \n> In 606e088d5d (update-index: add --show-index-version, 2023-09-12),\n> we added the new '--show-index-version' option and documented it,\n> but forgot to add it to the synopsis section. Do so now.\n> \n> ?\n\nYes, the explicit explanation is clearer. Thank you.\n\nI'll submit a v2 with a clearer commit message.\n\n-Dov\n\n\n\n\n> \n> > Signed-off-by: Dov Murik \n> > ---\n> > Documentation/git-update-index.txt | 1 +\n> > 1 file changed, 1 insertion(+)\n> >\n> > diff --git a/Documentation/git-update-index.txt b/Documentation/git-update-index.txt\n> > index 8c47890a6a..7128aed540 100644\n> > --- a/Documentation/git-update-index.txt\n> > +++ b/Documentation/git-update-index.txt\n> > @@ -25,6 +25,7 @@ SYNOPSIS\n> > \t [--really-refresh] [--unresolve] [--again | -g]\n> > \t [--info-only] [--index-info]\n> > \t [-z] [--stdin] [--index-version ]\n> > +\t [--show-index-version]\n> > \t [--verbose]\n> > \t [--] [...]\n> >\n> >\n> > base-commit: 3402c0e53fb798cb471dd6562eb5c938885b7295\n> > --\n> > 2.39.3 (Apple Git-146)\n"}]}