{"thread":{"id":"61450","subject":"Error: failed to store: -25299","startedAt":"2024-05-10T07:52:36Z","lastAt":"2024-05-22T02:37:51Z","messageCount":6,"participants":["ryenus","Jeff King","brian m. carlson","Koji Nakamaru"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"494396","messageId":"CAKkAvazeFvCfT7tZm3emwA=k-NnzPD7X0v4t2E9Ja4r-GpZfoQ@mail.gmail.com","threadId":"61450","inReplyTo":null,"subject":"Error: failed to store: -25299","fromName":"ryenus","fromEmail":"ryenus@gmail.com","sentAt":"2024-05-10T07:52:25Z","receivedAt":"2024-05-10T07:52:36Z","isPatch":false,"sender":{"key":"ryenus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/610161?v=4"},"body":"Command I run: `parallel git -C {} fetch ::: repo1 repo2 rep3`, which is\nto fetch multiple repositories in parallel using GNU parallel.\n\nThis worked pretty well for me in the past, however with git version\n2.45, maybe 2.44 as well, it would randomly emit below error:\n\n> failed to store: -25299\n\nOR\n\n> Already up to date.\n> failed to store: -25299\n> failed to store: -25299\n\nThis is on a Macbook with multiple cores. And it seems to happen to a\nrandom subset of the chosen repositories.\n\nBut if I do this without GNU parallel, or `parallel -j1` with only\none worker, things work just fine.\nAnd when I switched back to git 2.43.2, I don't see such error either.\n"},{"id":"494522","messageId":"20240510221323.GA1971112@coredump.intra.peff.net","threadId":"61450","inReplyTo":"CAKkAvazeFvCfT7tZm3emwA=k-NnzPD7X0v4t2E9Ja4r-GpZfoQ@mail.gmail.com","subject":"Re: Error: failed to store: -25299","fromName":"Jeff King","fromEmail":"peff@peff.net","sentAt":"2024-05-10T22:13:23Z","receivedAt":"2024-05-10T22:13:24Z","isPatch":false,"sender":{"key":"peff@peff.net","avatar":"https://avatars.githubusercontent.com/u/45925?v=4"},"body":"On Fri, May 10, 2024 at 03:52:25PM +0800, ryenus wrote:\n\n> Command I run: `parallel git -C {} fetch ::: repo1 repo2 rep3`, which is\n> to fetch multiple repositories in parallel using GNU parallel.\n> \n> This worked pretty well for me in the past, however with git version\n> 2.45, maybe 2.44 as well, it would randomly emit below error:\n> \n> > failed to store: -25299\n\nThere's some related discussion over in:\n\n  https://lore.kernel.org/git/pull.1729.git.1715328467099.gitgitgadget@gmail.com/\n\nBut most curious to me is:\n\n> But if I do this without GNU parallel, or `parallel -j1` with only\n> one worker, things work just fine.\n> And when I switched back to git 2.43.2, I don't see such error either.\n\nI would have assumed this was an issue going back to 2011, since each of\nthose fetches is going to try storing the successful credential. But if\nolder-but-recent versions of Git did not have the problem, it could be\nthat we are being more aggressive about invoking storage for some\nreason. Can you bisect?\n\nThe obvious recent changes to the credential code were brian's\ncapability/state series, but those are not yet in a released version\n(and from a quick scan I did not see anything that would obviously\nchange things there).\n\n-Peff\n"},{"id":"494526","messageId":"Zj6nFPQBKJg8q7JV@tapette.crustytoothpaste.net","threadId":"61450","inReplyTo":"20240510221323.GA1971112@coredump.intra.peff.net","subject":"Re: Error: failed to store: -25299","fromName":"brian m. carlson","fromEmail":"sandals@crustytoothpaste.net","sentAt":"2024-05-10T23:00:36Z","receivedAt":"2024-05-10T23:00:46Z","isPatch":false,"sender":{"key":"sandals@crustytoothpaste.net","avatar":"https://avatars.githubusercontent.com/u/497054?v=4"},"body":"On 2024-05-10 at 22:13:23, Jeff King wrote:\n> I would have assumed this was an issue going back to 2011, since each of\n> those fetches is going to try storing the successful credential. But if\n> older-but-recent versions of Git did not have the problem, it could be\n> that we are being more aggressive about invoking storage for some\n> reason. Can you bisect?\n> \n> The obvious recent changes to the credential code were brian's\n> capability/state series, but those are not yet in a released version\n> (and from a quick scan I did not see anything that would obviously\n> change things there).\n\nYeah, this sounds like a change to the osxkeychain helper.  There were\nsome changes there in 2.45 that could in theory be related that weren't\nin 2.43 or 2.44, but I must admit not being very familiar with the macOS\nkeychain tooling, so it's hard for me to say for certain.\n\nMy changes aren't in a released version and I haven't touched the\nosxkeychain helper (since I don't have a Mac), so I think it's unlikely\nto be related, but of course if someone finds a bug, I'm very open to\nfixing it.\n-- \nbrian m. carlson (they/them or he/him)\nToronto, Ontario, CA\n"},{"id":"494629","messageId":"CAKkAvaxFbcLZNdz5cdAF8ZFNtVT1qQYKWcmkniQ3Uzu8mdEt5w@mail.gmail.com","threadId":"61450","inReplyTo":"20240510221323.GA1971112@coredump.intra.peff.net","subject":"Re: Error: failed to store: -25299","fromName":"ryenus","fromEmail":"ryenus@gmail.com","sentAt":"2024-05-13T11:43:24Z","receivedAt":"2024-05-13T11:43:36Z","isPatch":false,"sender":{"key":"ryenus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/610161?v=4"},"body":"On Sat, 11 May 2024 at 06:13, Jeff King <peff@peff.net> wrote:\n>\n> On Fri, May 10, 2024 at 03:52:25PM +0800, ryenus wrote:\n>\n> > Command I run: `parallel git -C {} fetch ::: repo1 repo2 rep3`, which is\n> > to fetch multiple repositories in parallel using GNU parallel.\n> >\n> > This worked pretty well for me in the past, however with git version\n> > 2.45, maybe 2.44 as well, it would randomly emit below error:\n> >\n> > > failed to store: -25299\n>\n> There's some related discussion over in:\n>\n>   https://lore.kernel.org/git/pull.1729.git.1715328467099.gitgitgadget@gmail.com/\n>\n> But most curious to me is:\n>\n> > But if I do this without GNU parallel, or `parallel -j1` with only\n> > one worker, things work just fine.\n> > And when I switched back to git 2.43.2, I don't see such error either.\n>\n> I would have assumed this was an issue going back to 2011, since each of\n> those fetches is going to try storing the successful credential. But if\n> older-but-recent versions of Git did not have the problem, it could be\n> that we are being more aggressive about invoking storage for some\n> reason. Can you bisect?\n>\n> The obvious recent changes to the credential code were brian's\n> capability/state series, but those are not yet in a released version\n> (and from a quick scan I did not see anything that would obviously\n> change things there).\n>\n> -Peff\n\n@Bo98, possible to share any insight? It appears related to the following patch:\n\n* osxkeychain: replace deprecated SecKeychain API [1]\n[1]: https://github.com/git/git/commit/9abe31f5f161be4d69118bdfae00103cd6efa510\n\nApologize if I'm guessing it wrong :-)\n"},{"id":"494630","messageId":"CAOTNsDzLAW_2C2vk4y+=GRvsHKZ_C+rEtorFAuoZaDu+jhQhdg@mail.gmail.com","threadId":"61450","inReplyTo":"CAKkAvaxFbcLZNdz5cdAF8ZFNtVT1qQYKWcmkniQ3Uzu8mdEt5w@mail.gmail.com","subject":"Re: Error: failed to store: -25299","fromName":"Koji Nakamaru","fromEmail":"koji.nakamaru@gree.net","sentAt":"2024-05-13T14:29:52Z","receivedAt":"2024-05-13T14:30:04Z","isPatch":false,"sender":{"key":"koji.nakamaru@gree.net","avatar":"https://avatars.githubusercontent.com/u/2645978?v=4"},"body":"The patch fixed error handling. This is the direct reason for the error.\n\ncf. https://github.com/git/git/commit/9abe31f5f161be4d69118bdfae00103cd6efa510#diff-9dc7db77a1c795b4849ac77ac8d618a75c85ff3b2128501ffa647c43df200d60R308-R314\n\n\nKoji Nakamaru\n"},{"id":"495260","messageId":"CAKkAvayTe7yU27G3HKZaG0Ch0gGDC50+sxonFQ08cPdDdHsKoQ@mail.gmail.com","threadId":"61450","inReplyTo":"CAOTNsDzLAW_2C2vk4y+=GRvsHKZ_C+rEtorFAuoZaDu+jhQhdg@mail.gmail.com","subject":"Re: Error: failed to store: -25299","fromName":"ryenus","fromEmail":"ryenus@gmail.com","sentAt":"2024-05-22T02:37:40Z","receivedAt":"2024-05-22T02:37:51Z","isPatch":false,"sender":{"key":"ryenus@gmail.com","avatar":"https://avatars.githubusercontent.com/u/610161?v=4"},"body":"On Mon, 13 May 2024 at 22:30, Koji Nakamaru <koji.nakamaru@gree.net> wrote:\n>\n> The patch fixed error handling. This is the direct reason for the error.\n>\n> cf. https://github.com/git/git/commit/9abe31f5f161be4d69118bdfae00103cd6efa510#diff-9dc7db77a1c795b4849ac77ac8d618a75c85ff3b2128501ffa647c43df200d60R308-R314\n>\n>\n> Koji Nakamaru\n\nJust checked with git 2.44.0 and it has no such issue.\nTherefore this is confirmed to be a regression in git 2.45.0\n\nI'd expect such error to be skipped and/or ignored, or even update the\nstore asynchronously, maybe with a config to customize the behavior.\n"}]}