{"thread":{"id":"61412","subject":"[PATCH] Win32: Fix building with NO_UNIX_SOCKETS","startedAt":"2024-05-03T09:15:01Z","lastAt":"2024-05-03T15:43:37Z","messageCount":3,"participants":["Mike Hommey","Johannes Schindelin","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"493972","messageId":"20240503091427.2808390-1-mh@glandium.org","threadId":"61412","inReplyTo":null,"subject":"[PATCH] Win32: Fix building with NO_UNIX_SOCKETS","fromName":"Mike Hommey","fromEmail":"mh@glandium.org","sentAt":"2024-05-03T09:14:27Z","receivedAt":"2024-05-03T09:15:01Z","isPatch":true,"sender":{"key":"mh@glandium.org","avatar":"https://avatars.githubusercontent.com/u/1038527?v=4"},"body":"After 2406bf5fc5 it fails with:\n\ncompat/mingw.c:4160:5: error: no previous prototype for function 'mingw_have_unix_sockets' [-Werror,-Wmissing-prototypes]\n   4160 | int mingw_have_unix_sockets(void)\n        |     ^\n\nbecause the prototype is behind `ifndef NO_UNIX_SOCKETS`\n\nSigned-off-by: Mike Hommey <mh@glandium.org>\n---\n compat/mingw.c | 2 ++\n 1 file changed, 2 insertions(+)\n\ndiff --git a/compat/mingw.c b/compat/mingw.c\nindex 4876344b5b..6b06ea540f 100644\n--- a/compat/mingw.c\n+++ b/compat/mingw.c\n@@ -3159,6 +3159,7 @@ int uname(struct utsname *buf)\n \treturn 0;\n }\n \n+#ifndef NO_UNIX_SOCKETS\n int mingw_have_unix_sockets(void)\n {\n \tSC_HANDLE scm, srvc;\n@@ -3177,3 +3178,4 @@ int mingw_have_unix_sockets(void)\n \t}\n \treturn ret;\n }\n+#endif\n-- \n2.45.0.1.ge6f3e402ce\n\n"},{"id":"493973","messageId":"47580fe5-6934-9a76-f927-d66c6c338143@gmx.de","threadId":"61412","inReplyTo":"20240503091427.2808390-1-mh@glandium.org","subject":"Re: [PATCH] Win32: Fix building with NO_UNIX_SOCKETS","fromName":"Johannes Schindelin","fromEmail":"johannes.schindelin@gmx.de","sentAt":"2024-05-03T09:26:04Z","receivedAt":"2024-05-03T09:26:13Z","isPatch":true,"sender":{"key":"johannes.schindelin@gmx.de","avatar":"https://avatars.githubusercontent.com/u/127790?v=4"},"body":"Hi Mike,\n\nOn Fri, 3 May 2024, Mike Hommey wrote:\n\n> After 2406bf5fc5 it fails with:\n>\n> compat/mingw.c:4160:5: error: no previous prototype for function 'mingw_have_unix_sockets' [-Werror,-Wmissing-prototypes]\n>    4160 | int mingw_have_unix_sockets(void)\n>         |     ^\n>\n> because the prototype is behind `ifndef NO_UNIX_SOCKETS`\n\nGood catch!\n\nAcked-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n\nThank you,\nJohannes\n\n>\n> Signed-off-by: Mike Hommey <mh@glandium.org>\n> ---\n>  compat/mingw.c | 2 ++\n>  1 file changed, 2 insertions(+)\n>\n> diff --git a/compat/mingw.c b/compat/mingw.c\n> index 4876344b5b..6b06ea540f 100644\n> --- a/compat/mingw.c\n> +++ b/compat/mingw.c\n> @@ -3159,6 +3159,7 @@ int uname(struct utsname *buf)\n>  \treturn 0;\n>  }\n>\n> +#ifndef NO_UNIX_SOCKETS\n>  int mingw_have_unix_sockets(void)\n>  {\n>  \tSC_HANDLE scm, srvc;\n> @@ -3177,3 +3178,4 @@ int mingw_have_unix_sockets(void)\n>  \t}\n>  \treturn ret;\n>  }\n> +#endif\n> --\n> 2.45.0.1.ge6f3e402ce\n>\n>\n"},{"id":"494010","messageId":"xmqqv83uaok9.fsf@gitster.g","threadId":"61412","inReplyTo":"47580fe5-6934-9a76-f927-d66c6c338143@gmx.de","subject":"Re: [PATCH] Win32: Fix building with NO_UNIX_SOCKETS","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-05-03T15:43:34Z","receivedAt":"2024-05-03T15:43:37Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:\n\n> Hi Mike,\n>\n> On Fri, 3 May 2024, Mike Hommey wrote:\n>\n>> After 2406bf5fc5 it fails with:\n>>\n>> compat/mingw.c:4160:5: error: no previous prototype for function 'mingw_have_unix_sockets' [-Werror,-Wmissing-prototypes]\n>>    4160 | int mingw_have_unix_sockets(void)\n>>         |     ^\n>>\n>> because the prototype is behind `ifndef NO_UNIX_SOCKETS`\n>\n> Good catch!\n>\n> Acked-by: Johannes Schindelin <johannes.schindelin@gmx.de>\n>\n> Thank you,\n> Johannes\n\nThanks, both.  Will queue.\n\n>\n>>\n>> Signed-off-by: Mike Hommey <mh@glandium.org>\n>> ---\n>>  compat/mingw.c | 2 ++\n>>  1 file changed, 2 insertions(+)\n>>\n>> diff --git a/compat/mingw.c b/compat/mingw.c\n>> index 4876344b5b..6b06ea540f 100644\n>> --- a/compat/mingw.c\n>> +++ b/compat/mingw.c\n>> @@ -3159,6 +3159,7 @@ int uname(struct utsname *buf)\n>>  \treturn 0;\n>>  }\n>>\n>> +#ifndef NO_UNIX_SOCKETS\n>>  int mingw_have_unix_sockets(void)\n>>  {\n>>  \tSC_HANDLE scm, srvc;\n>> @@ -3177,3 +3178,4 @@ int mingw_have_unix_sockets(void)\n>>  \t}\n>>  \treturn ret;\n>>  }\n>> +#endif\n>> --\n>> 2.45.0.1.ge6f3e402ce\n>>\n>>\n"}]}