{"thread":{"id":"61393","subject":"What's cooking in git.git (Apr 2024, #10; Mon, 29)","startedAt":"2024-04-29T17:22:40Z","lastAt":"2024-04-30T04:45:31Z","messageCount":4,"participants":["Junio C Hamano","Dragan Simic","Patrick Steinhardt","Linus Arver"],"isPatch":false,"patchVersion":null,"patchTotal":null},"messages":[{"id":"493662","messageId":"xmqqplu8ulra.fsf@gitster.g","threadId":"61393","inReplyTo":null,"subject":"What's cooking in git.git (Apr 2024, #10; Mon, 29)","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-04-29T17:22:33Z","receivedAt":"2024-04-29T17:22:40Z","isPatch":false,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Here are the topics that have been cooking in my tree. Commits\nprefixed with '+' are in 'next' (being in 'next' is a sign that a\ntopic is stable enough to be used and are candidate to be in a\nfuture release). Commits prefixed with '-' are only in 'seen', and\naren't considered \"accepted\" at all and may be annotated with an URL\nto a message that raises issues but they are no means exhaustive. A\ntopic without enough support may be discarded after a long period of\nno activity (of course they can be resubmit when new interests\narise).\n\nGit 2.45 has been tagged.\n\nCopies of the source code to Git live in many repositories, and the\nfollowing is a list of the ones I push into or their mirrors. Some\nrepositories have only a subset of branches.\n\nWith maint, master, next, seen, todo:\n\n\tgit://git.kernel.org/pub/scm/git/git.git/\n\tgit://repo.or.cz/alt-git.git/\n\thttps://kernel.googlesource.com/pub/scm/git/git/\n\thttps://github.com/git/git/\n\thttps://gitlab.com/git-scm/git/\n\nWith all the integration branches and topics broken out:\n\n\thttps://github.com/gitster/git/\n\nEven though the preformatted documentation in HTML and man format\nare not sources, they are published in these repositories for\nconvenience (replace \"htmldocs\" with \"manpages\" for the manual\npages):\n\n\tgit://git.kernel.org/pub/scm/git/git-htmldocs.git/\n\thttps://github.com/gitster/git-htmldocs.git/\n\nRelease tarballs are available at:\n\n\thttps://www.kernel.org/pub/software/scm/git/\n\n--------------------------------------------------\n[Graduated to 'master']\n\n* rj/add-i-leak-fix (2024-04-22) 4 commits\n (merged to 'next' on 2024-04-23 at b10e350a54)\n + add: plug a leak on interactive_add\n + add-patch: plug a leak handling the '/' command\n + add-interactive: plug a leak in get_untracked_files\n + apply: plug a leak in apply_data\n\n Leakfix.\n source: <69f86760-96ff-4c62-9649-4627652b7c19@gmail.com>\n\n\n* rs/vsnprintf-failure-is-not-a-bug (2024-04-21) 1 commit\n (merged to 'next' on 2024-04-23 at bf66ab6ea7)\n + don't report vsnprintf(3) error as bug\n\n Demote a BUG() to an die() when the failure from vsnprintf() may\n not be due to a programmer error.\n source: \n\n--------------------------------------------------\n[New Topics]\n\n* rh/complete-symbolic-ref (2024-04-25) 3 commits\n - completion: add docs on how to add subcommand completions\n - completion: improve docs for using __git_complete\n - completion: add 'symbolic-ref'\n\n Command line completion script (in contrib/) learned to complete\n \"git symbolic-ref\" a bit better (you need to enable plumbing\n commands to be completed with GIT_COMPLETION_SHOW_ALL_COMMANDS).\n\n Will merge to 'next'.\n source: <20240425101845.708554-3-rhi@pengutronix.de>\n\n\n* jt/doc-submitting-rerolled-series (2024-04-25) 1 commit\n - doc: clarify practices for submitting updated patch versions\n\n Developer doc update.\n\n Will merge to 'next'.\n source: <20240425213404.133660-1-jltobler@gmail.com>\n\n\n* bc/zsh-compatibility (2024-04-26) 2 commits\n - vimdiff: make script and tests work with zsh\n - t4046: avoid continue in &&-chain for zsh\n\n source: <20240426221154.2194139-1-sandals@crustytoothpaste.net>\n\n\n* jc/rev-parse-fatal-doc (2024-04-28) 1 commit\n - rev-parse: document that most of the time you need to be in a repository\n\n--------------------------------------------------\n[Cooking]\n\n* ps/undecided-is-not-necessarily-sha1 (2024-04-29) 13 commits\n - SQUASH???\n - repository: stop setting SHA1 as the default object hash\n - builtin/shortlog: don't set up revisions without repo\n - builtin/diff: explicitly set hash algo when there is no repo\n - builtin/bundle: abort \"verify\" early when there is no repository\n - builtin/blame: don't access potentially unitialized `the_hash_algo`\n - builtin/rev-parse: allow shortening to more than 40 hex characters\n - remote-curl: fix parsing of detached SHA256 heads\n - attr: fix BUG() when parsing attrs outside of repo\n - attr: don't recompute default attribute source\n - parse-options-cb: only abbreviate hashes when hash algo is known\n - path: move `validate_headref()` to its only user\n - path: harden validation of HEAD with non-standard hashes\n\n Before discovering the repository details, We used to assume SHA-1\n as the \"default\" hash function, which has been corrected. Hopefully\n this will smoke out codepaths that rely on such an unwarranted\n assumptions.\n\n fuzz-smoke-test job at GitHub Actions CI breaks with this in 'seen'\n cf. \n source: \n\n\n* aj/stash-staged-fix (2024-04-22) 1 commit\n (merged to 'next' on 2024-04-23 at d49e9dade0)\n + stash: fix \"--staged\" with binary files\n\n \"git stash -S\" did not handle binary files correctly, which has\n been corrected.\n\n Will cook in 'next'.\n source: \n\n\n* rj/add-p-typo-reaction (2024-04-26) 1 commit\n - add-patch: response to unknown command\n\n When the user responds to a prompt given by \"git add -p\" with an\n unsupported command, list of available commands were given, which\n was too much if the user knew what they wanted to type but merely\n made a typo. Now the user gets a much shorter error message.\n\n Expecting a reroll.\n cf. <305296f1-975b-41b9-968c-3984d8056196@gmail.com>\n source: \n\n\n* ds/format-patch-rfc-and-k (2024-04-19) 1 commit\n (merged to 'next' on 2024-04-23 at b3b0c5507a)\n + format-patch: ensure that --rfc and -k are mutually exclusive\n\n The \"-k\" and \"--rfc\" options of \"format-patch\" will now error out\n when used together, as one tells us not to add anything to the\n title of the commit, and the other one tells us to add \"RFC\" in\n addition to \"PATCH\".\n\n Will cook in 'next'.\n source: <71d195c248879e7c46fac0e84c6b0a8aa90bd2c2.1713488563.git.dsimic@manjaro.org>\n\n\n* jc/format-patch-rfc-more (2024-04-23) 2 commits\n (merged to 'next' on 2024-04-23 at 9f51487974)\n + format-patch: \"--rfc=-(WIP)\" appends to produce [PATCH (WIP)]\n + format-patch: allow --rfc to optionally take a value, like --rfc=WIP\n\n The \"--rfc\" option of \"git format-patch\" learned to take an\n optional string value to be used in place of \"RFC\" to tweak the\n \"[PATCH]\" on the subject header.\n\n Will cook in 'next'.\n source: <20240423175234.170434-1-gitster@pobox.com>\n\n\n* ps/the-index-is-no-more (2024-04-18) 6 commits\n - repository: drop `initialize_the_repository()`\n - repository: drop `the_index` variable\n - builtin/clone: stop using `the_index`\n - repository: initialize index in `repo_init()`\n - builtin: stop using `the_index`\n - t/helper: stop using `the_index`\n\n The singleton index_state instance \"the_index\" has been eliminated\n by always instantiating \"the_repository\" and replacing references\n to \"the_index\" with references to its .index member.\n\n Will merge to 'next'?\n source: \n\n\n* pw/rebase-m-signoff-fix (2024-04-18) 6 commits\n (merged to 'next' on 2024-04-23 at 66374c00e2)\n + rebase -m: fix --signoff with conflicts\n + sequencer: store commit message in private context\n + sequencer: move current fixups to private context\n + sequencer: start removing private fields from public API\n + sequencer: always free \"struct replay_opts\"\n + Merge branch 'pw/t3428-cleanup' into pw/rebase-m-signoff-fix\n\n \"git rebase --signoff\" used to forget that it needs to add a\n sign-off to the resulting commit when told to continue after a\n conflict stops its operation.\n\n Will cook in 'next'.\n source: \n\n\n* js/for-each-repo-keep-going (2024-04-24) 2 commits\n (merged to 'next' on 2024-04-25 at d33253d919)\n + maintenance: running maintenance should not stop on errors\n + for-each-repo: optionally keep going on an error\n\n A scheduled \"git maintenance\" job is expected to work on all\n repositories it knows about, but it stopped at the first one that\n errored out. Now it keeps going.\n\n Will cook in 'next'.\n source: \n\n\n* xx/disable-replace-when-building-midx (2024-04-17) 1 commit\n (merged to 'next' on 2024-04-23 at 6c8f41740e)\n + midx: disable replace objects\n\n The procedure to build multi-pack-index got confused by the\n replace-refs mechanism, which has been corrected by disabling the\n latter.\n\n Will cook in 'next'.\n source: \n\n\n* kn/update-ref-symrefs (2024-04-26) 7 commits\n - ref: support symrefs in 'reference-transaction' hook\n - update-ref: add support for 'symref-update' command\n - update-ref: add support for 'symref-create' command\n - update-ref: add support for 'symref-delete' command\n - update-ref: add support for 'symref-verify' command\n - files-backend: extract out `create_symref_lock`\n - refs: accept symref values in `ref_transaction[_add]_update`\n\n \"update-ref\" learns to also handle symbolic refs.\n\n Expecting a reroll.\n cf. \n source: <20240426152449.228860-1-knayak@gitlab.com>\n\n\n* la/doc-use-of-contacts-when-contributing (2024-04-18) 8 commits\n (merged to 'next' on 2024-04-25 at 5102a45f63)\n + SubmittingPatches: demonstrate using git-contacts with git-send-email\n + SubmittingPatches: add heading for format-patch and send-email\n + SubmittingPatches: dedupe discussion of security patches\n + SubmittingPatches: discuss reviewers first\n + SubmittingPatches: quote commands\n + SubmittingPatches: mention GitGitGadget\n + SubmittingPatches: clarify 'git-contacts' location\n + MyFirstContribution: mention contrib/contacts/git-contacts\n\n Advertise \"git contacts\", a tool for newcomers to find people to\n ask review for their patches, a bit more in our developer\n documentation.\n\n Will cook in 'next'.\n source: \n\n\n* ps/ci-test-with-jgit (2024-04-12) 13 commits\n - t0612: add tests to exercise Git/JGit reftable compatibility\n - t0610: fix non-portable variable assignment\n - t06xx: always execute backend-specific tests\n - ci: install JGit dependency\n - ci: make Perforce binaries executable for all users\n - ci: merge scripts which install dependencies\n - ci: fix setup of custom path for GitLab CI\n - ci: merge custom PATH directories\n - ci: convert \"install-dependencies.sh\" to use \"/bin/sh\"\n - ci: drop duplicate package installation for \"linux-gcc-default\"\n - ci: skip sudo when we are already root\n - ci: expose distro name in dockerized GitHub jobs\n - ci: rename \"runs_on_pool\" to \"distro\"\n\n Tests to ensure interoperability between reftable written by jgit\n and our code have been added and enabled in CI.\n\n Will merge to 'next'.\n source: \n\n\n* pw/rebase-i-error-message (2024-04-08) 2 commits\n - rebase -i: improve error message when picking merge\n - rebase -i: pass struct replay_opts to parse_insn_line()\n\n When the user adds to \"git rebase -i\" instruction to \"pick\" a merge\n commit, the error experience is not pleasant. Such an error is now\n caught earlier in the process that parses the todo list.\n\n Expecting a reroll.\n cf. <88bc0787-e7ae-49e5-99e8-97f6c55ea8c6@gmail.com>\n source: \n\n\n* ps/reftable-write-optim (2024-04-08) 11 commits\n - reftable/block: reuse compressed array\n - reftable/block: reuse zstream when writing log blocks\n - reftable/writer: reset `last_key` instead of releasing it\n - reftable/writer: unify releasing memory\n - reftable/writer: refactorings for `writer_flush_nonempty_block()`\n - reftable/writer: refactorings for `writer_add_record()`\n - refs/reftable: don't recompute committer ident\n - reftable: remove name checks\n - refs/reftable: skip duplicate name checks\n - refs/reftable: perform explicit D/F check when writing symrefs\n - refs/reftable: fix D/F conflict error message on ref copy\n\n Code to write out reftable has seen some optimization and\n simplification.\n\n Will merge to 'next'?\n source: \n\n\n* ds/send-email-per-message-block (2024-04-10) 2 commits\n - send-email: make it easy to discern the messages for each patch\n - send-email: move newline characters out of a few translatable strings\n\n \"git send-email\" learned to separate its reports on each message it\n sends out with an extra blank line in between.\n\n Will merge to 'next'?\n source: \n\n\n* ew/khash-to-khashl (2024-03-28) 3 commits\n - khashl: fix ensemble lookups on empty table\n - treewide: switch to khashl for memory savings\n - list-objects-filter: use kh_size API\n\n The hashtable library \"khash.h\" has been replaced with \"khashl.h\"\n that has better memory usage characteristics.\n\n Needs review.\n cf. \n source: <20240328101356.300374-1-e@80x24.org>\n\n\n* bc/credential-scheme-enhancement (2024-04-16) 16 commits\n - credential: add method for querying capabilities\n - credential-cache: implement authtype capability\n - t: add credential tests for authtype\n - credential: add support for multistage credential rounds\n - t5563: refactor for multi-stage authentication\n - docs: set a limit on credential line length\n - credential: enable state capability\n - credential: add an argument to keep state\n - http: add support for authtype and credential\n - docs: indicate new credential protocol fields\n - credential: add a field called \"ephemeral\"\n - credential: gate new fields on capability\n - credential: add a field for pre-encoded credentials\n - http: use new headers for each object request\n - remote-curl: reset headers on new request\n - credential: add an authtype field\n\n The credential helper protocol, together with the HTTP layer, have\n been enhanced to support authentication schemes different from\n username & password pair, like Bearer and NTLM.\n\n Comments?\n source: <20240417000240.3611948-1-sandals@crustytoothpaste.net>\n\n\n* tb/pseudo-merge-reachability-bitmap (2024-03-20) 24 commits\n - t/perf: implement performace tests for pseudo-merge bitmaps\n - pseudo-merge: implement support for finding existing merges\n - ewah: `bitmap_equals_ewah()`\n - pack-bitmap: extra trace2 information\n - pack-bitmap.c: use pseudo-merges during traversal\n - t/test-lib-functions.sh: support `--date` in `test_commit_bulk()`\n - pack-bitmap: implement test helpers for pseudo-merge\n - ewah: implement `ewah_bitmap_popcount()`\n - pseudo-merge: implement support for reading pseudo-merge commits\n - pack-bitmap.c: read pseudo-merge extension\n - pseudo-merge: scaffolding for reads\n - pack-bitmap: extract `read_bitmap()` function\n - pack-bitmap-write.c: write pseudo-merge table\n - pack-bitmap-write.c: select pseudo-merge commits\n - pseudo-merge: implement support for selecting pseudo-merge commits\n - pack-bitmap: make `bitmap_writer_push_bitmapped_commit()` public\n - pack-bitmap: implement `bitmap_writer_has_bitmapped_object_id()`\n - pack-bitmap-write: support storing pseudo-merge commits\n - pseudo-merge.ch: initial commit\n - pack-bitmap: move some initialization to `bitmap_writer_init()`\n - pack-bitmap: drop unused `max_bitmaps` parameter\n - ewah: implement `ewah_bitmap_is_subset()`\n - config: repo_config_get_expiry()\n - Documentation/technical: describe pseudo-merge bitmaps format\n\n The pack-bitmap machinery learned to write pseudo-merge bitmaps,\n which act as imaginary octopus merges covering un-bitmapped\n reference tips. This enhances bitmap coverage, and thus,\n performance, for repositories with many references using bitmaps.\n\n Expecting a reroll.\n cf. \n source: \n\n\n* la/hide-trailer-info (2024-04-26) 11 commits\n - trailer unit tests: inspect iterator contents\n - trailer: document parse_trailers() usage\n - trailer: retire trailer_info_get() from API\n - trailer: make trailer_info struct private\n - trailer: make parse_trailers() return trailer_info pointer\n - interpret-trailers: access trailer_info with new helpers\n - sequencer: use the trailer iterator\n - trailer: teach iterator about non-trailer lines\n - trailer: add unit tests for trailer iterator\n - Makefile: sort UNIT_TEST_PROGRAMS\n + Merge branch 'la/format-trailer-info' into la/hide-trailer-info\n\n The trailer API has been reshuffled a bit.\n\n Will merge to 'next'?\n cf. \n source: \n\n\n* ds/doc-config-reflow (2024-03-14) 1 commit\n - config.txt: perform some minor reformatting\n\n Reflow a paragraph in the documentation source without any effect\n to the formatted text.\n\n Will discard.\n source: <97bdaf075bf5a68554cca1731eca78aff2662907.1710444774.git.dsimic@manjaro.org>\n\n\n* ie/config-includeif-hostname (2024-03-19) 2 commits\n - config: learn the \"hostname:\" includeIf condition\n - t: add a test helper for getting hostname\n\n The conditional inclusion mechanism for configuration files learned\n to switch on the hostname.\n\n Expecting a reroll.\n cf. <20240319210428.GC1159535@coredump.intra.peff.net>\n cf. <20240320001934.GA903718@coredump.intra.peff.net>\n source: <20240319183722.211300-1-ignacio@iencinas.com>\n\n\n* js/build-fuzz-more-often (2024-04-24) 1 commit\n (merged to 'next' on 2024-04-25 at 28f65d1be2)\n + fuzz: link fuzz programs with `make all` on Linux\n\n In addition to building the objects needed, try to link the objects\n that are used in fuzzer tests, to make sure at least they build\n without bitrot, in Linux CI runs.\n\n Will cook in 'next'.\n source: \n\n\n* cw/git-std-lib (2024-02-28) 4 commits\n - SQUASH??? get rid of apparent debugging crufts\n - test-stdlib: show that git-std-lib is independent\n - git-std-lib: introduce Git Standard Library\n - pager: include stdint.h because uintmax_t is used\n\n Split libgit.a out to a separate git-std-lib tor easier reuse.\n\n Expecting a reroll.\n source: \n\n\n* js/cmake-with-test-tool (2024-04-24) 2 commits\n - cmake: let `test-tool` run the unit tests, too\n - Merge branch 'js/unit-test-suite-runner' into js/cmake-with-test-tool\n (this branch uses js/unit-test-suite-runner.)\n\n \"test-tool\" is now built in CMake build to also run the unit tests.\n\n May want to roll it into the base topic.\n Will merge to 'next' together with the base topic.\n source: \n\n\n* js/unit-test-suite-runner (2024-04-24) 8 commits\n - ci: use test-tool as unit test runner on Windows\n - t/Makefile: run unit tests alongside shell tests\n - unit tests: add rule for running with test-tool\n - test-tool run-command testsuite: support unit tests\n - test-tool run-command testsuite: remove hardcoded filter\n - test-tool run-command testsuite: get shell from env\n - t0080: turn t-basic unit test into a helper\n - Merge branch 'jk/unit-tests-buildfix' into js/unit-test-suite-runner\n (this branch is used by js/cmake-with-test-tool.)\n\n The \"test-tool\" has been taught to run testsuite tests in parallel,\n bypassing the need to use the \"prove\" tool.\n\n Needs review.\n source: \n\n\n* bk/complete-dirname-for-am-and-format-patch (2024-01-12) 1 commit\n - completion: dir-type optargs for am, format-patch\n\n Command line completion support (in contrib/) has been\n updated for a few commands to complete directory names where a\n directory name is expected.\n\n Expecting a reroll.\n cf. <40c3a824-a961-490b-94d4-4eb23c8f713d@gmail.com>\n cf. <6683f24e-7e56-489d-be2d-8afe1fc38d2b@gmail.com>\n source: \n\n\n* bk/complete-send-email (2024-01-12) 1 commit\n - completion: don't complete revs when --no-format-patch\n\n Command line completion support (in contrib/) has been taught to\n avoid offering revision names as candidates to \"git send-email\" when\n the command is used to send pre-generated files.\n\n Expecting a reroll.\n cf. \n source: \n\n\n* tb/path-filter-fix (2024-01-31) 16 commits\n - bloom: introduce `deinit_bloom_filters()`\n - commit-graph: reuse existing Bloom filters where possible\n - object.h: fix mis-aligned flag bits table\n - commit-graph: new Bloom filter version that fixes murmur3\n - commit-graph: unconditionally load Bloom filters\n - bloom: prepare to discard incompatible Bloom filters\n - bloom: annotate filters with hash version\n - repo-settings: introduce commitgraph.changedPathsVersion\n - t4216: test changed path filters with high bit paths\n - t/helper/test-read-graph: implement `bloom-filters` mode\n - bloom.h: make `load_bloom_filter_from_graph()` public\n - t/helper/test-read-graph.c: extract `dump_graph_info()`\n - gitformat-commit-graph: describe version 2 of BDAT\n - commit-graph: ensure Bloom filters are read with consistent settings\n - revision.c: consult Bloom filters for root commits\n - t/t4216-log-bloom.sh: harden `test_bloom_filters_not_used()`\n\n The Bloom filter used for path limited history traversal was broken\n on systems whose \"char\" is unsigned; update the implementation and\n bump the format version to 2.\n\n Waiting for a final ack?\n cf. \n source: \n\n\n* jc/rerere-cleanup (2023-08-25) 4 commits\n - rerere: modernize use of empty strbuf\n - rerere: try_merge() should use LL_MERGE_ERROR when it means an error\n - rerere: fix comment on handle_file() helper\n - rerere: simplify check_one_conflict() helper function\n\n Code clean-up.\n\n Not ready to be reviewed yet.\n source: <20230824205456.1231371-1-gitster@pobox.com>\n"},{"id":"493665","messageId":"5209161598ea38138becfdb33e7e8811@manjaro.org","threadId":"61393","inReplyTo":"xmqqplu8ulra.fsf@gitster.g","subject":"Re: What's cooking in git.git (Apr 2024, #10; Mon, 29)","fromName":"Dragan Simic","fromEmail":"dsimic@manjaro.org","sentAt":"2024-04-29T17:45:49Z","receivedAt":"2024-04-29T17:45:51Z","isPatch":false,"sender":{"key":"dsimic@manjaro.org","avatar":null},"body":"On 2024-04-29 19:22, Junio C Hamano wrote:\n> \n> * ds/send-email-per-message-block (2024-04-10) 2 commits\n> - send-email: make it easy to discern the messages for each patch\n> - send-email: move newline characters out of a few translatable \n> strings\n> \n> \"git send-email\" learned to separate its reports on each message it\n> sends out with an extra blank line in between.\n> \n> Will merge to 'next'?\n> source: \n\nOh, nice, this is reassuring... I'd be so happy to see those patches\naccepted, which would avoid wasting all the effort that went into them,\nwhile also making \"git send-email\" a bit more user friendly. :)\n"},{"id":"493667","messageId":"Zi_hhpoXHrCz2kcf@tanuki","threadId":"61393","inReplyTo":"xmqqplu8ulra.fsf@gitster.g","subject":"Re: What's cooking in git.git (Apr 2024, #10; Mon, 29)","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-04-29T18:05:58Z","receivedAt":"2024-04-29T18:06:06Z","isPatch":false,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Mon, Apr 29, 2024 at 10:22:33AM -0700, Junio C Hamano wrote:\n> * ps/the-index-is-no-more (2024-04-18) 6 commits\n> - repository: drop `initialize_the_repository()`\n> - repository: drop `the_index` variable\n> - builtin/clone: stop using `the_index`\n> - repository: initialize index in `repo_init()`\n> - builtin: stop using `the_index`\n> - t/helper: stop using `the_index`\n> \n> The singleton index_state instance \"the_index\" has been eliminated\n> by always instantiating \"the_repository\" and replacing references\n> to \"the_index\" with references to its .index member.\n> \n> Will merge to 'next'?\n> source: \n\nI'd be happy to see it gone as one more step towards less global state.\nIt may be debatable whether the index should really be contained in\n`struct repository`, but even if we ultimately decide that it is not,\ndropping `the_index` would be a necessary step into that direction\nanyway.\n\nSo yeah, I'd be happy to see `the_index` gone. From thereon we can\ncontinue to iterate.\n\n> * ps/reftable-write-optim (2024-04-08) 11 commits\n> - reftable/block: reuse compressed array\n> - reftable/block: reuse zstream when writing log blocks\n> - reftable/writer: reset `last_key` instead of releasing it\n> - reftable/writer: unify releasing memory\n> - reftable/writer: refactorings for `writer_flush_nonempty_block()`\n> - reftable/writer: refactorings for `writer_add_record()`\n> - refs/reftable: don't recompute committer ident\n> - reftable: remove name checks\n> - refs/reftable: skip duplicate name checks\n> - refs/reftable: perform explicit D/F check when writing symrefs\n> - refs/reftable: fix D/F conflict error message on ref copy\n> \n> Code to write out reftable has seen some optimization and\n> simplification.\n> \n> Will merge to 'next'?\n> source: \n\nThis series has seen reviews and I don't have any remaining things to\naddress here, so I think it's ready to go.\n\nPatrick\n"},{"id":"493724","messageId":"CAMo6p=EPuyfdFb4dkAC4Z5mejE_uB2MeJKfkg7CQ8NN3P6KYSQ@mail.gmail.com","threadId":"61393","inReplyTo":"xmqqplu8ulra.fsf@gitster.g","subject":"Re: What's cooking in git.git (Apr 2024, #10; Mon, 29)","fromName":"Linus Arver","fromEmail":"linusarver@gmail.com","sentAt":"2024-04-30T04:45:30Z","receivedAt":"2024-04-30T04:45:31Z","isPatch":false,"sender":{"key":"linusarver@gmail.com","avatar":"https://avatars.githubusercontent.com/u/725613?v=4"},"body":"Junio C Hamano writes:\n\n> * la/hide-trailer-info (2024-04-26) 11 commits\n> - trailer unit tests: inspect iterator contents\n> - trailer: document parse_trailers() usage\n> - trailer: retire trailer_info_get() from API\n> - trailer: make trailer_info struct private\n> - trailer: make parse_trailers() return trailer_info pointer\n> - interpret-trailers: access trailer_info with new helpers\n> - sequencer: use the trailer iterator\n> - trailer: teach iterator about non-trailer lines\n> - trailer: add unit tests for trailer iterator\n> - Makefile: sort UNIT_TEST_PROGRAMS\n> + Merge branch 'la/format-trailer-info' into la/hide-trailer-info\n>\n> The trailer API has been reshuffled a bit.\n>\n> Will merge to 'next'?\n> cf. \n> source: \n\nI should be able to send a reroll to address Christian's comments\nsometime later this week. Thanks\n"}]}