{"thread":{"id":"61371","subject":"[PATCH] doc: clarify practices for submitting updated patch versions","startedAt":"2024-04-25T21:35:38Z","lastAt":"2024-04-26T10:09:02Z","messageCount":3,"participants":["Justin Tobler","Roland Hieber","Karthik Nayak"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"493487","messageId":"20240425213404.133660-1-jltobler@gmail.com","threadId":"61371","inReplyTo":null,"subject":"[PATCH] doc: clarify practices for submitting updated patch versions","fromName":"Justin Tobler","fromEmail":"jltobler@gmail.com","sentAt":"2024-04-25T21:34:04Z","receivedAt":"2024-04-25T21:35:38Z","isPatch":true,"sender":{"key":"jltobler@gmail.com","avatar":"https://avatars.githubusercontent.com/u/53454972?v=4"},"body":"The `SubmittingPatches` documentation briefly mentions that related\npatches should be grouped together in their own e-mail thread. Expand on\nthis to explicitly state that updated versions of a patch series should\nalso follow this. Also provide add a link to existing documentation from\n`MyFirstContribution` that provides detailed instructions on how to do\nthis via `git-send-email(1)`.\n\nSigned-off-by: Justin Tobler \n---\n Documentation/SubmittingPatches | 10 ++++++----\n 1 file changed, 6 insertions(+), 4 deletions(-)\n\ndiff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\nindex c647c7e1b4..bc212836f9 100644\n--- a/Documentation/SubmittingPatches\n+++ b/Documentation/SubmittingPatches\n@@ -415,10 +415,12 @@ e-mail tools, so that they may comment on specific portions of\n your code. For this reason, each patch should be submitted\n \"inline\" in a separate message.\n \n-Multiple related patches should be grouped into their own e-mail\n-thread to help readers find all parts of the series. To that end,\n-send them as replies to either an additional \"cover letter\" message\n-(see below), the first patch, or the respective preceding patch.\n+All subsequent versions of a patch series and other related patches should be\n+grouped into their own e-mail thread to help readers find all parts of the\n+series. To that end, send them as replies to either an additional \"cover\n+letter\" message (see below), the first patch, or the respective preceding patch.\n+Here is a link:MyFirstContribution.html#v2-git-send-email[step-by-step guide] on\n+how to submit updated versions of a patch series.\n \n If your log message (including your name on the\n `Signed-off-by` trailer) is not writable in ASCII, make sure that\n\nbase-commit: e326e520101dcf43a0499c3adc2df7eca30add2d\n-- \n2.44.0\n\n"},{"id":"493508","messageId":"20240426093110.3lxbmhwfl3efwo2s@glados","threadId":"61371","inReplyTo":"20240425213404.133660-1-jltobler@gmail.com","subject":"Re: [PATCH] doc: clarify practices for submitting updated patch versions","fromName":"Roland Hieber","fromEmail":"rohieb+git@rohieb.name","sentAt":"2024-04-26T09:31:10Z","receivedAt":"2024-04-26T09:37:07Z","isPatch":true,"sender":{"key":"rohieb+git@rohieb.name","avatar":null},"body":"On Thu, Apr 25, 2024 at 04:34:04PM -0500, Justin Tobler wrote:\n> The `SubmittingPatches` documentation briefly mentions that related\n> patches should be grouped together in their own e-mail thread. Expand on\n> this to explicitly state that updated versions of a patch series should\n> also follow this. Also provide add a link to existing documentation from\n> `MyFirstContribution` that provides detailed instructions on how to do\n> this via `git-send-email(1)`.\n\nThankst! I obviously didn't read the old text in the intended way when I\nsubmitted my patch iterations yesterday, so your patch makes it much more clear!\n\n - Roland\n\n> Signed-off-by: Justin Tobler \n> ---\n> Documentation/SubmittingPatches | 10 ++++++----\n> 1 file changed, 6 insertions(+), 4 deletions(-)\n> \n> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\n> index c647c7e1b4..bc212836f9 100644\n> --- a/Documentation/SubmittingPatches\n> +++ b/Documentation/SubmittingPatches\n> @@ -415,10 +415,12 @@ e-mail tools, so that they may comment on specific portions of\n> your code. For this reason, each patch should be submitted\n> \"inline\" in a separate message.\n> \n> -Multiple related patches should be grouped into their own e-mail\n> -thread to help readers find all parts of the series. To that end,\n> -send them as replies to either an additional \"cover letter\" message\n> -(see below), the first patch, or the respective preceding patch.\n> +All subsequent versions of a patch series and other related patches should be\n> +grouped into their own e-mail thread to help readers find all parts of the\n> +series. To that end, send them as replies to either an additional \"cover\n> +letter\" message (see below), the first patch, or the respective preceding patch.\n> +Here is a link:MyFirstContribution.html#v2-git-send-email[step-by-step guide] on\n> +how to submit updated versions of a patch series.\n> \n> If your log message (including your name on the\n> `Signed-off-by` trailer) is not writable in ASCII, make sure that\n> \n> base-commit: e326e520101dcf43a0499c3adc2df7eca30add2d\n> -- \n> 2.44.0\n> \n\n-- \nRoland Hieber\nE-Mail: rohieb@rohieb.name\nWeb: https://rohieb.name\nPGP Fingerprint: 3B7A C587 9464 CAB6 5B90 7151 B241 3C66 DD2C 3FEA\n"},{"id":"493509","messageId":"CAOLa=ZRsbUK0Zvo-VK8h2VfSicQLQ=StC5b4VvAzrFquTBn7bQ@mail.gmail.com","threadId":"61371","inReplyTo":"20240425213404.133660-1-jltobler@gmail.com","subject":"Re: [PATCH] doc: clarify practices for submitting updated patch versions","fromName":"Karthik Nayak","fromEmail":"karthik.188@gmail.com","sentAt":"2024-04-26T10:09:00Z","receivedAt":"2024-04-26T10:09:02Z","isPatch":true,"sender":{"key":"karthik.188@gmail.com","avatar":"https://avatars.githubusercontent.com/u/1786334?v=4"},"body":"Justin Tobler writes:\n\n> The `SubmittingPatches` documentation briefly mentions that related\n> patches should be grouped together in their own e-mail thread. Expand on\n> this to explicitly state that updated versions of a patch series should\n> also follow this. Also provide add a link to existing documentation from\n> `MyFirstContribution` that provides detailed instructions on how to do\n> this via `git-send-email(1)`.\n>\n> Signed-off-by: Justin Tobler \n> ---\n> Documentation/SubmittingPatches | 10 ++++++----\n> 1 file changed, 6 insertions(+), 4 deletions(-)\n>\n> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches\n> index c647c7e1b4..bc212836f9 100644\n> --- a/Documentation/SubmittingPatches\n> +++ b/Documentation/SubmittingPatches\n> @@ -415,10 +415,12 @@ e-mail tools, so that they may comment on specific portions of\n> your code. For this reason, each patch should be submitted\n> \"inline\" in a separate message.\n>\n> -Multiple related patches should be grouped into their own e-mail\n> -thread to help readers find all parts of the series. To that end,\n> -send them as replies to either an additional \"cover letter\" message\n> -(see below), the first patch, or the respective preceding patch.\n> +All subsequent versions of a patch series and other related patches should be\n\nThe 'other related patches' is not a strict rule we follow, is it?\n\n> +grouped into their own e-mail thread to help readers find all parts of the\n> +series. To that end, send them as replies to either an additional \"cover\n> +letter\" message (see below), the first patch, or the respective preceding patch.\n> +Here is a link:MyFirstContribution.html#v2-git-send-email[step-by-step guide] on\n> +how to submit updated versions of a patch series.\n\nThanks for this.\n"}]}