{"thread":{"id":"61350","subject":"[[PATCH] [RESUBMIT] Consistency for substitution hints (i18n) 0/1]","startedAt":"2024-04-21T18:14:14Z","lastAt":"2024-04-21T18:14:14Z","messageCount":2,"participants":["Alexander Shopov"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"493275","messageId":"20240421181408.82736-1-ash@kambanaria.org","threadId":"61350","inReplyTo":null,"subject":"[[PATCH] [RESUBMIT] Consistency for substitution hints (i18n) 0/1]","fromName":"Alexander Shopov","fromEmail":"ash@kambanaria.org","sentAt":"2024-04-21T18:14:04Z","receivedAt":"2024-04-21T18:14:14Z","isPatch":true,"sender":{"key":"ash@kambanaria.org","avatar":"https://avatars.githubusercontent.com/u/449359?v=4"},"body":"i18n: as translators choose substitution hints applicable\nto their writing system, expose the ones in parse-options\nfor completeness\n\nAlexander Shopov (1):\n  parse-options: use localized substitution hints\n\n parse-options.c | 17 ++++++++++++++---\n 1 file changed, 14 insertions(+), 3 deletions(-)\n\n-- \n2.44.0\n\n"},{"id":"493276","messageId":"20240421181408.82736-2-ash@kambanaria.org","threadId":"61350","inReplyTo":"20240421181408.82736-1-ash@kambanaria.org","subject":"[[PATCH] [RESUBMIT] Consistency for substitution hints (i18n) 1/1] parse-options: use localized substitution hints","fromName":"Alexander Shopov","fromEmail":"ash@kambanaria.org","sentAt":"2024-04-21T18:14:05Z","receivedAt":"2024-04-21T18:14:14Z","isPatch":true,"sender":{"key":"ash@kambanaria.org","avatar":"https://avatars.githubusercontent.com/u/449359?v=4"},"body":"i18n: as translators choose substitution hints applicable\nto their writing system, expose the ones in parse-options\nfor completeness\n\nSigned-off-by: Alexander Shopov <ash@kambanaria.org>\n---\n parse-options.c | 17 ++++++++++++++---\n 1 file changed, 14 insertions(+), 3 deletions(-)\n\ndiff --git a/parse-options.c b/parse-options.c\nindex 63a99dea6e..93712c6904 100644\n--- a/parse-options.c\n+++ b/parse-options.c\n@@ -27,6 +27,7 @@ static void optbug(const struct option *opt, const char *reason)\n }\n \n static const char *optname(const struct option *opt, enum opt_parsed flags)\n+// FIXME\n {\n \tstatic struct strbuf sb = STRBUF_INIT;\n \n@@ -1055,17 +1056,27 @@ int parse_options(int argc, const char **argv,\n }\n \n static int usage_argh(const struct option *opts, FILE *outfile)\n+/// Fixme\n {\n \tconst char *s;\n \tint literal = (opts->flags & PARSE_OPT_LITERAL_ARGHELP) ||\n \t\t!opts->argh || !!strpbrk(opts->argh, \"()<>[]|\");\n \tif (opts->flags & PARSE_OPT_OPTARG)\n \t\tif (opts->long_name)\n-\t\t\ts = literal ? \"[=%s]\" : \"[=<%s>]\";\n+\t\t\ts = literal ? \"[=%s]\" :\n+\t\t\t  /* TRANSLATORS: keep as is unless you use hints for substitution other than `<>'\n+\t\t\t     in which case use those */\n+\t\t\t  _(\"[=<%s>]\");\n \t\telse\n-\t\t\ts = literal ? \"[%s]\" : \"[<%s>]\";\n+\t\t\ts = literal ? \"[%s]\" :\n+\t\t\t  /* TRANSLATORS: keep as is unless you use hints for substitution other than `<>'\n+\t\t\t     in which case use those */\n+\t\t\t  _(\"[<%s>]\");\n \telse\n-\t\ts = literal ? \" %s\" : \" <%s>\";\n+\t\ts = literal ? \" %s\" :\n+\t\t  /* TRANSLATORS: keep as is unless you use hints for substitution other than `<>'\n+\t\t     in which case use those */\n+\t\t  _(\" <%s>\");\n \treturn utf8_fprintf(outfile, s, opts->argh ? _(opts->argh) : _(\"...\"));\n }\n \n-- \n2.44.0\n\n"}]}