{"thread":{"id":"61318","subject":"[PATCH] Documentation: fix linkgit reference","startedAt":"2024-04-14T22:08:06Z","lastAt":"2024-04-15T18:02:30Z","messageCount":3,"participants":["Yehezkel Bernat via GitGitGadget","Patrick Steinhardt","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"492926","messageId":"pull.1706.git.git.1713132482976.gitgitgadget@gmail.com","threadId":"61318","inReplyTo":null,"subject":"[PATCH] Documentation: fix linkgit reference","fromName":"Yehezkel Bernat via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-04-14T22:08:02Z","receivedAt":"2024-04-14T22:08:06Z","isPatch":true,"sender":{"key":"name:Yehezkel Bernat","avatar":null},"body":"From: Yehezkel Bernat <yehezkelshb@gmail.com>\n\nIn git-replay documentation, linkgit to git-rev-parse is missing the man\nsection which breaks its rendering\n\nAdd section number as done in other references to this command\n\nSigned-off-by: Yehezkel Bernat <YehezkelShB@gmail.com>\n---\n    Documentation: fix linkgit reference\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1706%2FYehezkelShB%2Fyb%2Ffix-linkgit-reference-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1706/YehezkelShB/yb/fix-linkgit-reference-v1\nPull-Request: https://github.com/git/git/pull/1706\n\n Documentation/git-replay.txt | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\ndiff --git a/Documentation/git-replay.txt b/Documentation/git-replay.txt\nindex f6c269c62d5..8f3300c683a 100644\n--- a/Documentation/git-replay.txt\n+++ b/Documentation/git-replay.txt\n@@ -46,7 +46,7 @@ the new commits (in other words, this mimics a cherry-pick operation).\n \tRange of commits to replay. More than one <revision-range> can\n \tbe passed, but in `--advance <branch>` mode, they should have\n \ta single tip, so that it's clear where <branch> should point\n-\tto. See \"Specifying Ranges\" in linkgit:git-rev-parse and the\n+\tto. See \"Specifying Ranges\" in linkgit:git-rev-parse[1] and the\n \t\"Commit Limiting\" options below.\n \n include::rev-list-options.txt[]\n\nbase-commit: 8f7582d995682f785e80e344197cc715e6bc7d8e\n-- \ngitgitgadget\n"},{"id":"492930","messageId":"ZhzVnnoBFt2nau4x@tanuki","threadId":"61318","inReplyTo":"pull.1706.git.git.1713132482976.gitgitgadget@gmail.com","subject":"Re: [PATCH] Documentation: fix linkgit reference","fromName":"Patrick Steinhardt","fromEmail":"ps@pks.im","sentAt":"2024-04-15T07:22:06Z","receivedAt":"2024-04-15T07:22:12Z","isPatch":true,"sender":{"key":"ps@pks.im","avatar":"https://avatars.githubusercontent.com/u/4056630?v=4"},"body":"On Sun, Apr 14, 2024 at 10:08:02PM +0000, Yehezkel Bernat via GitGitGadget wrote:\n> From: Yehezkel Bernat <yehezkelshb@gmail.com>\n> \n> In git-replay documentation, linkgit to git-rev-parse is missing the man\n> section which breaks its rendering\n> \n> Add section number as done in other references to this command\n\nNit: sentences should end with a dot.\n\n> Signed-off-by: Yehezkel Bernat <YehezkelShB@gmail.com>\n\nOther than that this patch looks good to me, thanks!\n\nPatrick\n\n> ---\n>     Documentation: fix linkgit reference\n> \n> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1706%2FYehezkelShB%2Fyb%2Ffix-linkgit-reference-v1\n> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1706/YehezkelShB/yb/fix-linkgit-reference-v1\n> Pull-Request: https://github.com/git/git/pull/1706\n> \n>  Documentation/git-replay.txt | 2 +-\n>  1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/git-replay.txt b/Documentation/git-replay.txt\n> index f6c269c62d5..8f3300c683a 100644\n> --- a/Documentation/git-replay.txt\n> +++ b/Documentation/git-replay.txt\n> @@ -46,7 +46,7 @@ the new commits (in other words, this mimics a cherry-pick operation).\n>  \tRange of commits to replay. More than one <revision-range> can\n>  \tbe passed, but in `--advance <branch>` mode, they should have\n>  \ta single tip, so that it's clear where <branch> should point\n> -\tto. See \"Specifying Ranges\" in linkgit:git-rev-parse and the\n> +\tto. See \"Specifying Ranges\" in linkgit:git-rev-parse[1] and the\n>  \t\"Commit Limiting\" options below.\n>  \n>  include::rev-list-options.txt[]\n> \n> base-commit: 8f7582d995682f785e80e344197cc715e6bc7d8e\n> -- \n> gitgitgadget\n> \n"},{"id":"492957","messageId":"xmqq4jc2o66l.fsf@gitster.g","threadId":"61318","inReplyTo":"ZhzVnnoBFt2nau4x@tanuki","subject":"Re: [PATCH] Documentation: fix linkgit reference","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-04-15T18:02:26Z","receivedAt":"2024-04-15T18:02:30Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"Patrick Steinhardt <ps@pks.im> writes:\n\n> On Sun, Apr 14, 2024 at 10:08:02PM +0000, Yehezkel Bernat via GitGitGadget wrote:\n>> From: Yehezkel Bernat <yehezkelshb@gmail.com>\n>> \n>> In git-replay documentation, linkgit to git-rev-parse is missing the man\n>> section which breaks its rendering\n>> \n>> Add section number as done in other references to this command\n>\n> Nit: sentences should end with a dot.\n>\n>> Signed-off-by: Yehezkel Bernat <YehezkelShB@gmail.com>\n>\n> Other than that this patch looks good to me, thanks!\n>\n> Patrick\n\nThanks, both.  Will just tweak the proposed log message while\nqueuing.\n\n\n>> ---\n>>     Documentation: fix linkgit reference\n>> \n>> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1706%2FYehezkelShB%2Fyb%2Ffix-linkgit-reference-v1\n>> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1706/YehezkelShB/yb/fix-linkgit-reference-v1\n>> Pull-Request: https://github.com/git/git/pull/1706\n>> \n>>  Documentation/git-replay.txt | 2 +-\n>>  1 file changed, 1 insertion(+), 1 deletion(-)\n>> \n>> diff --git a/Documentation/git-replay.txt b/Documentation/git-replay.txt\n>> index f6c269c62d5..8f3300c683a 100644\n>> --- a/Documentation/git-replay.txt\n>> +++ b/Documentation/git-replay.txt\n>> @@ -46,7 +46,7 @@ the new commits (in other words, this mimics a cherry-pick operation).\n>>  \tRange of commits to replay. More than one <revision-range> can\n>>  \tbe passed, but in `--advance <branch>` mode, they should have\n>>  \ta single tip, so that it's clear where <branch> should point\n>> -\tto. See \"Specifying Ranges\" in linkgit:git-rev-parse and the\n>> +\tto. See \"Specifying Ranges\" in linkgit:git-rev-parse[1] and the\n>>  \t\"Commit Limiting\" options below.\n>>  \n>>  include::rev-list-options.txt[]\n>> \n>> base-commit: 8f7582d995682f785e80e344197cc715e6bc7d8e\n>> -- \n>> gitgitgadget\n>> \n"}]}