{"thread":{"id":"61312","subject":"[PATCH] Documentation: fix typos describing date format","startedAt":"2024-04-12T08:51:19Z","lastAt":"2024-04-12T16:02:49Z","messageCount":2,"participants":["blanet via GitGitGadget","Junio C Hamano"],"isPatch":true,"patchVersion":1,"patchTotal":null},"messages":[{"id":"492855","messageId":"pull.1716.git.1712911876943.gitgitgadget@gmail.com","threadId":"61312","inReplyTo":null,"subject":"[PATCH] Documentation: fix typos describing date format","fromName":"blanet via GitGitGadget","fromEmail":"gitgitgadget@gmail.com","sentAt":"2024-04-12T08:51:16Z","receivedAt":"2024-04-12T08:51:19Z","isPatch":true,"sender":{"key":"name:blanet","avatar":null},"body":"From: Xing Xin <xingxin.xx@bytedance.com>\n\nThis commit corrects a typographical error found in both\ndate-formats.txt and git-fast-import.txt documentation, where the term\n`email format` was mistakenly used instead of `date format`.\n\nSigned-off-by: Xing Xin <xingxin.xx@bytedance.com>\n---\n    Documentation: fix typos describing date format\n\nPublished-As: https://github.com/gitgitgadget/git/releases/tag/pr-1716%2Fblanet%2Fxx%2Fdocumentation-typofix-v1\nFetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1716/blanet/xx/documentation-typofix-v1\nPull-Request: https://github.com/gitgitgadget/git/pull/1716\n\n Documentation/date-formats.txt    | 2 +-\n Documentation/git-fast-import.txt | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)\n\ndiff --git a/Documentation/date-formats.txt b/Documentation/date-formats.txt\nindex 67645cae64f..e24517c496f 100644\n--- a/Documentation/date-formats.txt\n+++ b/Documentation/date-formats.txt\n@@ -11,7 +11,7 @@ Git internal format::\n \tFor example CET (which is 1 hour ahead of UTC) is `+0100`.\n \n RFC 2822::\n-\tThe standard email format as described by RFC 2822, for example\n+\tThe standard date format as described by RFC 2822, for example\n \t`Thu, 07 Apr 2005 22:13:13 +0200`.\n \n ISO 8601::\ndiff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt\nindex b2607366b91..0ccede255ea 100644\n--- a/Documentation/git-fast-import.txt\n+++ b/Documentation/git-fast-import.txt\n@@ -303,7 +303,7 @@ and some sanity checks on the numeric values may also be performed.\n \twith e.g. bogus timezone values.\n \n `rfc2822`::\n-\tThis is the standard email format as described by RFC 2822.\n+\tThis is the standard date format as described by RFC 2822.\n +\n An example value is ``Tue Feb 6 11:22:18 2007 -0500''.  The Git\n parser is accurate, but a little on the lenient side.  It is the\n\nbase-commit: 436d4e5b14df49870a897f64fe92c0ddc7017e4c\n-- \ngitgitgadget\n"},{"id":"492874","messageId":"xmqqh6g6po0u.fsf@gitster.g","threadId":"61312","inReplyTo":"pull.1716.git.1712911876943.gitgitgadget@gmail.com","subject":"Re: [PATCH] Documentation: fix typos describing date format","fromName":"Junio C Hamano","fromEmail":"gitster@pobox.com","sentAt":"2024-04-12T16:02:41Z","receivedAt":"2024-04-12T16:02:49Z","isPatch":true,"sender":{"key":"gitster@pobox.com","avatar":"https://avatars.githubusercontent.com/u/54884?v=4"},"body":"\"blanet via GitGitGadget\" <gitgitgadget@gmail.com> writes:\n\n> From: Xing Xin <xingxin.xx@bytedance.com>\n>\n> This commit corrects a typographical error found in both\n> date-formats.txt and git-fast-import.txt documentation, where the term\n> `email format` was mistakenly used instead of `date format`.\n\nSaying \"date\" is much more correct than \"email\" ;-).  Thanks for\nnoticing both instances.\n\n>  Documentation/date-formats.txt    | 2 +-\n>  Documentation/git-fast-import.txt | 2 +-\n>  2 files changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/Documentation/date-formats.txt b/Documentation/date-formats.txt\n> index 67645cae64f..e24517c496f 100644\n> --- a/Documentation/date-formats.txt\n> +++ b/Documentation/date-formats.txt\n> @@ -11,7 +11,7 @@ Git internal format::\n>  \tFor example CET (which is 1 hour ahead of UTC) is `+0100`.\n>  \n>  RFC 2822::\n> -\tThe standard email format as described by RFC 2822, for example\n> +\tThe standard date format as described by RFC 2822, for example\n>  \t`Thu, 07 Apr 2005 22:13:13 +0200`.\n\nRFC 2822 defines it as \"date-time\" (and this hasn't been updated by\nRFC 5322).  \"date\" is used to specifically mean \"day month year\".\n\n    https://www.rfc-editor.org/rfc/rfc2822.html#section-3.3\n\n    date-time       =       [ day-of-week \",\" ] date FWS time [CFWS]\n    day-of-week     =       ([FWS] day-name) / obs-day-of-week\n    day-name        =       \"Mon\" / \"Tue\" / \"Wed\" / \"Thu\" /\n                            \"Fri\" / \"Sat\" / \"Sun\"\n    date            =       day month year\n\nSo the new phrasing may get complain from pedants.  Saying \"The\nstandard date-time format as described by RFC 2822\" is more\ntechnically correct, but I actually wonder if we should go in the\nopposite, looser direction, like\n\n\tThe timestamp format used by RFC 2822, for example\n\t...\n\nso that we do not even pretend to use the wording they use in the\nRFC documents.  Doing so makes it in line with \"git rev-list --help\"\nwhich says\n\n\t\"--date=rfc\" shows timestamps in RFC 2822 format, often\n        found in e-mail messages.\n\nBut that's minor.  \"date\" is fine as-is.  The same comment applies\nto the other hunk.\n\nThanks.\n\n> diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt\n> index b2607366b91..0ccede255ea 100644\n> --- a/Documentation/git-fast-import.txt\n> +++ b/Documentation/git-fast-import.txt\n> @@ -303,7 +303,7 @@ and some sanity checks on the numeric values may also be performed.\n>  \twith e.g. bogus timezone values.\n>  \n>  `rfc2822`::\n> -\tThis is the standard email format as described by RFC 2822.\n> +\tThis is the standard date format as described by RFC 2822.\n>  +\n>  An example value is ``Tue Feb 6 11:22:18 2007 -0500''.  The Git\n>  parser is accurate, but a little on the lenient side.  It is the\n>\n> base-commit: 436d4e5b14df49870a897f64fe92c0ddc7017e4c\n"}]}